Re: lnstat

On Sat, 3 Mar 2018 22:56:02 +0100 David Kaufmann <as...@ionic.at> wrote: > Hi! > > `lnstat` segfaults (tested on Debian 9, CentOS 6+7, Fedora 27) if it is > started as `lnstat -w 1` > > according to gdb the crash is in `build_hdr_string` at lnstat.c:212 > > as i

lnstat

Hi! `lnstat` segfaults (tested on Debian 9, CentOS 6+7, Fedora 27) if it is started as `lnstat -w 1` according to gdb the crash is in `build_hdr_string` at lnstat.c:212 as it seems to be an useless value for the option anyway it might make sense to just handle a single "1" the sam

[iproute PATCH 1/5] lnstat: review lnstat_update()

Instead of calling rewind() and fgets() before every call to scan_lines(), move them into scan_lines() itself. This should also fix compat mode, as before the second call to scan_lines() the first line was skipped unconditionally. Signed-off-by: Phil Sutter --- misc/lnstat_util.c

[iproute PATCH 2/2] lnstat: fix header displaying mechanism

The algorithm depends on the loop counter ('i') to increment by one in each iteration. Though if running endlessly (count==0), the counter was not incremented at all. Also change formatting of the header printing conditional a bit so it's hopefully easier to read. Fixes: e7e2913 ("lnstat

[iproute PATCH 0/2] lnstat: review --subject option

Add missing description in help output, fix algorithm. Phil Sutter (2): lnstat: describe -s option in help output lnstat: fix header displaying mechanism misc/lnstat.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) -- 2.5.0 -- To unsubscribe from this list: send

[iproute PATCH 1/2] lnstat: describe -s option in help output

Signed-off-by: Phil Sutter --- misc/lnstat.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/misc/lnstat.c b/misc/lnstat.c index 1e547d0..529bc33 100644 --- a/misc/lnstat.c +++ b/misc/lnstat.c @@ -73,7 +73,10 @@ static int usage(char *name, int exit_code)

[iproute PATCH 5/6] man: lnstat: rewrite manpage

Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/lnstat.8 | 197 -- 1 file changed, 192 insertions(+), 5 deletions(-) diff --git a/man/man8/lnstat.8 b/man/man8/lnstat.8 index 699ddf4..69fe876 100644 --- a/man/man8/lnstat.8 +++ b/ma

[IPROUTE] manpage for lnstat

Hello, I wrote a manpage for lnstat, would be great if it could be applied to the next release. @Harald, I'm following your 'If somebody wants to do a manpage, feel free to send me a patch :)' of lnstat's README. :) regards, -mika- .TH LNSTAT 1 .SH NAME lnstat \- unified linux network

Re: [IPROUTE] manpage for lnstat

On Thu, Oct 26, 2006 at 10:41:26PM +0200, Michael Prokop wrote: Hello, I wrote a manpage for lnstat, would be great if it could be applied to the next release. Stephen: Please include it into your next release, looks fine to me. @Harald, I'm following your 'If somebody wants to do

Re: [IPROUTE] manpage for lnstat

On Thu, 26 Oct 2006 22:41:26 +0200 Michael Prokop [EMAIL PROTECTED] wrote: -mika- [lnstat.1 text/plain (2087 bytes)] Added, but I took the liberty of moving it to section 8 (lnstat.8) because that is where the other iproute2 commands are. -- Stephen Hemminger [EMAIL PROTECTED