Re: regression: UFO removal breaks kvm live migration

2017-11-17 Thread Willem de Bruijn
On Fri, Nov 17, 2017 at 9:48 AM, Willem de Bruijn wrote: >>> Okay, I will send a patch to reinstate UFO for this use case (only). There >>> is some related work in tap_handle_frame and packet_direct_xmit to >>> segment directly in the device. I will be traveling the next few days, so >>> it won't

Re: regression: UFO removal breaks kvm live migration

2017-11-17 Thread Willem de Bruijn
>> Okay, I will send a patch to reinstate UFO for this use case (only). There >> is some related work in tap_handle_frame and packet_direct_xmit to >> segment directly in the device. I will be traveling the next few days, so >> it won't be in time for 4.14 (but can go in stable later, of course). >

Re: regression: UFO removal breaks kvm live migration

2017-11-17 Thread Willem de Bruijn
On Fri, Nov 10, 2017 at 12:32 AM, Willem de Bruijn wrote: > On Wed, Nov 8, 2017 at 9:53 PM, Jason Wang wrote: >> >> >> On 2017年11月08日 20:32, David Miller wrote: >>> >>> From: Jason Wang >>> Date: Wed, 8 Nov 2017 17:25:48 +0900 >>> On 2017年11月08日 17:08, Willem de Bruijn wrote: > > Th

Re: regression: UFO removal breaks kvm live migration

2017-11-09 Thread David Miller
From: Willem de Bruijn Date: Fri, 10 Nov 2017 14:32:29 +0900 > Okay, I will send a patch to reinstate UFO for this use case (only). Thank you.

Re: regression: UFO removal breaks kvm live migration

2017-11-09 Thread Willem de Bruijn
On Wed, Nov 8, 2017 at 9:53 PM, Jason Wang wrote: > > > On 2017年11月08日 20:32, David Miller wrote: >> >> From: Jason Wang >> Date: Wed, 8 Nov 2017 17:25:48 +0900 >> >>> On 2017年11月08日 17:08, Willem de Bruijn wrote: That won't help in the short term. I'm still reading up to see if th

Re: regression: UFO removal breaks kvm live migration

2017-11-08 Thread Michael S. Tsirkin
On Wed, Nov 08, 2017 at 08:32:31PM +0900, David Miller wrote: > From: Jason Wang > Date: Wed, 8 Nov 2017 17:25:48 +0900 > > > On 2017年11月08日 17:08, Willem de Bruijn wrote: > >> That won't help in the short term. I'm still reading up to see if > >> there are > >> any other options besides reimplem

Re: regression: UFO removal breaks kvm live migration

2017-11-08 Thread David Miller
From: Jason Wang Date: Wed, 8 Nov 2017 21:53:27 +0900 > On 2017年11月08日 20:32, David Miller wrote: >> From: Jason Wang >> Date: Wed, 8 Nov 2017 17:25:48 +0900 >> >>> On 2017年11月08日 17:08, Willem de Bruijn wrote: That won't help in the short term. I'm still reading up to see if there are

Re: regression: UFO removal breaks kvm live migration

2017-11-08 Thread Jason Wang
On 2017年11月08日 20:32, David Miller wrote: From: Jason Wang Date: Wed, 8 Nov 2017 17:25:48 +0900 On 2017年11月08日 17:08, Willem de Bruijn wrote: That won't help in the short term. I'm still reading up to see if there are any other options besides reimplement or advertise-but-drop, such as an i

Re: regression: UFO removal breaks kvm live migration

2017-11-08 Thread David Miller
From: Jason Wang Date: Wed, 8 Nov 2017 17:25:48 +0900 > On 2017年11月08日 17:08, Willem de Bruijn wrote: >> That won't help in the short term. I'm still reading up to see if >> there are >> any other options besides reimplement or advertise-but-drop, such as >> an implicit trigger that would make th

Re: regression: UFO removal breaks kvm live migration

2017-11-08 Thread Jason Wang
On 2017年11月08日 17:08, Willem de Bruijn wrote: On Wed, Nov 8, 2017 at 4:49 PM, Jason Wang wrote: On 2017年11月08日 15:26, David Miller wrote: From: Willem de Bruijn Date: Wed, 8 Nov 2017 12:36:26 +0900 On Tue, Nov 7, 2017 at 5:02 PM, Michal Kubecek wrote: I didn't have time to think it thr

Re: regression: UFO removal breaks kvm live migration

2017-11-08 Thread Willem de Bruijn
On Wed, Nov 8, 2017 at 4:49 PM, Jason Wang wrote: > > > On 2017年11月08日 15:26, David Miller wrote: >> >> From: Willem de Bruijn >> Date: Wed, 8 Nov 2017 12:36:26 +0900 >> >>> On Tue, Nov 7, 2017 at 5:02 PM, Michal Kubecek wrote: I didn't have time to think it through yet but perhaps we

Re: regression: UFO removal breaks kvm live migration

2017-11-07 Thread Jason Wang
On 2017年11月08日 15:26, David Miller wrote: From: Willem de Bruijn Date: Wed, 8 Nov 2017 12:36:26 +0900 On Tue, Nov 7, 2017 at 5:02 PM, Michal Kubecek wrote: I didn't have time to think it through yet but perhaps we could allow setting TUN_F_UFO and ignore its value. If the feature is enabl

Re: regression: UFO removal breaks kvm live migration

2017-11-07 Thread David Miller
From: Willem de Bruijn Date: Wed, 8 Nov 2017 12:36:26 +0900 > On Tue, Nov 7, 2017 at 5:02 PM, Michal Kubecek wrote: >> I didn't have time to think it through yet but perhaps we could allow >> setting TUN_F_UFO and ignore its value. > > If the feature is enabled guests may try to send UFO packet

Re: regression: UFO removal breaks kvm live migration

2017-11-07 Thread Willem de Bruijn
On Tue, Nov 7, 2017 at 5:02 PM, Michal Kubecek wrote: > Hello, > > I just received this bug report: > > https://bugzilla.suse.com/show_bug.cgi?id=1066757 > > The reporter runs a live migration of a kvm guest from a host with > kernel supporting UFO (openSUSE 42.2 or 42.3, based on 4.4) to a host

regression: UFO removal breaks kvm live migration

2017-11-07 Thread Michal Kubecek
Hello, I just received this bug report: https://bugzilla.suse.com/show_bug.cgi?id=1066757 The reporter runs a live migration of a kvm guest from a host with kernel supporting UFO (openSUSE 42.2 or 42.3, based on 4.4) to a host with kernel with UFO support removed (SLE15 or openSUSE 15.0 pre-re