RE: sky2: Use seq_putc() in sky2_debug_show()

2017-05-09 Thread David Laight
From: Stephen Hemminger > Sent: 09 May 2017 06:50 > On Mon, 8 May 2017 19:42:46 +0200 > SF Markus Elfring wrote: > > > > Which issue do you mean? I dont see any issue you fix here. > > > > Are the run time characteristics a bit nicer for the function seq_putc > > in comparison to the function seq

Re: sky2: Use seq_putc() in sky2_debug_show()

2017-05-08 Thread Stephen Hemminger
On Mon, 8 May 2017 19:42:46 +0200 SF Markus Elfring wrote: > > Which issue do you mean? I dont see any issue you fix here. > > Are the run time characteristics a bit nicer for the function “seq_putc” > in comparison to the function “seq_puts” for printing a single line break > here? > > Rega

Re: sky2: Use seq_putc() in sky2_debug_show()

2017-05-08 Thread SF Markus Elfring
> Which issue do you mean? I dont see any issue you fix here. Are the run time characteristics a bit nicer for the function “seq_putc” in comparison to the function “seq_puts” for printing a single line break here? Regards, Markus

Re: [PATCH] sky2: Use seq_putc() in sky2_debug_show()

2017-05-08 Thread Lino Sanfilippo
Hi, On 08.05.2017 18:42, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 8 May 2017 18:38:17 +0200 > > A single character (line break) should be put into a sequence. Why? > Thus use the corresponding function "seq_putc". > > This issue was detected by using the Coccinelle softwar

[PATCH] sky2: Use seq_putc() in sky2_debug_show()

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 18:38:17 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/sky