On Tuesday 30 January 2007 11:30 pm, Linas Vepstas wrote:
> Shifting to the right by 5 bits has no effect on the result
> of this conditional. Either the bit is set, or its not.
> There is no need to shift.
>
> > + if ( (phy_reg & 0x0020) >> 7 ) {
You are right, I corrected this.
> The result
Francois,
thank you for your comments. I'll send a revised patch soon.
> +#define BCM5421_MODE_MASK1 << 5
>
> Please add parenthesis.
Done.
> "&" is fine despite the lack of parenthesis above but it is error-prone.
Corrected.
>
> +
> + if ( mode == GMII_COPPER) {
>^^^
>
On Sat, Jan 27, 2007 at 12:38:09AM +0100, Francois Romieu wrote:
> Jens Osterkamp <[EMAIL PROTECTED]> :
> >
> Index: linux-2.6.20-rc5/drivers/net/sungem_phy.c
> ===
> --- linux-2.6.20-rc5.orig/drivers/net/sungem_phy.c
> +++ linux-2.6.
Jens Osterkamp <[EMAIL PROTECTED]> :
> > Patch is whitespace damaged...
>
> sending it again as attachment...
Inlined patches are preferred.
Index: linux-2.6.20-rc5/drivers/net/sungem_phy.c
===
--- linux-2.6.20-rc5.orig/drivers/net
> Patch is whitespace damaged...
sending it again as attachment...
Jens
Subject: spidernet: add improved phy support
This patch adds improved version of enable_fiber for both the 5421 and
the 5461 phy. It is now possible to specify with these wether you want
autonegotiation or not. This is neede
On Fri, 2007-01-26 at 14:07 +0100, Jens Osterkamp wrote:
> This patch adds improved version of enable_fiber for both the 5421 and
> the 5461 phy. It is now possible to specify with these wether you want
> autonegotiation or not. This is needed for bladecenter switches where
> some expect autonegoti
This patch adds improved version of enable_fiber for both the 5421 and
the 5461 phy. It is now possible to specify with these wether you want
autonegotiation or not. This is needed for bladecenter switches where
some expect autonegotiation and some dont seem to like this at all.
Depending on this f
