Re: spidernet: dynamic phy setup code

2007-02-06 Thread Ishizaki Kou
Ben-san, Jens-san Thanks for your comments and advices. First, we should apologize to you that some troubles which we informed about spidernet auto-negotiation are caused by our mistake. We used wrong MACRO for advertise variable to phy-def-ops-setup_aneg(). We will post the revised patch for

Re: [Cbe-oss-dev] spidernet: dynamic phy setup code

2007-02-04 Thread Benjamin Herrenschmidt
On Thu, 2007-02-01 at 12:04 +0100, Jens Osterkamp wrote: Ishizaki-san, This patch partially works on celleb but remains following several problems. 1. It doesn't recover once an ethernet cable which is connected to a spider_net card is unpluged. My understanding is that you are

Re: spidernet: dynamic phy setup code

2007-02-04 Thread Benjamin Herrenschmidt
We use bcm5461. There is a possibility that we don't know the appropriate setting which is applicable for both type of switches. Have you tested the existing 54xx code in sungem_phy.c ? We use that with 5462 at least in K2 and all sorts of 54xx chips and it works fine... Just setup the right

Re: spidernet: dynamic phy setup code

2007-02-02 Thread Ishizaki Kou
Jens-san, Thanks for your comments. Ishizaki-san, This patch partially works on celleb but remains following several problems. 1. It doesn't recover once an ethernet cable which is connected to a spider_net card is unpluged. My understanding is that you are using the LINK interrupt to

Re: [Cbe-oss-dev] spidernet: dynamic phy setup code

2007-02-01 Thread Ishizaki Kou
I apologize if you received this mail many times. Jens-san This patch modifies the patch submitted by Kou Ishizaki to make it work on the blade (http://marc.theaimsgroup.com/?l=linux-netdevm=116593424505539w=2). Unfortunately I dont have access to a Celleb so I cannot test it there. Thanks

Re: spidernet: dynamic phy setup code

2007-02-01 Thread Jens Osterkamp
On Friday 26 January 2007 9:21 pm, Benjamin Herrenschmidt wrote: Can't we have a device-tree property indicating wether to use fiber or copper ? Well, yes, I am sure we could, but what would be the benefit of doing so if we can get the same information dynamically ? Jens - To unsubscribe

Re: [Cbe-oss-dev] spidernet: dynamic phy setup code

2007-02-01 Thread Jens Osterkamp
Ishizaki-san, This patch partially works on celleb but remains following several problems. 1. It doesn't recover once an ethernet cable which is connected to a spider_net card is unpluged. My understanding is that you are using the LINK interrupt to detect this. For the blade this is

spidernet: dynamic phy setup code

2007-01-26 Thread Jens Osterkamp
This patch modifies the patch submitted by Kou Ishizaki to make it work on the blade (http://marc.theaimsgroup.com/?l=linux-netdevm=116593424505539w=2). Unfortunately I dont have access to a Celleb so I cannot test it there. The basic logic behind this is simple : when the interface first comes

Re: spidernet: dynamic phy setup code

2007-01-26 Thread Linas Vepstas
On Fri, Jan 26, 2007 at 02:09:29PM +0100, Jens Osterkamp wrote: This patch modifies the patch submitted by Kou Ishizaki to make it work on the blade (http://marc.theaimsgroup.com/?l=linux-netdevm=116593424505539w=2). Index: linux-2.6/drivers/net/spider_net.c + if (card-aneg_count

Re: spidernet: dynamic phy setup code

2007-01-26 Thread Benjamin Herrenschmidt
On Fri, 2007-01-26 at 14:09 +0100, Jens Osterkamp wrote: This patch modifies the patch submitted by Kou Ishizaki to make it work on the blade (http://marc.theaimsgroup.com/?l=linux-netdevm=116593424505539w=2). Unfortunately I dont have access to a Celleb so I cannot test it there. The basic