Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-21 Thread Ian Jackson
Prashant Sreedharan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]"): > On Fri, 2015-04-17 at 15:12 -0400, David Miller wrote: > > From: Konrad Rzeszutek Wilk > > Date: Fri, 17 Apr 2015 15:04:48 -0400 > > > A huge amount of NIC d

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread Prashant Sreedharan
On Fri, 2015-04-17 at 15:12 -0400, David Miller wrote: > From: Konrad Rzeszutek Wilk > Date: Fri, 17 Apr 2015 15:04:48 -0400 > > > From 9e417af099e3cee2b219ab28ffc1e96b0564b213 Mon Sep 17 00:00:00 2001 > > From: Konrad Rzeszutek Wilk > > Date: Fri, 17 Apr 2015 14:55:47 -0400 > > Subject: [PATCH]

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread David Miller
From: Konrad Rzeszutek Wilk Date: Fri, 17 Apr 2015 15:04:48 -0400 > From 9e417af099e3cee2b219ab28ffc1e96b0564b213 Mon Sep 17 00:00:00 2001 > From: Konrad Rzeszutek Wilk > Date: Fri, 17 Apr 2015 14:55:47 -0400 > Subject: [PATCH] config: Enable NEED_DMA_MAP_STATE when SWIOTLB is selected > > A hu

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread Konrad Rzeszutek Wilk
On Fri, Apr 17, 2015 at 10:46:09AM -0700, Michael Chan wrote: > On Fri, 2015-04-17 at 13:19 -0400, David Miller wrote: > > So the gist of the situation is, that NEED_DMA_MAP_STATE can be 'n' in > > situations where we might actually need it to be 'y' based upon kernel > > comman line boot options g

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread Michael Chan
On Fri, 2015-04-17 at 13:19 -0400, David Miller wrote: > So the gist of the situation is, that NEED_DMA_MAP_STATE can be 'n' in > situations where we might actually need it to be 'y' based upon kernel > comman line boot options given. > > Right? Yes. > > -- To unsubscribe from this list: send

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread David Miller
From: Ian Jackson Date: Fri, 17 Apr 2015 17:29:28 +0100 > Prashant Sreedharan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and > 3 more messages]"): >> Ok this is what is causing the problem, the driver uses >> DEFINE_DMA_UNMAP_ADDR(), dma_unmap_addr_set

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread Ian Jackson
Prashant Sreedharan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]"): > Ok this is what is causing the problem, the driver uses > DEFINE_DMA_UNMAP_ADDR(), dma_unmap_addr_set() to keep a copy of the dma > "mapping" and dma_unmap_addr() to get

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread Prashant Sreedharan
On Thu, 2015-04-16 at 18:15 +0100, Ian Jackson wrote: > Michael Chan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more > messages]"): > > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > > > Yes, this looks like the driver

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread David Miller
From: Michael Chan Date: Thu, 16 Apr 2015 09:39:13 -0700 > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: >> Yes, this looks like the driver is not syncing the DMA buffers. Unmap is >> supposed to synchronize as well. >> > > For small rx packets (< 256 bytes), we sync th

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread Ian Jackson
Michael Chan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]"): > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > > Yes, this looks like the driver is not syncing the DMA buffers. Unmap is > > supposed to synchronize a

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread Michael Chan
On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > Yes, this looks like the driver is not syncing the DMA buffers. Unmap is > supposed to synchronize as well. > For small rx packets (< 256 bytes), we sync the DMA buffer before we copy the data to another SKB. For larger pac

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread cascardo
On Thu, Apr 16, 2015 at 11:18:39AM +0100, Ian Jackson wrote: > Prashant writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more > messages]"): > > Ian, using your config we are able to recreate the problem that you are > > seeing. The driver finds the RX data

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread Ian Jackson
Prashant writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]"): > Ian, using your config we are able to recreate the problem that you are > seeing. The driver finds the RX data buffer to be all zero, with a > analyzer trace we are seeing the chip is DM

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-15 Thread Prashant
On 4/15/2015 3:54 AM, Ian Jackson wrote: Prashant writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]"): I tried to reproduce the problem on 32 bit 3.14.34 stable kernel baremetal, with iommu=soft swiotlb=force but no luck, no drops or errors. I did not try w

Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-15 Thread Ian Jackson
Prashant writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]"): > I tried to reproduce the problem on 32 bit 3.14.34 stable kernel > baremetal, with iommu=soft swiotlb=force but no luck, no drops or > errors. I did not try with Xen 64 bit yet. Btw I n