Re: that TCP bug

2005-08-10 Thread Herbert Xu
On Wed, Aug 10, 2005 at 06:29:56PM -0700, David S. Miller wrote: > > And what's more the original code there modifying packets_out > looks wrong. Hmm I was actually careful in making sure the rewritten expression did the same thing to packets_out so I hope that's not the case :) I just had anoth

Re: that TCP bug

2005-08-10 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 07:55:36 +1000 > Here is a patch that adjusts fackets_out accordingly. And what's more the original code there modifying packets_out looks wrong. I think I'm going to push this in for 2.6.13. - To unsubscribe from this list: send the li

Re: that TCP bug

2005-08-10 Thread Herbert Xu
On Tue, Aug 09, 2005 at 10:19:11PM +1000, herbert wrote: > > So cnt is equal to fackets_out - reordering. Normally > fackets_out is less than packets_out. The only reason > I've found that might cause fackets_out to exceed packets_out > is if tcp_fragment is called from tcp_retransmit_skb with a