From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 23 Aug 2005 00:46:05 +0200
> [FIB_TRIE]: Don't ignore negative results from fib_semantic_match
>
> When a semantic match occurs either success, not found or an error
> (for matching unreachable routes/blackholes) is returned. fib_trie
> ignores
Patrick McHardy writes:
> That fixed it, it boots fine now and passes Vladimir's testcase.
> [FIB_TRIE]: Don't ignore negative results from fib_semantic_match
Hello!
Oh thanks for this one... wonder if this one can have confused us too.
Dave can you please...
Signed-off-by: Robert Olsson
On Tue, Aug 23, 2005 at 12:46:05AM +0200, Patrick McHardy wrote:
> [FIB_TRIE]: Don't ignore negative results from fib_semantic_match
>
> When a semantic match occurs either success, not found or an error
> (for matching unreachable routes/blackholes) is returned. fib_trie
> ignores the errors and
Thomas Graf wrote:
* Patrick McHardy <[EMAIL PROTECTED]> 2005-08-22 23:38
@@ -1364,7 +1365,7 @@ fn_trie_lookup(struct fib_table *tb, con
}
if (IS_LEAF(n)) {
-if (check_leaf(t, (struct leaf *)n, key, &plen, flp,
res, &ret))
+if ((ret == check_leaf(t, (s
Thomas Graf wrote:
* Patrick McHardy <[EMAIL PROTECTED]> 2005-08-22 23:38
@@ -1364,7 +1365,7 @@ fn_trie_lookup(struct fib_table *tb, con
}
if (IS_LEAF(n)) {
- if (check_leaf(t, (struct leaf *)n, key, &plen, flp, res,
&ret))
+
* Patrick McHardy <[EMAIL PROTECTED]> 2005-08-22 23:38
> @@ -1364,7 +1365,7 @@ fn_trie_lookup(struct fib_table *tb, con
> }
>
> if (IS_LEAF(n)) {
> - if (check_leaf(t, (struct leaf *)n, key, &plen, flp,
> res, &ret))
> + if ((re
Patrick McHardy wrote:
Vladimir B. Savkin wrote:
The same with "blackhole" routes, looks like they are ignored.
This patch should fix it. Please try it and report if it helps.
Please wait with testing, I must have done something stupid, booting
with this patch results in multiple oopses :)
Vladimir B. Savkin wrote:
А simple test case (2.6.13-rc6, fib_trie enabled):
# ip ro
172.16.16.0/22 dev vlan0173 proto kernel scope link src 172.16.18.1
172.16.0.0/16 via 172.16.16.1 dev vlan0173
10.0.0.0/8 via 172.16.16.1 dev vlan0173
# ip ro add unreachable 10.10.10.10
# ip ro flush cac
