On Mon, Jan 22, 2007 at 10:19:18AM +0300, Michael Tokarev wrote:
...
I was only running tcpdump - yes, it was running almost the
whole day, with different options. I did almost nothing.
You over-estimate my contribution, really ;)
The very good thing is that this bug is now found, and
On Mon, Jan 22, 2007 at 06:45:57PM +1100, Herbert Xu wrote:
On Mon, Jan 22, 2007 at 07:52:14AM +0100, Jarek Poplawski wrote:
I was so impressed by the amount of work done by Michael
that I magnified his merit and forgot to mention the role
of Patrick and Herbert, particularly here:
On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote:
+
+ /* PCI config space info */
+ pci_read_config_byte(pdev, PCI_REVISION_ID, hw-revision_id);
+ pci_read_config_word(pdev, PCI_COMMAND, hw-pci_cmd_word);
I'm highly suspicious of drivers that use the PCI_COMMAND word...
On 1/20/07, Arjan van de Ven [EMAIL PROTECTED] wrote:
On Sat, 2007-01-20 at 15:54 +0530, kalash nainwal wrote:
Hi there,
We've a kernel (n/w) module, which sits over ethernet. Whenever a pkt
is received (in softirq), after doing some minimal processing,
wake_up() is called to wake up
On Sun, Jan 21, 2007 at 02:02:15PM +0100, Thibaut VARENE wrote:
On 1/21/07, Thibaut VARENE [EMAIL PROTECTED] wrote:
...
Hmm, I think this is guaranteed not to work. In between those lines
the lock is released, while data in the mp structure is still being
accessed. It seems that this bit of
On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote:
On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote:
I said mostly fullmac. Sort of like ipw2100 (IIRC) is softmac but it
does all the association stuff in firmware. It doesn't fit fullmac, but
it's a lot more fullmac than
On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote:
3) Could you enumerate your issues with the command dispatching? Right
now, many of the commands are blocking, which is suboptimal. This is an
artifact of the embedded history of the part. We need to eventually fix
that and
diff --git a/drivers/net/atl1/atl1_hw.h b/drivers/net/atl1/atl1_hw.h
new file mode 100644
index 000..0450b77
--- /dev/null
+++ b/drivers/net/atl1/atl1_hw.h
[...]
+/* MII definition */
+/* PHY Common Register */
+#define MII_BMCR 0x00
+#define
Not only check the pointer against 0 but also the dereferenced value
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |6 --
2 files changed, 5 insertions(+), 3 deletions(-)
diff -Nurp -X dontdiff
Fix to use exactly one queue for incoming packets in all
firmware configurations
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nurp -X dontdiff linux-2.6.20-rc5/drivers/net/ehea/ehea_main.c
Logical partitions are not allowed to (try to) set the autonegotiation status.
This patch removes the respective function call from the port setup function.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |4 ++--
1 files changed, 2 insertions(+), 2
Count OFDT nodes to determine the number of available ports
instead of using the possibly outdated value from the hypervisor
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c | 15 ++-
1 files changed, 14 insertions(+), 1 deletion(-)
diff -Nurp -X
Disabled dump of hcall regs on some permission issues and
fixed appropriate misleading logmessages
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c | 16 +++-
drivers/net/ehea/ehea_phyp.c | 10 --
2 files changed, 15 insertions(+), 11
Fixed possible nullpointer access in event queue processing
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff -Nurp -X dontdiff linux-2.6.20-rc5/drivers/net/ehea/ehea_main.c
* Patrick McHardy [EMAIL PROTECTED] 2007-01-17 13:33
[NETLINK]: Don't BUG on undersized allocations
Currently netlink users BUG when the allocated skb for an event
notification is undersized. While this is certainly a kernel bug,
its not critical and crashing the kernel is too drastic,
As it is currently written, sys_select checks its return code to convert
ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, and
so if select is called from userspace with a NULL timeval, then it is possible
for the ERESTARTNOHAND errno to leak into userspace, which is
Herbert Xu wrote:
On Mon, Jan 22, 2007 at 07:52:14AM +0100, Jarek Poplawski wrote:
I was so impressed by the amount of work done by Michael
that I magnified his merit and forgot to mention the role
of Patrick and Herbert, particularly here:
You don't need to be so modest!
While no
I will be sending NetXen: 1G/10G Ethernet Driver updates in subsequent emails.
Thanks,
--Amit
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
This patch is to make the driver work with multiple minor firmware versions
Signed-off-by: Amit S. Kale [EMAIL PROTECTED]
---
netxen_nic.h|7 +++
netxen_nic_hw.c |3 ++-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/netxen/netxen_nic.h
This will use pci_register_driver() instead of pci_module_init().
Signed-off-by: Amit S. Kale [EMAIL PROTECTED]
Signed-off-by: Richard Knutsson [EMAIL PROTECTED]
---
netxen_nic.h |2 +-
netxen_nic_main.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
I am extremely sorry for sending this patch with wrong subject line before this.
Now i am resending the patch with correct line.
Thanks,
--Amit
This will use pci_register_driver() instead of pci_module_init().
Signed-off-by: Amit S. Kale [EMAIL PROTECTED]
Signed-off-by: Richard Knutsson [EMAIL
On 1/22/07, Marcelo Tosatti [EMAIL PROTECTED] wrote:
On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote:
On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote:
I said mostly fullmac. Sort of like ipw2100 (IIRC) is softmac but it
does all the association stuff in firmware. It
Jarek and Thibaut,
Thank you both very much for your work finding and fixing this bug.
Jarek, can you verify that the following patch fixes the problem you
were seeing?
-Dale
- Patch follows -
From: Dale Farnsworth [EMAIL PROTECTED]
mv643xx_eth: Fix race condition in
On Sat, Jan 20, 2007 at 08:05:07AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
Hello.
In article [EMAIL PROTECTED] (at Fri, 19 Jan 2007 16:23:14 -0500), Neil
Horman [EMAIL PROTECTED] says:
Patch to Implement IPv6 RFC 4429 (Optimistic Duplicate Address Detection).
In
Good work. We will
On Saturday 20 January 2007 07:19, Jan Evert van Grootheest wrote:
Hi,
Just writing to thank all of you that made the adm8211 driver in John
Linvilles wireless-2.6 development tree (not the dscape one, which I
will try also).
CC me then. :) Note that I only maintain the d80211 based adm8211
On Mon, Jan 22, 2007 at 08:39:24PM +0200, Mika Penttilä wrote:
Neil Horman wrote:
snip
I think you should remove / modify the :
if (!dad)
goto out;
which makes the rfc4429 tests not functional.
--Mika
Yeah, I think you're right. In fact, as I look at it more closely I think
Hi Neil
I don't this is still right...
@@ -746,6 +772,7 @@ static void ndisc_recv_ns(struct sk_buff *skb)
int dad = ipv6_addr_any(saddr);
int inc;
int is_router;
+ int type;
if (ipv6_addr_is_multicast(msg-target)) {
ND_PRINTK2(KERN_WARNING
@@
On Saturday 20 January 2007 17:18, Larry Finger wrote:
Some versions of the bcm43xx chips only support 30-bit DMA, which means
that the descriptors and buffers must be in the first 1 GB of RAM. On
the i386 and x86_64 architectures with more than 1 GB RAM, an incorrect
assignment may occur.
On Friday 19 January 2007 08:54, Pavel Roskin wrote:
Hello, Michael!
I did more testing, and the results are following. It looks like the
oopses and panics on i386 were triggered by 4k stacks. x86_64 doesn't
have this option.
Now that I enabled other debug options on both platforms. but
Michael Buesch wrote:
On Saturday 20 January 2007 17:18, Larry Finger wrote:
Some versions of the bcm43xx chips only support 30-bit DMA, which means
that the descriptors and buffers must be in the first 1 GB of RAM. On
the i386 and x86_64 architectures with more than 1 GB RAM, an incorrect
On Monday 22 January 2007 21:18, Larry Finger wrote:
When I looked at the b44 driver to see how that code handled the problem, it
used the pci-form of
the calls rather than the dma-version. Thus I switched early in the debug
process - even before I
had the necessary hardware. Once I got it
Hello, Michael!
On Mon, 2007-01-22 at 21:06 +0100, Michael Buesch wrote:
It's obviously some stack/memory corruption. But I'm not
sure if this is a stackoverflow. I'd rather say no, it isn't.
Could probably be triggered by something like kfree()ing
a dangling pointer or something...
Yes.
Hi Dave,
here are two additional fixes for the Bluetooth subsystem that should go
in before the final 2.6.20 release. It was possible that the well known
PSM could be bound by anybody. That should not be possible like TCP/IP
ports below 1024 are also restricted. The other one is a simple endian
On Tuesday 23 January 2007 00:00, Neil Horman wrote:
As it is currently written, sys_select checks its return code to convert
ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause,
and so if select is called from userspace with a NULL timeval, then it is
possible for the
Hello.
In article [EMAIL PROTECTED] (at Mon, 22 Jan 2007 13:15:28 -0500), Neil
Horman [EMAIL PROTECTED] says:
Reposted patch, with your suggestions/corrections incorporated. The only
thing
I left alone was your last comment regarding the checking of saddr for being a
unicast address.
Michael Buesch wrote:
On Monday 22 January 2007 21:44, Pavel Roskin wrote:
The problems with a MadWifi based AP turn out to be related to 802.11g.
If the AP is configured for 802.11b only, everything is working. If
802.11g is enabled, strange things are happening. Judging by what's on
the
Arjan, thank you very much for reviewing the driver.
Arjan van de Ven wrote:
On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote:
[snip]
+void atl1_irq_disable(struct atl1_adapter *adapter)
+{
+ atomic_inc(adapter-irq_sem);
+ iowrite32(0, adapter-hw.hw_addr + REG_IMR);
+
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/8139cp.c|7 +-
drivers/net/myri10ge/myri10ge.c | 23 -
drivers/net/sis190.c
Jeff Garzik wrote:
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
Jeff,
is there a reason that you didn't pull the e1000 tree from us? I send you all
the information 5 days ago, WITH the changes that you
Auke Kok wrote:
Jeff Garzik wrote:
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
Jeff,
is there a reason that you didn't pull the e1000 tree from us? I send
you all the information 5 days ago, WITH the changes
Jeff Garzik wrote:
Auke Kok wrote:
Jeff Garzik wrote:
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
Jeff,
is there a reason that you didn't pull the e1000 tree from us? I send
you all the information 5 days
Frederik Deweerdt wrote:
On Sun, Jan 21, 2007 at 01:45:27PM -0800, Auke Kok wrote:
Frederik Deweerdt wrote:
On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote:
It's the 10th resume and in /proc/interrupts eth0 appers 10 times.
The e100_resume() function should be calling
in the test program below the getsockname result on a TCP socket changes
across a write which produces EPIPE... here's a fragment of the strace:
getsockname(3, {sa_family=AF_INET, sin_port=htons(37636),
sin_addr=inet_addr(127.0.0.1)}, [17863593746633850896]) = 0
...
write(3, hi!\n, 4)
John W. Linville wrote:
The following changes since commit 10764889c6355cbb335cf0578ce12427475d1a65:
Larry Finger (1):
bcm43xx: Fix failure to deliver PCI-E interrupts
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
Ananda Raju wrote:
This patch adds two load parameters napi and ufo. Previously NAPI was
compilation option with these changes wan enable disable NAPI using load
parameter. Also we are introducing ufo load parameter to enable/disable
ufo feature
Signed-off-by: Sivakumar Subramani [EMAIL
dean gaudet [EMAIL PROTECTED] wrote:
in the test program below the getsockname result on a TCP socket changes
across a write which produces EPIPE... here's a fragment of the strace:
getsockname(3, {sa_family=AF_INET, sin_port=htons(37636),
sin_addr=inet_addr(127.0.0.1)},
Ananda Raju wrote:
1. Fix for reset and link handling.
2. Allow for promiscuos mode and multicast state be maintained through
ifconfig up and down.
3. Support to print adapter serial number.
Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED]
overall, looks OK, but have small nits noted
Ananda Raju wrote:
@@ -6999,7 +7003,7 @@ s2io_init_nic(struct pci_dev *pdev, cons
goto mem_alloc_failed;
}
- sp-bar0 = ioremap(pci_resource_start(pdev, 0),
+ sp-bar0 = (caddr_t) ioremap(pci_resource_start(pdev, 0),
Ananda Raju wrote:
Removed unused code in en_dis_able_nic_intrs(), TX_DMA_INTR, RX_DMA_INTR,
TX_XGXS_INTR, MC_INTR
Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED]
ACK
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
Ananda Raju wrote:
Removed namespace collisions due to usage of nic_t as per Ralf's patch
([EMAIL PROTECTED]).
Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED]
ACK
Please make the following the first line of your email body:
From: Ralf Baechle [EMAIL PROTECTED]
That will tell the patch
Jay Vosburgh wrote:
The code to select names for the bonding interfaces was, for the
non-sysfs creation case, always using a hard-coded set of bond0, bond1,
etc, up to max_bonds. This caused conflicts for the second or
subsequent loads of the module.
Changed the code to obtain
Kumar Gala wrote:
We need to export phy_ethtool_gset and phy_ethtool_sset to allow drivers
that
use these functions to be built as modules.
Signed-off-by: Kumar Gala [EMAIL PROTECTED]
your patch was corrupt. applied manually
Jeff
-
To unsubscribe from this list: send the line
Amit S. Kale wrote:
I am extremely sorry for sending this patch with wrong subject line before this.
Now i am resending the patch with correct line.
Thanks,
--Amit
Please include comments such as the above quoted /below/ the ---
terminator.
The git merge scripts copy everything preceding
Ayaz Abdulla wrote:
---
This email message is for the sole use of the intended recipient(s) and
may contain
confidential information. Any unauthorized review, use, disclosure or
distribution
is prohibited. If
Ayaz Abdulla wrote:
This patch adds a limit to how much tx work can be done in each
iteration of tx processing. If the max limit is reached, remaining tx
completions will be handled by timer interrupt.
Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED]
you attached the entire driver, rather than
Ayaz Abdulla wrote:
This patch introduces hw statistics for older devices that supported it.
It breaks up the counters supported into separate versions.
Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED]
ACK patches 11-12
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
On Mon, 2007-01-22 at 22:00 +0100, Michael Buesch wrote:
No more random crashes. There is still a crash if I rmmod the driver
while wlan0 is up, but it's a separate issue, and it's easy to avoid
(unlike the interface going down). I hope to look at it soon.
Did you apply that d80211
Jay Cliburn wrote:
This is the latest submittal of the patchset providing support for the
Attansic L1 gigabit ethernet adapter. This patchset is built against
kernel version 2.6.20-rc5.
This version incorporates all comments from:
Christoph Hellwig:
http://lkml.org/lkml/2007/1/11/43
Thomas Klein wrote:
Not only check the pointer against 0 but also the dereferenced value
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |6 --
2 files changed, 5 insertions(+), 3 deletions(-)
applied 1-7 to
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 56 +-
On Wed, Jan 17, 2007 at 08:14:17PM +0300, Kirill Korotaev wrote:
another small minor note.
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
arch/frv/kernel/pm.c | 50
+++---
On Wed, Jan 17, 2007 at 12:31:22PM -0700, Eric W. Biederman wrote:
Kirill Korotaev [EMAIL PROTECTED] writes:
Eric, though I personally don't care much:
1. I ask for not setting your authorship/copyright on the code which you
just
copied
from other places. Just doesn't look polite
62 matches
Mail list logo
