[PATCH v5 net-next 14/15] nfp: pass ring count as function parameter

2016-04-07 Thread Jakub Kicinski
Soon ring resize will call this functions with values different than the current configuration we need to explicitly pass the ring count as parameter. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 23 +-

[PATCH v5 net-next 11/15] nfp: sync ring state during FW reconfiguration

2016-04-07 Thread Jakub Kicinski
FW reconfiguration in .ndo_open()/.ndo_stop() should reset/ restore queue state. Since we need IRQs to be disabled when filling rings on RX path we have to move disable_irq() from .ndo_open() all the way up to IRQ allocation. nfp_net_start_vec() becomes trivial now so it's inlined.

[PATCH v5 net-next 07/15] nfp: reorganize initial filling of RX rings

2016-04-07 Thread Jakub Kicinski
Separate allocation of buffers from giving them to FW, thanks to this it will be possible to move allocation earlier on .ndo_open() path and reuse buffers during runtime reconfiguration. Similar to TX side clean up the spill of functionality from flush to freeing the ring. Unlike on TX side, RX

[PATCH v5 net-next 13/15] nfp: convert .ndo_change_mtu() to prepare/commit paradigm

2016-04-07 Thread Jakub Kicinski
When changing MTU on running device first allocate new rings and buffers and once it succeeds proceed with changing MTU. Allocation of new rings is not really necessary for this operation - it's done to keep the code simple and because size of the extra ring memory is quite small compared to the

[PATCH v5 net-next 05/15] nfp: allocate ring SW structs dynamically

2016-04-07 Thread Jakub Kicinski
To be able to switch rings more easily on config changes allocate them dynamically, separately from nfp_net structure. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 6 ++--- .../net/ethernet/netronome/nfp/nfp_net_common.c

[PATCH v5 net-next 06/15] nfp: cleanup tx ring flush and rename to reset

2016-04-07 Thread Jakub Kicinski
Since we never used flush without freeing the ring later the functionality of the two operations is mixed. Rename flush to ring reset and move there all the things which have to be done after FW ring state is cleared. While at it do some clean-ups. Signed-off-by: Jakub Kicinski

[PATCH v5 net-next 15/15] nfp: allow ring size reconfiguration at runtime

2016-04-07 Thread Jakub Kicinski
Since much of the required changes have already been made for changing MTU at runtime let's use it for ring size changes as well. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 1 +

[PATCH v5 net-next 09/15] nfp: move filling ring information to FW config

2016-04-07 Thread Jakub Kicinski
nfp_net_[rt]x_ring_{alloc,free} should only allocate or free ring resources without touching the device. Move setting parameters in the BAR to separate functions. This will make it possible to reuse alloc/free functions to allocate new rings while the device is running. Signed-off-by: Jakub

[PATCH v5 net-next 10/15] nfp: slice .ndo_open() and .ndo_stop() up

2016-04-07 Thread Jakub Kicinski
Divide .ndo_open() and .ndo_stop() into logical, callable chunks. No functional changes. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 218 + 1 file changed, 136 insertions(+), 82 deletions(-) diff

[PATCH v5 net-next 03/15] nfp: break up nfp_net_{alloc|free}_rings

2016-04-07 Thread Jakub Kicinski
nfp_net_{alloc|free}_rings contained strange mix of allocations and vector initialization. Remove it, declare vector init as a separate function and handle allocations explicitly. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c

Re: [PATCH v6 net-next] net: ipv4: Consider failed nexthops in multipath routes

2016-04-07 Thread Julian Anastasov
Hello, On Thu, 7 Apr 2016, David Ahern wrote: > Multipath route lookups should consider knowledge about next hops and not > select a hop that is known to be failed. > > Example: > > [h2] [h3] 15.0.0.5 > |

Re: [Lsf-pc] [Lsf] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-07 Thread Rik van Riel
On Thu, 2016-04-07 at 08:48 -0700, Chuck Lever wrote: > > > > On Apr 7, 2016, at 7:38 AM, Christoph Hellwig > > wrote: > > > > This is also very interesting for storage targets, which face the > > same > > issue.  SCST has a mode where it caches some fully constructed > >

[PATCH 1/9] afs: Wait for outstanding async calls before closing rxrpc socket

2016-04-07 Thread David Howells
The afs filesystem needs to wait for any outstanding asynchronous calls (such as FS.GiveUpCallBacks cleaning up the callbacks lodged with a server) to complete before closing the AF_RXRPC socket when unloading the module. This may occur if the module is removed too quickly after unmounting all

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 17:23 +0100, David Howells wrote: > Disable a debugging statement that has been left enabled > > Signed-off-by: David Howells > --- > >  net/rxrpc/ar-ack.c |2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/rxrpc/ar-ack.c

Re: [PATCH net-next] tcp/dccp: fix inet_reuseport_add_sock()

2016-04-07 Thread David Miller
From: Eric Dumazet Date: Wed, 06 Apr 2016 22:07:34 -0700 > From: Eric Dumazet > > David Ahern reported panics in __inet_hash() caused by my recent commit. > > The reason is inet_reuseport_add_sock() was still using > sk_nulls_for_each_rcu() instead

[PATCH v2 3/5] net: w5100: enable to support sleepable register access interface

2016-04-07 Thread Akinobu Mita
SPI transfer routines are callable only from contexts that can sleep. This adds ability to tell the core driver that the interface mode cannot access w5100 register on atomic contexts. In this case, workqueue and threaded irq are required. This also corrects timeout period waiting for command

[PATCH v2 4/5] net: w5100: support SPI interface mode

2016-04-07 Thread Akinobu Mita
This adds new w5100-spi driver which shares the bus interface independent code with existing w5100 driver. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * v2 - Use spi_write_then_read instead of

[PATCH v2 2/5] net: w5100: add ability to support other bus interface

2016-04-07 Thread Akinobu Mita
The w5100 driver currently only supports direct and indirect bus interface mode which use MMIO space for accessing w5100 registers. In order to support SPI interface mode which is supported by W5100 chip, this makes the bus interface abstraction layer more generic so that separated w5100-spi

[PATCH v2 5/5] net: w5100: support W5200

2016-04-07 Thread Akinobu Mita
This adds support for W5200 chip. W5100 and W5200 have similar memory map although some of their offsets are different. The register access sequences between them are different but w5100 driver has abstraction layer for difference bus interface modes so it is easy to add W5200 support to w5100

[PATCH v2 1/5] net: w5100: move mmiowb into register access callbacks

2016-04-07 Thread Akinobu Mita
Instead of sprinkle mmiowb over the driver code, move it into primary register write callbacks. (w5100_write, w5100_write16, w5100_writebuf) This is a preparation for supporting SPI interface which doesn't use MMIO for accessing w5100 registers. Signed-off-by: Akinobu Mita

[PATCH 4/9] rxrpc: Static arrays of strings should be const char *const[]

2016-04-07 Thread David Howells
Static arrays of strings should be const char *const[]. Signed-off-by: David Howells --- include/rxrpc/packet.h |2 -- net/rxrpc/ar-internal.h |2 +- net/rxrpc/misc.c|2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 5/9] rxrpc: Differentiate local and remote abort codes in structs

2016-04-07 Thread David Howells
In the rxrpc_connection and rxrpc_call structs, there's one field to hold the abort code, no matter whether that value was generated locally to be sent or was received from the peer via an abort packet. Split the abort code fields in two for cleanliness sake and add an error field to hold the

[PATCH 8/9] rxrpc: Absorb the rxkad security module

2016-04-07 Thread David Howells
Absorb the rxkad security module into the af_rxrpc module so that there's only one module file. This avoids a circular dependency whereby rxkad pins af_rxrpc and cached connections pin rxkad but can't be manually evicted (they will expire eventually and cease pinning). With this change, af_rxrpc

[PATCH 6/9] rxrpc: Don't pass gfp around in incoming call handling functions

2016-04-07 Thread David Howells
Don't pass gfp around in incoming call handling functions, but rather hard code it at the points where we actually need it since the value comes from within the rxrpc driver and is always the same. Signed-off-by: David Howells --- net/rxrpc/ar-accept.c |4 ++--

[PATCH 7/9] rxrpc: Don't assume transport address family and size when using it

2016-04-07 Thread David Howells
Don't assume transport address family and size when using the peer address to send a packet. Instead, use the start of the transport address rather than any particular element of the union and use the transport address length noted inside the sockaddr_rxrpc struct. This will be necessary when

[PATCH 9/9] rxrpc: Create a null security type and get rid of conditional calls

2016-04-07 Thread David Howells
Create a null security type for security index 0 and get rid of all conditional calls to the security operations. We expect normally to be using security, so this should be of little negative impact. Signed-off-by: David Howells --- net/rxrpc/Makefile|1 +

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Howells
Joe Perches wrote: > It might be better to remove kenter and _enter > altogether and use function tracing instead. Possibly - but not at this time. Besides, isn't the function tracing log lost if the machine crashes? David

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 18:05 +0100, David Howells wrote: > Joe Perches wrote: > > It might be better to remove kenter and _enter > > altogether and use function tracing instead. > Possibly - but not at this time. Swell. > Besides, isn't the function tracing log lost > if the

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Miller
From: Joe Perches Date: Thu, 07 Apr 2016 09:31:17 -0700 > On Thu, 2016-04-07 at 17:23 +0100, David Howells wrote: >> Disable a debugging statement that has been left enabled >> >> Signed-off-by: David Howells >> --- >> >>  net/rxrpc/ar-ack.c |2 +- >>

Re: [PATCH v2 1/5] net: w5100: move mmiowb into register access callbacks

2016-04-07 Thread David Miller
Where is your "[PATCH v2 0/5] ..." header posting explaing what this series is doing, at a high level, how it is doing that, and why it is doing it that way? This is mandator for patch series submissions.

Re: Backport Security Fix for CVE-2015-8787 to v4.1

2016-04-07 Thread David Miller
From: Yuki Machida Date: Thu, 7 Apr 2016 15:40:30 +0900 > Hi David, > > I conformed that a patch of CVE-2015-8787 not applied at v4.1.21. > Could you please apply a patch for 4.1-stable ? > > CVE-2015-8787 > Upstream commit 94f9cd81436c85d8c3a318ba92e236ede73752fc

Re: mwifiex: ie_list is an array, so no need to check if NULL

2016-04-07 Thread Kalle Valo
> From: Colin Ian King > > ap_ie->ie_list is an array of struct mwifiex_ie and can never > be null, so the null check on this array is redundant and can > be removed. > > Signed-off-by: Colin Ian King Thanks, applied to

How to get creatior PID information for the local tcp connection

2016-04-07 Thread Vishnu Pratap Singh
Hi, Issue - How to get PID information for the local tcp connection i want to get the creator PID for each socket in user space for local tcp connection, i see in kernel there is support for returing PID with "SO_PEERCRED" ioctl to work across namespaces. it uses struct pid and struct cred

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-07 Thread Bart Van Assche
On 04/07/16 07:38, Christoph Hellwig wrote: This is also very interesting for storage targets, which face the same issue. SCST has a mode where it caches some fully constructed SGLs, which is probably very similar to what NICs want to do. I think a cached allocator for page sets + the

Re: [PATCH v2] packet: uses kfree_skb() for drops or errors.

2016-04-07 Thread Willem de Bruijn
On Wed, Apr 6, 2016 at 5:14 PM, Weongyo Jeong wrote: > consume_skb() isn't for drop or error cases for drop or error -> for error > that kfree_skb() is more proper > one. At this patch, it fixed tpacket_rcv() and packet_rcv() to be > consistent for error or non-error

[PATCH 3/9] rxrpc: Move some miscellaneous bits out into their own file

2016-04-07 Thread David Howells
Move some miscellaneous bits out into their own file to make it easier to split the call handling. Signed-off-by: David Howells --- include/net/af_rxrpc.h |1 + net/rxrpc/Makefile |3 +- net/rxrpc/ar-ack.c | 68

[PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Howells
Disable a debugging statement that has been left enabled Signed-off-by: David Howells --- net/rxrpc/ar-ack.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c index 16d967075eaf..01a017a05f14 100644 ---

[PATCH 0/9] RxRPC: 2nd rewrite part 1

2016-04-07 Thread David Howells
-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160407 This is based on net-next/master David --- David Howells (9): afs: Wait for outstanding async calls before closing rxrpc socket rxrpc: Disable a debugging

Re: [netfilter-core] [PATCH] netfilter: unnecessary to check whether ip6_route_output() returns NULL

2016-04-07 Thread Pablo Neira Ayuso
On Sun, Apr 03, 2016 at 10:03:33PM +0800, Haishuang Yan wrote: > ip6_route_output() never returns NULL, so it is not appropriate to > check if the return value is NULL. Applied, thanks.

Re: optimizations to sk_buff handling in rds_tcp_data_ready

2016-04-07 Thread Sowmini Varadhan
On (04/07/16 07:16), Eric Dumazet wrote: > Use skb split like TCP in output path ? That almost looks like what I want, but skb_split modifies both skb and skb1, and I want to leave skb untouched (otherwise I will mess up the book-keeping in tcp_read_sock). But skb_split is a good template- I

[PATCH V2 6/8] net: mediatek: fix TX locking

2016-04-07 Thread John Crispin
Inside the TX path there is a lock inside the tx_map function. This is however too late. The patch moves the lock to the start of the xmit function right before the free count check of the DMA ring happens. If we do not do this, the code becomes racy leading to TX stalls and dropped packets. This

[PATCH V2] net: mediatek: update the IRQ part of the binding document

2016-04-07 Thread John Crispin
The current binding document only describes a single interrupt. Update the document by adding the 2 other interrupts. The driver currently only uses a single interrupt. The HW is however able to using IRQ grouping to split TX and RX onto separate GIC irqs. Signed-off-by: John Crispin

[PATCH V2 4/8] net: mediatek: fix stop and wakeup of queue

2016-04-07 Thread John Crispin
The driver supports 2 MACs. Both run on the same DMA ring. If we go above/below the TX rings threshold value, we always need to wake/stop the queue of both devices. Not doing to can cause TX stalls and packet drops on one of the devices. Signed-off-by: John Crispin ---

[PATCH V2 2/8] net: mediatek: mtk_cal_txd_req() returns bad value

2016-04-07 Thread John Crispin
The code used to also support the PDMA engine, which had 2 packet pointers per descriptor. Because of this we had to divide the result by 2 and round it up. This is no longer needed as the code only supports QDMA. Signed-off-by: John Crispin ---

[PATCH V2 1/8] net: mediatek: watchdog_timeo was not set

2016-04-07 Thread John Crispin
The original commit failed to set watchdog_timeo. This patch sets watchdog_timeo to HZ. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Howells
Joe Perches wrote: > > Joe Perches wrote: > > > It might be better to remove kenter and _enter > > > altogether and use function tracing instead. > > Possibly - but not at this time. > > Swell. I didn't say I wouldn't do it - it's just that I'm trying to

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Howells
David Miller wrote: > Yeah this custom stuff is really inappropriate given the excellent > infrastructure we have these days... Excellent only if I can get at it to find out why the something went wrong. If it's lost because the machine panics, then it is worthless. David

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Miller
From: David Howells Date: Thu, 07 Apr 2016 20:45:08 +0100 > David Miller wrote: > >> Yeah this custom stuff is really inappropriate given the excellent >> infrastructure we have these days... > > Excellent only if I can get at it to find out why the

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Howells
Joe Perches wrote: > > Let's see...  If the machine panics whilst I'm developing stuff (quite > > likely if something goes wrong in BH context), how do I get at the > > function tracing log to find out why it panicked if the log is then > > lost?  With the serial console, at

Re: [PATCH net-next 0/8] udp: GRO in UDP sockets

2016-04-07 Thread David Miller
From: Tom Herbert Date: Tue, 5 Apr 2016 08:22:48 -0700 > This patch set adds GRO functions (gro_receive and gro_complete) to UDP > sockets and removes udp_offload infrastructure. > > Add GRO functions (gro_receive and gro_complete) to UDP sockets. In > udp_gro_receive and

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-07 Thread Jesper Dangaard Brouer
On Thu, 07 Apr 2016 12:14:00 -0400 Rik van Riel wrote: > On Thu, 2016-04-07 at 08:48 -0700, Chuck Lever wrote: > > > > > > On Apr 7, 2016, at 7:38 AM, Christoph Hellwig > > > wrote: > > > > > > This is also very interesting for storage targets, which face

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-07 Thread Andrew Lunn
> I'm back to working on this driver, and I need some more help with > how to handle the phy. mdio-gpio.txt doesn't really tell me much. > I'm actually working on an ACPI system and not DT. I can help you with DT, but not ACPI. The MDIO bus can be a separate Linux device. Since you have GPIO

Re: [Lsf] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-07 Thread Jesper Dangaard Brouer
On Thu, 7 Apr 2016 19:48:50 + "Waskiewicz, PJ" wrote: > On Thu, 2016-04-07 at 16:17 +0200, Jesper Dangaard Brouer wrote: > > (Topic proposal for MM-summit) > > > > Network Interface Cards (NIC) drivers, and increasing speeds stress > > the page-allocator (and DMA

[RFC PATCH] possible bug in handling of ipv4 route caching

2016-04-07 Thread Chris Friesen
Hi, We think we may have found a bug in the handling of ipv4 route caching, and are curious what you think. For local routes that require a particular output interface we do not want to cache the result. Caching the result causes incorrect behaviour when there are multiple source addresses on

[PATCH V2 5/8] net: mediatek: fix mtk_pending_work

2016-04-07 Thread John Crispin
The driver supports 2 MACs. Both run on the same DMA ring. If we hit a TX timeout we need to stop both netdevs before restarting them again. If we don't do this, mtk_stop() wont shutdown DMA and the consecutive call to mtk_open() wont restart DMA and enable IRQs. Signed-off-by: John Crispin

[PATCH V2 0/8] net: mediatek: make the driver pass stress tests

2016-04-07 Thread John Crispin
While testing the driver we managed to get the TX path to stall and fail to recover. When dual MAC support was added to the driver, the whole queue stop/wake code was not properly adapted. There was also a regression in the locking of the xmit function. The fact that watchdog_timeo was not set and

[PATCH V2 7/8] net: mediatek: move the pending_work struct to the device generic struct

2016-04-07 Thread John Crispin
The worker always touches both netdevs. It is ethernet core and not MAC specific. We only need one worker, which belongs into the ethernets core struct. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 10 --

[PATCH V2 3/8] net: mediatek: remove superfluous reset call

2016-04-07 Thread John Crispin
HW reset is triggered in the mtk_hw_init() function. There is no need to also reset the core during probe. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |4 1 file changed, 4 deletions(-) diff --git

Re: [PATCH V2 6/8] net: mediatek: fix TX locking

2016-04-07 Thread Sergei Shtylyov
Hello. On 04/07/2016 10:26 PM, John Crispin wrote: Inside the TX path there is a lock inside the tx_map function. This is however too late. The patch moves the lock to the start of the xmit function right before the free count check of the DMA ring happens. If we do not do this, the code

Re: [PATCH v2 net-next 00/10] allow bpf attach to tracepoints

2016-04-07 Thread David Miller
From: Alexei Starovoitov Date: Wed, 6 Apr 2016 18:43:21 -0700 > Hi Steven, Peter, Steven/Peter, can you give this series a review? Thanks!

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Miller
From: David Howells Date: Thu, 07 Apr 2016 21:47:19 +0100 > David Miller wrote: > >> > Excellent only if I can get at it to find out why the something went wrong. >> > If it's lost because the machine panics, then it is worthless. >> >> If you're ok

[PATCH V2 8/8] net: mediatek: do not set the QID field in the TX DMA descriptors

2016-04-07 Thread John Crispin
The QID field gets set to the mac id. This made the DMA linked list queue the traffic of each MAC on a different internal queue. However during long term testing we found that this will cause traffic stalls as the multi queue setup requires a more complete initialisation which is not part of the

Re: [Lsf] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-07 Thread Waskiewicz, PJ
On Thu, 2016-04-07 at 16:17 +0200, Jesper Dangaard Brouer wrote: > (Topic proposal for MM-summit) > > Network Interface Cards (NIC) drivers, and increasing speeds stress > the page-allocator (and DMA APIs).  A number of driver specific > open-coded approaches exists that work-around these

Re: [PATCH v2 net-next 02/10] perf: remove unused __addr variable

2016-04-07 Thread Peter Zijlstra
On Wed, Apr 06, 2016 at 06:43:23PM -0700, Alexei Starovoitov wrote: > now all calls to perf_trace_buf_submit() pass 0 as 4th > argument which will be repurposed in the next patch which will > change the meaning of 1st arg of perf_tp_event() to event_type > > Signed-off-by: Alexei Starovoitov

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 20:43 +0100, David Howells wrote: > Joe Perches wrote: > > > Joe Perches wrote: > > > > It might be better to remove kenter and _enter > > > > altogether and use function tracing instead. > > > Possibly - but not at this time. > > Swell.

Re: [PATCH net-next 0/3] sock: lockdep tightening

2016-04-07 Thread David Miller
From: Hannes Frederic Sowa Date: Tue, 5 Apr 2016 17:10:13 +0200 > First patch is from Eric Dumazet and improves lockdep accuracy for > socket locks. After that, second patch introduces lockdep_sock_is_held > and uses it. Final patch reverts and reworks the lockdep

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Howells
David Miller wrote: > > Excellent only if I can get at it to find out why the something went wrong. > > If it's lost because the machine panics, then it is worthless. > > If you're ok with these kenter things spewing into the logs with the > current facility, you can run

Re: [PATCH v2 net-next 03/10] perf: split perf_trace_buf_prepare into alloc and update parts

2016-04-07 Thread Peter Zijlstra
On Wed, Apr 06, 2016 at 06:43:24PM -0700, Alexei Starovoitov wrote: > split allows to move expensive update of 'struct trace_entry' to later phase. > Repurpose unused 1st argument of perf_tp_event() to indicate event type. > > While splitting use temp variable 'rctx' instead of '*rctx' to avoid >

[net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held'

2016-04-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 1fbbe1a8a9b195c4ac856540dfaef49d663c2e91 commit: 1e1d04e678cf72442f57ce82803c7a407769135f [194/196] net: introduce lockdep_is_held and update various places to use it config: i386-tinyconfig (attached as

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

2016-04-07 Thread David Howells
David Miller wrote: > As you can with the function tracer and tracepoints. I've had experience with tracepoints before (i2c and smbus). It wasn't particularly fun. There's got to be some easier way to write them. Hmmm... Of the _enter() and _leave() macros in my tree at

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-07 Thread Timur Tabi
Andrew Lunn wrote: I'm back to working on this driver, and I need some more help with how to handle the phy. mdio-gpio.txt doesn't really tell me much. I'm actually working on an ACPI system and not DT. I can help you with DT, but not ACPI. The MDIO bus can be a separate Linux device. Since

[PATCH net-next] sock: make lockdep_sock_is_held static inline

2016-04-07 Thread Hannes Frederic Sowa
I forgot to add inline to lockdep_sock_is_held, so it generated all kinds of build warnings if not build with lockdep support. Reported-by: kbuild test robot Signed-off-by: Hannes Frederic Sowa --- include/net/sock.h | 2 +- 1 file changed, 1

Re: [RFC PATCH] possible bug in handling of ipv4 route caching

2016-04-07 Thread Julian Anastasov
Hello, On Thu, 7 Apr 2016, Chris Friesen wrote: > Hi, > > We think we may have found a bug in the handling of ipv4 route caching, > and are curious what you think. > > For local routes that require a particular output interface we do not > want to cache the result. Caching the result

Re: [PATCH net-next] sock: make lockdep_sock_is_held static inline

2016-04-07 Thread Hannes Frederic Sowa
On 08.04.2016 00:37, Eric Dumazet wrote: On Thu, 2016-04-07 at 15:30 -0700, Eric Dumazet wrote: But... this wont solve the compiler error ? include/net/sock.h: In function 'lockdep_sock_is_held': include/net/sock.h:1367:2: error: implicit declaration of function 'lockdep_is_held'

Re: [PATCH net] lockdep: provide always true lockdep_is_held stub if lockdep disabled

2016-04-07 Thread Hannes Frederic Sowa
On 08.04.2016 01:12, Hannes Frederic Sowa wrote: I need this to provide a generic lockdep_sock_is_held function which can be easily used in the kernel without using ifdef PROVEN macros. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Eric Dumazet

[PATCH net-next v2] sock: make lockdep_sock_is_held inline and conditional on LOCKDEP

2016-04-07 Thread Hannes Frederic Sowa
lockdep_is_held is only specified if CONFIG_LOCKDEP is defined, so make it depending on it. Also add the missing inline keyword, so no warnings about unused functions show up during complilation. Cc: Eric Dumazet Cc: David Miller Signed-off-by:

Re: [PATCH net-next v2] sock: make lockdep_sock_is_held inline and conditional on LOCKDEP

2016-04-07 Thread David Miller
From: Hannes Frederic Sowa Date: Fri, 8 Apr 2016 01:35:18 +0200 > lockdep_is_held is only specified if CONFIG_LOCKDEP is defined, so make > it depending on it. > > Also add the missing inline keyword, so no warnings about unused functions > show up during

Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 18:36 -0700, Dexuan Cui wrote: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. [] > diff --git

[PATCH ipoute2] iplink: display number of rx/tx queues

2016-04-07 Thread Eric Dumazet
From: Eric Dumazet We can set the attributes, so would be nice to display them when provided by the kernel. Signed-off-by: Eric Dumazet --- diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 3998d8c..f7bd1c7 100644 --- a/ip/ipaddress.c +++

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-07 Thread Jesse Gross
On Thu, Apr 7, 2016 at 7:32 PM, Alexander Duyck wrote: > This patch adds support for a feature I am calling IP ID mangling. It is > basically just another way of saying the IP IDs that are transmitted by the > tunnel may not match up with what would normally be expected.

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-07 Thread Alexander Duyck
On Thu, Apr 7, 2016 at 4:22 PM, Jesse Gross wrote: > On Thu, Apr 7, 2016 at 7:32 PM, Alexander Duyck wrote: >> This patch adds support for a feature I am calling IP ID mangling. It is >> basically just another way of saying the IP IDs that are transmitted

[PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

[PATCH v8 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-04-07 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

Re: [PATCH net-next] sock: make lockdep_sock_is_held static inline

2016-04-07 Thread Eric Dumazet
On Fri, 2016-04-08 at 00:47 +0200, Hannes Frederic Sowa wrote: > I see... hmpf. > > Wouldn't it be nicer if I include a helper a la: > > #define lockdep_is_held(lock) 1 > > in lockdep.h in case lockdep is globally not enabled? I do actually have > already another user for this outside of

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-07 Thread Andrew Lunn
On Thu, Apr 07, 2016 at 04:43:47PM -0500, Timur Tabi wrote: > On my platform, firmware (UEFI) configures all of the GPIOs. I need > to get confirmation, but it appears that we don't actually make any > GPIO calls at all. I see code that looks like this: > > for (i = 0;

Re: [PATCH net-next v2] macvlan: Support interface operstate properly

2016-04-07 Thread Banerjee, Debabrata
On 4/7/16, 7:05 AM, "Nikolay Aleksandrov" wrote: >On 04/07/2016 12:36 AM, Debabrata Banerjee wrote: >> Set appropriate macvlan interface status based on lower device and our >> status. Can be up, down, or lowerlayerdown. >What about dormant ? > >That being said I

Re: [PATCH v2 net-next 00/10] allow bpf attach to tracepoints

2016-04-07 Thread David Miller
Series applied, thanks Alexei.

[PATCH net-next] macvlan: Set nocarrier when lowerdev admin down

2016-04-07 Thread Debabrata Banerjee
When the lowerdev is set administratively down disable carrier on the macvlan interface. This means operstate gets set properly instead of still being "up". Signed-off-by: Debabrata Banerjee --- drivers/net/macvlan.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-04-07 Thread Yang Yingliang
On 2016/3/30 20:56, Sergei Shtylyov wrote: Hello. On 3/30/2016 8:16 AM, Yang Yingliang wrote: When task A hold the sk owned in tcp_sendmsg, if lots of packets arrive and the packets will be added to backlog queue. The packets will be handled in release_sock called from tcp_sendmsg. When the

Re: [PATCH net-next] bpf: simplify verifier register state assignments

2016-04-07 Thread Daniel Borkmann
On 04/07/2016 04:39 AM, Alexei Starovoitov wrote: verifier is using the following structure to track the state of registers: struct reg_state { enum bpf_reg_type type; union { int imm; struct bpf_map *map_ptr; }; }; and later on in states_equal() does

Backport Security Fix for CVE-2015-8787 to v4.1

2016-04-07 Thread Yuki Machida
Hi David, I conformed that a patch of CVE-2015-8787 not applied at v4.1.21. Could you please apply a patch for 4.1-stable ? CVE-2015-8787 Upstream commit 94f9cd81436c85d8c3a318ba92e236ede73752fc Regards, Yuki Machida

[PATCH 0/1] net: stmmac: socfgpa: Ensure emac bit set in System Manger for PTP

2016-04-07 Thread Phil Reid
Enable PTP FPGA clock, pps and ext trig connections to stmmac. Note: This hardware configuration is not offically support by Altera. Phil Reid (1): net: stmmac: socfgpa: Ensure emac bit set in System Manger for PTP drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 16 +--- 1

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-04-07 Thread Yang Yingliang
On 2016/3/30 21:47, Eric Dumazet wrote: On Wed, 2016-03-30 at 13:56 +0800, Yang Yingliang wrote: Sorry, I made a mistake. I am very sure my kernel has these two patches. And I can get some dropping of the packets in 10Gb eth. # netstat -s | grep -i backlog TCPBacklogDrop: 4135 #

[PATCH] net: mark DECnet as broken

2016-04-07 Thread Vegard Nossum
There are NULL pointer dereference bugs in DECnet which can be triggered by unprivileged users and have been reported multiple times to LKML, however nobody seems confident enough in the proposed fixes to merge them and the consensus seems to be that nobody cares enough about DECnet to see it

Re: [PATCH] net: mark DECnet as broken

2016-04-07 Thread James Cameron
On Thu, Apr 07, 2016 at 09:22:43AM +0200, Vegard Nossum wrote: > There are NULL pointer dereference bugs in DECnet which can be triggered > by unprivileged users and have been reported multiple times to LKML, > however nobody seems confident enough in the proposed fixes to merge them > and the

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-07 Thread Paolo Abeni
Hi Casey, On Wed, 2016-04-06 at 14:43 -0700, Casey Schaufler wrote: > On 4/6/2016 2:51 AM, Paolo Abeni wrote: > > Currently, selinux always registers iptables POSTROUTING hooks regarless of > > the running policy needs for any action to be performed by them. > > > > Even the socket_sock_rcv_skb()

[PATCH 1/1] net: stmmac: socfgpa: Ensure emac bit set in System Manger for PTP

2016-04-07 Thread Phil Reid
When using the PTP fpga to hps clock source for the stmmac module the appropriate bit in the System Manager FPGA Interface Group register needs to be set. This is not set by the bootloader setup when the HPS emac pins are being for this emac module. This allows the PTP clock to be sourced from

Re: [PATCH v2 2/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-07 Thread Jakub Sitnicki
On Wed, Apr 06, 2016 at 07:53 PM CEST, Marcelo Ricardo Leitner wrote: > Currently, the processing of multiple chunks in a single SCTP packet > leads to multiple calls to sk_data_ready, causing multiple wake up > signals which are costly and doesn't make it wake up any

[PATCH] netlink: don't send NETLINK_URELEASE for unbound sockets

2016-04-07 Thread Johannes Berg
From: Dmitry Ivanov All existing users of NETLINK_URELEASE use it to clean up resources that were previously allocated to a socket via some command. As a result, no users require getting this notification for unbound sockets. Sending it for unbound sockets, however,

Re: [net PATCH v3] GRE: Disable segmentation offloads w/ CSUM and we are encapsulated via FOU

2016-04-07 Thread David Miller
From: Alexander Duyck Date: Tue, 05 Apr 2016 09:13:39 -0700 > This patch fixes an issue I found in which we were dropping frames if we > had enabled checksums on GRE headers that were encapsulated by either FOU > or GUE. Without this patch I was barely able to get 1 Gb/s of

<    1   2   3   >