[PATCH net-next] Add a tcp_filter hook before handle ack packet

2017-06-20 Thread Chenbo Feng
From: Chenbo Feng Currently in both ipv4 and ipv6 code path, the ack packet received when sk at TCP_NEW_SYN_RECV state is not filtered by socket filter or cgroup filter since it is handled from tcp_child_process and never reaches the tcp_filter inside tcp_v4_rcv or tcp_v6_rcv. Adding a tcp_filter

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/20 21:28, Andrew Lunn wrote: The question really is, why is not this properly integrated into the PHY driver and PHYLIB such that the only thing the Ethernet MAC driver has to call is a function of the PHY driver putting it in self-test? >>> >>> This whole drive

[PATCH] PATCH v3 Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Michael J Dilmore
The bond_options.c file contains multiple netdev_info messages that clutter kernel output. This patches replaces these with netdev_dbg messages and adds a netdev_dbg for packets for slave. Signed-off-by: Michael J Dilmore Suggested-by: Joe Perches --- drivers/net/bonding/bond_options.c | 54 +++

Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Ethan Zhao
Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva wrote: > Check return value from call to e

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: David Miller Date: Tue, 20 Jun 2017 21:17:13 -0400 > From: Felix Manlunas > Date: Tue, 20 Jun 2017 13:51:25 -0700 > > > From: Derek Chickles > > Date: Tue, 20 Jun 2017 13:15:34 -0700 > > > >> > From: David Miller [mailto:da...@davemloft.net] > >> > Sent: Tuesday, June 20, 2017 12:22 PM

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread jeffy
Hi Cong Wang, i don't know much about net core, maybe i'm misreading the code...but On 06/21/2017 02:42 AM, Cong Wang wrote: In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf") I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, unfortunately, as reporte

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread David Ahern
On 6/20/17 5:41 PM, Ben Greear wrote: > On 06/20/2017 11:05 AM, Michal Kubecek wrote: >> On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: >>> On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: > On 06/13/2017 07:27 PM, David Ahern wrote: > >

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread jeffy
Hi Cong Wang, oh, oops, i did misread. also, Tested-by: Jeffy Chen On 06/21/2017 11:01 AM, jeffy wrote: Hi Cong Wang, i don't know much about net core, maybe i'm misreading the code...but On 06/21/2017 02:42 AM, Cong Wang wrote: In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread Andrew Lunn
On Wed, Jun 21, 2017 at 10:03:29AM +0800, l00371289 wrote: > Hi, Andrew > > On 2017/6/20 21:27, Andrew Lunn wrote: > > On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: > >> hi, Florian > >> > >> On 2017/6/20 5:00, Florian Fainelli wrote: > >>> On 06/16/2017 02:24 AM, Lin Yun Sheng wrote:

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread David Ahern
On 6/20/17 2:42 PM, Cong Wang wrote: > In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after > ipv6_dev_notf") > I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, > unfortunately, as reported by jeffy, netdev_wait_allrefs() > could rebroadcast NETDEV_UNREGISTER event until

[PATCH net-next] r8152: correct the definition

2017-06-20 Thread Hayes Wang
Replace VLAN_HLEN and CRC_SIZE with ETH_FCS_LEN. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 8bc4573..6cfffef 100644 --- a/drivers/net/us

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/21 11:13, Andrew Lunn wrote: > On Wed, Jun 21, 2017 at 10:03:29AM +0800, l00371289 wrote: >> Hi, Andrew >> >> On 2017/6/20 21:27, Andrew Lunn wrote: >>> On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: hi, Florian On 2017/6/20 5:00, Florian Fainelli wr

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread John Crispin
On 20/06/17 23:52, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote: On 20/06/17 16:01, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices.

[PATCH net-next] qede: Fix compilation without QED_RDMA

2017-06-20 Thread Yuval Mintz
From: Chad Dupuis When CONFIG_QED_RDMA isn't defined, we'd hit the following: /include/linux/qed/qede_rdma.h:84:19: warning: ‘qede_rdma_dev_add’ used but never defined [enabled by default] static inline int qede_rdma_dev_add(struct qede_dev *dev); Fixes: bbfcd1e8e167 ("qed*: Set rdma generic

Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-20 Thread Steffen Klassert
On Mon, Jun 19, 2017 at 11:33:20AM +0300, yoss...@mellanox.com wrote: > From: Yossi Kuperman > > IPv6 payload length indicates the size of the payload, including any > extension headers. In xfrm6_transport_finish, ipv6_hdr(skb)->payload_len > is set to the payload size only, regardless of the pre

[PATCH v2] brcmfmac: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Christophe JAILLET
If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error handling path to free it in such a case. Cc: sta...@vger.kernel.org Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") Signed-off-by: Christophe JAILLET --- v2: Add CC tag Change prefix --- drivers/net/

[PATCH rdma-next 01/19] RDMA/netlink: Add flag to consolidate common handing

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Add ability to provide flags to control RDMA netlink callbacks and convert addr.c and sa_query.c to be first users of such infrastructure. It allows to move their CAP_NET_ADMIN checks into netlink core. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/addr.c

[PATCH rdma-next 00/19] RDMA Netlink Device Client

2017-06-20 Thread Leon Romanovsky
The following patch set is an implementation of NLDEV - RDMA netlink device client. It is based on the already sent patch [1] and patch set [2]. This client is needed to properly integrate coming RDMAtool [3] into iproute2 package which is based on netlink. The following patch set can be logicall

[PATCH rdma-next 02/19] RDMA/netlink: Simplify the put_msg and put_attr

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Reuse standard macros to cancel the netlink message in case of error. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/netlink.c | 31 +-- 1 file changed, 9 insertions(+), 22 deletions(-) diff --git a/drivers/infiniband/core/netlink.

[PATCH rdma-next 04/19] RDMA/netlink: Rename and remove redundant parameter from ibnl_multicast

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The pointer to netlink header was not used in the ibnl_multicast function, so let's remove it and simplify the function signature. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/addr.c | 2 +- drivers/infiniband/core/iwpm_msg.c | 2 +- drivers/infiniband/c

[PATCH rdma-next 05/19] RDMA/netlink: Simplify and rename ibnl_chk_listeners

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Make ibnl_chk_listeners function to be one line by removing unneeded comparison. Rename that function to be complaint to other functions in RDMA netlink. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/addr.c | 2 +- drivers/infiniband/core/netlink.c | 8

[PATCH rdma-next 16/19] RDMa/netlink: Add nldev device doit implementation

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Provide ability to query specific device. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c ind

[PATCH rdma-next 08/19] RDMA/core: Expose translation from device name to ib_device

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Provide ability to convert from device name to ib_device for the IB/core users. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/core_priv.h | 1 + drivers/infiniband/core/device.c| 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH rdma-next 10/19] RDMA/netlink: Reduce indirection access to cb_table

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Introduce intermediate variable to store access to fields of cb_table. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/netlink.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/core/netlink.c b/drivers/infin

[PATCH rdma-next 11/19] RDMA/netlink: Convert LS to doit callback

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky RDMA_NL_LS protocol is actually is not dump anything, but sets data and it should be handled by doit callback. This patch actually converts RDMA_NL_LS to doit callback, while preserving IWCM and RDMA_CM flows through netlink_dump_start(). Signed-off-by: Leon Romanovsky --

[PATCH rdma-next 12/19] RDMA/netlink: Update copyright

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Add Mellanox to the copyright header. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c index 52fce73be9c1..9731c313e9b9 100644 --

[PATCH rdma-next 07/19] RDMA/core: Add iterator over ib_devices

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The coming nldev needs iterate over all IB devices in the system and in order do not expose the ib_devices list outside the devices.c, it is necessary to provide function iterator. Current version is written explicitly for nldev callback to avoid over-engineering at this st

[PATCH rdma-next 06/19] RDMA/netlink: Rename netlink callback struct

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The RDMA netlink client infrastructure was removed and made obsolete the old name (ibnl_client_cbs). This patch renames to the more appropriate name (rdma_nl_cbs). Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/device.

[PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Introduce new defines to rdma_netlink.h, so the RDMA configuration tool will be able to communicate with RDMA subsystem by using the shared defines. The addition of new client (NLDEV) revealed the fact that we exposed by mistake the RDMA_NL_I40IW define which is not backed

[PATCH rdma-next 18/19] RDMA/netlink: Implement nldev port doit callback

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Provide ability to get specific to device and port information. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infi

[PATCH rdma-next 14/19] RDMA/netlink: Add nldev initialization flows

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Add nldev init and exit flows to the RDMA/core. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/Makefile| 4 +++- drivers/infiniband/core/core_priv.h | 4 drivers/infiniband/core/device.c| 2 ++ drivers/infiniband/core/nldev.c | 45 +

[PATCH rdma-next 17/19] RDMA/netlink: Add nldev port dumpit implementation

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky This patch implements the query interface to get all ports data for the specific device. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 60 + 1 file changed, 60 insertions(+) diff --git a/drivers/infiniband/co

[PATCH rdma-next 19/19] RDMA/netlink: Expose device and port capability masks

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The port capability mask is exposed to user space via sysfs interface, while device capabilities are available for verbs only. This patch provides those capabilities through netlink interface. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 19 +

[PATCH rdma-next 09/19] RDMA/netlink: Add and implement doit netlink callback

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The .doit callback is used by netlink core to differentiate between get and set operations. Common convention is to use that call for command operations like (SET, ADD, e.t.c.) and/or access without NLF_M_DUMP flag. This commit adds proper declaration and implementation to

[PATCH rdma-next 03/19] RDMA/netlink: Rename and remove redundant parameter from ibnl_unicast

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Netlink message header is not needed for unicast reply, hence remove it. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/iwpm_msg.c | 6 +++--- drivers/infiniband/core/iwpm_util.c | 4 ++-- drivers/infiniband/core/netlink.c | 5 ++--- include/rdma/rdma_netli

[PATCH rdma-next 15/19] RDMA/netlink: Implement nldev device dumpit calback

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky This patch adds the ability to return all available devices together with their properties. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 61 - 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/dri

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-20 Thread Kalle Valo
David Miller writes: > From: Jia-Ju Bai > Date: Mon, 19 Jun 2017 10:48:53 +0800 > >> The driver may sleep under a spin lock, and the function call path is: >> netxen_nic_pci_mem_access_direct (acquire the lock by spin_lock) >> ioremap --> may sleep >> >> To fix it, the lock is released before

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-20 Thread Jia-Ju Bai
On 06/21/2017 02:11 PM, Kalle Valo wrote: David Miller writes: From: Jia-Ju Bai Date: Mon, 19 Jun 2017 10:48:53 +0800 The driver may sleep under a spin lock, and the function call path is: netxen_nic_pci_mem_access_direct (acquire the lock by spin_lock) ioremap --> may sleep To fix it,

<    1   2   3