[PATCH 04/47] net: 8390: remove m32r specific bits

2018-03-14 Thread Arnd Bergmann
The m32r architecture is getting removed, so we can kill off the architecture specific hacks in this driver. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/8390/Kconfig | 3 +-- drivers/net/ethernet/8390/ne.c| 23 ++- 2 files changed, 3 insertions(+), 23 deletions

Re: [PATCH 06/47] net: smsc: remove m32r specific smc91x configuration

2018-03-14 Thread Nicolas Pitre
On Wed, 14 Mar 2018, Arnd Bergmann wrote: > The m32r architecture is getting removed, so this part can be > cleaned up as well. > > Signed-off-by: Arnd Bergmann Acked-by: Nicolas Pitre > --- > drivers/net/ethernet/smsc/Kconfig | 4 ++-- > drivers/net/ethernet/smsc/smc91x.h | 26 ---

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-14 Thread Jiri Pirko
Wed, Mar 14, 2018 at 01:36:23AM CET, sridhar.samudr...@intel.com wrote: >On 3/12/2018 2:08 PM, Jiri Pirko wrote: >> Mon, Mar 12, 2018 at 09:58:06PM CET, sridhar.samudr...@intel.com wrote: >> > >> > On 3/12/2018 1:12 PM, Jiri Pirko wrote: >> > > Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr..

[PATCH 30/47] can: remove bfin_can driver

2018-03-14 Thread Arnd Bergmann
The blackfin architecture is getting removed, so this one is now obsolete. Signed-off-by: Arnd Bergmann --- drivers/net/can/Kconfig| 9 - drivers/net/can/Makefile | 1 - drivers/net/can/bfin_can.c | 784 - 3 files changed, 794 deletions(-) d

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-14 Thread Jiri Pirko
Wed, Mar 14, 2018 at 02:50:02AM CET, jakub.kicin...@netronome.com wrote: >On Tue, 13 Mar 2018 17:53:39 +0200, Or Gerlitz wrote: >> > Starting with type 2, in our current NIC HW APIs we have to duplicate >> > these rules >> > into two rules set to HW: >> > >> > 2.1 VF rep --> uplink 0 >> > 2.2 VF re

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-14 Thread Jiri Pirko
Wed, Mar 14, 2018 at 12:23:59PM CET, gerlitz...@gmail.com wrote: >On Wed, Mar 14, 2018 at 11:50 AM, Jiri Pirko wrote: >> Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: >>>On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: > >>>This sounds nice for the case where one install ingr

[PATCH v6 6/6] staging: fsl-dpaa2/ethsw: Add TODO

2018-03-14 Thread Razvan Stefanescu
Add a TODO file describing what needs to be added/changed before the driver can be moved out of staging. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - remove fsl-mc bus driver dependency as it is out of staging v5: - no changes v6:

[PATCH v6 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

2018-03-14 Thread Razvan Stefanescu
Add driver information, link details and hardware statistics to be reported via ethtool -S. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - removed driver version v4: - no changes v5: - no changes v6: - use SPDX license identifier drivers/staging/

[PATCH v6 5/6] staging: fsl-dpaa2/ethsw: Add README

2018-03-14 Thread Razvan Stefanescu
Add a README file describing the driver architecture, components and interfaces. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes v5: - no changes v6: - no changes drivers/staging/fsl-dpaa2/ethsw/README | 106 +++

[PATCH v6 4/6] staging: fsl-dpaa2/ethsw: Add maintainer for Ethernet Switch driver

2018-03-14 Thread Razvan Stefanescu
Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes v5: - no changes v6: - no changes MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c3c2b75..20d7bf2 100644 --- a/MAINTA

[PATCH v6 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

2018-03-14 Thread Razvan Stefanescu
Add the command build/parse APIs for operating on DPSW objects through the DPAA2 Management Complex. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - use u8 for en parameter of dpsw_if_set_flooding/broadcast() v3: - no changes v4: - adjust to moving MC-bus out of staging -

[PATCH v6 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-14 Thread Razvan Stefanescu
Introduce the DPAA2 Ethernet Switch driver, which manages Datapath Switch (DPSW) objects discovered on the MC bus. Suggested-by: Alexandru Marginean Signed-off-by: Razvan Stefanescu --- Changelog: v2: - fix PVID cleanup in ethsw_port_add_vlan() - rename err2 to ret in ethsw_port_add/del

[PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2018-03-14 Thread Razvan Stefanescu
This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs with DPAA2 (DataPath Acceleration Architecture v2). The driver manages switch objects discovered on the fsl-mc bus. A description of the driver can be found in the associated README file. The patchset consists of: * A set o

[PATCH 46/47] staging: irda: remove bfin_sir driver

2018-03-14 Thread Arnd Bergmann
The blackfin architecture is getting removed, so this driver is now obsolete. Signed-off-by: Arnd Bergmann --- drivers/staging/irda/drivers/Kconfig| 45 -- drivers/staging/irda/drivers/Makefile | 1 - drivers/staging/irda/drivers/bfin_sir.c | 819 driver

[PATCH net] net: use skb_to_full_sk() in skb_update_prio()

2018-03-14 Thread Eric Dumazet
Andrei Vagin reported a KASAN: slab-out-of-bounds error in skb_update_prio() Since SYNACK might be attached to a request socket, we need to get back to the listener socket. Since this listener is manipulated without locks, add const qualifiers to sock_cgroup_prioidx() so that the const can also be

Re: [PATCH bpf-next v5 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-14 Thread Daniel Borkmann
Just a minor question below, the rest seems fine to me as far as I can tell. On 03/13/2018 10:47 PM, Song Liu wrote: [...] > +enum bpf_stack_build_id_status { > + /* user space need an empty entry to identify end of a trace */ > + BPF_STACK_BUILD_ID_EMPTY = 0, > + /* with valid build_i

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Kalle Valo
Rafał Miłecki writes: >>> + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; >>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) >> >> #ifndef? > > I followed what is used in the include/linux/etherdevice.h. Is that a > good exceuse? Could it be there any some good reason for #if

Re: [PATCH net-next 1/5] sctp: add refcnt support for sh_key

2018-03-14 Thread Xin Long
On Wed, Mar 14, 2018 at 9:59 PM, Neil Horman wrote: > On Wed, Mar 14, 2018 at 07:05:30PM +0800, Xin Long wrote: >> With refcnt support for sh_key, chunks auth sh_keys can be decided >> before enqueuing it. Changing the active key later will not affect >> the chunks already enqueued. >> >> Furtherm

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering

Re: [PATCH net-next 0/2] skbuff: Fix applications not being woken for errors

2018-03-14 Thread Willem de Bruijn
On Tue, Mar 13, 2018 at 4:35 PM, Vinicius Costa Gomes wrote: > Hi, > > Changes from the RFC: > - tweaked commit messages; > > Original cover letter: > > This is actually a "bug report"-RFC instead of the more usual "new > feature"-RFC. > > We are developing an application that uses TX hardware ti

Re: [PATCH 46/47] staging: irda: remove bfin_sir driver

2018-03-14 Thread Arnd Bergmann
On Wed, Mar 14, 2018 at 5:32 PM, Greg Kroah-Hartman wrote: > On Wed, Mar 14, 2018 at 04:35:59PM +0100, Arnd Bergmann wrote: >> The blackfin architecture is getting removed, so this >> driver is now obsolete. >> >> Signed-off-by: Arnd Bergmann >> --- >> drivers/staging/irda/drivers/Kconfig|

Re: [PATCH 46/47] staging: irda: remove bfin_sir driver

2018-03-14 Thread Greg Kroah-Hartman
On Wed, Mar 14, 2018 at 04:35:59PM +0100, Arnd Bergmann wrote: > The blackfin architecture is getting removed, so this > driver is now obsolete. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/irda/drivers/Kconfig| 45 -- > drivers/staging/irda/drivers/Makefile | 1 - > drivers

[PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread Jonathan Toppins
The problem was introduced in commit 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs because tp->lock spinlock is held which is obtained in tg3_start by way of tg3_full_lock(), line 11571. The documentation for usleep_range() specifically states it cannot be used inside a spinl

Re: [PATCH bpf-next v5 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-14 Thread Song Liu
> On Mar 14, 2018, at 9:07 AM, Daniel Borkmann wrote: > > Just a minor question below, the rest seems fine to me as far as I > can tell. > > On 03/13/2018 10:47 PM, Song Liu wrote: > [...] >> +enum bpf_stack_build_id_status { >> +/* user space need an empty entry to identify end of a trace

Re: [PATCH net-next 2/2] skbuff: Fix not waking applications when errors are enqueued

2018-03-14 Thread Eric Dumazet
On 03/13/2018 01:35 PM, Vinicius Costa Gomes wrote: When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in poll(

[PATCH net-next] sock: remove zerocopy sockopt restriction on closed tcp state

2018-03-14 Thread Willem de Bruijn
From: Willem de Bruijn Socket option SO_ZEROCOPY determines whether the kernel ignores or processes flag MSG_ZEROCOPY on subsequent send calls. This to avoid changing behavior for legacy processes. Limiting the state change to closed sockets is annoying with passive sockets and not necessary for

Re: [PATCH net-next] sock: remove zerocopy sockopt restriction on closed tcp state

2018-03-14 Thread David Miller
From: Willem de Bruijn Date: Wed, 14 Mar 2018 12:49:19 -0400 > From: Willem de Bruijn > > Socket option SO_ZEROCOPY determines whether the kernel ignores or > processes flag MSG_ZEROCOPY on subsequent send calls. This to avoid > changing behavior for legacy processes. > > Limiting the state ch

Re: [PATCH] can: enable multi-queue for SocketCAN devices

2018-03-14 Thread Jonas Mark (BT-FIR/ENG1)
Hello Marc, > >> Do you have a driver or a patch to make a driver mq aware? > > > > Yes, we have CAN hardware with multiple queues and we also have a > > SocketCAN driver for it. > > > > IMHO the driver will be of very little use for the Linux community > > because the HW is proprietary. > > That

Re: [PATCH net] net: use skb_to_full_sk() in skb_update_prio()

2018-03-14 Thread David Miller
From: Eric Dumazet Date: Wed, 14 Mar 2018 09:04:16 -0700 > Andrei Vagin reported a KASAN: slab-out-of-bounds error in > skb_update_prio() > > Since SYNACK might be attached to a request socket, we need to > get back to the listener socket. > Since this listener is manipulated without locks, add

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. Th

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 15:24, Kalle Valo wrote: Rafał Miłecki writes: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. This is an obsoleted standa

[PATCH] vhost: fix vhost ioctl signature to build with clang

2018-03-14 Thread Sonny Rao
Clang is particularly anal about signed vs unsigned comparisons and doesn't like the fact that some ioctl numbers set the MSB, so we get this error when trying to build vhost on aarch64: drivers/vhost/vhost.c:1400:7: error: overflow converting case value to switch condition type (3221794578 to 18

Re: [PATCH net-next 0/2] sfc: support FEC configuration

2018-03-14 Thread David Miller
From: Edward Cree Date: Wed, 14 Mar 2018 14:19:11 + > Implements the ethtool get & set fecparam operations. Series applied, thanks.

Re: [PATCH RFC bpf-next 0/6] bpf: introduce cgroup-bpf bind, connect, post-bind hooks

2018-03-14 Thread David Ahern
On 3/13/18 8:39 PM, Alexei Starovoitov wrote: > For our container management we've been using complicated and fragile setup > consisting of LD_PRELOAD wrapper intercepting bind and connect calls from > all containerized applications. > The setup involves per-container IPs, policy, etc, so tradition

Re: [PATCH 0/5] DPAA Ethernet fixes

2018-03-14 Thread David Miller
From: Madalin Bucur Date: Wed, 14 Mar 2018 08:37:27 -0500 > This patch set is addressing several issues in the DPAA Ethernet > driver suite: > > - module unload crash caused by wrong reference to device being left >in the cleanup code after the DSA related changes > - scheduling wile atomi

Re: [PATCH net-next] tuntap: XDP_TX can use native XDP

2018-03-14 Thread David Miller
From: Jason Wang Date: Wed, 14 Mar 2018 11:23:40 +0800 > Now we have ndo_xdp_xmit, switch to use it instead of the slow generic > XDP TX routine. XDP_TX on TAP gets ~20% improvements from ~1.5Mpps to > ~1.8Mpps on 2.60GHz Core(TM) i7-5600U. > > Signed-off-by: Jason Wang Applied, thanks Jason.

Re: [PATCH RFC bpf-next 0/6] bpf: introduce cgroup-bpf bind, connect, post-bind hooks

2018-03-14 Thread महेश बंडेवार
On Tue, Mar 13, 2018 at 8:39 PM, Alexei Starovoitov wrote: > For our container management we've been using complicated and fragile setup > consisting of LD_PRELOAD wrapper intercepting bind and connect calls from > all containerized applications. > The setup involves per-container IPs, policy, etc

Re: [PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread Michael Chan
On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: > The problem was introduced in commit > 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs > because tp->lock spinlock is held which is obtained in tg3_start > by way of tg3_full_lock(), line 11571. The documentation for u

[PATCH bpf-next v6 0/2] bpf stackmap with build_id+offset

2018-03-14 Thread Song Liu
Changes v4 -> v6: 1. When kernel stack is added to stackmap with build_id, use fallback mechanism to store ip (status == BPF_STACK_BUILD_ID_IP). Changes v4 -> v5: 1. Only allow build_id lookup in non-nmi context. Added comment and commit message to highlight this limitation. 2. Minor fix r

[PATCH bpf-next v6 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-14 Thread Song Liu
Currently, bpf stackmap store address for each entry in the call trace. To map these addresses to user space files, it is necessary to maintain the mapping from these virtual address to symbols in the binary. Usually, the user space profiler (such as perf) has to scan /proc/pid/maps at the beginnin

[PATCH bpf-next v6 2/2] bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID

2018-03-14 Thread Song Liu
test_stacktrace_build_id() is added. It accesses tracepoint urandom_read with "dd" and "urandom_read" and gathers stack traces. Then it reads the stack traces from the stackmap. urandom_read is a statically link binary that reads from /dev/urandom. test_stacktrace_build_id() calls readelf to read

RE: [Intel-wired-lan] [next-queue PATCH v4 2/8] igb: Fix queue selection on MAC filters on i210 and i211

2018-03-14 Thread Vinicius Costa Gomes
Hi, "Brown, Aaron F" writes: >> --- a/drivers/net/ethernet/intel/igb/igb_main.c >> +++ b/drivers/net/ethernet/intel/igb/igb_main.c >> @@ -8747,12 +8747,19 @@ static void igb_rar_set_index(struct igb_adapter >> *adapter, u32 index) >> if (is_valid_ether_addr(addr)) >>

[PATCH] vhost: add vsock compat ioctl

2018-03-14 Thread Sonny Rao
This will allow usage of vsock from 32-bit binaries on a 64-bit kernel. Signed-off-by: Sonny Rao --- drivers/vhost/vsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 0d14e2ff19f16..d0e65e92110e5 100644 --- a/drivers/vhost/vsock.c +++ b

Re: [PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread Jonathan Toppins
On 03/14/2018 01:22 PM, Michael Chan wrote: > On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: >> The problem was introduced in commit >> 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs >> because tp->lock spinlock is held which is obtained in tg3_start >> by way of tg

Re: [PATCH net-next] liquidio: Add support for liquidio 10GBase-T NIC

2018-03-14 Thread David Miller
From: Felix Manlunas Date: Tue, 13 Mar 2018 22:04:45 -0700 > From: Veerasenareddy Burru > > Added ethtool changes to show port type as TP (Twisted Pair) for > 10GBASE-T ports. Same driver and firmware works for liquidio NIC with > SFP+ ports or TP ports. > > Signed-off-by: Veerasenareddy Burru

Re: [PATCH bpf-next v6 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-14 Thread Song Liu
> On Mar 14, 2018, at 10:23 AM, Song Liu wrote: > > Currently, bpf stackmap store address for each entry in the call trace. > To map these addresses to user space files, it is necessary to maintain > the mapping from these virtual address to symbols in the binary. Usually, > the user space prof

Re: [PATCH net v2] ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu

2018-03-14 Thread David Miller
From: Sabrina Dubroca Date: Wed, 14 Mar 2018 10:21:14 +0100 > Prior to the rework of PMTU information storage in commit > 2c8cec5c10bc ("ipv4: Cache learned PMTU information in inetpeer."), > when a PMTU event advertising a PMTU smaller than > net.ipv4.route.min_pmtu was received, we would disabl

Re: [PATCH bpf-next v6 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-14 Thread Daniel Borkmann
On 03/14/2018 06:36 PM, Song Liu wrote: >> On Mar 14, 2018, at 10:23 AM, Song Liu wrote: >> >> Currently, bpf stackmap store address for each entry in the call trace. >> To map these addresses to user space files, it is necessary to maintain >> the mapping from these virtual address to symbols in

Re: [PATCH net-next 0/2] skbuff: Fix applications not being woken for errors

2018-03-14 Thread Soheil Hassas Yeganeh
On Wed, Mar 14, 2018 at 12:32 PM Willem de Bruijn < willemdebruijn.ker...@gmail.com> wrote: > On Tue, Mar 13, 2018 at 4:35 PM, Vinicius Costa Gomes > wrote: > > Hi, > > > > Changes from the RFC: > > - tweaked commit messages; > > > > Original cover letter: > > > > This is actually a "bug report"

Re: [PATCH net-next 0/3] net/smc: fixes 2018-03-14

2018-03-14 Thread David Miller
From: Ursula Braun Date: Wed, 14 Mar 2018 11:00:59 +0100 > here are smc changes for the net-next tree. > The first patch enables SMC to work with mlx5-RoCE-devices. > Patches 2 and 3 deal with link group freeing. Series applied, thank you.

Re: [PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread David Miller
From: Michael Chan Date: Wed, 14 Mar 2018 10:22:51 -0700 > On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: >> The problem was introduced in commit >> 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs >> because tp->lock spinlock is held which is obtained in tg3_start

Re: [PATCH net-next 0/5] sctp: add support for some sctp auth APIs from RFC6458

2018-03-14 Thread David Miller
From: Xin Long Date: Wed, 14 Mar 2018 19:05:29 +0800 > This patchset mainly adds support for SCTP AUTH Information for sendmsg, > described in RFC6458: > > 5.3.8. SCTP AUTH Information Structure (SCTP_AUTHINFO) > > and also adds a sockopt described in RFC6458: > > 8.3.4. Deactivate a

Re: pull-request: can 2018-03-14

2018-03-14 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 14 Mar 2018 13:05:21 +0100 > this is a pull request of two patches for net/master. > > Both patches are by Andri Yngvason and fix problems in the cc770 driver, > that show up quite fast on RT systems, but also on non RT setups. Series applied, thanks Marc.

[PATCH net-next] sunvnet: does not support GSO for sctp

2018-03-14 Thread cathy . zhou
From: Cathy Zhou The NETIF_F_GSO_SOFTWARE implies support for GSO on SCTP, but the sunvnet driver does not support GSO for sctp. Here we remove the NETIF_F_GSO_SOFTWARE feature flag and only report NETIF_F_ALL_TSO instead. Signed-off-by: Cathy Zhou Signed-off-by: Shannon Nelson --- drivers/n

Re: [PATCH RFC bpf-next 1/6] bpf: Hooks for sys_bind

2018-03-14 Thread Alexei Starovoitov
On Tue, Mar 13, 2018 at 11:21:08PM -0700, Eric Dumazet wrote: > > If I understand well, strace(1) will not show the real (after modification > by eBPF) IP/port ? correct. Just like it won't show anything after syscall entry, whether lsm acted, seccomp, etc > What about selinux and other LSM ?

Re: [PATCH RFC bpf-next 0/6] bpf: introduce cgroup-bpf bind, connect, post-bind hooks

2018-03-14 Thread Alexei Starovoitov
On Wed, Mar 14, 2018 at 10:13:22AM -0700, David Ahern wrote: > On 3/13/18 8:39 PM, Alexei Starovoitov wrote: > > For our container management we've been using complicated and fragile setup > > consisting of LD_PRELOAD wrapper intercepting bind and connect calls from > > all containerized applicatio

Re: [PATCH RFC bpf-next 0/6] bpf: introduce cgroup-bpf bind, connect, post-bind hooks

2018-03-14 Thread Alexei Starovoitov
On Wed, Mar 14, 2018 at 10:22:03AM -0700, Mahesh Bandewar (महेश बंडेवार) wrote: > On Tue, Mar 13, 2018 at 8:39 PM, Alexei Starovoitov wrote: > > For our container management we've been using complicated and fragile setup > > consisting of LD_PRELOAD wrapper intercepting bind and connect calls from

Re: [PATCH net-next] sunvnet: does not support GSO for sctp

2018-03-14 Thread David Miller
From: cathy.z...@oracle.com Date: Wed, 14 Mar 2018 10:56:07 -0700 > From: Cathy Zhou > > The NETIF_F_GSO_SOFTWARE implies support for GSO on SCTP, but the > sunvnet driver does not support GSO for sctp. Here we remove the > NETIF_F_GSO_SOFTWARE feature flag and only report NETIF_F_ALL_TSO > ins

Re: [PATCH net-next 0/6] ibmvnic: Update TX pool and TX routines

2018-03-14 Thread David Miller
From: Thomas Falcon Date: Tue, 13 Mar 2018 19:34:17 -0500 > This patch restructures the TX pool data structure and provides a > separate TX pool array for TSO transmissions. This is already used > in some way due to our unique DMA situation, namely that we cannot > use single DMA mappings for pac

Re: [PATCH net-next v2 0/4] net: qualcomm: rmnet: Updates 2018-03-12

2018-03-14 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Tue, 13 Mar 2018 16:50:24 -0600 > This series contains some minor updates for rmnet driver. > > Patch 1 contains fixes for sparse warnings. > Patch 2 updates the copyright date to 2018. > Patch 3 is a cleanup in receive path. > Patch 4 has the implement

Re: [PATCH net-next 0/6] ibmvnic: Update TX pool and TX routines

2018-03-14 Thread Thomas Falcon
On 03/14/2018 01:03 PM, David Miller wrote: > From: Thomas Falcon > Date: Tue, 13 Mar 2018 19:34:17 -0500 > >> This patch restructures the TX pool data structure and provides a >> separate TX pool array for TSO transmissions. This is already used >> in some way due to our unique DMA situation, nam

Re: [PATCH RFC bpf-next 1/6] bpf: Hooks for sys_bind

2018-03-14 Thread Alexei Starovoitov
On Wed, Mar 14, 2018 at 03:37:01PM +0100, Daniel Borkmann wrote: > > --- a/include/uapi/linux/bpf.h > > +++ b/include/uapi/linux/bpf.h > > @@ -133,6 +133,8 @@ enum bpf_prog_type { > > BPF_PROG_TYPE_SOCK_OPS, > > BPF_PROG_TYPE_SK_SKB, > > BPF_PROG_TYPE_CGROUP_DEVICE, > > + BPF_PROG_TYP

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

2018-03-14 Thread Pablo Neira Ayuso
Hi David, Just for the record, this is a summary of what we have discussed so far: 1) The existing flowtable infrastructure provides a software fast path that is being useful for a valid number of usecases, in particular, OpenWRT/LEDE developers/users are very enthusiastic about this. Re

Re: [PATCH net] net/sched: act_simple: don't leak 'index' in the error path

2018-03-14 Thread Cong Wang
On Tue, Mar 13, 2018 at 7:13 PM, Davide Caratti wrote: > Similarly to what other TC actions do, we can duplicate 'sdata' before > calling tcf_idr_create(), and avoid calling tcf_idr_cleanup(), so that > leaks of 'index' don't occur anymore. Looks like we just need to replace the tcf_idr_cleanup()

Re: [PATCH RFC bpf-next 1/6] bpf: Hooks for sys_bind

2018-03-14 Thread Alexei Starovoitov
On Wed, Mar 14, 2018 at 11:00 AM, Alexei Starovoitov wrote: > >> It seems this is exactly the case where a netns would be the correct answer. > > Unfortuantely that's not the case. That's what I tried to explain > in the cover letter: > "The setup involves per-container IPs, policy, etc, so tradit

Re: [PATCH 0/5] DPAA Ethernet fixes

2018-03-14 Thread Joakim Tjernlund
On Wed, 2018-03-14 at 08:37 -0500, Madalin Bucur wrote: > Hi, > > This patch set is addressing several issues in the DPAA Ethernet > driver suite: > > - module unload crash caused by wrong reference to device being left >in the cleanup code after the DSA related changes > - scheduling wile

[PATCH net-next v3 3/4] net: qualcomm: rmnet: Remove unnecessary device assignment

2018-03-14 Thread Subash Abhinov Kasiviswanathan
Device of the de-aggregated skb is correctly assigned after inspecting the mux_id, so remove the assignment in rmnet_map_deaggregate(). Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 1 - 1 file changed, 1 deletion(-) diff --git a/driver

[PATCH net-next v3 0/4] net: qualcomm: rmnet: Updates 2018-03-12

2018-03-14 Thread Subash Abhinov Kasiviswanathan
This series contains some minor updates for rmnet driver. Patch 1 contains fixes for sparse warnings. Patch 2 updates the copyright date to 2018. Patch 3 is a cleanup in receive path. Patch 4 has the implementation of the fill_info operation. v1->v2: Remove the force casts since the data type is

[PATCH net-next v3 1/4] net: qualcomm: rmnet: Fix casting issues

2018-03-14 Thread Subash Abhinov Kasiviswanathan
Fix warnings which were reported when running with sparse (make C=1 CF=-D__CHECK_ENDIAN__) drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:81:15: warning: cast to restricted __be16 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:271:37: warning: incorrect type in assignment (different ba

[PATCH net-next v3 2/4] net: qualcomm: rmnet: Update copyright year to 2018

2018-03-14 Thread Subash Abhinov Kasiviswanathan
Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c| 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h

[PATCH net-next v3 4/4] net: qualcomm: rmnet: Implement fill_info

2018-03-14 Thread Subash Abhinov Kasiviswanathan
This is needed to query the mux_id and flags of a rmnet device. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/d

Re: [PATCH] vhost: add vsock compat ioctl

2018-03-14 Thread Michael S. Tsirkin
On Wed, Mar 14, 2018 at 10:26:05AM -0700, Sonny Rao wrote: > This will allow usage of vsock from 32-bit binaries on a 64-bit > kernel. > > Signed-off-by: Sonny Rao I think you need to convert the pointer argument though. Something along the lines of: #ifdef CONFIG_COMPAT static long vhost_vsock

[PATCH net-next 1/2] net: Add rtnl_lock_killable()

2018-03-14 Thread Kirill Tkhai
rtnl_lock() is widely used mutex in kernel. Some of kernel code does memory allocations under it. In case of memory deficit this may invoke OOM killer, but the problem is a killed task can't exit if it's waiting for the mutex. This may be a reason of deadlock and panic. This patch adds a new primi

[PATCH net-next 0/2] Introduce rtnl_lock_killable()

2018-03-14 Thread Kirill Tkhai
rtnl_lock() is widely used mutex in kernel. Some of kernel code does memory allocations under it. In case of memory deficit this may invoke OOM killer, but the problem is a killed task can't exit if it's waiting for the mutex. This may be a reason of deadlock and panic. This patchset adds a new pr

[PATCH net-next 2/2] net: Use rtnl_lock_killable() in register_netdev()

2018-03-14 Thread Kirill Tkhai
This patch adds rtnl_lock_killable() to one of hot path using rtnl_lock(). Signed-off-by: Kirill Tkhai --- net/core/dev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 12a9aad0b057..d8887cc38e7b 100644 --- a/net/core/dev.c +++ b/ne

Re: [PATCH net-next v2 0/4] net: qualcomm: rmnet: Updates 2018-03-12

2018-03-14 Thread Subash Abhinov Kasiviswanathan
Please address Joe's feedback and only update the copyright date on files that actually had changes this year. Thank you. Hi David I have fixed that now in v3. However, patchwork is not showing the entire series. It shows only the first patch for some reason even if I search with me as submit

Re: [PATCH net-next 0/2] skbuff: Fix applications not being woken for errors

2018-03-14 Thread Vinicius Costa Gomes
Hi, Willem de Bruijn writes: >> Another interesting fact is that if the POLLIN event is added to the >> poll() .events, poll() no longer becomes stuck, > > The process has registered interest only in POLLIN, which the call to > sk_data_read (sock_def_readable) will trigger. > >> and more interes

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-03-14 Thread Grygorii Strashko
On 02/26/2018 02:16 PM, Florian Fainelli wrote: > On 02/26/2018 12:08 PM, Grygorii Strashko wrote: >> Hi Florian, >> >> The TI CPSW driver produces warning as below when booted in switch mode: >> [8.882295] sysfs: cannot create duplicate filename >> '/devices/platform/4400.ocp/48484000.e

Re: [PATCH net-next 1/5] sctp: add refcnt support for sh_key

2018-03-14 Thread Marcelo Ricardo Leitner
On Thu, Mar 15, 2018 at 12:12:32AM +0800, Xin Long wrote: > On Wed, Mar 14, 2018 at 9:59 PM, Neil Horman wrote: > > On Wed, Mar 14, 2018 at 07:05:30PM +0800, Xin Long wrote: > >> With refcnt support for sh_key, chunks auth sh_keys can be decided > >> before enqueuing it. Changing the active key la

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-03-14 Thread Florian Fainelli
On 03/14/2018 12:40 PM, Grygorii Strashko wrote: > > > On 02/26/2018 02:16 PM, Florian Fainelli wrote: >> On 02/26/2018 12:08 PM, Grygorii Strashko wrote: >>> Hi Florian, >>> >>> The TI CPSW driver produces warning as below when booted in switch mode: >>> [8.882295] sysfs: cannot create dupli

RE: [Intel-wired-lan] [next-queue PATCH v4 6/8] igb: Add MAC address support for ethtool nftuple filters

2018-03-14 Thread Vinicius Costa Gomes
Hi, "Brown, Aaron F" writes: >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >> Behalf Of Vinicius Costa Gomes >> Sent: Wednesday, March 7, 2018 4:37 PM >> To: intel-wired-...@lists.osuosl.org >> Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus > palen...@intel.com> >>

[PATCH RFC 0/7] net: phy: patch series aiming to improve few aspects of phylib

2018-03-14 Thread Heiner Kallweit
This patch series aims to tackle few issues with phylib: - address issues with patch series [1] (smsc911x + phylib changes) - make phy_stop synchronous - get rid of phy_start/stop_machine and handle it in phy_start/phy_stop - in mdio_suspend consider runtime pm state of mdio bus parent - consider

[PATCH RFC 4/7] net: phy: remove phy_start_machine

2018-03-14 Thread Heiner Kallweit
Now that phy_start() integrated the functionality of phy_start_machine() we can remove it. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c| 16 drivers/net/phy/phy_device.c | 1 - drivers/net/phy/phylink.c| 1 - include/linux/phy.h | 1 - 4 files

[PATCH RFC 6/7] net: phy: use new function phy_stop_suspending in, mdio_bus_phy_suspend

2018-03-14 Thread Heiner Kallweit
Use new function phy_stop_suspending() in mdio_bus_phy_suspend() to also disable interrupts and set link state to down. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/driver

[PATCH RFC 1/7] net: phy: unconditionally resume and re-enable interrupts, in phy_start

2018-03-14 Thread Heiner Kallweit
In subsequent patches of this series interrupts will be disabled during system suspend, also we will have to resume the PHY in states other than PHY_HALTED. To prepare for this unconditionally resume and re-enable interrupts in phy_start(). Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.

[PATCH net] netlink: avoid a double skb free in genlmsg_mcast()

2018-03-14 Thread Nicolas Dichtel
nlmsg_multicast() consumes always the skb, thus the original skb must be freed only when this function is called with a clone. Fixes: cb9f7a9a5c96 ("netlink: ensure to loop over all netns in genlmsg_multicast_allns()") Reported-by: Ben Hutchings Signed-off-by: Nicolas Dichtel --- net/netlink/g

[PATCH RFC 7/7] net: phy: remove phy_stop_machine

2018-03-14 Thread Heiner Kallweit
Now that the functionality of phy_stop() was integrated to __phy_stop() we can remove phy_stop_machine(). Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c| 18 -- drivers/net/phy/phy_device.c | 2 -- include/linux/phy.h | 1 - 3 files changed, 21 deleti

[PATCH RFC 5/7] net: phy: make phy_stop synchronous

2018-03-14 Thread Heiner Kallweit
Currently phy_stop() just sets the state to PHY_HALTED and relies on the state machine to do the remaining work. It can take up to 1s until the state machine runs again what causes issues in situations where e.g. driver / device is brought down directly after executing phy_stop(). Fix this by exec

[PATCH RFC 3/7] net: phy: resume PHY only if needed in, mdio_bus_phy_suspend

2018-03-14 Thread Heiner Kallweit
Currently the PHY is unconditionally resumed in mdio_bus_phy_suspend(). In cases where the PHY was sleepinh before suspending or if somebody else takes care of resuming later, this is not needed and wastes energy. Also start the state machine only if it's used by the driver (indicated by the adjus

[PATCH RFC 2/7] net: phy: improve checking for when PHY is allowed to, suspend

2018-03-14 Thread Heiner Kallweit
This patch improves and unifies checking for when PHY is allowed to suspend. New is a check for the parent of the MDIO bus being runtime-suspended. In this case the MDIO bus may not be accessible and therefore we don't try to suspend the PHY. Instead we rely on the parent to suspend all devices on

Re: [RESEND] rsi: Remove stack VLA usage

2018-03-14 Thread Tobin C. Harding
On Wed, Mar 14, 2018 at 11:19:53AM +0200, Kalle Valo wrote: > "Tobin C. Harding" writes: > > > Added Konstantin in case he is in charge of administering > > patchwork.kernel.org? > > > > On Tue, Mar 13, 2018 at 07:53:34PM -0700, Kees Cook wrote: > >> On Tue, Mar 13, 2018 at 7:11 PM, Tobin C. Har

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-03-14 Thread Grygorii Strashko
On 03/14/2018 02:50 PM, Florian Fainelli wrote: > On 03/14/2018 12:40 PM, Grygorii Strashko wrote: >> >> >> On 02/26/2018 02:16 PM, Florian Fainelli wrote: >>> On 02/26/2018 12:08 PM, Grygorii Strashko wrote: Hi Florian, The TI CPSW driver produces warning as below when booted in s

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

2018-03-14 Thread Alexander Zubkov
Hello, For example, it can be fixed in such way (patch is below): - split handling of default and all/any - set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag for default - and AF_UNSPEC for all/any In this case "ip route show default" shows only default route and "ip route show all" sh

[PATCH net] skbuff: Fix not waking applications when errors are enqueued

2018-03-14 Thread Vinicius Costa Gomes
When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in poll() (for example). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2

Re: [PATCH] vhost: add vsock compat ioctl

2018-03-14 Thread Sonny Rao
On Wed, Mar 14, 2018 at 12:05 PM, Michael S. Tsirkin wrote: > On Wed, Mar 14, 2018 at 10:26:05AM -0700, Sonny Rao wrote: >> This will allow usage of vsock from 32-bit binaries on a 64-bit >> kernel. >> >> Signed-off-by: Sonny Rao > > I think you need to convert the pointer argument though. > Some

[net-next 4/9] i40e: Cleanup i40e_vlan_rx_register

2018-03-14 Thread Jeff Kirsher
From: Jacob Keller We used to use the function i40e_vlan_rx_register as a way to hook into the now defunct .ndo_vlan_rx_register netdev hook. This was removed but we kept the function around because we still used it internally to control enabling or disabling of VLAN stripping. As pointed out in

[net-next 7/9] i40e: factor out re-enable functions for ATR and SB

2018-03-14 Thread Jeff Kirsher
From: Jacob Keller A future patch needs to expand on the logic for re-enabling ATR. Doing so would cause some code to break the 80-character line limit. To reduce the level of indentation, factor out helper functions for re-enabling ATR and SB rules. Signed-off-by: Jacob Keller Tested-by: Andr

[net-next 9/9] i40e: restore TCPv4 input set when re-enabling ATR

2018-03-14 Thread Jeff Kirsher
From: Jacob Keller When we re-enable ATR we need to restore the input set for TCPv4 filters, in order for ATR to function correctly. We already do this for the normal case of re-enabling ATR when disabling ntuple support. However, when re-enabling ATR after the last TCPv4 filter is removed (but w

[net-next 8/9] i40e: fix for wrong partition id calculation on OCP mezz cards

2018-03-14 Thread Jeff Kirsher
From: Mariusz Stachura This patch overwrites number of ports for X722 devices with support for OCP PHY mezzanine. The old method with checking if port is disabled in the PRTGEN_CNF register cannot be used in this case. When the OCP is removed, ports were seen as disabled, which resulted in wrong

[net-next 3/9] i40e: Fix attach VF to VM issue

2018-03-14 Thread Jeff Kirsher
From: Paweł Jabłoński Fix for "Resource temporarily unavailable" problem when virsh is trying to attach a device to VM. When the VF driver is loaded on host and virsh is trying to attach it to the VM and set a MAC address, it ends with a race condition between i40e_reset_vf and i40e_ndo_set_vf_ma

<    1   2   3   >