[PATCH 0/5] DPAA Ethernet fixes

2018-03-14 Thread Madalin Bucur
Hi, This patch set is addressing several issues in the DPAA Ethernet driver suite: - module unload crash caused by wrong reference to device being left in the cleanup code after the DSA related changes - scheduling wile atomic bug in QMan code revealed during dpaa_eth module unload - a

Re: [PATCH net-next 1/5] sctp: add refcnt support for sh_key

2018-03-14 Thread Marcelo Ricardo Leitner
On Wed, Mar 14, 2018 at 07:05:30PM +0800, Xin Long wrote: > With refcnt support for sh_key, chunks auth sh_keys can be decided > before enqueuing it. Changing the active key later will not affect > the chunks already enqueued. > > Furthermore, this is necessary when adding the support for

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Kalle Valo
Rafał Miłecki writes: > From: Rafał Miłecki > > Testing brcmfmac with more recent firmwares resulted in AP interfaces > not working in some specific setups. Debugging resulted in discovering > support for IAPP in Broadcom's firmwares. This is an obsoleted

Re: [PATCH RFC bpf-next 1/6] bpf: Hooks for sys_bind

2018-03-14 Thread Daniel Borkmann
On 03/14/2018 04:39 AM, Alexei Starovoitov wrote: [...] > +#define BPF_CGROUP_RUN_PROG_INET4_BIND(sk, uaddr) \ > + BPF_CGROUP_RUN_SA_PROG(sk, uaddr, BPF_CGROUP_INET4_BIND) > + > +#define BPF_CGROUP_RUN_PROG_INET6_BIND(sk, uaddr) \ > +

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

2018-03-14 Thread Yuval Shaia
On Tue, Mar 13, 2018 at 06:13:45PM +0200, Yuval Shaia wrote: > On Tue, Mar 13, 2018 at 05:07:22PM +0200, Liran Alon wrote: > > Before this commit, dev_forward_skb() always cleared packet's > > per-network-namespace info. Even if the packet doesn't cross > > network namespaces. > > > > The comment

Re: [PATCH] net: dsa: drop some VLAs in switch.c

2018-03-14 Thread Salvatore Mesoraca
2018-03-14 12:24 GMT+01:00 David Laight : > Isn't using DECLARE_BITMAP() completely OTT when the maximum size is less > than the number of bits in a word? It allocates ceiling(size/8) "unsigned long"s, so yes.

Re: [PATCH net 2/2] qed: Fix non TCP packets should be dropped on iWARP ll2 connection

2018-03-14 Thread Joe Perches
On Wed, 2018-03-14 at 14:49 +0200, Michal Kalderon wrote: > FW workaround. The iWARP LL2 connection did not expect TCP packets > to arrive on it's connection. The fix drops any non-tcp packets [] > diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c >

[PATCH] netlink: make sure nladdr has correct size in netlink_connect()

2018-03-14 Thread Alexander Potapenko
KMSAN reports use of uninitialized memory in the case when |alen| is smaller than sizeof(struct netlink_sock), and therefore |nladdr| isn't fully copied from the userspace. Signed-off-by: Alexander Potapenko Fixes: 1da177e4c3f41524 ("Linux-2.6.12-rc2") ---

[PATCH net-next 2/2] sfc: support FEC configuration through ethtool

2018-03-14 Thread Edward Cree
As well as 'auto' and the forced 'off', 'rs' and 'baser' states, we also handle combinations of settings (since the fecparam->fec field is a bitmask), where auto|rs and auto|baser specify a preferred FEC mode but will fall back to the other if the cable or link partner doesn't support it.

Re: [PATCH] netlink: make sure nladdr has correct size in netlink_connect()

2018-03-14 Thread Eric Dumazet
On Wed, Mar 14, 2018 at 7:16 AM, Alexander Potapenko wrote: > > > > On Wed, Mar 14, 2018 at 3:11 PM Eric Dumazet wrote: >> >> On Wed, Mar 14, 2018 at 7:03 AM, Alexander Potapenko >> wrote: >> > KMSAN reports use of uninitialized memory

Fw: [Bug 199109] New: pptp: kernel printk "recursion detected", and then reboot itself

2018-03-14 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 14 Mar 2018 06:56:09 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199109] New: pptp: kernel printk "recursion detected", and then reboot itself https://bugzilla.kernel.org/show_bug.cgi?id=199109

Re: WARNING in __local_bh_enable_ip (2)

2018-03-14 Thread Eric Dumazet
On 03/14/2018 01:11 PM, syzbot wrote: Hello, syzbot hit the following crash on net-next commit be9fc0971a5c27b791608cf9705a04fe96dbd395 (Tue Mar 13 11:44:53 2018 +) net: fix sysctl_fb_tunnels_only_for_init_net link error So far this crash happened 2 times on net-next. Unfortunately, I

[PATCH v2] vhost: add vsock compat ioctl

2018-03-14 Thread Sonny Rao
This will allow usage of vsock from 32-bit binaries on a 64-bit kernel. Signed-off-by: Sonny Rao --- drivers/vhost/vsock.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 0d14e2ff19f16..ee0c385d9fe54

Re: WARNING in __local_bh_enable_ip (2)

2018-03-14 Thread Sowmini Varadhan
On (03/14/18 14:28), Eric Dumazet wrote: > > > spin_lock_bh(_tcp_conn_lock);/spin_unlock_bh(_tcp_conn_lock); in > rds_tcp_conn_free() > > is in conflict with the spin_lock_irqsave(_conn_lock, flags); > in __rds_conn_create() yes I was going to look into this and fix it later. > Hard to

Re: [PATCH 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs

2018-03-14 Thread Alexander Duyck
On Wed, Mar 14, 2018 at 5:13 AM, wrote: > On 2018-03-14 01:08, Timur Tabi wrote: >> >> On 3/13/18 10:20 PM, Sinan Kaya wrote: >>> >>> +/* Assumes caller has executed a write barrier to order memory and >>> device >>> + * requests. >>> + */ >>> static inline void

[PATCH net-next v2 2/2] skbuff: Fix not waking applications when errors are enqueued

2018-03-14 Thread Vinicius Costa Gomes
When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in poll() (for example). Fixes: 1da177e4c3f4

[PATCH net-next v2 1/2] selftests/txtimestamp: Add more configurable parameters

2018-03-14 Thread Vinicius Costa Gomes
Add a way to configure if poll() should wait forever for an event, the number of packets that should be sent for each and if there should be any delay between packets. Signed-off-by: Vinicius Costa Gomes --- .../selftests/networking/timestamping/txtimestamp.c | 21

[PATCH net-next v2 0/2] skbuff: Fix applications not being woken for errors

2018-03-14 Thread Vinicius Costa Gomes
Hi, Changes from v1: - Fixed comments from Willem de Bruijn, about the order of the options passed to getopt(); - Added Reviewed-by and Fixes tags to patch (2); Changes from the RFC: - tweaked commit messages; Original cover letter: This is actually a "bug report"-RFC instead of the more

[PATCH net-next v3 3/4] net: qualcomm: rmnet: Remove unnecessary device assignment

2018-03-14 Thread Subash Abhinov Kasiviswanathan
Device of the de-aggregated skb is correctly assigned after inspecting the mux_id, so remove the assignment in rmnet_map_deaggregate(). Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 1 - 1 file changed, 1

[PATCH net-next v3 0/4] net: qualcomm: rmnet: Updates 2018-03-12

2018-03-14 Thread Subash Abhinov Kasiviswanathan
This series contains some minor updates for rmnet driver. Patch 1 contains fixes for sparse warnings. Patch 2 updates the copyright date to 2018. Patch 3 is a cleanup in receive path. Patch 4 has the implementation of the fill_info operation. v1->v2: Remove the force casts since the data type is

[PATCH net-next v3 1/4] net: qualcomm: rmnet: Fix casting issues

2018-03-14 Thread Subash Abhinov Kasiviswanathan
Fix warnings which were reported when running with sparse (make C=1 CF=-D__CHECK_ENDIAN__) drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:81:15: warning: cast to restricted __be16 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:271:37: warning: incorrect type in assignment (different

[PATCH net-next v3 2/4] net: qualcomm: rmnet: Update copyright year to 2018

2018-03-14 Thread Subash Abhinov Kasiviswanathan
Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c| 2 +-

[PATCH net-next 1/2] net: Add rtnl_lock_killable()

2018-03-14 Thread Kirill Tkhai
rtnl_lock() is widely used mutex in kernel. Some of kernel code does memory allocations under it. In case of memory deficit this may invoke OOM killer, but the problem is a killed task can't exit if it's waiting for the mutex. This may be a reason of deadlock and panic. This patch adds a new

Re: [PATCH net-next v2 0/4] net: qualcomm: rmnet: Updates 2018-03-12

2018-03-14 Thread Subash Abhinov Kasiviswanathan
Please address Joe's feedback and only update the copyright date on files that actually had changes this year. Thank you. Hi David I have fixed that now in v3. However, patchwork is not showing the entire series. It shows only the first patch for some reason even if I search with me as

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-03-14 Thread Florian Fainelli
On 03/14/2018 12:40 PM, Grygorii Strashko wrote: > > > On 02/26/2018 02:16 PM, Florian Fainelli wrote: >> On 02/26/2018 12:08 PM, Grygorii Strashko wrote: >>> Hi Florian, >>> >>> The TI CPSW driver produces warning as below when booted in switch mode: >>> [8.882295] sysfs: cannot create

Re: [PATCH] vhost: add vsock compat ioctl

2018-03-14 Thread Michael S. Tsirkin
On Wed, Mar 14, 2018 at 10:26:05AM -0700, Sonny Rao wrote: > This will allow usage of vsock from 32-bit binaries on a 64-bit > kernel. > > Signed-off-by: Sonny Rao I think you need to convert the pointer argument though. Something along the lines of: #ifdef CONFIG_COMPAT

Re: [PATCH net-next 0/2] skbuff: Fix applications not being woken for errors

2018-03-14 Thread Vinicius Costa Gomes
Hi, Willem de Bruijn writes: >> Another interesting fact is that if the POLLIN event is added to the >> poll() .events, poll() no longer becomes stuck, > > The process has registered interest only in POLLIN, which the call to > sk_data_read (sock_def_readable)

Re: [PATCH net-next 1/5] sctp: add refcnt support for sh_key

2018-03-14 Thread Marcelo Ricardo Leitner
On Thu, Mar 15, 2018 at 12:12:32AM +0800, Xin Long wrote: > On Wed, Mar 14, 2018 at 9:59 PM, Neil Horman wrote: > > On Wed, Mar 14, 2018 at 07:05:30PM +0800, Xin Long wrote: > >> With refcnt support for sh_key, chunks auth sh_keys can be decided > >> before enqueuing it.

RE: [Intel-wired-lan] [next-queue PATCH v4 6/8] igb: Add MAC address support for ethtool nftuple filters

2018-03-14 Thread Vinicius Costa Gomes
Hi, "Brown, Aaron F" writes: >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >> Behalf Of Vinicius Costa Gomes >> Sent: Wednesday, March 7, 2018 4:37 PM >> To: intel-wired-...@lists.osuosl.org >> Cc: netdev@vger.kernel.org; Sanchez-Palencia,

[PATCH net-next v3 4/4] net: qualcomm: rmnet: Implement fill_info

2018-03-14 Thread Subash Abhinov Kasiviswanathan
This is needed to query the mux_id and flags of a rmnet device. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 30 ++ 1 file changed, 30 insertions(+) diff --git

[PATCH net-next 0/2] Introduce rtnl_lock_killable()

2018-03-14 Thread Kirill Tkhai
rtnl_lock() is widely used mutex in kernel. Some of kernel code does memory allocations under it. In case of memory deficit this may invoke OOM killer, but the problem is a killed task can't exit if it's waiting for the mutex. This may be a reason of deadlock and panic. This patchset adds a new

[PATCH net-next 2/2] net: Use rtnl_lock_killable() in register_netdev()

2018-03-14 Thread Kirill Tkhai
This patch adds rtnl_lock_killable() to one of hot path using rtnl_lock(). Signed-off-by: Kirill Tkhai --- net/core/dev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 12a9aad0b057..d8887cc38e7b 100644 ---

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-03-14 Thread Grygorii Strashko
On 02/26/2018 02:16 PM, Florian Fainelli wrote: > On 02/26/2018 12:08 PM, Grygorii Strashko wrote: >> Hi Florian, >> >> The TI CPSW driver produces warning as below when booted in switch mode: >> [8.882295] sysfs: cannot create duplicate filename >>

[PATCH RFC 0/7] net: phy: patch series aiming to improve few aspects of phylib

2018-03-14 Thread Heiner Kallweit
This patch series aims to tackle few issues with phylib: - address issues with patch series [1] (smsc911x + phylib changes) - make phy_stop synchronous - get rid of phy_start/stop_machine and handle it in phy_start/phy_stop - in mdio_suspend consider runtime pm state of mdio bus parent -

[PATCH RFC 3/7] net: phy: resume PHY only if needed in, mdio_bus_phy_suspend

2018-03-14 Thread Heiner Kallweit
Currently the PHY is unconditionally resumed in mdio_bus_phy_suspend(). In cases where the PHY was sleepinh before suspending or if somebody else takes care of resuming later, this is not needed and wastes energy. Also start the state machine only if it's used by the driver (indicated by the

[PATCH RFC 2/7] net: phy: improve checking for when PHY is allowed to, suspend

2018-03-14 Thread Heiner Kallweit
This patch improves and unifies checking for when PHY is allowed to suspend. New is a check for the parent of the MDIO bus being runtime-suspended. In this case the MDIO bus may not be accessible and therefore we don't try to suspend the PHY. Instead we rely on the parent to suspend all devices on

[PATCH RFC 7/7] net: phy: remove phy_stop_machine

2018-03-14 Thread Heiner Kallweit
Now that the functionality of phy_stop() was integrated to __phy_stop() we can remove phy_stop_machine(). Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c| 18 -- drivers/net/phy/phy_device.c | 2 -- include/linux/phy.h | 1 - 3

[PATCH RFC 4/7] net: phy: remove phy_start_machine

2018-03-14 Thread Heiner Kallweit
Now that phy_start() integrated the functionality of phy_start_machine() we can remove it. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c| 16 drivers/net/phy/phy_device.c | 1 - drivers/net/phy/phylink.c| 1 - include/linux/phy.h

[PATCH RFC 6/7] net: phy: use new function phy_stop_suspending in, mdio_bus_phy_suspend

2018-03-14 Thread Heiner Kallweit
Use new function phy_stop_suspending() in mdio_bus_phy_suspend() to also disable interrupts and set link state to down. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH RFC 1/7] net: phy: unconditionally resume and re-enable interrupts, in phy_start

2018-03-14 Thread Heiner Kallweit
In subsequent patches of this series interrupts will be disabled during system suspend, also we will have to resume the PHY in states other than PHY_HALTED. To prepare for this unconditionally resume and re-enable interrupts in phy_start(). Signed-off-by: Heiner Kallweit

[PATCH net] netlink: avoid a double skb free in genlmsg_mcast()

2018-03-14 Thread Nicolas Dichtel
nlmsg_multicast() consumes always the skb, thus the original skb must be freed only when this function is called with a clone. Fixes: cb9f7a9a5c96 ("netlink: ensure to loop over all netns in genlmsg_multicast_allns()") Reported-by: Ben Hutchings Signed-off-by:

[PATCH RFC 5/7] net: phy: make phy_stop synchronous

2018-03-14 Thread Heiner Kallweit
Currently phy_stop() just sets the state to PHY_HALTED and relies on the state machine to do the remaining work. It can take up to 1s until the state machine runs again what causes issues in situations where e.g. driver / device is brought down directly after executing phy_stop(). Fix this by

Re: [RESEND] rsi: Remove stack VLA usage

2018-03-14 Thread Tobin C. Harding
On Wed, Mar 14, 2018 at 11:19:53AM +0200, Kalle Valo wrote: > "Tobin C. Harding" writes: > > > Added Konstantin in case he is in charge of administering > > patchwork.kernel.org? > > > > On Tue, Mar 13, 2018 at 07:53:34PM -0700, Kees Cook wrote: > >> On Tue, Mar 13, 2018 at 7:11

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-03-14 Thread Grygorii Strashko
On 03/14/2018 02:50 PM, Florian Fainelli wrote: > On 03/14/2018 12:40 PM, Grygorii Strashko wrote: >> >> >> On 02/26/2018 02:16 PM, Florian Fainelli wrote: >>> On 02/26/2018 12:08 PM, Grygorii Strashko wrote: Hi Florian, The TI CPSW driver produces warning as below when booted in

[PATCH net] skbuff: Fix not waking applications when errors are enqueued

2018-03-14 Thread Vinicius Costa Gomes
When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in poll() (for example). Fixes: 1da177e4c3f4

sctp: use proc_remove_subtree()

2018-03-14 Thread Al Viro
use proc_remove_subtree() for subtree removal, both on setup failure halfway through and on teardown. No need to make simple things complex... Signed-off-by: Al Viro --- include/net/sctp/sctp.h | 9 + net/sctp/proc.c | 90

Re: sctp: use proc_remove_subtree()

2018-03-14 Thread Al Viro
On Wed, Mar 14, 2018 at 08:46:21PM +, Al Viro wrote: > use proc_remove_subtree() for subtree removal, both on setup failure > halfway through and on teardown. No need to make simple things > complex... ... and sctp_dbg_objcnt_exit() can be removed as well - remove_proc_subtree() will get

[PATCH] net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred

2018-03-14 Thread Christophe JAILLET
If the optional regulator is deferrred, we must release some resources. They will be re-allocated when the probe function will be called again. Fixes: 6eacf31139bf ("ethernet: arc: Add support for Rockchip SoC layer device tree bindings") Signed-off-by: Christophe JAILLET

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

2018-03-14 Thread Alexander Zubkov
Hello, For example, it can be fixed in such way (patch is below): - split handling of default and all/any - set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag for default - and AF_UNSPEC for all/any In this case "ip route show default" shows only default route and "ip route show all"

Re: [PATCH] vhost: add vsock compat ioctl

2018-03-14 Thread Sonny Rao
On Wed, Mar 14, 2018 at 12:05 PM, Michael S. Tsirkin wrote: > On Wed, Mar 14, 2018 at 10:26:05AM -0700, Sonny Rao wrote: >> This will allow usage of vsock from 32-bit binaries on a 64-bit >> kernel. >> >> Signed-off-by: Sonny Rao > > I think you need to

[net-next 7/9] i40e: factor out re-enable functions for ATR and SB

2018-03-14 Thread Jeff Kirsher
From: Jacob Keller A future patch needs to expand on the logic for re-enabling ATR. Doing so would cause some code to break the 80-character line limit. To reduce the level of indentation, factor out helper functions for re-enabling ATR and SB rules. Signed-off-by:

[net-next 9/9] i40e: restore TCPv4 input set when re-enabling ATR

2018-03-14 Thread Jeff Kirsher
From: Jacob Keller When we re-enable ATR we need to restore the input set for TCPv4 filters, in order for ATR to function correctly. We already do this for the normal case of re-enabling ATR when disabling ntuple support. However, when re-enabling ATR after the last

[net-next 8/9] i40e: fix for wrong partition id calculation on OCP mezz cards

2018-03-14 Thread Jeff Kirsher
From: Mariusz Stachura This patch overwrites number of ports for X722 devices with support for OCP PHY mezzanine. The old method with checking if port is disabled in the PRTGEN_CNF register cannot be used in this case. When the OCP is removed, ports were seen as

[net-next 4/9] i40e: Cleanup i40e_vlan_rx_register

2018-03-14 Thread Jeff Kirsher
From: Jacob Keller We used to use the function i40e_vlan_rx_register as a way to hook into the now defunct .ndo_vlan_rx_register netdev hook. This was removed but we kept the function around because we still used it internally to control enabling or disabling of VLAN

[net-next 3/9] i40e: Fix attach VF to VM issue

2018-03-14 Thread Jeff Kirsher
From: Paweł Jabłoński Fix for "Resource temporarily unavailable" problem when virsh is trying to attach a device to VM. When the VF driver is loaded on host and virsh is trying to attach it to the VM and set a MAC address, it ends with a race condition between

[net-next 6/9] i40e: track filter type statistics when deleting invalid filters

2018-03-14 Thread Jeff Kirsher
From: Jacob Keller When hardware has trouble with a particular filter, we delete it from the list. Unfortunately, we did not properly update the per-filter statistic when doing so. Create a helper function to handle this, and properly reduce the necessary counter so

[net-next 2/9] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower

2018-03-14 Thread Jeff Kirsher
From: Gustavo A R Silva It seems this is a copy-paste error and that the proper variable to use in this particular case is _src_ instead of _dst_. Addresses-Coverity-ID: 1465282 ("Copy-paste error") Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")

[net-next 5/9] i40e: Fix permission check for VF MAC filters

2018-03-14 Thread Jeff Kirsher
From: Filip Sadowski When VF requests adding of MAC filters the checking is done against number of already present MAC filters not adding them at the same time. It makes it possible to add a bunch of filters at once possibly exceeding acceptable limit of

[net-next 0/9][pull request] 40GbE Intel Wired LAN Driver Updates 2018-03-14

2018-03-14 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Corentin Labbe cleans up the left over FCoE files in the i40e driver. Gustavo A R Silva fixes a cut and paste error. Paweł fixes a race condition when the VF driver is loaded on a host and virsh is trying to attach it to the virtual machine

[net-next 1/9] i40e: remove i40e_fcoe files

2018-03-14 Thread Jeff Kirsher
From: Corentin Labbe i40e_fcoe support was removed via commit 9eed69a9147c ("i40e: Drop FCoE code from core driver files") But this left files in place but un-compilable. Let's finish the cleaning. Signed-off-by: Corentin Labbe Tested-by: Andrew

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Arend van Spriel
On 3/14/2018 4:57 PM, Rafał Miłecki wrote: On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Arend van Spriel
On 3/14/2018 5:10 PM, Kalle Valo wrote: Rafał Miłecki writes: + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) #ifndef? I followed what is used in the include/linux/etherdevice.h. Is that a good

Re: [Intel-wired-lan] [PATCH 03/15] ice: Start hardware initialization

2018-03-14 Thread Venkataramanan, Anirudh
On Mon, 2018-03-12 at 19:05 -0700, Shannon Nelson wrote: > On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: > > This patch implements multiple pieces of the initialization flow > > as follows: > > > > 1) A reset is issued to ensure a clean device state, followed > > by initialization of

Re: [Intel-wired-lan] [PATCH 02/15] ice: Add support for control queues

2018-03-14 Thread Jeff Kirsher
On Mon, 2018-03-12 at 19:05 -0700, Shannon Nelson wrote: > On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: > > A control queue is a hardware interface which is used by the driver > > to interact with other subsystems (like firmware, PHY, etc.). It is > > implemented as a producer-consumer ring.

[PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-14 Thread Grygorii Strashko
Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per one netdevice, as result such drivers will produce warning during system boot and fail to connect second phy to netdevice when PHYLIB framework will try to create sysfs link netdev->phydev for second PHY in

[PATCH 1/2] sysfs: symlink: export sysfs_create_link_nowarn()

2018-03-14 Thread Grygorii Strashko
The sysfs_create_link_nowarn() is going to be used in phylib framework in suseuent patch which can be built as module. Hence, export sysfs_create_link_nowarn() to avoid build errors. Cc: Florian Fainelli Fixes: a3995460491d ("net: phy: Relax error checking on

[PATCH 2/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-14 Thread Grygorii Strashko
Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per one netdevice, as result such drivers will produce warning during system boot and fail to connect second phy to netdevice when PHYLIB framework will try to create sysfs link netdev->phydev for second PHY in

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 16:08, Kalle Valo wrote: Arend van Spriel writes: On 3/14/2018 3:24 PM, Kalle Valo wrote: +config BRCMFMAC_IAPP >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >+ depends on BRCMFMAC >+ ---help--- >+ Most of Broadcom's

<    1   2   3