RE: fix for bnx2x panic during ethtool reporting

2018-04-24 Thread Kalluru, Sudarsana
-Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: 18 April 2018 05:12 To: Sebastian Kuzminsky ; linux-ker...@vger.kernel.org; netdev@vger.kernel.org; Elior, Ariel ; Dept-Eng Everest Linux L2

Re: [PATCH net-next] net: init sk_cookie for inet socket

2018-04-24 Thread Eric Dumazet
On 04/23/2018 09:39 PM, Yafang Shao wrote: > On Tue, Apr 24, 2018 at 12:09 AM, Eric Dumazet wrote: >> >> >> On 04/23/2018 08:58 AM, David Miller wrote: >>> From: Yafang Shao >>> Date: Sun, 22 Apr 2018 21:50:04 +0800 >>> With sk_cookie we can

Re: [PATCH net-next] net: init sk_cookie for inet socket

2018-04-24 Thread Yafang Shao
On Tue, Apr 24, 2018 at 7:41 PM, Eric Dumazet wrote: > > > On 04/23/2018 09:39 PM, Yafang Shao wrote: >> On Tue, Apr 24, 2018 at 12:09 AM, Eric Dumazet >> wrote: >>> >>> >>> On 04/23/2018 08:58 AM, David Miller wrote: From: Yafang Shao

[PATCH] mlxsw: spectrum_switchdev: remove duplicated check on multicast_enable

2018-04-24 Thread Colin King
From: Colin Ian King The check on bridge_port->bridge_device->multicast_enable is performed twice in two nested if statements. I can't see any reason for this, the second check is redundant and can be removed. Detected by cppcheck:

[PATCH net-next] qed: Fix copying 2 strings

2018-04-24 Thread Denis Bolotin
The strscpy() was a recent fix (net: qed: use correct strncpy() size) to prevent passing the length of the source buffer to strncpy() and guarantee null termination. It misses the goal of overwriting only the first 3 characters in "???_BIG_RAM" and "???_RAM" while keeping the rest of the string.

Re: [PATCH 1/1] Revert "rds: ib: add error handle"

2018-04-24 Thread Dag Moxnes
I was going to suggest the following correction: If all agree that this is the correct way of doing it, I can go ahead and an post it. Regards, -Dag On 04/24/2018 01:10 PM, Håkon Bugge wrote: On 24 Apr 2018, at 05:27, santosh.shilim...@oracle.com wrote: On 4/23/18 6:39 PM, Zhu Yanjun

[PATCH net-next V3 1/3] net/dim: Rename *_get_profile() functions to *_get_rx_moderation()

2018-04-24 Thread Tal Gilboa
Preparation for introducing adaptive TX to net DIM. Signed-off-by: Tal Gilboa Reviewed-by: Tariq Toukan --- drivers/net/ethernet/broadcom/bcmsysport.c| 6 +++--- drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c | 8

[PATCH net-next V3 0/3] Introduce adaptive TX interrupt moderation to net DIM

2018-04-24 Thread Tal Gilboa
Net DIM is a library designed for dynamic interrupt moderation. It was implemented and optimized with receive side interrupts in mind, since these are usually the CPU expensive ones. This patch-set introduces adaptive transmit interrupt moderation to net DIM, complete with a usage in the mlx5e

[PATCH net-next V3 3/3] net/mlx5e: Enable adaptive-TX moderation

2018-04-24 Thread Tal Gilboa
Add support for adaptive TX moderation. This greatly reduces TX interrupt rate and increases bandwidth, mostly for TCP bandwidth over ARM architecture (below). There is a slight single stream TCP with very large message sizes degradation (x86). In this case if there's any moderation on transmitted

[PATCH net-next V3 2/3] net/dim: Support adaptive TX moderation

2018-04-24 Thread Tal Gilboa
Interrupt moderation for TX traffic requires different profiles than RX interrupt moderation. The main goal here is to reduce interrupt rate and allow better payload aggregation by keeping SKBs in the TX queue a bit longer. Ping-pong behavior would get a profile with a short timer, so latency

[PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Yafang Shao
This revert commit ("net: init sk_cookie for inet socket") Per discussion with Eric. Signed-off-by: Yafang Shao --- include/linux/sock_diag.h | 9 - net/ipv4/tcp_input.c | 8 +--- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

2018-04-24 Thread Mikulas Patocka
On Mon, 23 Apr 2018, Matthew Wilcox wrote: > On Mon, Apr 23, 2018 at 08:06:16PM -0400, Mikulas Patocka wrote: > > Some bugs (such as buffer overflows) are better detected > > with kmalloc code, so we must test the kmalloc path too. > > Well now, this brings up another item for the collective

[PATCH] net/tls: remove redundant second null check on sgout

2018-04-24 Thread Colin King
From: Colin Ian King A duplicated null check on sgout is redundant as it is known to be already true because of the identical earlier check. Remove it. Detected by cppcheck: net/tls/tls_sw.c:696: (warning) Identical inner 'if' condition is always true. Signed-off-by:

Re: [PATCH net-next] net: init sk_cookie for inet socket

2018-04-24 Thread Eric Dumazet
On 04/24/2018 04:47 AM, Yafang Shao wrote: > > Could you pls. explain the issue to me ? Just run a synflood test on your host, it will definitely show the atomic consuming most cpu cycles in inet_reqsk_alloc(), because of huge contention on a cache line shared by all cpus. Performance is

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

2018-04-24 Thread Michal Hocko
On Mon 23-04-18 20:06:16, Mikulas Patocka wrote: [...] > @@ -404,6 +405,12 @@ void *kvmalloc_node(size_t size, gfp_t f >*/ > WARN_ON_ONCE((flags & GFP_KERNEL) != GFP_KERNEL); > > +#ifdef CONFIG_DEBUG_SG > + /* Catch bugs when the caller uses DMA API on the result of kvmalloc.

[PATCH iproute2-next v2] Add support for cake qdisc

2018-04-24 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth

[PATCH iproute2-next v3] Add support for cake qdisc

2018-04-24 Thread Toke Høiland-Jørgensen
sch_cake is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter To shape

[PATCH 2/8] dt-bindings: stm32-dwmac: add support of MPU families

2018-04-24 Thread Christophe Roullier
Add description for Ethernet MPU families fields Signed-off-by: Christophe Roullier --- Documentation/devicetree/bindings/net/stm32-dwmac.txt | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git

[PATCH 8/8] dt-bindings: stm32: add compatible for syscon

2018-04-24 Thread Christophe Roullier
This patch describes syscon DT bindings. Signed-off-by: Christophe Roullier --- Documentation/devicetree/bindings/arm/stm32.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/stm32.txt

[PATCH 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c.

2018-04-24 Thread Christophe Roullier
Glue codes to support stm32mp157c device and stay compatible with stm32 mcu family Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 267 -- 1 file changed, 252 insertions(+), 15 deletions(-) diff --git

[PATCH 0/8] net: ethernet: stmmac: add support for stm32mp1

2018-04-24 Thread Christophe Roullier
Patches to have Ethernet support on stm32mp1 Christophe Roullier (8): net: ethernet: stmmac: add adaptation for stm32mp157c. dt-bindings: stm32-dwmac: add support of MPU families ARM: dts: stm32: add ethernet pins to stm32mp157c ARM: dts: stm32: Add syscfg on stm32mp1 ARM: dts: stm32:

[PATCH 3/8] ARM: dts: stm32: add ethernet pins to stm32mp157c

2018-04-24 Thread Christophe Roullier
Add ethernet pins on stm32mp157c. Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 46 +++ 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi

[PATCH 6/8] net: stmmac: add dwmac-4.20a compatible

2018-04-24 Thread Christophe Roullier
Manage dwmac-4.20a version from synopsys Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

[PATCH 5/8] ARM: dts: stm32: Add ethernet dwmac on stm32mp1

2018-04-24 Thread Christophe Roullier
Add Ethernet support (Synopsys MAC IP 4.20a) on stm32mp1 SOC. Enable feature supported by the stmmac driver, such as TSO. Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157c.dtsi | 30 ++ 1 file changed, 30 insertions(+)

[PATCH 7/8] ARM: dts: stm32: add support of ethernet on stm32mp157c-ev1

2018-04-24 Thread Christophe Roullier
MAC is connected to a PHY in RGMII mode. Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157c-ev1.dts | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts

Re: [PATCH net-next V3 0/3] Introduce adaptive TX interrupt moderation to net DIM

2018-04-24 Thread Andy Gospodarek
On Tue, Apr 24, 2018 at 10:18:09AM -0400, David Miller wrote: > From: Tal Gilboa > Date: Tue, 24 Apr 2018 13:36:00 +0300 > > > Net DIM is a library designed for dynamic interrupt moderation. It was > > implemented and optimized with receive side interrupts in mind, since

[PATCH 4/8] ARM: dts: stm32: Add syscfg on stm32mp1

2018-04-24 Thread Christophe Roullier
System configuration controller is mainly used to manage the compensation cell and other IOs and system related settings. Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157c.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH v2 net] sfc: ARFS filter IDs

2018-04-24 Thread Edward Cree
On 24/04/18 15:14, Edward Cree wrote: > Associate an arbitrary ID with each ARFS filter, allowing to properly query > for expiry. The association is maintained in a hash table, which is > protected by a spinlock. > > v2: fixed uninitialised variable (thanks davem and lkp-robot). > > Fixes:

Re: [PATCH net-next V3 0/3] Introduce adaptive TX interrupt moderation to net DIM

2018-04-24 Thread David Miller
From: Andy Gospodarek Date: Tue, 24 Apr 2018 11:02:46 -0400 > There is also an advantage that since this is done a per queue basis one > queue that may be handling a bulk transfer can have its coalescing > parameters adjusted while others stay at a setting that

[PATCH v2 net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Yafang Shao
This reverts commit ("net: init sk_cookie for inet socket") Per discussion with Eric, when update sock_net(sk)->cookie_gen, the whole cache cache line will be invalidated, as this cache line is shared with all cpus, that may cause great performace hit. Bellow is the data form Eric. "Performance

Re: [PATCH] l2tp: fix l2tp_eth_dev_xmit()'s return type

2018-04-24 Thread Guillaume Nault
On Tue, Apr 24, 2018 at 03:18:53PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

Re: [PATCH v2 net] sfc: ARFS filter IDs

2018-04-24 Thread David Miller
From: Edward Cree Date: Tue, 24 Apr 2018 16:06:24 +0100 > On 24/04/18 15:14, Edward Cree wrote: >> Associate an arbitrary ID with each ARFS filter, allowing to properly query >> for expiry. The association is maintained in a hash table, which is >> protected by a

Re: [PATCH v2 net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread David Miller
From: Yafang Shao Date: Tue, 24 Apr 2018 23:07:45 +0800 > This reverts commit ("net: init sk_cookie for inet socket") > > Per discussion with Eric, when update sock_net(sk)->cookie_gen, the > whole cache cache line will be invalidated, as this cache line is shared > with

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +struct tc_cake_xstats { > + __u16 version; > + __u16 tin_stats_size; /* == sizeof(struct tc_cake_tin_stats) */ > + __u32 capacity_estimate; > + __u32 memory_limit; > + __u32 memory_used; > +

Re: [PATCH v2 net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Eric Dumazet
On 04/24/2018 08:07 AM, Yafang Shao wrote: > This reverts commit ("net: init sk_cookie for inet socket") > > Per discussion with Eric, when update sock_net(sk)->cookie_gen, the > whole cache cache line will be invalidated, as this cache line is shared > with all cpus, that may cause great

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 16:52:57 +0200 Toke Høiland-Jørgensen wrote: > Well, this is leftover from keeping track of different versions of the > out-of-tree patch, and we already broke compatibility pretty thoroughly > as a preparation for upstreaming. So I'm fine with dropping the

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

2018-04-24 Thread Yafang Shao
On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet wrote: > > > On 04/24/2018 05:05 AM, Yafang Shao wrote: >> This revert commit ("net: init sk_cookie for inet socket") >> >> Per discussion with Eric. >> > > I suggest you include a bit more details, about cache line false

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +static const u8 precedence[] = {0, 0, 0, 0, 0, 0, 0, 0, > + 1, 1, 1, 1, 1, 1, 1, 1, > + 2, 2, 2, 2, 2, 2, 2, 2, > + 3, 3, 3, 3, 3,

Re: simplify procfs code for seq_file instances

2018-04-24 Thread Andrew Morton
On Tue, 24 Apr 2018 16:23:04 +0200 Christoph Hellwig wrote: > On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > > git://git.infradead.org/users/hch/misc.git proc_create > > > > > > I want to ask if it is time to start using poorman function overloading > >

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-24 Thread Mikulas Patocka
On Tue, 24 Apr 2018, Michal Hocko wrote: > On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: > > > Fixing __vmalloc code > > is easy and it doesn't require cooperation with maintainers. > > But it is a hack against the intention of the scope api. It is not! You can fix __vmalloc now and you

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Georgios Amanakis
On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +config NET_SCH_CAKE > + tristate "Common Applications Kept Enhanced (CAKE)" > + help > + Say Y here if you want to use the Common Applications Kept Enhanced > + (CAKE) queue management

[PATCH bpf-next v5 0/2] bpf: allow map helpers access to map values directly

2018-04-24 Thread Paul Chaignon
Currently, helpers that expect ARG_PTR_TO_MAP_KEY and ARG_PTR_TO_MAP_VALUE can only access stack and packet memory. This patchset allows these helpers to directly access map values by passing registers of type PTR_TO_MAP_VALUE. The first patch changes the verifier; the second adds new test

[PATCH bpf-next v5 2/2] tools/bpf: add verifier tests for accesses to map values

2018-04-24 Thread Paul Chaignon
This patch adds new test cases for accesses to map values from map helpers. Signed-off-by: Paul Chaignon --- tools/testing/selftests/bpf/test_verifier.c | 266 1 file changed, 266 insertions(+) diff --git

[PATCH] net: gianfar: fix gfar_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH] xen-netback: fix xenvif_start_xmit()'s return type

2018-04-24 Thread Wei Liu
On Tue, Apr 24, 2018 at 03:18:12PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

[PATCH] cxgb4vf: fix t4vf_eth_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] ath6kl: fix ath6kl_data_tx()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: ethernet: ave: fix ave_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-24 Thread Michal Hocko
On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: > > > On Mon, 23 Apr 2018, Michal Hocko wrote: > > > On Mon 23-04-18 10:06:08, Mikulas Patocka wrote: > > > > > > > He didn't want to fix vmalloc(GFP_NOIO) > > > > > > > > I don't remember that conversation, so I don't know whether I agree with

Re: [Xen-devel] [PATCH] xen-netfront: fix xennet_start_xmit()'s return type

2018-04-24 Thread Wei Liu
On Tue, Apr 24, 2018 at 03:18:14PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

[PATCH] net: dwc-xlgmac: fix xlgmac_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: w5300: fix w5300_start_tx()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: pch_gbe: fix pch_gbe_xmit_frame()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: ks8851: fix ks_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] liquidio: fix liquidio_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementations in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: mvpp2: fix mvpp2_tx()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: hip04: fix hip04_mac_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: ixgbevf: fix ixgbevf_xmit_frame()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: gemini: fix gmac_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] can: janz-ican3: fix ican3_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] caif: fix cfspi_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH net-next 1/3] net: phy: Add binding for vendor specific C45 MDIO address space

2018-04-24 Thread Rob Herring
On Tue, Apr 17, 2018 at 11:29:27AM -0700, Florian Fainelli wrote: > On 04/17/2018 11:27 AM, Andrew Lunn wrote: > > On Tue, Apr 17, 2018 at 11:18:20AM -0700, Florian Fainelli wrote: > >> On 04/17/2018 02:02 AM, Vicentiu Galanopulo wrote: > >>> The extra property enables the discovery on the MDIO

[PATCH V7 net-next 01/14] tcp: Add clean acked data hook

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin Called when a TCP segment is acknowledged. Could be used by application protocols who hold additional metadata associated with the stream data. This is required by TLS device offload to release metadata associated with acknowledged TLS records.

[PATCH V7 net-next 00/14] TLS offload, netdev & MLX5 support

2018-04-24 Thread Boris Pismenny
Hi Dave, The following series provides TLS TX inline crypto offload. v1->v2: - Added IS_ENABLED(CONFIG_TLS_DEVICE) and a STATIC_KEY for icsk_clean_acked - File license fix - Fix spelling, comment by DaveW - Move memory allocations out of tls_set_device_offload and other misc fixes,

[PATCH V7 net-next 02/14] net: Rename and export copy_skb_header

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin copy_skb_header is renamed to skb_copy_header and exported. Exposing this function give more flexibility in copying SKBs. skb_copy and skb_copy_expand do not give enough control over which parts are copied. Signed-off-by: Ilya Lesokhin

[PATCH V7 net-next 03/14] net: Add Software fallback infrastructure for socket dependent offloads

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin With socket dependent offloads we rely on the netdev to transform the transmitted packets before sending them to the wire. When a packet from an offloaded socket is rerouted to a different device we need to detect it and do the transformation in software.

[PATCH V7 net-next 08/14] net/mlx5e: Move defines out of ipsec code

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin The defines are not IPSEC specific. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Acked-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +++

[PATCH bpf-next v5 1/2] bpf: allow map helpers access to map values directly

2018-04-24 Thread Paul Chaignon
Helpers that expect ARG_PTR_TO_MAP_KEY and ARG_PTR_TO_MAP_VALUE can only access stack and packet memory. Allow these helpers to directly access map values by passing registers of type PTR_TO_MAP_VALUE. This change removes the need for an extra copy to the stack when using a map value to perform

[PATCH V7 net-next 04/14] net: Add TLS offload netdev ops

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin Add new netdev ops to add and delete tls context Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- include/linux/netdevice.h | 24

[PATCH V7 net-next 07/14] net/tls: Add generic NIC offload infrastructure

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin This patch adds a generic infrastructure to offload TLS crypto to a network device. It enables the kernel TLS socket to skip encryption and authentication operations on the transmit side of the data path. Leaving those computationally expensive operations

[PATCH V7 net-next 11/14] net/mlx5e: TLS, Add Innova TLS TX offload data path

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin Implement the TLS tx offload data path according to the requirements of the TLS generic NIC offload infrastructure. Special metadata ethertype is used to pass information to the hardware. Signed-off-by: Ilya Lesokhin Signed-off-by:

[PATCH V7 net-next 06/14] net/tls: Split conf to rx + tx

2018-04-24 Thread Boris Pismenny
In TLS inline crypto, we can have one direction in software and another in hardware. Thus, we split the TLS configuration to separate structures for receive and transmit. Signed-off-by: Boris Pismenny --- include/net/tls.h | 51 +--- net/tls/tls_main.c |

[PATCH V7 net-next 12/14] net/mlx5e: TLS, Add error statistics

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin Add statistics for rare TLS related errors. Since the errors are rare we have a counter per netdev rather then per SQ. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Acked-by: Saeed Mahameed

[PATCH V7 net-next 09/14] net/mlx5: Accel, Add TLS tx offload interface

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin Add routines for manipulating TLS TX offload contexts. In Innova TLS, TLS contexts are added or deleted via a command message over the SBU connection. The HW then sends a response message over the same connection. Add implementation for Innova TLS

[PATCH V7 net-next 10/14] net/mlx5e: TLS, Add Innova TLS TX support

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin Add NETIF_F_HW_TLS_TX capability and expose tlsdev_ops to work with the TLS generic NIC offload infrastructure. The NETIF_F_HW_TLS_TX capability will be added in the next patch. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris

[PATCH V7 net-next 05/14] net: Add TLS TX offload features

2018-04-24 Thread Boris Pismenny
From: Ilya Lesokhin This patch adds a netdev feature to configure TLS TX offloads. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- include/linux/netdev_features.h

[PATCH] openvswitch: make vport_ops:send()'s return type consistent

2018-04-24 Thread Luc Van Oostenryck
The method struct vport_ops:send() is defined as returning an 'netdev_tx_t', which is defined as a typedef for a bitwise type and otherwise used for the start_xmit() methods. However, most openvswitch drivers use for this method dev_queue_xmit() which returns an 'int' and the return value of

[PATCH] net: caif: fix chnl_net_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] l2tp: fix l2tp_eth_dev_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net/hsr: fix hsr_dev_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] batman-adv: fix batadv_interface_tx()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] hv_netsvc: fix netvsc_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: plip: fix plip_tx_packet()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] openvswitch: fix internal_dev_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH] net: ks8851: fix ks_start_xmit()'s return type

2018-04-24 Thread Yuval Shaia
On Tue, Apr 24, 2018 at 03:17:02PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

[PATCH] net: smsc911x: fix smsc911x_hard_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: qcom/emac: fix emac_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: macb: fix macb_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] liquidio: fix lio_vf_rep_pkt_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: aquantia: fix aq_ndev_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: nb8800: fix nb8800_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCHv2 net] team: fix netconsole setup over team

2018-04-24 Thread David Miller
From: Xin Long Date: Tue, 24 Apr 2018 14:33:37 +0800 > The same fix in Commit dbe173079ab5 ("bridge: fix netconsole > setup over bridge") is also needed for team driver. > > While at it, remove the unnecessary parameter *team from > team_port_enable_netpoll(). > > v1->v2:

Re: [PATCH] batman-adv: fix batadv_interface_tx()'s return type

2018-04-24 Thread Sven Eckelmann
On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote: [...] > -static int batadv_interface_tx(struct sk_buff *skb, > +static netdev_tx_t batadv_interface_tx(struct sk_buff *skb, > struct net_device *soft_iface) > { > struct ethhdr *ethhdr; >

[PATCH] amd-xgbe: fix xgbe_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: arc_emac: fix arc_emac_tx()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] can: xilinx: fix xcan_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] can: sun4i: fix sun4ican_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [RFC v3 net-next 13/18] net/sched: Introduce the TBS Qdisc

2018-04-24 Thread David Miller
From: Thomas Gleixner Date: Tue, 24 Apr 2018 10:50:04 +0200 (CEST) > So adding 8 bytes to spare duplicated code will not change the kmem_cache > object size and I really doubt that anyone will notice. It's about where the cache lines end up when each and every byte is added

Re: [PATCH] vhost_net: use packet weight for rx handler, too

2018-04-24 Thread David Miller
From: Paolo Abeni Date: Tue, 24 Apr 2018 10:34:36 +0200 > Similar to commit a2ac99905f1e ("vhost-net: set packet weight of > tx polling to 2 * vq size"), we need a packet-based limit for > handler_rx, too - elsewhere, under rx flood with small packets, > tx can be delayed for

<    1   2   3   4   >