Re: [PATCH v2 04/12] net: ethernet: aquantia: Low-level hardware interfaces

2017-01-06 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] [also build test ERROR on v4.10-rc2 next-20170106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alexander-Loktionov/net-ethernet-aquantia

[PATCH net-next] mdio: Demote print from info to debug in mdio_device_register

2017-01-06 Thread Florian Fainelli
While it is useful to know which MDIO device is being registered, demote the dev_info() to a dev_dbg(). Signed-off-by: Florian Fainelli --- drivers/net/phy/mdio_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_device.c

Re: [PATCH v2 12/12] net: ethernet: aquantia: Receive side scaling

2017-01-06 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] [also build test ERROR on v4.10-rc2 next-20170106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alexander-Loktionov/net-ethernet-aquantia

Re: [PATCH v2 12/12] net: ethernet: aquantia: Receive side scaling

2017-01-06 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] [also build test ERROR on v4.10-rc2 next-20170106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alexander-Loktionov/net-ethernet-aquantia

Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF

2017-01-06 Thread Eric Biggers
Hi Jason, just a few comments: On Fri, Jan 06, 2017 at 09:10:52PM +0100, Jason A. Donenfeld wrote: > +#define SIPHASH_ALIGNMENT __alignof__(u64) > +typedef u64 siphash_key_t[2]; I was confused by all the functions passing siphash_key_t "by value" until I saw that it's actually typedefed to

[PATCH] treewide: fix semicolon.cocci warnings

2017-01-06 Thread kbuild test robot
net/netfilter/x_tables.c:716:59-60: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Fengguang Wu --- x_tables.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

Re: [PATCH net] be2net: fix accesses to unicast list

2017-01-06 Thread David Miller
From: Ivan Vecera Date: Fri, 6 Jan 2017 20:30:02 +0100 > Commit 988d44b "be2net: Avoid redundant addition of mac address in HW" > introduced be_dev_mac_add & be_uc_mac_add helpers that incorrectly > access adapter->uc_list as an array of bytes instead of an array of > be_eth_addr.

Re: [PATCH] netlabel: add CALIPSO to the list of built-in protocols

2017-01-06 Thread David Miller
From: Paul Moore Date: Fri, 06 Jan 2017 14:26:54 -0500 > From: Paul Moore > > When we added CALIPSO support in Linux v4.8 we forgot to add it to the > list of supported protocols with display at boot. > > Signed-off-by: Paul Moore

Re: [PATCH net-next 0/4] l2tp: cleanup socket lookup code in l2tp_ip and l2tp_ip6

2017-01-06 Thread David Miller
From: Guillaume Nault Date: Fri, 6 Jan 2017 20:03:53 +0100 > First three patches remove redundant tests and add missing "const" > qualifiers. > > Fourth patch splits the conditionals found in __l2tp_ip*_bind_lookup(), > to make these functions easier to review. In the

Re: [net-next][PATCH] RDS: validate the requested traces user input against max supported

2017-01-06 Thread David Miller
From: Santosh Shilimkar Date: Fri, 6 Jan 2017 10:44:15 -0800 > Larger than supported value can lead to array read/write overflow. > > Reported-by: Colin Ian King > Signed-off-by: Santosh Shilimkar Applied,

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-06 Thread Stephen Hemminger
On Mon, 2 Jan 2017 20:32:14 +0100 Linus Lüssing wrote: > This feature is intended for interface types which have a more reliable > and/or efficient way to deliver unicast packets than broadcast ones > (e.g. wifi). Why is this not done in MAC80211 rather than bridge?

[PATCH net-next v2 1/2] net: make ndo_get_stats64 a void function

2017-01-06 Thread Stephen Hemminger
The network device operation for reading statistics is only called in one place, and it ignores the return value. Having a structure return value is potentially confusing because some future driver could incorrectly assume that the return value was used. Fix all drivers with ndo_get_stats64 to

[PATCH net-next 2/2] net: remove useless memset's in drivers get_stats64

2017-01-06 Thread Stephen Hemminger
In dev_get_stats() the statistic structure storage has already been zeroed. Therefore network drivers do not need to call memset() again. Signed-off-by: Stephen Hemminger --- Found while reviewing earlier patch drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 1 -

Re: [net-next PATCH] net: reduce cycles spend on ICMP replies that gets rate limited

2017-01-06 Thread David Miller
From: Eric Dumazet Date: Fri, 06 Jan 2017 14:08:06 -0800 > On Fri, 2017-01-06 at 11:40 -0800, Eric Dumazet wrote: >> On Fri, 2017-01-06 at 18:39 +0100, Jesper Dangaard Brouer wrote: >> >> >> > @@ -648,13 +668,17 @@ void icmp_send(struct sk_buff *skb_in, int type, int

Re: [PATCH net-next 0/2] afs: Implement bulk read

2017-01-06 Thread David Miller
git/log/?h=rxrpc-rewrite > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20170106 Pulled, thanks David.

Re: [PATCH next v1] ipvlan: don't use IDR for generating dev_id

2017-01-06 Thread David Miller
From: Mahesh Bandewar Date: Fri, 6 Jan 2017 16:33:11 -0800 > From: Mahesh Bandewar > > The patch 009146d117b ("ipvlan: assign unique dev-id for each slave > device.") used ida_simple_get() to generate dev_ids assigned to the > slave devices. However

Re: [PATCHv3 net-next] sctp: prepare asoc stream for stream reconf

2017-01-06 Thread David Miller
From: Xin Long Date: Fri, 6 Jan 2017 22:18:33 +0800 > sctp stream reconf, described in RFC 6525, needs a structure to > save per stream information in assoc, like stream state. > > In the future, sctp stream scheduler also needs it to save some > stream scheduler params

Re: [PATCH v5 0/3] adding new glue driver dwmac-dwc-qos-eth

2017-01-06 Thread David Miller
From: Joao Pinto Date: Fri, 6 Jan 2017 10:48:30 + > This patch set contains the porting of the synopsys/dwc_eth_qos.c driver > to the stmmac structure. This operation resulted in the creation of a new > platform glue driver called dwmac-dwc-qos-eth which was based in

Re: [PATCH net] udp: inuse checks can quit early for reuseport

2017-01-06 Thread David Miller
From: Eric Garver Date: Thu, 5 Jan 2017 20:22:36 -0500 > UDP lib inuse checks will walk the entire hash bucket to check if the > portaddr is in use. In the case of reuseport we can stop searching when > we find a matching reuseport. > > On a 16-core VM a test program that spawns

Re: [PATCH net-next V2 0/3] net/sched: act_pedit: Use offset relative to conventional network headers

2017-01-06 Thread David Miller
From: Amir Vadai Date: Thu, 5 Jan 2017 11:54:51 +0200 > Enhancing the UAPI to allow for specifying that would allow the same > flows to be set into both SW and HW. This is actually not backward compatible. When pedit rules are dumped, older tools will not know about the type

[PATCH net-next] net: ipv4: Remove flow arg from ip_mkroute_input

2017-01-06 Thread David Ahern
fl4 arg is not used; remove it. Signed-off-by: David Ahern --- net/ipv4/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 7b52ac20145b..b9bff78274bf 100644 --- a/net/ipv4/route.c +++

[PATCH net-next] net: ipmr: Remove nowait arg to ipmr_get_route

2017-01-06 Thread David Ahern
ipmr_get_route has 1 caller and the nowait arg is 0. Remove the arg and simplify ipmr_get_route accordingly. Signed-off-by: David Ahern --- include/linux/mroute.h | 2 +- net/ipv4/ipmr.c| 7 +-- net/ipv4/route.c | 2 +- 3 files changed, 3

Re: [net-next PATCH v6 0/3] net: dummy: Introduce dummy virtual functions

2017-01-06 Thread David Miller
From: Phil Sutter Date: Thu, 5 Jan 2017 20:09:10 +0100 > This series adds VF support to dummy device driver after adding the > necessary infrastructure changes: > > Patch 1 adds a netdevice callback for device-specific VF count > retrieval. Patch 2 then changes dev_num_vf()

[PATCH v5] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-06 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" There is no checking valid value of maxmtu when getting it from device tree. This resolution added the checking condition to ensure the assignment is made within a valid range. Signed-off-by: Kweh, Hock Leong ---

[PATCH net-next] liquidio: simplify octeon_flush_iq()

2017-01-06 Thread Felix Manlunas
From: Derek Chickles Because every call to octeon_flush_iq() has a hardcoded 1 for the pending_thresh argument, simplify that function by removing that argument. This avoids one atomic read as well. Signed-off-by: Derek Chickles

Re: [next PATCH 00/11] ixgbe: Add support for writable pages and build_skb

2017-01-06 Thread Jeff Kirsher
On Fri, 2017-01-06 at 16:41 -0500, David Miller wrote: > From: Alexander Duyck > Date: Fri, 06 Jan 2017 08:06:16 -0800 > > > The testing matrix for all of these patches is going to be pretty > > extensive.  Basically we want to test these patches on as many > >

Re: [PATCH v2 03/12] net: ethernet: aquantia: Add ring support code

2017-01-06 Thread Lino Sanfilippo
On 06.01.2017 09:06, Alexander Loktionov wrote: From: David VomLehn Add code to support the transmit and receive ring buffers. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov

[PATCH net-next] liquidio: store the L4 hash of rx packets in skb

2017-01-06 Thread Felix Manlunas
From: Prasad Kanneganti Store the L4 hash of received packets in the skb; the hash is computed in the NIC firmware. Signed-off-by: Prasad Kanneganti Signed-off-by: Felix Manlunas Signed-off-by: Derek

RE: [PATCH v3] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-06 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Saturday, January 07, 2017 8:07 AM > To: Kweh, Hock Leong > Cc: David S. Miller ; Joao Pinto > ; Giuseppe CAVALLARO

RE: [PATCH v4] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-06 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Saturday, January 07, 2017 8:12 AM > To: Kweh, Hock Leong > Cc: David S. Miller ; Joao Pinto > ; Giuseppe CAVALLARO

[PATCH next v1] ipvlan: don't use IDR for generating dev_id

2017-01-06 Thread Mahesh Bandewar
From: Mahesh Bandewar The patch 009146d117b ("ipvlan: assign unique dev-id for each slave device.") used ida_simple_get() to generate dev_ids assigned to the slave devices. However (Eric has pointed out that) there is a shortcoming with that approach as it always uses the

Re: [PATCH v2 02/12] net: ethernet: aquantia: Common functions and definitions

2017-01-06 Thread Lino Sanfilippo
Hi, On 06.01.2017 09:06, Alexander Loktionov wrote: + +#define TXT(_T_) #_T_ +#define TXTTXT(_T_) TXT(_T_) do you really need these (IMHO ugly) macros? AFAICS you only use them to build the driver version string. + +#define AQ_CFG_DRV_AUTHOR "aQuantia" +#define AQ_CFG_DRV_DESC

Re: [PATCH v4] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-06 Thread Andy Shevchenko
On Sat, Jan 7, 2017 at 10:10 AM, Kweh, Hock Leong wrote: > From: "Kweh, Hock Leong" > > There is no checking valid value of maxmtu when getting it from device tree. > This resolution added the checking condition to ensure the assignment is >

Re: [PATCH v3] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-06 Thread Andy Shevchenko
On Sat, Jan 7, 2017 at 1:47 AM, Kweh, Hock Leong wrote: >> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> > @@ -3345,8 +3345,14 @@ int stmmac_dvr_probe(struct device *device, >> >

[PATCH v4] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-06 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" There is no checking valid value of maxmtu when getting it from device tree. This resolution added the checking condition to ensure the assignment is made within a valid range. Signed-off-by: Kweh, Hock Leong ---

RE: [PATCH v3] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-06 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Saturday, January 07, 2017 1:07 AM > To: Kweh, Hock Leong > Cc: David S. Miller ; Joao Pinto > ; Giuseppe CAVALLARO

Re: [PATCHv1 7/7] IPVTAP: IP-VLAN based tap driver

2017-01-06 Thread महेश बंडेवार
few superficial comments inline. On Fri, Jan 6, 2017 at 2:33 PM, Sainath Grandhi wrote: > This patch adds a tap character device driver that is based on the > IP-VLAN network interface, called ipvtap. An ipvtap device can be created > in the same way as an ipvlan

RE: [PATCH v3] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-06 Thread Kweh, Hock Leong
> -Original Message- > From: Joao Pinto [mailto:joao.pi...@synopsys.com] > Sent: Saturday, January 07, 2017 12:58 AM > To: Kweh, Hock Leong ; David S. Miller > ; Joao Pinto ; Giuseppe > CAVALLARO

Re: [Intel-wired-lan] [PATCH v2] PCI: lock each enable/disable num_vfs operation in sysfs

2017-01-06 Thread Greg
On Fri, 2017-01-06 at 23:28 +, Tantilov, Emil S wrote: > >-Original Message- > >From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > >Behalf Of Greg > >Sent: Friday, January 06, 2017 3:18 PM > >To: Tantilov, Emil S > >Cc:

RE: [Intel-wired-lan] [PATCH v2] PCI: lock each enable/disable num_vfs operation in sysfs

2017-01-06 Thread Tantilov, Emil S
>-Original Message- >From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On >Behalf Of Greg >Sent: Friday, January 06, 2017 3:18 PM >To: Tantilov, Emil S >Cc: linux-...@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux-

[PATCH net] bpf: change back to orig prog on too many passes

2017-01-06 Thread Daniel Borkmann
If after too many passes still no image could be emitted, then swap back to the original program as we do in all other cases and don't use the one with blinding. Fixes: 959a75791603 ("bpf, x86: add support for constant blinding") Signed-off-by: Daniel Borkmann Acked-by:

Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-06 Thread Eric Dumazet
On Fri, 2017-01-06 at 14:33 -0800, Sainath Grandhi wrote: > +static int tap_list_add(dev_t major, const char *device_name) > +{ > + int err = 0; > + struct major_info *tap_major; > + > + tap_major = kzalloc(sizeof(*tap_major), GFP_ATOMIC); > + > + tap_major->major = MAJOR(major);

Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-06 Thread Andy Shevchenko
On Sat, Jan 7, 2017 at 12:33 AM, Sainath Grandhi wrote: > Extending tap APIs get/free_minor and create/destroy_cdev to handle more than > one > type of virtual interface. > > Signed-off-by: Sainath Grandhi > Tested-by: Sainath Grandhi

Re: [PATCH v2] PCI: lock each enable/disable num_vfs operation in sysfs

2017-01-06 Thread Greg
On Fri, 2017-01-06 at 13:59 -0800, Emil Tantilov wrote: > Enabling/disabling SRIOV via sysfs by echo-ing multiple values > simultaneously: > > echo 63 > /sys/class/net/ethX/device/sriov_numvfs& > echo 63 > /sys/class/net/ethX/device/sriov_numvfs > > sleep 5 > > echo 0 >

Re: [PATCHv1 7/7] IPVTAP: IP-VLAN based tap driver

2017-01-06 Thread Eric Dumazet
On Fri, 2017-01-06 at 14:33 -0800, Sainath Grandhi wrote: > This patch adds a tap character device driver that is based on the > IP-VLAN network interface, called ipvtap. An ipvtap device can be created > in the same way as an ipvlan device, using 'type ipvtap', and then accessed > using the tap

Re: [PATCHv1 1/7] TAP: Refactoring macvtap.c

2017-01-06 Thread Andy Shevchenko
On Sat, Jan 7, 2017 at 12:33 AM, Sainath Grandhi wrote: > macvtap module has code for tap/queue management and link management. This > patch splits > the code into macvtap_main.c for link management and tap.c for tap/queue > management. > Functionality in tap.c can be

Re: [PATCH 2/2] ARM: dts: dra72-evm-revc: enable irqs for dp83867 eth phys

2017-01-06 Thread Tony Lindgren
* Grygorii Strashko [170106 12:56]: > TI DRA72-EVM Rev C has two DP83867 ethernet phys which support IRQ > generation in case of phy/link status changes. The INT/PWDN lines from both > DP83867 phys are wired to DRA7 gpio6.16, so reflect the same in DT. Hmm not seeing

Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2

2017-01-06 Thread Florian Fainelli
On 01/06/2017 02:20 PM, Andrew Lunn wrote: >> If one wants to rename an interface, udev rules can be used as usual. > > Hi Vivien > > Do you have some examples? > > A quick look at udevadm info suggests we can use > > ATTR{phys_port_id} and ATTR{phys_switch_id} > > Humm, it would be nice to

Re: [PATCH net-next 2/2] arm: dts: vf610-zii-dev-rev-b: remove ports label

2017-01-06 Thread Andrew Lunn
On Fri, Jan 06, 2017 at 05:00:43PM -0500, Vivien Didelot wrote: > Now that the "label" property is optional for Ethernet switch ports, > remove them in the ZII Dev Rev B board DTS. > > On a Rev B board, once eth1 is up, this DTS now exposes to userspace: > > # ip link | grep ': ' | cut -d:

Re: [PATCH 2/3] xen: modify xenstore watch event interface

2017-01-06 Thread Boris Ostrovsky
On 01/06/2017 10:05 AM, Juergen Gross wrote: > Today a Xenstore watch event is delivered via a callback function > declared as: > > void (*callback)(struct xenbus_watch *, > const char **vec, unsigned int len); > > As all watch events only ever come with two parameters (path and

[PATCHv1 1/7] TAP: Refactoring macvtap.c

2017-01-06 Thread Sainath Grandhi
macvtap module has code for tap/queue management and link management. This patch splits the code into macvtap_main.c for link management and tap.c for tap/queue management. Functionality in tap.c can be re-used for implementing tap on other virtual interfaces. Signed-off-by: Sainath Grandhi

[PATCHv1 4/7] TAP: Abstract type of virtual interface from tap implementation

2017-01-06 Thread Sainath Grandhi
macvlan object is re-structured to hold tap related elements in a separate entity, tap_dev. Upon NETDEV_REGISTER device_event, tap_dev is registered with idr and fetched again on tap_open. Few of the tap functions are modified to accepted tap_dev as argument. tap_dev object includes callbacks to

[PATCHv1 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-01-06 Thread Sainath Grandhi
Tap character devices can be implemented on other virtual interfaces like ipvlan, similar to macvtap. Source code for tap functionality in macvtap can be re-used for this purpose. This patch series splits macvtap source into two modules, macvtap and tap. This patch series also includes a patch

[PATCHv1 2/7] TAP: Renaming tap related APIs, data structures, macros

2017-01-06 Thread Sainath Grandhi
Renaming tap related APIs, data structures and macros in tap.c from macvtap_.* to tap_.* Signed-off-by: Sainath Grandhi Tested-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 18 +-- drivers/net/tap.c | 332

[PATCHv1 3/7] TAP: Tap character device creation/destroy API

2017-01-06 Thread Sainath Grandhi
This patch provides tap device create/destroy APIs in tap.c. Signed-off-by: Sainath Grandhi Tested-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 29 +++-- drivers/net/tap.c | 64

[PATCHv1 7/7] IPVTAP: IP-VLAN based tap driver

2017-01-06 Thread Sainath Grandhi
This patch adds a tap character device driver that is based on the IP-VLAN network interface, called ipvtap. An ipvtap device can be created in the same way as an ipvlan device, using 'type ipvtap', and then accessed using the tap user space interface. Signed-off-by: Sainath Grandhi

[PATCHv1 6/7] TAP: tap as an independent module

2017-01-06 Thread Sainath Grandhi
This patch makes tap a separate module for other types of virtual interfaces, for example, ipvlan to use. Signed-off-by: Sainath Grandhi Tested-by: Sainath Grandhi --- drivers/net/Kconfig| 14 +++ drivers/net/Makefile | 3

[PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-06 Thread Sainath Grandhi
Extending tap APIs get/free_minor and create/destroy_cdev to handle more than one type of virtual interface. Signed-off-by: Sainath Grandhi Tested-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 6 +-- drivers/net/tap.c |

Re: [PATCH net-next] net: dsa: move HWMON support to its own file

2017-01-06 Thread Andrew Lunn
On Fri, Jan 06, 2017 at 04:42:00PM -0500, Vivien Didelot wrote: > Isolate the HWMON support in DSA in its own file. Currently only the > legacy DSA code is concerned. > > Signed-off-by: Vivien Didelot Seems like a good step towards removing it completely and

Re: [PATCH v2 00/12] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-06 Thread David VomLehn
On 01/06/2017 01:02 PM, David Miller wrote: From: Alexander Loktionov Date: Fri, 6 Jan 2017 00:06:01 -0800 This series introduced the AQtion NIC driver for the aQuantia AQC107/AQC108 network devices. v1: Initial version v2: o Make necessary

Re: [PATCH net-next] net: dsa: move HWMON support to its own file

2017-01-06 Thread Florian Fainelli
On 01/06/2017 01:42 PM, Vivien Didelot wrote: > Isolate the HWMON support in DSA in its own file. Currently only the > legacy DSA code is concerned. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2

2017-01-06 Thread Vivien Didelot
In the new DTS bindings for DSA (dsa2), the "ethernet" and "link" phandles are respectively mandatory and exclusive to CPU port and DSA link device tree nodes. Simplify dsa2.c a bit by checking the presence of such phandle instead of checking the redundant "label" property. Then the Linux

[PATCH net-next 0/2] net: dsa: make "label" property optional

2017-01-06 Thread Vivien Didelot
Patch 1/2 makes the "label" property in new DSA bindings optional. This doesn't change the current behavior with existing DTS files. As Linux considers the Ethernet switch ports as normal NICs by default, not providing a "label" property for user ports results in using the standard "ethX" network

[PATCH net-next 2/2] arm: dts: vf610-zii-dev-rev-b: remove ports label

2017-01-06 Thread Vivien Didelot
Now that the "label" property is optional for Ethernet switch ports, remove them in the ZII Dev Rev B board DTS. On a Rev B board, once eth1 is up, this DTS now exposes to userspace: # ip link | grep ': ' | cut -d: -f2 lo eth0 eth1 eth2@eth1 eth3@eth1 eth4@eth1

Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2

2017-01-06 Thread Andrew Lunn
> If one wants to rename an interface, udev rules can be used as usual. Hi Vivien Do you have some examples? A quick look at udevadm info suggests we can use ATTR{phys_port_id} and ATTR{phys_switch_id} Humm, it would be nice to know why the second switch has a phys_switch_id of 0100. How

[PATCH v2] PCI: lock each enable/disable num_vfs operation in sysfs

2017-01-06 Thread Emil Tantilov
Enabling/disabling SRIOV via sysfs by echo-ing multiple values simultaneously: echo 63 > /sys/class/net/ethX/device/sriov_numvfs& echo 63 > /sys/class/net/ethX/device/sriov_numvfs sleep 5 echo 0 > /sys/class/net/ethX/device/sriov_numvfs& echo 0 > /sys/class/net/ethX/device/sriov_numvfs Results

Re: [net-next PATCH] net: reduce cycles spend on ICMP replies that gets rate limited

2017-01-06 Thread Eric Dumazet
On Fri, 2017-01-06 at 11:40 -0800, Eric Dumazet wrote: > On Fri, 2017-01-06 at 18:39 +0100, Jesper Dangaard Brouer wrote: > > > > @@ -648,13 +668,17 @@ void icmp_send(struct sk_buff *skb_in, int type, int > > code, __be32 info) > > } > > } > > > > - icmp_param =

[PATCH] [v2] net: qcom/emac: add ethtool support

2017-01-06 Thread Timur Tabi
Add support for some ethtool methods: get/set link settings, get/set message level, get statistics, get link status, get ring params, get pause params, and restart autonegotiation. The code to collect the hardware statistics is moved into its own function so that it can be used by "get

[PATCH net-next] net: dsa: move HWMON support to its own file

2017-01-06 Thread Vivien Didelot
Isolate the HWMON support in DSA in its own file. Currently only the legacy DSA code is concerned. Signed-off-by: Vivien Didelot --- net/dsa/Makefile | 1 + net/dsa/dsa.c | 131 +-- net/dsa/dsa_priv.h |

Re: [next PATCH 00/11] ixgbe: Add support for writable pages and build_skb

2017-01-06 Thread David Miller
From: Alexander Duyck Date: Fri, 06 Jan 2017 08:06:16 -0800 > The testing matrix for all of these patches is going to be pretty > extensive. Basically we want to test these patches on as many platforms > and architectures as possible with as many features being

Re: pull-request: mac80211 2017-01-06

2017-01-06 Thread David Miller
From: Johannes Berg Date: Fri, 6 Jan 2017 13:37:20 +0100 > Here's another fix for something I noticed while reviewing the code in > a new suggested patch that added another netlink socket destroy path. > > Since the new patch would otherwise cause conflicts, it might

[PATCH net] tg3: Fix race condition in tg3_get_stats64().

2017-01-06 Thread Michael Chan
The driver's ndo_get_stats64() method is not always called under RTNL. So it can race with driver close or ethtool reconfigurations. Fix the race condition by taking tp->lock spinlock in tg3_free_consistent() when freeing the tp->hw_stats memory block. tg3_get_stats64() is already taking

Re: [PATCH net-next] cxgb4: Add port description for new cards.

2017-01-06 Thread David Miller
From: Ganesh Goudar Date: Fri, 6 Jan 2017 16:52:10 +0530 > Add port description for 25G and 100G cards, and also > change few port descriptions in compliance with the new > naming convention. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] cxgb4/cxgb4vf: Display 25G and 100G link speed

2017-01-06 Thread David Miller
From: Ganesh Goudar Date: Fri, 6 Jan 2017 16:51:46 +0530 > Add support to report 25G and 100G links, which was missed > as part of commit "eb97ad99f9ed". > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH v2 00/12] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-06 Thread David Miller
From: Alexander Loktionov Date: Fri, 6 Jan 2017 00:06:01 -0800 > This series introduced the AQtion NIC driver for the aQuantia > AQC107/AQC108 network devices. > > v1: Initial version > v2: o Make necessary drivers/net/ethernet changes to integrate software >

Re: [PATCH] vti6: fix device register to report IFLA_INFO_KIND

2017-01-06 Thread David Miller
From: David Forster Date: Fri, 6 Jan 2017 10:27:59 + > vti6 interface is registered before the rtnl_link_ops block > is attached. As a result the resulting RTM_NEWLINK is missing > IFLA_INFO_KIND. Re-order attachment of rtnl_link_ops block to fix. > > Signed-off-by:

Re: [net-next 00/10][pull request] 1GbE Intel Wired LAN Driver Updates 2017-01-06

2017-01-06 Thread David Miller
From: Jeff Kirsher Date: Fri, 6 Jan 2017 02:48:42 -0800 > This series contains updates/fixes to igb and e1000e. Pulled, thanks Jeff.

[PATCH 1/2] sh_eth: get rid of 'sh_eth_cpu_data::shift_rd0'

2017-01-06 Thread Sergei Shtylyov
After checking all the available manuals, I have enough information to conclude that the 'shift_rd0' flag is only relevant for the Ether cores supporting so called "intelligent checksum" (and hence having CSMR) which is indicated by the 'hw_crc' flag. Since all the relevant SoCs now have

[PATCH 2/2] sh_eth: rename 'sh_eth_cpu_data::hw_crc'

2017-01-06 Thread Sergei Shtylyov
The 'struct sh_eth_cpu_data' field indicating the "intelligent checksum" support was misnamed 'hw_crc' -- rename it to 'hw_checksum'. Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 12 ++--

[PATCH 0/2] sh_eth: "intgelligent checksum" related cleanups

2017-01-06 Thread Sergei Shtylyov
Hello. Here's a set of 2 patches against DaveM's 'net.git' repo, as they are based on a couple patches merged there recently; however, the patches are destined for 'net-next.git' (once 'net.git' gets merged there next time). I'm cleaning up the "intelligent checksum" related code (however, the

[PATCH net] be2net: fix unicast list filling

2017-01-06 Thread Ivan Vecera
The adapter->pmac_id[0] item is used for primary MAC address but this is not true for adapter->uc_list[0] as is assumed in be_set_uc_list(). There are N UC addresses copied first from net_device to adapter->uc_list[1..N] and then N UC addresses from adapter->uc_list[0..N-1] are sent to HW. So the

Re: [PATCH 1/2] net: ipv4: Simplify rt_fill_info

2017-01-06 Thread David Miller
From: David Ahern Date: Thu, 5 Jan 2017 19:32:46 -0800 > rt_fill_info has only 1 caller and both of the last 2 args -- nowait > and flags -- are hardcoded to 0. Given that remove them as input arguments > and simplify rt_fill_info accordingly. > > Signed-off-by: David

Re: [PATCH net-next] net: ipv4: make fib_select_default static

2017-01-06 Thread David Miller
From: David Ahern Date: Thu, 5 Jan 2017 19:33:59 -0800 > fib_select_default has a single caller within the same file. > Make it static. > > Signed-off-by: David Ahern Also applied, thanks David.

[PATCH 2/2] ARM: dts: dra72-evm-revc: enable irqs for dp83867 eth phys

2017-01-06 Thread Grygorii Strashko
TI DRA72-EVM Rev C has two DP83867 ethernet phys which support IRQ generation in case of phy/link status changes. The INT/PWDN lines from both DP83867 phys are wired to DRA7 gpio6.16, so reflect the same in DT. Signed-off-by: Grygorii Strashko ---

Re: [PATCHv2 net-next] cxgb4: Synchronize access to mailbox

2017-01-06 Thread David Miller
From: Hariprasad Shenai Date: Fri, 6 Jan 2017 08:47:20 +0530 > The issue comes when there are multiple threads attempting to use > the mailbox facility at the same time. > When DCB operations and interface up/down is run in a loop for every > 0.1 sec, we observed mailbox

Re: [PATCH] net: phy: dp83867: fix irq generation

2017-01-06 Thread David Miller
From: Grygorii Strashko Date: Thu, 5 Jan 2017 14:48:07 -0600 > For proper IRQ generation by DP83867 phy the INT/PWDN pin has to be > programmed as an interrupt output instead of a Powerdown input in > Configuration Register 3 (CFG3), Address 0x001E, bit 7 INT_OE = 1.

Re: [PATCH net-next v2] net: dsa: b53: Utilize common helpers for u64/MAC

2017-01-06 Thread David Miller
From: Florian Fainelli Date: Thu, 5 Jan 2017 11:08:58 -0800 > Utilize the two functions recently introduced: u64_to_ether() and > ether_to_u64() instead of our own versions. > > Reviewed-by: Andrew Lunn > Signed-off-by: Florian Fainelli

Re: [PATCH v2 4/7] x86: put msr-index.h in uapi

2017-01-06 Thread Andy Shevchenko
On Fri, Jan 6, 2017 at 11:43 AM, Nicolas Dichtel wrote: > This header file is exported, thus move it to uapi. Just hint for the future: -M (move) -C (copy) -D (delete) [though this is NOT for applying] -- With Best Regards, Andy Shevchenko

Re: [PATCH net-next] net: dsa: remove version string

2017-01-06 Thread David Miller
From: Vivien Didelot Date: Thu, 5 Jan 2017 12:28:41 -0500 > The dsa_driver_version string is irrelevant and has not been bumped > since its introduction about 9 years ago. Kill it. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next] liquidio: fix wrong information about channels reported to ethtool

2017-01-06 Thread David Miller
From: Felix Manlunas Date: Wed, 4 Jan 2017 16:18:50 -0800 > From: Weilin Chang > > Information reported to ethtool about channels is sometimes wrong for PF, > and always wrong for VF. Fix them by getting the information from the > right

Re: [PATCH net-next 1/4] siphash: add cryptographically secure PRF

2017-01-06 Thread David Miller
Please do not quote an entire large patch, just to make a small comment or annotation. This makes it so that every reader of your posting has to scroll down a lot just to see a small amount of new content. Simply edit down the quoted material to the actually required context, and then add the

[net-next v1 6/8] net: netcp: ale: update to support unknown vlan controls for NU switch

2017-01-06 Thread Murali Karicheri
In NU Ethernet switch used on some of the Keystone SoCs, there is separate UNKNOWNVLAN register for membership, unreg mcast flood, reg mcast flood and force untag egress bits in ALE. So control for these fields require different address offset, shift and size of field. As this ALE has the same

[net-next v1 3/8] net: netcp: store network statistics in 64 bits

2017-01-06 Thread Murali Karicheri
From: Michael Scherban Previously the network statistics were stored in 32 bit variable which can cause some stats to roll over after several minutes of high traffic. This implements 64 bit storage so larger numbers can be stored. Signed-off-by: Michael Scherban

Re: [RFC PATCH next] ipv6: do not send RTM_DELADDR for tentative addresses

2017-01-06 Thread David Miller
From: Mahesh Bandewar Date: Wed, 4 Jan 2017 15:01:01 -0800 > From: Mahesh Bandewar > > RTM_NEWADDR notification is sent when IFA_F_TENTATIVE is cleared from > the address. So if the address is added and deleted before DAD probes > completes, the

[net-next v1 1/8] net: netcp: extract eflag from desc for rx_hook handling

2017-01-06 Thread Murali Karicheri
Extract the eflag bits from the received desc and pass it down the rx_hook chain to be available for netcp modules. Also the psdata and epib data has to be inspected by the netcp modules. So the desc can be freed only after returning from the rx_hook. So move knav_pool_desc_put() after the rx_hook

[net-next v1 5/8] net: netcp: use hw capability to remove FCS word from rx packets

2017-01-06 Thread Murali Karicheri
Some of the newer Ethernet switch hw (such as that on k2e/l/g) can strip the Etherenet FCS from packet at the port 0 egress of the switch. So use this capability instead of doing it in software. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori ---

[net-next v1 8/8] net: netcp: ale: add proper ale entry mask bits for netcp switch ALE

2017-01-06 Thread Murali Karicheri
For NetCP NU Switch ALE, some of the mask bits are different than defaults used in the driver. Add a new macro DEFINE_ALE_FIELD1 that use a configurable mask bits and use it in the driver. These bits are set to correct values by using the new variables added to cpsw_ale structure and re-used in

[net-next v1 7/8] net: netcp: ale: use ale_status to size the ale table

2017-01-06 Thread Murali Karicheri
ALE h/w on newer version of NetCP (K2E/L/G) does provide a ALE_STATUS register for the size of the ALE Table implemented in h/w. Currently for example we set ALE Table size to 1024 for NetCP ALE on K2E even though the ALE Status/Documentation shows it has 8192 entries. So take advantage of this

[net-next v1 2/8] net: netcp: remove the redundant memmov()

2017-01-06 Thread Murali Karicheri
The psdata is populated with command data by netcp modules to the tail of the buffer and set_words() copy the same to the front of the psdata. So remove the redundant memmov function call. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 6 +++---

[net-next v1 4/8] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY

2017-01-06 Thread Murali Karicheri
Currently to parse phy-handle, driver doesn't check if the interface is MAC to PHY. This patch add this check for all MAC to PHY interface types supported by the driver. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori ---

  1   2   3   >