Hi Andrew,
Thanks a lot for you comments.
On 06/02/2018 07:49 PM, Andrew Lunn wrote:
> Hi Grygorii
>
>> Don't know howto:
>> 1) add FDB entry with "blocked" flag - ALE can discard all packets with
>> SRC/DST
>> address = blocked MAC
>> 2) add multicast MAC address with Supervisory Packet flag s
On 06/02/2018 09:08 AM, Andrew Lunn wrote:
> On Fri, Jun 01, 2018 at 04:29:08PM -0500, Grygorii Strashko wrote:
>> Hi Ilias,
>
>
>> Second, Thanks a lot for your great work. I'm still testing it with different
>> use cases and trying to consolidate my re
On 06/02/2018 07:26 PM, Andrew Lunn wrote:
>> *After this patch set*: goal keep things working the same as max as
>> possible and get rid of TI custom tool.
>
> We are happy to keep things the same, if they fit with the switchdev
> model. Anything in your customer TI tool/model which does not f
instead?
We cannot use devm_platform_ioremap_resource() here, see
Commit 03f66f067560 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()")
Correct, could you add fixed tag as above commit actually introduced an issue:
devm_ioremap_resource() checks input parameters for null.
Rev
cover/1301048/
Grygorii Strashko (9):
net: ethernet: ti: ale: add cpsw_ale_get_num_entries api
net: ethernet: ti: ale: add static configuration
net: ethernet: ti: cpsw: use dev_id for ale configuration
net: netcp: ethss: use dev_id for ale configuration
net: ethernet: ti: am65-cpsw: use dev_i
-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 13 +
drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 +
drivers/net/ethernet/ti/cpsw_ale.c | 61 +---
drivers/net/ethernet/ti/cpsw_ale.h | 1 +
4 files changed, 70 insertions(+), 6
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI cpsw driver to use dev_id="cpsw" and
perform clean up by removing "ale_entries" configuration code.
Signed-off-by: Grygorii Strashko
---
drivers/net/etherne
Hi Jakub,
On 05/09/2020 03:10, Jakub Kicinski wrote:
On Sat, 5 Sep 2020 02:09:24 +0300 Grygorii Strashko wrote:
The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5
CPSW ALE, but has more extended functions and different ALE VLAN entry
format.
This patch adds support
Add cpsw_ale_get_num_entries() API to return number of ALE table entries
and update existing drivers to use it.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 10 ++
drivers/net/ethernet/ti/cpsw_ale.c | 5 +
drivers/net/ethernet/ti
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI Keystone 2 NETCP driver to use dev_id and
perform clean up by removing "ale_entries" configuration code.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/netcp_et
get/set access
functions. It also allows to detect incorrect access to not available ALL
entry fields.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_ale.c | 239 ++---
drivers/net/ethernet/ti/cpsw_ale.h | 3 +
2 files changed, 188 insertions(+), 54
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI TI AM65x/J721E CPSW NUSS driver to use
dev_id.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
ev_id identifier.
This feature is not enabled by default until existing CPSW drivers will be
modified by follow up patches.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_ale.c | 84 +-
drivers/net/ethernet/ti/cpsw_ale.h | 1 +
2 files changed, 83 inser
The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5
CPSW ALE, but has more extended functions and different ALE VLAN entry
format.
This patch adds support for for multi port TI J721E (CPSW9g) ALE variant.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti
Hence all existing driver updated to use ALE dev_id the usage of ale dev_id
can be made mandatory and cpsw_ale_create() can be updated to use
"features" property from ALE static configuration.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_
On 09/09/2020 05:28, David Miller wrote:
From: Grygorii Strashko
Date: Mon, 7 Sep 2020 17:31:36 +0300
+ ale_dev_id = cpsw_ale_match_id(cpsw_ale_id_match, params->dev_id);
+ if (ale_dev_id) {
+ params->ale_entries = ale_dev_id->tbl_entries;
+
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI cpsw driver to use dev_id="cpsw" and
perform clean up by removing "ale_entries" configuration code.
Signed-off-by: Grygorii Strashko
---
drivers/net/etherne
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI Keystone 2 NETCP driver to use dev_id and
perform clean up by removing "ale_entries" configuration code.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/netcp_et
Add cpsw_ale_get_num_entries() API to return number of ALE table entries
and update existing drivers to use it.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 10 ++
drivers/net/ethernet/ti/cpsw_ale.c | 5 +
drivers/net/ethernet/ti
The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5
CPSW ALE, but has more extended functions and different ALE VLAN entry
format.
This patch adds support for for multi port TI J721E (CPSW9g) ALE variant.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti
get/set access
functions. It also allows to detect incorrect access to not available ALL
entry fields.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_ale.c | 239 ++---
drivers/net/ethernet/ti/cpsw_ale.h | 3 +
2 files changed, 188 insertions(+), 54
-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 13 +
drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 +
drivers/net/ethernet/ti/cpsw_ale.c | 61 +---
drivers/net/ethernet/ti/cpsw_ale.h | 1 +
4 files changed, 70 insertions(+), 6
Hence all existing driver updated to use ALE dev_id the usage of ale dev_id
can be made mandatory and cpsw_ale_create() can be updated to use
"features" property from ALE static configuration.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_
ev_id identifier.
This feature is not enabled by default until existing CPSW drivers will be
modified by follow up patches.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_ale.c | 82 ++
drivers/net/ethernet/ti/cpsw_ale.h | 1 +
2 files changed, 83 inser
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI TI AM65x/J721E CPSW NUSS driver to use
dev_id.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
s
v2: https://lore.kernel.org/patchwork/cover/1301684/
v1: https://lore.kernel.org/patchwork/cover/1301048/
Grygorii Strashko (9):
net: ethernet: ti: ale: add cpsw_ale_get_num_entries api
net: ethernet: ti: ale: add static configuration
net: ethernet: ti: cpsw: use dev_id for ale configur
Add missed suspend/resume callbacks to properly restore networking after
suspend/resume cycle.
Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver
part 1 - dual-emac")
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_
In preparation of adding more multi-port K3 CPSW versions move ALE
selection in am65_cpsw_pdata, so it can be selected basing on DT
compatibility property.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +++-
drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 +
2
In preparation of adding more multi-port K3 CPSW versions move free
descriptor queue mode selection in am65_cpsw_pdata, so it can be selected
basing on DT compatibility property.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +++-
drivers/net/ethernet/ti/am65
Add/export cpsw_ale_vlan_del_modify() and use it in cpsw_switchdev instead
of generic cpsw_ale_del_vlan() to avoid mixing 8021Q and switchdev VLAN
offload. This is preparation patch equired by follow up changes.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_ale.c | 24
Use cppi5_desc_is_tdcm() helper for teardown indicator detection instead of
hard-coded value.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
b/drivers
v1: https://lore.kernel.org/patchwork/cover/1315766/
Grygorii Strashko (9):
net: ethernet: ti: am65-cpsw: move ale selection in pdata
net: ethernet: ti: am65-cpsw: move free desc queue mode selection in
pdata
net: ethernet: ti: am65-cpsw: use cppi5_desc_is_tdcm()
net: ethernet: ti: cps
_ale_del_vlan()
to preserve existing legacy CPSW drivers functionality.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 +---
drivers/net/ethernet/ti/cpsw_ale.c | 19 +++
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/driver
eep K3 CPSW active by forbidding PM runtime if CPTS is
enabled.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index f
No packet switching between
external ports happens.
- every port supports the same features as current AM65x CPSW on external
device.
Signed-off-by: Grygorii Strashko
---
changes in v2:
- fixed the case when Port 1 is disabled. The first *available* netdev is used
to assign RX/TX NAPI and DMA
and removing .ndo_set_features() callback implementation, which was used
only NETIF_F_HW_CSUM feature update purposes
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 30 +---
1 file changed, 1 insertion(+), 29 deletions(-)
diff --git a/drivers/net/eth
() as every completed TX skb can have
different ndev assigned (come from different netdevs).
To avoid performance issues for existing one-port CPSW2g devices the above
changes are done only for multi-port devices by splitting xmit path for
one-port and multi-port devices.
Signed-off-by: Grygorii
On 16/10/2020 02:19, Grygorii Strashko wrote:
Hi
This series adds multi-port support in mac-only mode (multi MAC mode) to TI
AM65x CPSW driver in preparation for enabling support for multi-port devices,
like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC.
The multi MAC mode is
On 29/07/2020 00:06, Petr Machata wrote:
Kurt Kanzenbach writes:
On Mon Jul 27 2020, Petr Machata wrote:
So this looks good, and works, but I'm wondering about one thing.
Thanks for testing.
Your code (and evidently most drivers as well) use a different check
than mlxsw, namely skb->
On 30/07/2020 11:00, Kurt Kanzenbach wrote:
In order to reduce code duplication between ptp drivers, generic helper
functions were introduced. Use them.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/ethernet/ti/am65-cpts.c | 37 +++--
1 file changed, 9 insertions(
On 31/07/2020 14:48, Kurt Kanzenbach wrote:
On Thu Jul 30 2020, Arnd Bergmann wrote:
On Thu, Jul 30, 2020 at 11:41 AM Kurt Kanzenbach wrote:
On Thu Jul 30 2020, Grygorii Strashko wrote:
On 30/07/2020 11:00, Kurt Kanzenbach wrote:
+msgtype = ptp_get_msgtype(hdr, ptp_class);
+seqid
On 31/07/2020 13:06, Kurt Kanzenbach wrote:
On Thu Jul 30 2020, Petr Machata wrote:
Kurt Kanzenbach writes:
@@ -107,6 +107,37 @@ unsigned int ptp_classify_raw(const struct sk_buff *skb)
}
EXPORT_SYMBOL_GPL(ptp_classify_raw);
+struct ptp_header *ptp_parse_header(struct sk_buff *skb,
On 05/08/2020 00:07, Russell King - ARM Linux admin wrote:
On Tue, Aug 04, 2020 at 11:56:12PM +0300, Grygorii Strashko wrote:
On 31/07/2020 13:06, Kurt Kanzenbach wrote:
On Thu Jul 30 2020, Petr Machata wrote:
Kurt Kanzenbach writes:
@@ -107,6 +107,37 @@ unsigned int ptp_classify_raw
On 05/08/2020 00:44, Russell King - ARM Linux admin wrote:
On Wed, Aug 05, 2020 at 12:34:47AM +0300, Grygorii Strashko wrote:
On 05/08/2020 00:07, Russell King - ARM Linux admin wrote:
On Tue, Aug 04, 2020 at 11:56:12PM +0300, Grygorii Strashko wrote:
On 31/07/2020 13:06, Kurt Kanzenbach
On 02/08/2020 23:22, Florian Fainelli wrote:
On 7/30/2020 1:00 AM, Kurt Kanzenbach wrote:
In order to reduce code duplication between ptp drivers, generic helper
functions were introduced. Use them.
Signed-off-by: Kurt Kanzenbach
---
[snip]
- if (unlikely(ptp_class & PTP_CLASS_V1)
On 05/08/2020 16:57, Kurt Kanzenbach wrote:
On Wed Aug 05 2020, Grygorii Strashko wrote:
I really do not want touch netcp, sry.
There are other internal code based on this even if there is only one hooks in
LKML now.
+ my comment above.
OK, I see. The use of lists makes more sense now
On 05/08/2020 12:29, Kurt Kanzenbach wrote:
On Wed Aug 05 2020, Russell King - ARM Linux admin wrote:
On Wed, Aug 05, 2020 at 01:04:31AM +0300, Grygorii Strashko wrote:
On 05/08/2020 00:44, Russell King - ARM Linux admin wrote:
On Wed, Aug 05, 2020 at 12:34:47AM +0300, Grygorii Strashko
hi David,
On 18/07/2020 04:47, David Miller wrote:
From: Grygorii Strashko
Date: Fri, 17 Jul 2020 15:19:32 +0300
From: Murali Karicheri
Currently drive supports taprio offload which is a tc feature offloaded
to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC
in the
avior.
Cc: Oleksij Rempel
Cc: Andrew Lunn
Cc: Philippe Schenker
Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031
PHY")
Signed-off-by: Grygorii Strashko
---
Fix for one more broken TI board with KSZ9031 PHY.
arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
1
avior.
Cc: Oleksij Rempel
Cc: Andrew Lunn
Cc: Philippe Schenker
Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031
PHY")
Signed-off-by: Grygorii Strashko
---
Fix for one more broken TI board with KSZ9031 PHY.
arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
1
APRIO offload support")
Signed-off-by: Murali Karicheri
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
b/drivers/net/ethernet/ti/am65-cpsw-nu
On 17/07/2020 17:55, Murali Karicheri wrote:
For small Ethernet frames with size less than minimum size 66 for HSR
vs 60 for regular Ethernet frames, hsr driver currently doesn't pad the
frame to make it minimum size. This results in incorrect LSDU size being
populated in the HSR tag for these
The new bit TX_GENF_CLR_EN has been added in AM65x SR2.0 to fix i2083
errata, which can be just set unconditionally for all SoCs.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpts.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net
In RMII link mode it's required to set bit 15 IFCTL_A in MAC_SL MAC_CONTROL
register to enable support for 100Mbit link speed.
Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth
subsystem driver")
Signed-off-by: Grygorii Strashko
---
drivers/net/ethern
Add cpsw_ale_get_num_entries() API to return number of ALE table entries
and update existing drivers to use it.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 10 ++
drivers/net/ethernet/ti/cpsw_ale.c | 5 +
drivers/net/ethernet/ti
ev_id identifier.
This feature is not enabled by default until existing CPSW drivers will be
modified by follow up patches.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_ale.c | 84 +-
drivers/net/ethernet/ti/cpsw_ale.h | 1 +
2 files change
tries
fields as the ALE VLAN entries are too much differ between different TI
CPSW ALE versions. So, handling them using flags, defines and get/set
functions are became over-complicated.
Patch 1 - is preparation patch
Grygorii Strashko (9):
net: ethernet: ti: ale: add cpsw_ale_get_num_entries api
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI Keystone 2 NETCP driver to use dev_id and
perform clean up by removing "ale_entries" configuration code.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/netcp_et
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI TI AM65x/J721E CPSW NUSS driver to use
dev_id.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
The previous patch has introduced possibility to select CPSW ALE by using
ALE dev_id identifier. Switch TI cpsw driver to use dev_id="cpsw" and
perform clean up by removing "ale_entries" configuration code.
Signed-off-by: Grygorii Strashko
---
drivers/net/etherne
-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 13 +
drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 +
drivers/net/ethernet/ti/cpsw_ale.c | 61 +---
drivers/net/ethernet/ti/cpsw_ale.h | 1 +
4 files changed, 70 insertions(+), 6
The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5
CPSW ALE, but has more extended functions and different ALE VLAN entry
format.
This patch adds support for for multi port TI J721E (CPSW9g) ALE variant.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti
get/set access
functions. It also allows to detect incorrect access to not available ALL
entry fields.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_ale.c | 239 ++---
drivers/net/ethernet/ti/cpsw_ale.h | 3 +
2 files changed, 188 insertions(+), 54
Hence all existing driver updated to use ALE dev_id the usage of ale dev_id
can be made mandatory and cpsw_ale_create() can be updated to use
"features" property from ALE static configuration.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_
ffload for multi MAC mode
Patch 6: Fixes CPTS context lose issue during PM runtime transition
Patches 7-8: add multi-port support to TI AM65x CPSW
Grygorii Strashko (8):
net: ethernet: ti: am65-cpsw: move ale selection in pdata
net: ethernet: ti: am65-cpsw: move free desc queue mode selection in p
In preparation of adding more multi-port K3 CPSW versions move free
descriptor queue mode selection in am65_cpsw_pdata, so it can be selected
basing on DT compatibility property.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +++-
drivers/net/ethernet/ti/am65
_ale_del_vlan()
to preserve existing legacy CPSW drivers functionality.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 +---
drivers/net/ethernet/ti/cpsw_ale.c | 19 +++
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/driver
In preparation of adding more multi-port K3 CPSW versions move ALE
selection in am65_cpsw_pdata, so it can be selected basing on DT
compatibility property.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +++-
drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 +
2
Use cppi5_desc_is_tdcm() helper for teardown indicator detection instead of
hard-coded value.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
b/drivers
completed TX skb can have
different ndev assigned (come from different netdevs).
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 41 +---
drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 +
2 files changed, 23 insertions(+), 19 deletions(-)
diff --git a
eep K3 CPSW active by forbidding PM runtime if CPTS is
enabled.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index f
ng between
external ports happens.
- every port supports the same features as current AM65x CPSW on external
device.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 111 ++-
1 file changed, 70 insertions(+), 41 deletions(-)
diff --git a/d
Add/export cpsw_ale_vlan_del_modify() and use it in cpsw_switchdev instead
of generic cpsw_ale_del_vlan() to avoid mixing 8021Q and switchdev VLAN
offload. This is preparation patch equired by follow up changes.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw_ale.c | 24
On 02/10/2020 02:08, Jakub Kicinski wrote:
On Thu, 1 Oct 2020 13:52:50 +0300 Grygorii Strashko wrote:
This series adds multi-port support in mac-only mode (multi MAC mode) to TI
AM65x CPSW driver in preparation for enabling support for multi-port devices,
like Main CPSW0 on K3 J721E SoC or
On 03/10/2020 02:07, Jakub Kicinski wrote:
On Fri, 2 Oct 2020 16:04:21 -0700 Jakub Kicinski wrote:
On Fri, 2 Oct 2020 12:56:43 +0300 Grygorii Strashko wrote:
On 02/10/2020 02:08, Jakub Kicinski wrote:
On Thu, 1 Oct 2020 13:52:50 +0300 Grygorii Strashko wrote:
This series adds multi-port
On 03/10/2020 05:09, David Miller wrote:
From: Grygorii Strashko
Date: Thu, 1 Oct 2020 13:52:57 +0300
This patch adds multi-port support to TI AM65x CPSW driver xmit/rx path in
preparation for adding support for multi-port devices, like Main CPSW0 on
K3 J721E SoC or future CPSW3g on K3
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel.
Cc: Kishon Vijay Abraham I
Cc: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
arch/arm/boot/dts/dra7-l4.dtsi | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch
The cpsw-phy-sel driver was replaced with new PHY driver phy-gmii-sel, so
deprecate cpsw-phy-sel bindings.
Cc: Kishon Vijay Abraham I
Cc: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
Documentation/devicetree/bindings/net/cpsw-phy-sel.txt | 2 +-
1 file changed, 1 insertion(+), 1
ren
Signed-off-by: Grygorii Strashko
---
drivers/phy/ti/Kconfig| 10 ++
drivers/phy/ti/Makefile | 1 +
drivers/phy/ti/phy-gmii-sel.c | 349 ++
3 files changed, 360 insertions(+)
create mode 100644 drivers/phy/ti/phy-gmii-sel.c
diff --git a
("net: ethernet: ti: cpsw: fix min eth packet size")
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index ceaec56..15d563c 100644
gged packets in
dual mac mode.
Hence, drop vid0 configuration in dual mac mode as it's not required for dual
mac mode functionality and, this way, make it possible to use priority
tagged packet in dual mac mode.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw.c | 7 ++
The cpsw-phy-sel driver was replaced with new PHY driver phy-gmii-sel, so
deprecate cpsw-phy-sel bindings and update CPSW binding to use phy-gmii-sel
PHY bindings.
Cc: Kishon Vijay Abraham I
Cc: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
Documentation/devicetree/bindings/net/cpsw.txt
Deprecate cpsw-phy-sel driver as it's been replaced with new
TI phy-gmii-sel PHY driver.
Cc: Kishon Vijay Abraham I
Cc: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/Kconfig | 6 +++---
drivers/net/ethernet/ti/cpsw.h | 6 ++
2 files changed, 9 inser
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/cpsw.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index e4aa030..ceaec56 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel.
Cc: Kishon Vijay Abraham I
Cc: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
arch/arm/boot/dts/am437x-l4.dtsi | 17 +
arch/arm/boot/dts/am43x-epos-evm.dts | 5 +
2 files changed, 10 insertions(+), 12
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel.
Cc: Kishon Vijay Abraham I
Cc: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
arch/arm/boot/dts/am335x-baltos-ir2110.dts| 4
arch/arm/boot/dts/am335x-baltos-ir3220.dts| 4
arch/arm/boot/dts/am335x-baltos
Add CPSW Port's Interface Mode Selection PHY (phy-gmii-sel) DT Bindings
Cc: Kishon Vijay Abraham I
Cc: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
.../devicetree/bindings/phy/ti-phy-gmii-sel.txt| 68 ++
1 file changed, 68 insertions(+)
create mode 1
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel.
Cc: Kishon Vijay Abraham I
Cc: Tony Lindgren
Signed-off-by: Grygorii Strashko
---
arch/arm/boot/dts/dm814x.dtsi | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/dm814x.dtsi b/arch/arm
t_mode_ext(slave->data->gmii_sel_phy, PHY_MODE_ETHERNET,
slave->data->phy_if);
Note. CPSW Port interface has to be reconfigured every time netdev is opened for
proper System Suspend support where CPSW can lose context.
[1] https://patchwork.kernel.org/cover/10689739/
Cc: Kishon
On 11/26/18 10:26 AM, Ivan Khoronzhuk wrote:
> On Sun, Nov 25, 2018 at 05:46:26PM -0600, Grygorii Strashko wrote:
>> In dual_mac mode CPSW driver uses vid1 and vid2 by default to implement
>> dual mac mode wich are used to configure pvids for each external ports.
>> But,
On 11/26/18 2:07 PM, Ivan Khoronzhuk wrote:
> On Mon, Nov 26, 2018 at 12:57:20PM -0600, Grygorii Strashko wrote:
>>
>>
>> On 11/26/18 10:26 AM, Ivan Khoronzhuk wrote:
>>> On Sun, Nov 25, 2018 at 05:46:26PM -0600, Grygorii Strashko wrote:
>>>> In dual_
On 11/26/18 1:58 PM, Rob Herring wrote:
> On Sun, Nov 25, 2018 at 06:15:30PM -0600, Grygorii Strashko wrote:
>> The cpsw-phy-sel driver was replaced with new PHY driver phy-gmii-sel, so
>> deprecate cpsw-phy-sel bindings.
>>
>> Cc: Kishon Vijay Abraham I
>> Cc
Hi Andrew,
On 11/25/18 8:27 PM, Andrew Lunn wrote:
> On Sun, Nov 25, 2018 at 05:43:15PM -0600, Grygorii Strashko wrote:
>> For proper VLAN packets forwarding CPSW driver uses min tx packet size of
>> 64bytes (VLAN_ETH_ZLEN, excluding ETH_FCS) which was corrected by
>> comm
On 11/27/18 10:49 PM, Andrew Lunn wrote:
>> [1] https://e2e.ti.com/support/arm/sitara_arm/f/791/t/701669
>
> Reading this, the interesting part is:
>
> My guess would be that the driver would have to track the
> configuration of the switch hardware to correctly pad the
> fram
On 11/26/18 2:07 PM, Ivan Khoronzhuk wrote:
> On Mon, Nov 26, 2018 at 12:57:20PM -0600, Grygorii Strashko wrote:
>>
>>
>> On 11/26/18 10:26 AM, Ivan Khoronzhuk wrote:
>>> On Sun, Nov 25, 2018 at 05:46:26PM -0600, Grygorii Strashko wrote:
>>>> In dual_
Hi Andrew,
On 11/28/18 4:02 PM, Andrew Lunn wrote:
>> This is dynamic configuration related to ALE VLAN entries and
>> I do not see the way to support its auto-detection with current driver,
>> unfortunately.
>
> I think you can subscribe to switchdev events which will tell you.
Thanks a lot for
On 11/29/18 9:26 AM, Ivan Khoronzhuk wrote:
> On Wed, Nov 28, 2018 at 03:15:46PM -0600, Grygorii Strashko wrote:
>>
>>
>> On 11/26/18 2:07 PM, Ivan Khoronzhuk wrote:
>>> On Mon, Nov 26, 2018 at 12:57:20PM -0600, Grygorii Strashko wrote:
>>>>
>>>
Hi All,
On 11/28/18 7:22 PM, David Miller wrote:
> From: Andrew Lunn
> Date: Thu, 29 Nov 2018 01:28:35 +0100
>
>> On Wed, Nov 28, 2018 at 04:43:40PM -0600, Grygorii Strashko wrote:
>>> Hi Andrew,
>>>
>>> On 11/28/18 4:02 PM, Andrew Lunn wrote:
>>
On 05/15/2018 04:59 PM, Florian Fainelli wrote:
A number of drivers have the following pattern:
if (np)
of_mdiobus_register()
else
mdiobus_register()
which the implementation of of_mdiobus_register() now takes care of.
Remove that pattern in drivers that strictly adhere to it.
bus.c:342: 'bus_find_device' explicitly returns a NULL value.
cpsw-phy-sel.c:181: 'dev' is dereferenced by passing argument 1 to function
'dev_get_drvdata'.
device.h:1024: 'dev' is passed to function 'dev_get_drvdata'.
device.h:1026: &#
101 - 200 of 605 matches
Mail list logo
