[PATCH 01/02] net: Export get_proc_net()

h one independently of the others. Signed-off-by: David Howells --- fs/proc/proc_net.c |3 ++- include/linux/proc_fs.h |2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c index 1763f370489d..23d56146e38f 100644 --- a/fs

[PATCH 02/02] afs: Implement namespacing

Implement namespacing within AFS, but don't yet let mounts occur outside the init namespace. An additional patch will be required propagate the network namespace across automounts. Signed-off-by: David Howells --- cell.c |4 +- internal.h | 39 +++--- m

Re: [PATCH net-next nfs 6/6] net: Convert rxrpc_net_ops

active yet as I'm trying to decide on how to deal with the DNS cache which also needs namespacing. > Signed-off-by: Kirill Tkhai DaveM: Can you take this into net-next and add: Acked-by: David Howells

[PATCH net 6/6] rxrpc: remove unused static variables

ned-off-by: Sebastian Andrzej Siewior Signed-off-by: David Howells --- net/rxrpc/security.c |3 --- 1 file changed, 3 deletions(-) diff --git a/net/rxrpc/security.c b/net/rxrpc/security.c index e9f428351293..c4479afe8ae7 100644 --- a/net/rxrpc/security.c +++ b/net/rxrpc/security.c @@ -

[PATCH net 5/6] rxrpc: Fix resend event time calculation

igned-off-by: Marc Dionne Signed-off-by: David Howells --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index 27f77b7d0ead..87ec697ca117 100644 --- a/net/rxrpc/call_event.c +++ b/net/rxrpc/call

[PATCH net 3/6] rxrpc: Fix Tx ring annotation after initial Tx failure

quot;rxrpc: Rewrite the data and ack handling code") Signed-off-by: David Howells --- net/rxrpc/sendmsg.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index 09f2a3e05221..7a94ce92ffdc 100644 --- a/net/rxrpc/sendmsg.c

[PATCH net 2/6] rxrpc: Fix a bit of time confusion

ctioning of the code. Fixes: a158bdd3247b ("rxrpc: Fix call timeouts") Signed-off-by: David Howells --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index ad2ab1103189..27f77b7d0e

[PATCH net 1/6] rxrpc: Fix firewall route keepalive

was transmitted to that peer. Also, just discard VERSION REPLY packets rather than replying to them. Signed-off-by: David Howells --- net/rxrpc/af_rxrpc.c|4 ++ net/rxrpc/ar-internal.h | 14 ++- net/rxrpc/conn_event.c |3 + net/rxrpc/input.c |2 + net/rxrpc/net_ns.c

[PATCH net 4/6] rxrpc: Don't treat call aborts as conn aborts

d with the new call automatically terminate the old call. Fixes: 18bfeba50dfd ("rxrpc: Perform terminal call ACK/ABORT retransmission from conn processor") Reported-by: Marc Dionne Signed-off-by: David Howells --- net/rxrpc/input.c | 15 +-- 1 file changed, 9 insert

[PATCH net-next 0/6] rxrpc: Fixes

/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes David --- David Howells (4): rxrpc: Fix firewall route keepalive rxrpc: Fix a bit of time confusion rxrpc: Fix Tx ring annotation after initial Tx failure rxrpc: Don't treat call aborts as conn aborts Marc Dion

Re: [PATCH net-next 0/6] rxrpc: Fixes

Sorry, that should be net, not net-next, in the subject line. David

[PATCH net-next 3/3] rxrpc: Trace call completion

Add a tracepoint to track rxrpc calls moving into the completed state and to log the completion type and the recorded error value and abort code. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 33 + net/rxrpc/ar-internal.h |1 + 2

[PATCH net-next 2/3] rxrpc, afs: Use debug_ids rather than pointers in traces

vices that use rxrpc, such as afs, to take numbers from the rxrpc counter, assign them to their own call struct and pass them in to rxrpc for both client and service calls so that the trace lines for each will have the same ID tag. Signed-off-by: David Howells --- fs/afs/internal.h|

[PATCH net-next 1/3] rxrpc: Trace resend

Add a tracepoint to trace packet resend events and to dump the Tx annotation buffer for added illumination. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 24 net/rxrpc/call_event.c |1 + 2 files changed, 25 insertions(+) diff --git a

[PATCH net-next 0/3] rxrpc: Tracing updates

://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (3): rxrpc: Trace resend rxrpc, afs: Use debug_ids rather than pointers in traces rxrpc: Trace call completion fs/afs/internal.h|1 fs/afs/rxrpc.c | 12

Re: [RFC iproute2 1/1] ip: netns: add mounted state file for each netns

Nicolas Dichtel wrote: > David Howells was working on a mount notification mechanism: > https://lwn.net/Articles/760714/ > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=notifications > > I don't know what is the status of this series. It&#x

[PATCH net] rxrpc: Fix oops when discarding a preallocated service call

Support network namespacing") Signed-off-by: David Howells cc: sta...@vger.kernel.org --- net/rxrpc/call_accept.c |1 + 1 file changed, 1 insertion(+) diff --git a/net/rxrpc/call_accept.c b/net/rxrpc/call_accept.c index dd30d74824b0..ec3383f97d4c 100644 --- a/net/rxrpc/call_accept.c +++ b/net

Does the kernel have a function to parse a text IPv6 address?

Does the kernel have a function to parse a text IPv6 address of the form "x:y:..::z" and put it into a struct sockaddr_in6? David

[PATCH net 2/2] rxrpc: Fix read-after-free in rxrpc_queue_local()

+78e71c5bab4f76a6a...@syzkaller.appspotmail.com Signed-off-by: David Howells --- include/trace/events/rxrpc.h |6 +++--- net/rxrpc/local_object.c | 19 ++- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/include/trace/events/rxrpc.h b/include/trace/ev

Re: [PATCH net 0/9] rxrpc: Fix use of skb_cow_data()

David Miller wrote: > Why don't you just do an skb_unshare() at the beginning when you know that > you'll need to do that? I was trying to defer any copying to process context rather than doing it in softirq context to spend less time in softirq context - plus that way I can use GFP_NOIO (kafs)

[PATCH net] rxrpc: Fix client call connect/disconnect race

;rxrpc: Improve management and caching of client connection objects") Signed-off-by: David Howells Reviewed-by: Marc Dionne --- include/trace/events/rxrpc.h |2 ++ net/rxrpc/conn_client.c | 20 +++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git

[PATCH net] rxrpc: Fix client call queueing, waiting for channel

nection objects") Signed-off-by: David Howells Reviewed-by: Marc Dionne --- net/rxrpc/conn_client.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c index 505690dbd0be..04e62afea063 100644 --- a/net/rxrpc/conn_clie

Re: [PATCH v3 net] rxrpc: fix race condition in rxrpc_input_packet()

itev fs/read_write.c:1107 [inline] > __x64_sys_writev+0x75/0xb0 fs/read_write.c:1107 > do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290 > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook") > Signed-off-by: Eric Dumazet > Reported-by: syzbot Acked-by: David Howells

[PATCH net] rxrpc: Fix net namespace cleanup

the 16k slab). Fix this by flipping the condition on the if-statement, putting the locked section inside the if-body and dropping the return from there. The function will then always go on to wait for the RCU cleanup on outstanding calls. Signed-off-by: David Howells --- ne

[RFC] Can I use MSG_WAITALL with sendmsg() for AF_RXRPC?

Can I MSG_WAITALL with sendmsg() when sending data through an AF_RXRPC socket to say: Ignore signals until all the given data is queued, provided that progress is reasonably made. where "progress" is defined as: Within a 2*RTT timeout since the last time we checked, at le

[PATCH net-next 2/3] rxrpc: Provide functions for allowing cleaner handling of signals

when partially complete on a CTRL+C, say, we have no idea of the state of the file after the abort. Signed-off-by: David Howells --- Documentation/networking/rxrpc.txt | 24 include/net/af_rxrpc.h |2 ++ net/rxrpc/af_rxrpc.c |

[PATCH net-next 1/3] rxrpc: Support service upgrade from a kernel service

d see what the service was upgraded to. Signed-off-by: David Howells --- Documentation/networking/rxrpc.txt | 17 +++-- fs/afs/internal.h |1 + fs/afs/rxrpc.c | 11 +++ include/net/af_rxrpc.h |5 +++-- net/

[PATCH net-next 3/3] rxrpc: Use MSG_WAITALL to tell sendmsg() to temporarily ignore signals

the period is exceeded with no progress, sendmsg() will return anyway, indicating how much data has been copied, if any. Once the supplied buffer is entirely decanted, the sendmsg() will return. Signed-off-by: David Howells --- Documentation/networking/rxrpc.txt | 12 fs/afs/rxrpc.c

[PATCH net-next 0/3] rxrpc: Add bits for kernel services

s.git rxrpc-next-20171018 David --- David Howells (3): rxrpc: Support service upgrade from a kernel service rxrpc: Provide functions for allowing cleaner handling of signals rxrpc: Use MSG_WAITALL to tell sendmsg() to temporarily ignore signals Documentation/networking/rxrpc.txt |

Re: [lkp-robot] [bisect done] ace45bec6d [ 52.056290] EIP: lock_release

kernel test robot wrote: > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > commit ace45bec6d77bc061c3c3d8ad99e298ea9800c2b > Author: David Howells > AuthorDate

Re: [PATCH 00/16] remove eight obsolete architectures

Do we have anything left that still implements NOMMU? David

Re: [PATCH net-next 0/6] rxrpc: Fixes

David Miller wrote: > David, this GIT URL has tons of unrelated changes. It seems to bring in > the parts of Linus's tree that haven't proagated to 'net' yet. Sorry about that, I rebased on the wrong branch by accident. I've got some more fixes. Should I just give the lot to you to pull into

[PATCH net-next 12/12] rxrpc: Fix leak of rxrpc_peer objects

) Signed-off-by: David Howells --- net/rxrpc/af_rxrpc.c|2 ++ net/rxrpc/ar-internal.h |1 + net/rxrpc/net_ns.c |1 + net/rxrpc/peer_object.c | 21 + net/rxrpc/sendmsg.c |1 + 5 files changed, 26 insertions(+) diff --git a/net/rxrpc/af_rxrp

[PATCH net-next 09/12] rxrpc: Add a tracepoint to track rxrpc_local refcounting

Add a tracepoint to track reference counting on the rxrpc_local struct. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 43 net/rxrpc/ar-internal.h | 27 +++-- net/rxrpc/call_accept.c |3 +- net/rxrpc/local_object.c

[PATCH net-next 10/12] rxrpc: Fix apparent leak of rxrpc_local objects

ject.c:439! Fix this by keeping a count of the live connections and waiting for it to go to zero at the end of rxrpc_destroy_all_connections(). Fixes: dee46364ce6f ("rxrpc: Add RCU destruction for connections and calls") Signed-off-by: David Howells --- net/rxrpc/ar-internal.h

[PATCH net-next 11/12] rxrpc: Add a tracepoint to track rxrpc_peer refcounting

Add a tracepoint to track reference counting on the rxrpc_peer struct. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 42 +++ net/rxrpc/ar-internal.h | 23 +++ net/rxrpc/peer_event.c |2 + net/rxrpc/peer_object.c

[PATCH net-next 08/12] rxrpc: Fix potential call vs socket/net destruction race

_object.c:634:57: warning: incorrect type in argument 1 (different address spaces) net/rxrpc/call_object.c:634:57:expected struct sock const *sk net/rxrpc/call_object.c:634:57:got struct sock [noderef] * Fixes: 2baec2c3f854 ("rxrpc: Support network namespacing") Signed-off-by

[PATCH net-next 05/12] rxrpc: Fix resend event time calculation

igned-off-by: Marc Dionne Signed-off-by: David Howells --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index 3dee89c7a06e..6e0d788b4dc4 100644 --- a/net/rxrpc/call_event.c +++ b/net/rxrpc/call

[PATCH net-next 06/12] rxrpc: remove unused static variables

ned-off-by: Sebastian Andrzej Siewior Signed-off-by: David Howells --- net/rxrpc/security.c |3 --- 1 file changed, 3 deletions(-) diff --git a/net/rxrpc/security.c b/net/rxrpc/security.c index e9f428351293..c4479afe8ae7 100644 --- a/net/rxrpc/security.c +++ b/net/rxrpc/security.c @@ -

[PATCH net-next 04/12] rxrpc: Don't treat call aborts as conn aborts

d with the new call automatically terminate the old call. Fixes: 18bfeba50dfd ("rxrpc: Perform terminal call ACK/ABORT retransmission from conn processor") Reported-by: Marc Dionne Signed-off-by: David Howells --- net/rxrpc/input.c | 15 +-- 1 file changed, 9 insert

[PATCH net-next 07/12] rxrpc: Fix checker warnings and errors

) Checker doesn't correctly handle of seq-retry lock context balance in rxrpc_find_service_conn_rcu(). (*) Checker thinks execution may proceed past the BUG() in rxrpc_publish_service_conn(). (*) Variable length array warnings from SKCIPHER_REQUEST_ON_STACK() in rxkad.c. Signed

[PATCH net-next 03/12] rxrpc: Fix Tx ring annotation after initial Tx failure

quot;rxrpc: Rewrite the data and ack handling code") Signed-off-by: David Howells --- net/rxrpc/sendmsg.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index 8503f279b467..783c777fc6e7 100644 --- a/net/rxrpc/sendmsg.c

[PATCH net-next 02/12] rxrpc: Fix a bit of time confusion

ctioning of the code. Fixes: a158bdd3247b ("rxrpc: Fix call timeouts") Signed-off-by: David Howells --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index 6a62e42e1d8d..3dee89c7a0

[PATCH net-next 01/12] rxrpc: Fix firewall route keepalive

was transmitted to that peer. Also, just discard VERSION REPLY packets rather than replying to them. Signed-off-by: David Howells --- net/rxrpc/af_rxrpc.c|4 ++ net/rxrpc/ar-internal.h | 14 ++- net/rxrpc/conn_event.c |3 + net/rxrpc/input.c |2 + net/rxrpc/net_ns.c

[PATCH net-next 00/12] rxrpc: Fixes and more traces

s are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-next-20180330 and can also be found on this branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (10): rxrpc

[PATCH net-next] rxrpc: Fix undefined packet handling

By analogy with other Rx implementations, RxRPC packet types 9, 10 and 11 should just be discarded rather than being aborted like other undefined packet types. Reported-by: Jeffrey Altman Signed-off-by: David Howells --- net/rxrpc/input.c|6 ++ net/rxrpc/protocol.h |6

Re: linux-next: build failure after merge of the tip tree

Peter Zijlstra wrote: > I figured that since there were only a handful of users it wasn't a > popular API, also David very much knew of those patches changing it so > could easily have pulled in the special tip/sched/wait branch :/ I'm not sure I could, since I have to base on net-next. I'm not

Re: linux-next: build failure after merge of the tip tree

Stephen Rothwell wrote: > + wait_var_event(&rxnet->nr_calls, !atomic_read(&rxnet->nr_calls)); I would prefer == 0 to ! as it's not really a true/false value. But apart from that, it's looks okay and you can add my Reviewed-by. David

[PATCH net] rxrpc: Fix send in rxrpc_send_data_packet()

rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs") Reported-by: Marc Dionne Signed-off-by: David Howells --- net/rxrpc/output.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c index 42410e910aff..cf73dc006c3b 1

Re: [PATCH v2] KEYS: DNS: limit the length of option strings

Eric Biggers wrote: > Fix it by limiting option strings (combined name + value) to a much more > reasonable 128 bytes. The exact limit is arbitrary, but currently the > only recognized option is formatted as "dnserror=%lu" which fits well > within this limit. There will be more options coming (

Is it possible to get Rx timestamps in skb->tstamp?

Hi, Is it possible to tell a UDP socket that you'd like it to put reception timestamps in skb->tstamp? For some reason, I seem to remember that the kernel used to put something in there - and AF_RXRPC makes use of it. David

Re: Is it possible to get Rx timestamps in skb->tstamp?

Toke Høiland-Jørgensen wrote: > > Is it possible to tell a UDP socket that you'd like it to put > > reception timestamps in skb->tstamp? > > I think you probably want SO_TIMESTAMP*? > > See > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/times

Re: [PATCH net] KEYS: DNS: fix parsing multiple options

0" x 1' | keyctl padd dns_resolver desc @s (Note this is preexisting and nothing to do with your patch). I'm not sure how best to handle this. Anyway, Dave, can you take Eric's patch into the net tree with: Acked-by: David Howells David

Re: [PATCH net] KEYS: DNS: fix parsing multiple options

Simon Horman wrote: > > - eq = memchr(opt, '=', opt_len) ?: end; > > + eq = memchr(opt, '=', opt_len) ?: next_opt; > > opt_nlen = eq - opt; > > eq++; > > It seems risky to advance eq++ in the case there the value is empt

[PATCH net 1/6] rxrpc: Fix call ref leak

h is pinned by the call). Fix this by releasing the call in the error path. Fixes: 37411cad633f ("rxrpc: Fix potential NULL-pointer exception") Reported-by: syzbot+d850c266e3df14da1...@syzkaller.appspotmail.com Signed-off-by: David Howells --- net/rxrpc/sendmsg.c |1 + 1 f

Re: [PATCH net] rxrpc: use rcu protection while reading sk->sk_user_data

Eric Dumazet wrote: > We need to extend the rcu_read_lock() section in rxrpc_error_report() > and use rcu_dereference_sk_user_data() instead of plain access > to sk->sk_user_data to make sure all rules are respected. Should I take it that the caller won't be guaranteed to be holding the RCU read

Re: [PATCH 5/9] rxrpc: Check address length before reading srx_service field

Tetsuo Handa wrote: > KMSAN will complain if valid address length passed to bind() is shorter > than sizeof(struct sockaddr_rxrpc) bytes. Do you want me to add this to my rxrpc-fixes branch? David

Re: [PATCH 5/9] rxrpc: Check address length before reading srx_service field

Tetsuo Handa wrote: > > Do you want me to add this to my rxrpc-fixes branch? > > > > Yes, please. Sorry, saw your reply right after posting my patches. Will forward yours on next. David

Re: [PATCH net] rxrpc: fix race condition in rxrpc_input_packet()

Eric Dumazet wrote: > @@ -1181,6 +1177,9 @@ int rxrpc_input_packet(struct sock *udp_sk, struct > sk_buff *skb) > > _enter("%p", udp_sk); > > + if (!local) > + return -ENOENT; > + > This looks wrong. Did you mean "return -AF_INET"? The comment in net/ipv6/udp.c says

Re: [PATCH v2 net] rxrpc: fix race condition in rxrpc_input_packet()

Eric Dumazet wrote: > @@ -1161,19 +1161,15 @@ int rxrpc_extract_header(struct rxrpc_skb_priv *sp, > struct sk_buff *skb) > * handle data received on the local endpoint > * - may be called in interrupt context > * > - * The socket is locked by the caller and this prevents the socket from be

[PATCH net-next 0/3] rxrpc: Allow more calls to same peer

is branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (3): rxrpc: Impose a maximum number of client calls rxrpc: Rewrite the client connection manager rxrpc: Allow multiple client connections to the same peer inc

[PATCH net-next 2/3] rxrpc: Rewrite the client connection manager

t could also be made such that new call allocations are forced to wait until the number of outstanding connections subsides. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 33 - net/rxrpc/ar-internal.h | 68 +-- net/rxrpc/conn_clien

[PATCH net-next 1/3] rxrpc: Impose a maximum number of client calls

affect the limits on service calls and connections. Signed-off-by: David Howells --- net/rxrpc/af_rxrpc.c|7 --- net/rxrpc/ar-internal.h |2 ++ net/rxrpc/call_object.c | 43 +++ 3 files changed, 49 insertions(+), 3 deletions(-) diff --git a

[PATCH net-next 3/3] rxrpc: Allow multiple client connections to the same peer

Allow the number of parallel connections to a machine to be expanded from a single connection to a maximum of four. This allows up to 16 calls to be in progress at the same time to any particular peer instead of 4. Signed-off-by: David Howells --- net/rxrpc/conn_client.c |6 ++ 1 file

[PATCH net-next 3/5] rxrpc: Fix rxrpc_bundle::alloc_error to be signed

; is unsigned Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager") Reported-by Dan Carpenter Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-intern

[PATCH net-next 5/5] rxrpc: Fix an overget of the conn bundle when setting up a client conn

the candidate conn to the bundle. Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager") Signed-off-by: David Howells --- net/rxrpc/conn_client.c |1 - 1 file changed, 1 deletion(-) diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c index 0e

[PATCH net-next 0/5] rxrpc: Fixes for the connection manager rewrite

/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (5): rxrpc: Fix an error goto in rxrpc_connect_call() rxrpc: Fix a missing NULL-pointer check in a trace rxrpc: Fix rxrpc_bundle::alloc_error to be signed rxrpc: Fix conn bundle leak in net-namespace

[PATCH net-next 4/5] rxrpc: Fix conn bundle leak in net-namespace exit

+0x1f/0x30 arch/x86/entry/entry_64.S:294 Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager") Reported-by: syzbot+52071f826a617b9c7...@syzkaller.appspotmail.com Signed-off-by: David Howells --- net/rxrpc/conn_client.c |1 + 1 file changed, 1 insertion(+) diff -

[PATCH net-next 2/5] rxrpc: Fix a missing NULL-pointer check in a trace

/0x650 [rxrpc] ? wake_up_q+0xa0/0xa0 ? rxrpc_kernel_begin_call+0x12a/0x1b0 [rxrpc] rxrpc_new_client_call+0x2a5/0x5e0 [rxrpc] Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager") Reported-by: Marc Dionne Signed-off-by: David Howells Tested-by: M

[PATCH net-next 1/5] rxrpc: Fix an error goto in rxrpc_connect_call()

Fix an error-handling goto in rxrpc_connect_call() whereby it will jump to free the bundle it failed to allocate. Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: David Howells ---

Re: [PATCH net 0/6] rxrpc: Miscellaneous fixes

David Miller wrote: > I think the ".txt" at the end of the branch name is a mistake. Sigh. That's the name of the file with the cover message in it (named for the tag). I need to adjust my script yet more to check not only that the tag name is in there, but that it also doesn't have any bits o

Re: [PATCH 1/5] rxrpc: use semicolons rather than commas to separate statements

Julia Lawall wrote: > - call->completion = compl, > + call->completion = compl; Looks good. Do you want me to pick up the patch or send it yourself? If the latter: Acked-by: David Howells

[PATCH net-next 0/2] rxrpc: Fixes

/dhowells/linux-fs.git rxrpc-next-20201015 David --- David Howells (2): rxrpc: Fix bundle counting for exclusive connections rxrpc: Fix loss of final ack on shutdown net/rxrpc/ar-internal.h | 1 + net/rxrpc/conn_client.c | 3 +++ net/rxrpc/conn_event.c | 6 +++--- 3 files

[PATCH net-next 2/2] rxrpc: Fix loss of final ack on shutdown

quot;rxrpc: Delay terminal ACK transmission on a client call") Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |1 + net/rxrpc/conn_client.c |3 +++ net/rxrpc/conn_event.c |6 +++--- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/ar-internal.h

[PATCH net-next 1/2] rxrpc: Fix bundle counting for exclusive connections

Signed-off-by: David Howells cc: Hillf Danton --- net/rxrpc/conn_client.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c index 78c845a4f1ad..5d9adfd4c84f 100644 --- a/net/rxrpc/conn_client.c +++ b/net/rxrpc/con

Re: WARNING: proc registration bug in afs_manage_cell

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git 7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8

gssapi, crypto and afs/rxrpc

Hi Herbert, Dave, Trond, I've written basic gssapi-derived security support for AF_RXRPC: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rxgk I've borrowed some bits from net/sunrpc/auth_gss/ but there's a lot in there that is quite specific to the su

[PATCH net] rxrpc: Fix race between recvmsg and sendmsg on immediate call failure

;) Reported-by: syzbot+b54969381df354936...@syzkaller.appspotmail.com Signed-off-by: David Howells Reviewed-by: Marc Dionne --- net/rxrpc/call_object.c | 27 +++ net/rxrpc/conn_object.c |8 +--- net/rxrpc/recvmsg.c |2 +- net/rxrpc/sendmsg.c |3 ++

How to make a change in both net and net-next

Hi Dave, In the fix I just posted, subject: [PATCH net] rxrpc: Fix race between recvmsg and sendmsg on immediate call failure there's a change I need to make as part of the patch: - spin_lock_bh(&conn->params.peer->lock); - hlist_del_rcu(&call

[PATCH net] rxrpc: Fix sendmsg() returning EPIPE due to recvmsg() returning ENODATA

by the networking core. Also change rxrpc_sendmsg() so that it doesn't fail with delayed receive errors (there's no way for it to report which call, if any, the error was caused by). Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kern

[PATCH net 1/7] rxrpc: Keep the ACK serial in a var in rxrpc_input_ack()

Keep the ACK serial number in a variable in rxrpc_input_ack() as it's used frequently. Signed-off-by: David Howells --- net/rxrpc/input.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c index 7675793

[PATCH net 6/7] afs: Don't use VL probe running state to make decisions outside probe code

e if the server is known to be responding and update these as and when we know what to change them to. Fixes: 3bf0fb6f33dd ("afs: Probe multiple fileservers simultaneously") Signed-off-by: David Howells --- fs/afs/internal.h |4 +++- fs/afs/proc.c |2 +- fs/afs/vl_

[PATCH net 7/7] afs: Fix error handling in VL server rotation

dling") Signed-off-by: David Howells --- fs/afs/vl_rotate.c |4 1 file changed, 4 insertions(+) diff --git a/fs/afs/vl_rotate.c b/fs/afs/vl_rotate.c index ab2beb4ba20e..c0458c903b31 100644 --- a/fs/afs/vl_rotate.c +++ b/fs/afs/vl_rotate.c @@ -263,10 +263,14 @@ bool afs_select_vlser

[PATCH net 5/7] afs: Expose information from afs_vlserver through /proc for debugging

Convert various bitfields in afs_vlserver::probe to a mask and then expose this and some other bits of information through /proc/net/afs//vlservers to make it easier to debug VL server communication issues. Signed-off-by: David Howells --- fs/afs/internal.h |9 + fs/afs/proc.c

[PATCH net 4/7] afs: Remove afs_vlserver->probe.have_result

Remove afs_vlserver->probe.have_result as it's neither read nor waited upon. Fixes: 3bf0fb6f33dd ("afs: Probe multiple fileservers simultaneously") Signed-off-by: David Howells --- fs/afs/internal.h |1 - fs/afs/vl_probe.c |5 + 2 files changed, 1 insertion(+), 5

[PATCH net 2/7] rxrpc: Fix loss of RTT samples due to interposed ACK

quot;) Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 27 +-- net/rxrpc/ar-internal.h | 13 +++-- net/rxrpc/call_object.c |1 net/rxrpc/input.c| 104 -- net/rxrpc/outpu

[PATCH net 3/7] rxrpc: Make rxrpc_kernel_get_srtt() indicate validity

Fix rxrpc_kernel_get_srtt() to indicate the validity of the returned smoothed RTT. If we haven't had any valid samples yet, the SRTT isn't useful. Fixes: c410bf01933e ("rxrpc: Fix the excessive initial retransmission timeout") Signed-off-by: David Howells --- fs/afs/fs_

[PATCH net 0/7] rxrpc, afs: Fix probing issues

o be found on the following branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes David --- David Howells (7): rxrpc: Keep the ACK serial in a var in rxrpc_input_ack() rxrpc: Fix loss of RTT samples due to interposed ACK r

[PATCH net] rxrpc: Fix memory leak in rxkad_verify_response()

From: Dinghao Liu Fix a memory leak in rxkad_verify_response() whereby the response buffer doesn't get freed if we fail to allocate a ticket buffer. Fixes: ef68622da9cc ("rxrpc: Handle temporary errors better in rxkad security") Signed-off-by: Dinghao Liu Signed-off-by

[PATCH net-next 00/23] rxrpc: Fixes and preparation for RxGK

tches are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-next-20201010 and can also be found on this branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (22):

[PATCH net-next 01/23] keys: Provide the original description to the key preparser

it's better to do that when the key is loaded rather than deep in trying to process a response packet. Signed-off-by: David Howells cc: Jarkko Sakkinen cc: keyri...@vger.kernel.org --- include/linux/key-type.h |1 + security/keys/key.c |2 ++ 2 files changed, 3 insertions(+)

[PATCH net-next 04/23] rxrpc: Downgrade the BUG() for unsupported token type in rxrpc_read()

ty index 5 keys (Kerberos 5)") Signed-off-by: David Howells --- net/rxrpc/key.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index 8f7d7a6187db..c668e4b7dbff 100644 --- a/net/rxrpc/key.c +++ b/net/rxrpc/key.c @@ -1107,7 +1107,8

[PATCH net-next 06/23] rxrpc: Fix loss of final ack on shutdown

quot;rxrpc: Delay terminal ACK transmission on a client call") Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |1 + net/rxrpc/conn_client.c |3 +++ net/rxrpc/conn_event.c |6 +++--- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/ar-internal.h

[PATCH net-next 05/23] rxrpc: Fix some missing _bh annotations on locking conn->state_lock

s should have separate call number spaces") Signed-off-by: David Howells --- net/rxrpc/conn_event.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/conn_event.c b/net/rxrpc/conn_event.c index 0628dad2bdea..bba5d7906df6 100644 --- a/net/rxrpc/conn_even

[PATCH net-next 07/23] rxrpc: Fix accept on a connection that need securing

et. Change the mode of operation for userspace rxrpc server sockets to work like this too. Although this is a UAPI change, server sockets aren't currently functional. Fixes: 248f219cb8bc ("rxrpc: Rewrite the data and ack handling code") Signed-off-by: David Howells --- include/u

[PATCH net-next 02/23] rxrpc: Fix bundle counting for exclusive connections

Signed-off-by: David Howells cc: Hillf Danton --- net/rxrpc/conn_client.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c index 78c845a4f1ad..5d9adfd4c84f 100644 --- a/net/rxrpc/conn_client.c +++ b/net/rxrpc/con

[PATCH net-next 03/23] rxrpc: Fix rxkad token xdr encoding

quot;) Signed-off-by: Marc Dionne Signed-off-by: David Howells --- net/rxrpc/key.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index 94c3df392651..8f7d7a6187db 100644 --- a/net/rxrpc/key.c +++ b/net/rxrpc/key.c @@ -1072,7 +1

[PATCH net-next 08/23] rxrpc: The server keyring isn't network-namespaced

quest_key mechanism") Signed-off-by: David Howells --- net/rxrpc/key.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index c668e4b7dbff..75e84ed4fa63 100644 --- a/net/rxrpc/key.c +++ b/net/rxrpc/key.c @@ -940,7 +940,7 @@ int rx

[PATCH net-next 10/23] rxrpc: Remove the rxk5 security class as it's now defunct

Remove the rxrpc rxk5 security class as it's now defunct and nothing uses it anymore. Signed-off-by: David Howells --- include/keys/rxrpc-type.h | 55 - net/rxrpc/key.c | 468 - 2 files changed, 523 deletions(-) diff --git a/in

[PATCH net-next 11/23] rxrpc: List the held token types in the key description in /proc/keys

When viewing an rxrpc-type key through /proc/keys, display a list of held token types. Signed-off-by: David Howells --- net/rxrpc/key.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index 75b500650257

<    1   2   3   4   5   6   7   8   9   10   >