Re: [PATCH 1/2] rxrpc: Trim line-terminal whitespace [ver #2]

Hi Dave, Can you please add these two patches to net-next? Thanks, David

Re: [PATCH 2/2] rxrpc: Limit the listening backlog

David Howells <dhowe...@redhat.com> wrote: > + else if (backlog > max) > + break; Oops. Please ignore this version of the patch - I forgot to commit a change to it before posting. David

[PATCH 2/2] rxrpc: Limit the listening backlog

ly. Note that the AFS filesystem opens one socket and keeps it open for extended periods, so would miss out on changes to max_backlog. (3) Having a separate setting for the AFS filesystem. Signed-off-by: David Howells <dhowe...@redhat.com> --- fs/afs/rxrpc.c

[PATCH 1/2] rxrpc: Trim line-terminal whitespace

Trim line-terminal whitespace in net/rxrpc/ Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-input.c |2 +- net/rxrpc/ar-local.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/ar-input.c b/net/rxrpc/ar-input.c index d7c2a0

Re: [PATCH 1/2] rxrpc: Trim line-terminal whitespace [ver #2]

David Miller wrote: > There is a clear, documented, way to do this properly with your > patches themselves. Put it in the Subject line: > > Subject: "[PATCH net-next 1/2] rxrpc: ..." Hmmm... so there is. I don't remember seeing the netdev-FAQ appear. I wonder how

[PATCH net-next] rxrpc: Limit the listening backlog

ly. Note that the AFS filesystem opens one socket and keeps it open for extended periods, so would miss out on changes to max_backlog. (3) Having a separate setting for the AFS filesystem. Signed-off-by: David Howells <dhowe...@redhat.com> --- fs/afs/rxrpc.c

[PATCH net-next] rxrpc: Trim line-terminal whitespace

Trim line-terminal whitespace in net/rxrpc/ Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-input.c |2 +- net/rxrpc/ar-local.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/ar-input.c b/net/rxrpc/ar-input.c index d7c2a0

Re: [PATCH] rxrpc: Simplify connect() implementation and simplify sendmsg() op

Can you take this into net/next please? Thanks, David

[PATCH] rxrpc: Simplify connect() implementation and simplify sendmsg() op

to a currently active call. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/linux/rxrpc.h | 18 ++-- net/rxrpc/af_rxrpc.c | 177 +++ net/rxrpc/ar-call.c | 158 +++--- net/rxrpc/ar-connec

[PATCH net-next 2/2] rxrpc: Update the comments in ar-internal.h to reflect renames

Update the section comments in ar-internal.h that indicate the locations of the referenced items to reflect the renames done to the .c files in net/rxrpc/. This also involves some rearrangement to reflect keep the sections in order of filename. Signed-off-by: David Howells <dhowe...@redhat.

[PATCH net-next 1/2] rxrpc: Rename files matching ar-*.c to git rid of the "ar-" prefix

o that in a separate patch to make it easier for git to follow the history across the rename. I may also want to rename ar-internal.h at some point - but that would mean updating all the #includes and I'd rather do that in a separate step. Signed-off-by: David Howells <dhowe...@redhat.com. -

[PATCH net-next 0/2] rxrpc: Rename rxrpc source files

rxrpc-rewrite-20160613 David --- David Howells (2): rxrpc: Rename files matching ar-*.c to git rid of the "ar-" prefix rxrpc: Update the comments in ar-internal.h to reflect renames net/rxrpc/Makefile| 34 ++- net/rxrpc/ar

[PATCH net-next 8/8] rxrpc: Rework local endpoint management

for destruction and may not have their usage count moved from 0. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c | 19 ++ net/rxrpc/ar-internal.h | 55 --- net/rxrpc/call_accept.c | 25 +-- net/rxrpc/conn_event.c | 15 -- net/rxrpc/input.c

[PATCH net-next 7/8] rxrpc: Separate local endpoint event handling out into its own file

Separate local endpoint event handling out into its own file preparatory to overhauling the object management aspect (which remains in the original file). Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |1 net/rxrpc/ar-internal.h |5 ++ net

[PATCH net-next 4/8] rxrpc: Don't assume anything about the address in an ICMP packet

Don't assume anything about the address in an ICMP packet in rxrpc_error_report() as the address may not be IPv4 in future, especially since we're just printing these details. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/peer_event.c |8 1 file chan

[PATCH net-next 1/8] rxrpc: Rework peer object handling to use hash table and RCU

path. Creating lookups are done under spinlock rather than mutex as they might be set up due to an external stimulus if the local endpoint is a server. Captured network error messages (ICMP) are handled with respect to this struct and MTU size and RTT are cached here. Signed-off-by: David Howells

[PATCH net-next 3/8] rxrpc: Break MTU determination from ICMP into its own function

Break MTU determination from ICMP out into its own function to reduce the complexity of the error report handler. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/peer_event.c | 93 1 file changed, 54 insertions(+), 39 del

[PATCH net-next 2/8] rxrpc: Rename rxrpc_UDP_error_report() to rxrpc_error_report()

Rename rxrpc_UDP_error_report() to rxrpc_error_report() as it might get called for something other than UDP. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-internal.h |4 ++-- net/rxrpc/local_object.c |2 +- net/rxrpc/peer_event.c |2 +- 3 files chan

[PATCH net-next 5/8] rxrpc: Do a little bit of tidying in the ICMP processing

Do a little bit of tidying in the ICMP processing code. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/peer_event.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/rxrpc/peer_event.c b/net/rxrpc/peer_event.c index 6ba798d6659e..31c440

[PATCH net-next 6/8] rxrpc: Use the peer record to distribute network errors

level. (2) To also abort connection-level communications (such as CHALLENGE packets) where indicted by an error - but that requires some revamping of the connection event handling first. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-internal.h

[PATCH net-next 0/8] rxrpc: Rework endpoint record handling

--- David Howells (8): rxrpc: Rework peer object handling to use hash table and RCU rxrpc: Rename rxrpc_UDP_error_report() to rxrpc_error_report() rxrpc: Break MTU determination from ICMP into its own function rxrpc: Don't assume anything about the address in an ICMP packet

Re: [PATCH] rxrpc: fix uninitialized variable use

Arnd Bergmann wrote: > Hashing the peer key was introduced for AF_INET, but gcc > warns about the rxrpc_peer_hash_key function returning uninitialized > data for any other value of srx->transport.family: > > net/rxrpc/peer_object.c: In function 'rxrpc_peer_hash_key': >

Re: [patch net-next] rxrpc: checking for IS_ERR() instead of NULL

Dan Carpenter wrote: > rxrpc_lookup_peer_rcu() returns NULL on error, it never returns error > pointers. > > Fixes: be6e6707f6ee ('rxrpc: Rework peer object handling to use hash table > and RCU') > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH] rxrpc: fix uninitialized variable use

Arnd Bergmann wrote: > > I'm actually more tempted to put a BUG() in there because if any new family > > support (say AF_INET6) is added, I want to make sure I catch all the places. > > Makes sense. Do you want to do the patch yourself, or should I send > a new one doing that? >

[PATCH net-next 13/14] rxrpc: Kill the client connection bundle concept

removal of the rxrpc_transport struct. Bundling can be reintroduced later if necessary. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c | 11 - net/rxrpc/ar-internal.h | 54 ++--- net/rxrpc/call_object.c | 124 ++- net/rxrpc/conn_object.c

[PATCH net-next 01/14] rxrpc: checking for IS_ERR() instead of NULL

d RCU') Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c|4 ++-- net/rxrpc/call_accept.c |2 +- net/rxrpc/input.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/

[PATCH net-next 00/14] rxrpc: Get rid of conn bundle and transport structs

e use Dan Carpenter (1): rxrpc: checking for IS_ERR() instead of NULL David Howells (12): rxrpc: Use structs to hold connection params and protocol info rxrpc: Replace conn->trans->{local,peer} with conn->params.{local,peer} rxrpc: Fix exclusive connection handling

[PATCH net-next 14/14] rxrpc: Kill off the rxrpc_transport struct

of the rxrpc_transport struct and discarded the connection bundling code. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |1 net/rxrpc/af_rxrpc.c| 46 net/rxrpc/ar-internal.h | 59 ++ net/rxrpc/call_accept.c | 11 -- net

Re: [PATCH net-next 00/14] rxrpc: Get rid of conn bundle and transport structs

Ignore this version please. Fengguang's magic box of tricks spotted a bug in it. David

[PATCH net-next 12/14] rxrpc: Provide more refcount helper functions

Provide refcount helper functions for connections so that the code doesn't touch local or connection usage counts directly. Also make it such that local and peer put functions can take a NULL pointer. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c

[PATCH net-next 11/14] rxrpc: Make rxrpc_send_packet() take a connection not a transport

Make rxrpc_send_packet() take a connection not a transport as part of the phasing out of the rxrpc_transport struct. Whilst we're at it, rename the function to rxrpc_send_data_packet() to differentiate it from the other packet sending functions. Signed-off-by: David Howells <dhowe...@redhat.

[PATCH net-next 04/14] rxrpc: Replace conn->trans->{local, peer} with conn->params.{local, peer}

Replace accesses of conn->trans->{local,peer} with conn->params.{local,peer} thus making it easier for a future commit to remove the rxrpc_transport struct. This also reduces the number of memory accesses involved. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxr

[PATCH net-next 02/14] rxrpc: fix uninitialized variable use

use hash table and RCU") Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/peer_object.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/net/rxrpc/peer_object.c b/net/rxrpc/peer_object.c index faf222c21698..6baa

[PATCH net-next 05/14] rxrpc: Fix exclusive connection handling

ill exists and, if set, will override any lack of RXRPC_EXCLUSIVE_CALL being specified so that programs using the setsockopt() will appear to work the same. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/linux/rxrpc.h |3 + net/rxrpc/af_rxrpc.c|7 --- net/rxrpc/ar-i

[PATCH net-next 03/14] rxrpc: Use structs to hold connection params and protocol info

, including the duplicate local pointer. Whilst we're at it rename "proto" to "family" when referring to a protocol family. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c| 55 ++--- net/rxrpc/ar-internal.h | 61 +++

[PATCH net-next 08/14] rxrpc: Use IDR to allocate client conn IDs on a machine-wide basis

so that we can take a BH lock to prevent a locking issue against in-BH lookup of client connections. This will go away later when RCU is used for server connections also. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |1 net/rxrpc/af_rxrpc.c|2

[PATCH net-next 07/14] rxrpc: rxrpc_connection_lock shouldn't be a BH lock, but conn_lock is

rxrpc_connection_lock shouldn't be accessed as a BH-excluding lock. It's only accessed in a few places and none of those are in BH-context. rxrpc_transport::conn_lock, however, *is* a BH-excluding lock and should be accessed so consistently. Signed-off-by: David Howells <dhowe...@redhat.

[PATCH net-next 10/14] rxrpc: Calls displayed in /proc may in future lack a connection

o be shown - something required for AuriStor server compatibility. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/proc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/net/rxrpc/proc.c b/net/rxrpc/proc.c index 9863270691d7..500cdcdc843c

[PATCH net-next 06/14] rxrpc: Pass sk_buff * rather than rxrpc_host_header * to functions

Pass a pointer to struct sk_buff rather than struct rxrpc_host_header to functions so that they can in the future get at transport protocol parameters rather than just RxRPC parameters. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-internal.h |6 +++--- net

[PATCH net-next 09/14] rxrpc: Validate the net address given to rxrpc_kernel_begin_call()

Validate the net address given to rxrpc_kernel_begin_call() before using it. Whilst this should be mostly unnecessary for in-kernel users, it does clear the tail of the address struct in case we want to hash or compare the whole thing. Signed-off-by: David Howells <dhowe...@redhat.com> ---

[PATCH net-next 00/14] rxrpc: Get rid of conn bundle and transport structs [ver #2]

e use Dan Carpenter (1): rxrpc: checking for IS_ERR() instead of NULL David Howells (12): rxrpc: Use structs to hold connection params and protocol info rxrpc: Replace conn->trans->{local,peer} with conn->params.{local,peer} rxrpc: Fix exclusive connection handling

[PATCH net-next 12/14] rxrpc: Provide more refcount helper functions [ver #2]

Provide refcount helper functions for connections so that the code doesn't touch local or connection usage counts directly. Also make it such that local and peer put functions can take a NULL pointer. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c

Re: [PATCH net-next 00/14] rxrpc: Get rid of conn bundle and transport structs [ver #2]

David Howells <dhowe...@redhat.com> wrote: > The patches can be found here also: > > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowe

[PATCH net-next 14/14] rxrpc: Kill off the rxrpc_transport struct [ver #2]

of the rxrpc_transport struct and discarded the connection bundling code. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |1 - net/rxrpc/af_rxrpc.c| 46 +--- net/rxrpc/ar-internal.h | 57 ++ net

[PATCH net-next 01/14] rxrpc: checking for IS_ERR() instead of NULL [ver #2]

d RCU') Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c|4 ++-- net/rxrpc/call_accept.c |2 +- net/rxrpc/input.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/

[PATCH net-next 10/14] rxrpc: Calls displayed in /proc may in future lack a connection [ver #2]

o be shown - something required for AuriStor server compatibility. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/proc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/net/rxrpc/proc.c b/net/rxrpc/proc.c index 9863270691d7..500cdcdc843c

[PATCH net-next 05/14] rxrpc: Fix exclusive connection handling [ver #2]

ill exists and, if set, will override any lack of RXRPC_EXCLUSIVE_CALL being specified so that programs using the setsockopt() will appear to work the same. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/linux/rxrpc.h |3 + net/rxrpc/af_rxrpc.c|7 --- net/rxrpc/ar-i

[PATCH net-next 09/14] rxrpc: Validate the net address given to rxrpc_kernel_begin_call() [ver #2]

Validate the net address given to rxrpc_kernel_begin_call() before using it. Whilst this should be mostly unnecessary for in-kernel users, it does clear the tail of the address struct in case we want to hash or compare the whole thing. Signed-off-by: David Howells <dhowe...@redhat.com> ---

[PATCH net-next 07/14] rxrpc: rxrpc_connection_lock shouldn't be a BH lock, but conn_lock is [ver #2]

rxrpc_connection_lock shouldn't be accessed as a BH-excluding lock. It's only accessed in a few places and none of those are in BH-context. rxrpc_transport::conn_lock, however, *is* a BH-excluding lock and should be accessed so consistently. Signed-off-by: David Howells <dhowe...@redhat.

[PATCH net-next 06/14] rxrpc: Pass sk_buff * rather than rxrpc_host_header * to functions [ver #2]

Pass a pointer to struct sk_buff rather than struct rxrpc_host_header to functions so that they can in the future get at transport protocol parameters rather than just RxRPC parameters. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-internal.h |6 +++--- net

[PATCH net-next 11/14] rxrpc: Make rxrpc_send_packet() take a connection not a transport [ver #2]

Make rxrpc_send_packet() take a connection not a transport as part of the phasing out of the rxrpc_transport struct. Whilst we're at it, rename the function to rxrpc_send_data_packet() to differentiate it from the other packet sending functions. Signed-off-by: David Howells <dhowe...@redhat.

[PATCH net-next 02/14] rxrpc: fix uninitialized variable use [ver #2]

use hash table and RCU") Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/peer_object.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/net/rxrpc/peer_object.c b/net/rxrpc/peer_object.c index faf222c21698..6baa

[PATCH net-next 08/14] rxrpc: Use IDR to allocate client conn IDs on a machine-wide basis [ver #2]

so that we can take a BH lock to prevent a locking issue against in-BH lookup of client connections. This will go away later when RCU is used for server connections also. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |1 net/rxrpc/af_rxrpc.c|2

[PATCH net-next 04/14] rxrpc: Replace conn->trans->{local, peer} with conn->params.{local, peer} [ver #2]

Replace accesses of conn->trans->{local,peer} with conn->params.{local,peer} thus making it easier for a future commit to remove the rxrpc_transport struct. This also reduces the number of memory accesses involved. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxr

[PATCH net-next 03/14] rxrpc: Use structs to hold connection params and protocol info [ver #2]

, including the duplicate local pointer. Whilst we're at it rename "proto" to "family" when referring to a protocol family. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c| 55 ++--- net/rxrpc/ar-internal.h | 61 +++

[PATCH net-next 13/14] rxrpc: Kill the client connection bundle concept [ver #2]

removal of the rxrpc_transport struct. Bundling can be reintroduced later if necessary. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c | 11 - net/rxrpc/ar-internal.h | 57 ++--- net/rxrpc/call_object.c | 124 +- net/rxrpc/conn_client.c

Pushing AF_RXRPC rewrite patches to net/next

Hi Dave, I've split 23 patches out of my AF_RXRPC rewrite so far. If you look here: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-experimental the penultimate patch is the remnant rewrite, the 23 patches below that are ones I've split out of it. Are

[PATCH] rxrpc: Replace all unsigned with unsigned int

Replace all "unsigned" types with "unsigned int" types. Reported-by: David Miller <da...@davemloft.net> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c |2 +- net/rxrpc/ar-ack.c| 12 ++-- net/rxrpc/ar-call.c

Re: [PATCH] rxrpc: Replace all unsigned with unsigned int

David Howells <dhowe...@redhat.com> wrote: > Replace all "unsigned" types with "unsigned int" types. > > Reported-by: David Miller <da...@davemloft.net> > Signed-off-by: David Howells <dhowe...@redhat.com> This is aimed at net-next. David

[PATCH 1/9] afs: Wait for outstanding async calls before closing rxrpc socket

[kafs] ... Call Trace: [] afs_exit+0x1f/0x57 [kafs] [] SyS_delete_module+0xec/0x17d [] entry_SYSCALL_64_fastpath+0x12/0x6b Signed-off-by: David Howells <dhowe...@redhat.com> --- fs/afs/rxrpc.c | 16 +--- 1 file changed, 13 insertions

[PATCH 4/9] rxrpc: Static arrays of strings should be const char *const[]

Static arrays of strings should be const char *const[]. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/rxrpc/packet.h |2 -- net/rxrpc/ar-internal.h |2 +- net/rxrpc/misc.c|2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/include

[PATCH 5/9] rxrpc: Differentiate local and remote abort codes in structs

will need to be to indicate to userspace the difference between aborts via a control message. Signed-off-by: David Howells <dhowe...@redhat.com> --- fs/afs/rxrpc.c | 14 +++--- include/net/af_rxrpc.h |3 ++- net/rxrpc/ar-ack.c |4 ++-- net/rxrpc/ar-

[PATCH 8/9] rxrpc: Absorb the rxkad security module

can just be unloaded, despite having cached connections. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Kconfig |2 - net/rxrpc/Makefile |3 - net/rxrpc/af_rxrpc.c|9 +++ net/rxrpc/ar-internal.h | 21 ++-- net/rxrpc/ar-security.c

[PATCH 6/9] rxrpc: Don't pass gfp around in incoming call handling functions

Don't pass gfp around in incoming call handling functions, but rather hard code it at the points where we actually need it since the value comes from within the rxrpc driver and is always the same. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-accept.c |4 ++-

[PATCH 7/9] rxrpc: Don't assume transport address family and size when using it

IPv6 support is introduced. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-ack.c |4 ++-- net/rxrpc/ar-connevent.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c index d0eb98e1391c..3cd926

[PATCH 9/9] rxrpc: Create a null security type and get rid of conditional calls

Create a null security type for security index 0 and get rid of all conditional calls to the security operations. We expect normally to be using security, so this should be of little negative impact. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile|1

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Joe Perches wrote: > It might be better to remove kenter and _enter > altogether and use function tracing instead. Possibly - but not at this time. Besides, isn't the function tracing log lost if the machine crashes? David

[PATCH 3/9] rxrpc: Move some miscellaneous bits out into their own file

Move some miscellaneous bits out into their own file to make it easier to split the call handling. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/net/af_rxrpc.h |1 + net/rxrpc/Makefile |3 +- net/rxrpc/ar-ack.c | 68 ---

[PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Disable a debugging statement that has been left enabled Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-ack.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c index 16d967075eaf..01a017a05f14 100644 ---

[PATCH 0/9] RxRPC: 2nd rewrite part 1

-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160407 This is based on net-next/master David --- David Howells (9): afs: Wait for outstanding async calls before closing rxrpc socket rxrpc: Disable a debugging

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Joe Perches wrote: > > Joe Perches wrote: > > > It might be better to remove kenter and _enter > > > altogether and use function tracing instead. > > Possibly - but not at this time. > > Swell. I didn't say I wouldn't do it - it's just that I'm trying to

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

David Miller wrote: > Yeah this custom stuff is really inappropriate given the excellent > infrastructure we have these days... Excellent only if I can get at it to find out why the something went wrong. If it's lost because the machine panics, then it is worthless. David

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Joe Perches wrote: > > Let's see...  If the machine panics whilst I'm developing stuff (quite > > likely if something goes wrong in BH context), how do I get at the > > function tracing log to find out why it panicked if the log is then > > lost?  With the serial console, at

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

David Miller wrote: > > Excellent only if I can get at it to find out why the something went wrong. > > If it's lost because the machine panics, then it is worthless. > > If you're ok with these kenter things spewing into the logs with the > current facility, you can run

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

David Miller wrote: > As you can with the function tracer and tracepoints. I've had experience with tracepoints before (i2c and smbus). It wasn't particularly fun. There's got to be some easier way to write them. Hmmm... Of the _enter() and _leave() macros in my tree at

[PATCH 0/3] RxRPC: 2nd rewrite part 2

/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160412 This is based on net-next/master David --- David Howells (3): rxrpc: Don't permit use of connect() op and simplify

[PATCH 1/3] rxrpc: Don't permit use of connect() op and simplify sendmsg() op

be an error. It also isn't required to provide sendmsg() with an address - provided the control message data holds a user ID that maps to a currently active call. Signed-off-by: David Howells <dhowe...@redhat.com> --- Documentation/networking/rxrpc.txt |8 -- include/linux/r

[PATCH 2/3] rxrpc: The RXRPC_ACCEPT control message should not have an address

When sendmsg() is called with the RXRPC_ACCEPT control message, sendmsg() shouldn't also be given an address in msg_name. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-output.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/ar-outp

[PATCH 3/3] rxrpc: Use the listen() system call to move to listening state

Use the listen() system call to move to listening state and to set the socket backlog queue size. A limit is placed on the maximum queue size by way of: /proc/sys/net/rxrpc/max_backlog Signed-off-by: David Howells <dhowe...@redhat.com> --- fs/afs/rxrpc.c

Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1

David Miller wrote: > Series applied, but I had to fix up some trailing whitespace (reported by > GIT) by hand. Okay, thanks. David

Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1

David Howells <dhowe...@redhat.com> wrote: > > Series applied, but I had to fix up some trailing whitespace (reported by > > GIT) by hand. > > Do you perchance have a git hook script for checking for trailing whitespace? No matter - there's already such a script install

Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1

David Miller wrote: > Series applied, but I had to fix up some trailing whitespace (reported by > GIT) by hand. Do you perchance have a git hook script for checking for trailing whitespace? David

Getting at the UDP headers from ->data_ready()

Hi Willem, With regards to: commit 4d0fc73ebe94ac984a187f21fbf4f3a1ac846f5a Author: Willem de Bruijn Date: Thu Apr 7 11:44:59 2016 -0400 rxrpc: do not pull udp headers on receive Commit e6afc8ace6dd modified the udp receive path by pulling the udp

Re: Getting at the UDP headers from ->data_ready()

Willem de Bruijn wrote: > The network and transport header pointers are still valid. Commit e6afc8ace6dd > only changes where skb->data points to. It does not discard the data between > skb->head and skb->data. This rxrpc follow-up patch fixes some offset >

Re: linux-next: manual merge of the crypto tree with the net-next tree

Stephen Rothwell wrote: > Today's linux-next merge of the crypto tree got a conflict in: > > net/rxrpc/rxkad.c > > between commit: > > 0d12f8a4027d ("rxrpc: Keep the skb private record of the Rx header in host > byte order") > > from the net-next tree and commit:

Re: [PATCH 01/11] rxrpc: Add a common object cache

David Miller wrote: > >> I know you put a lot of time and effort into this, but I want to strongly > >> recommend against a garbage collected hash table for anything whatsoever. > >> > >> Especially if the given objects are in some way created/destroyed/etc. by > >>

Re: [PATCH 01/11] rxrpc: Add a common object cache

David Howells <dhowe...@redhat.com> wrote: > Does it make sense to maintain a FIFO list of connections (though this would > mean potentially taking a spinlock every time I get a packet)? It occurs to me that only inactive connections would need to be on an LRU list. Any connection

Re: linux-next: manual merge of the crypto tree with the net-next tree

Stephen Rothwell wrote: > > What's the best way to deal with this? Should I take Herbert's > > > > [PATCH 18/26] rxrpc: Use skcipher > > > > patch into my rxrpc tree also and pass it on to Dave? > > Linus can deal with it when he merges the latter of the crypto or

[PATCH 01/11] rxrpc: Add a common object cache

-count-1 objects to the current time, removing any that have expired. This is kicked by a single timer for the whole cache rather than having a timer per object. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |3 net/rxrpc/ar-internal.h | 39 net

[PATCH 00/11] RxRPC: Rewrite part 2

http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160307 This is based on net-next/master David --- David Howells (11): rxrpc: Add a

[PATCH 04/11] rxrpc: Implement local endpoint cache

until rxrpc_data_ready() returns - so we don't need to lock the local endpoint struct there. The other places we've taken the lock where we read the usage count and then increment it if not zero can be replaced by atomic_inc_not_zero() (hidden inside rxrpc_get_local_maybe()). Signed-off-by: David

[PATCH 03/11] rxrpc: Separate local endpoint object handling out into its own file

Separate local endpoint object handling out into its own file preparatory to overhauling it to use the new object cache. The original file is then be used exclusively for the local endpoint packet and event handling. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Ma

[PATCH 11/11] rxrpc: Rename rxrpc_UDP_error_report() to rxrpc_error_report()

Rename rxrpc_UDP_error_report() to rxrpc_error_report() as it might get called for something other than UDP. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-internal.h |2 +- net/rxrpc/local-object.c |2 +- net/rxrpc/peer-event.c |2 +- 3 files chan

[PATCH 05/11] rxrpc: procfs file to list local endpoints

Add a proc file to list local rxrpc endpoints using the object cache facility to do much of the work. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c |3 +++ net/rxrpc/local-object.c | 29 + 2 files changed, 32 inse

[PATCH 07/11] rxrpc: Rename ar-peer.c to peer-object.c

Rename ar-peer.c to peer-object.c for consistency (to be) with the other new object cache management files. It will be modified in a later commit. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |4 - net/rxrpc/ar-internal.h | 16 +- net/rxrpc/ar-

[PATCH 08/11] rxrpc: Implement peer endpoint cache

with respect to this struct and MTU size and RTT are cached here. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |3 net/rxrpc/af_rxrpc.c |6 + net/rxrpc/ar-accept.c|2 net/rxrpc/ar-error.c | 57 net/rxrpc/ar-i

[PATCH 06/11] rxrpc: Rename ar-local.c to local-event.c

Rename ar-local.c to local-event.c. What's left in the file is the local endpoint event/packet handling code after the object management has been separated out. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |2 - net/rxrpc/ar-internal.h | 10 ++-

[PATCH 09/11] rxrpc: Add /proc/net/rxrpc_peers to display the known remote endpoints

Add /proc/net/rxrpc_peers to display the remote endpoint records that are resident in the peer cache. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c|3 +++ net/rxrpc/peer-object.c | 32 2 files changed, 35 inse

[PATCH 10/11] rxrpc: Rename ar-error.c to peer-event.c

Rename ar-error.c to peer-event.c. This will form the core of the peer event handling code. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/Makefile |2 net/rxrpc/ar-error.c| 281 --- net/rxrpc/ar-internal.h

[PATCH 02/11] rxrpc: Do procfs lists through objcache

Use the object cache primary hash to provide lists of RxRPC objects through /proc/net/ for all caches where desired. Each user of the cache just needs to provide a show function in its objcache struct and register the proc file with objcache_seq_fops as its file operations. Signed-off-by: David

<    1   2   3   4   5   6   7   8   9   >