[net-next 3/6] net: ethernet: ti: am65-cpsw-nuss: Use DMA device for DMA API

2021-01-15 Thread Grygorii Strashko
adding AM64x CPSW3g support where DMA coherency supported per DMA channel. Signed-off-by: Peter Ujfalusi Co-developed-by: Vignesh Raghavendra Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 79 drivers

[net-next 6/6] net: ethernet: ti: am65-cpsw: add support for am64x cpsw3g

2021-01-15 Thread Grygorii Strashko
CPSW3g version. Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index d060744dd0b2

[net-next 4/6] net: ethernet: ti: am65-cpsw-nuss: Support for transparent ASEL handling

2021-01-15 Thread Grygorii Strashko
CP port) or non coherent individually by configuring the ASEL to appropriate value. [1] https://lore.kernel.org/patchwork/cover/1350756/ Signed-off-by: Peter Ujfalusi Co-developed-by: Vignesh Raghavendra Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- drivers/net/ethern

[net-next 0/6] net: ethernet: ti: am65-cpsw-nuss: introduce support for am64x cpsw3g

2021-01-15 Thread Grygorii Strashko
/spruim2 [2] https://patchwork.ozlabs.org/project/netdev/cover/20201130082046.16292-1-vigne...@ti.com/ Grygorii Strashko (2): dt-binding: ti: am65x-cpts: add assigned-clock and power-domains props dt-binding: net: ti: k3-am654-cpsw-nuss: update bindings for am64x cpsw3g Peter Ujfalusi (2): net

[net-next 1/6] dt-binding: ti: am65x-cpts: add assigned-clock and power-domains props

2021-01-15 Thread Grygorii Strashko
s', 'assigned-clocks' and 'power-domains' properties to the CPTS DT bindings to avoid dtbs_check warnings: cpts@310d: 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' cpts@310d: 'power-d

[net-next 2/6] dt-binding: net: ti: k3-am654-cpsw-nuss: update bindings for am64x cpsw3g

2021-01-15 Thread Grygorii Strashko
binding changes are minimal: - reword description - add new compatible 'ti,am642-cpsw-nuss' - allow 2 external ports child nodes - add missed 'assigned-clock' props [1] https://www.ti.com/lit/pdf/spruim2 Signed-off-by: Grygorii Strashko --- .../bindings/net/ti,k3-am654-c

[net-next 5/6] net: ti: cpsw_ale: add driver data for AM64 CPSW3g

2021-01-15 Thread Grygorii Strashko
From: Vignesh Raghavendra The AM642x CPSW3g is similar to j721e-cpswxg except its ALE table size is 512 entries. Add entry for the same. Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 7 +++ 1 file changed, 7 insertions

Re: [PATCH v4 net-next 01/11] net: switchdev: remove vid_begin -> vid_end range from VLAN objects

2021-01-15 Thread Grygorii Strashko
t from the switchdev API. But since the switchdev support for ranges has already been de facto deleted by a Mellanox employee and nobody noticed for 4 years, I'm going to assume it's not a biggie. Signed-off-by: Vladimir Oltean Reviewed-by: Ido Schimmel # switchdev and mlxsw Reviewed-by: Grygorii Strashko # cpsw_switchdev -- Best regards, grygorii

Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support

2020-12-03 Thread Grygorii Strashko
On 03/12/2020 16:18, Andrew Lunn wrote: We don't want to enable HW based switch support unless explicitly asked by user. This is the key point. Why? Does individual ports when passed through the switch not work properly? Does it add extra latency/jitter? When switch mode is enabled the for

[PATCH] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-18 Thread Grygorii Strashko
.mdio couldn't get reset GPIO" Hence, suppress error message when devm_gpiod_get_optional() returning -EPROBE_DEFER case. Signed-off-by: Grygorii Strashko --- drivers/net/phy/mdio_bus.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/mdio_bus.c b/

Re: [PATCH] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
On 19/11/2020 14:30, Heiner Kallweit wrote: Am 18.11.2020 um 15:24 schrieb Grygorii Strashko: The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned from: __mdiobus_register

[PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
.mdio couldn't get reset GPIO" Hence, suppress error message for devm_gpiod_get_optional() returning -EPROBE_DEFER case by using dev_err_probe(). Signed-off-by: Grygorii Strashko --- drivers/net/phy/mdio_bus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
On 19/11/2020 23:11, Heiner Kallweit wrote: Am 19.11.2020 um 21:34 schrieb Grygorii Strashko: The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which from: __mdiobus_register

Re: [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-11 Thread Grygorii Strashko
ments: Reviewed-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpts.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c index 75056c1..b77ff61 --- a/drivers/net/ethernet/ti/am65-cpts.c +++ b/dr

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Grygorii Strashko
hi Jakub, On 11/11/2020 14:32, Richard Cochran wrote: On Wed, Nov 11, 2020 at 05:24:41PM +0800, Wang Qing wrote: We always have to update the value of ret, otherwise the error value may be the previous one. And ptp_clock_register() never return NULL when PTP_1588_CLOCK enable. NAK. Your

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-12 Thread Grygorii Strashko
On 12/11/2020 10:25, Arnd Bergmann wrote: On Thu, Nov 12, 2020 at 2:48 AM 王擎 wrote: On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: I don't think v1 builds cleanly folks (not 100% sure, cpts is not compiled on x86): ret = cpts->ptp_cloc

[PATCH] net: ethernet: ti: cpsw: fix cpts irq after suspend

2020-11-12 Thread Grygorii Strashko
. Fixes: 84ea9c0a95d7 ("net: ethernet: ti: cpsw: enable cpts irq") Reported-by: Tony Lindgren Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 10 ++ drivers/net/ethernet/ti/cpsw_new.c | 9 ++--- 2 files changed, 12 insertions(+), 7 deletions(-) di

[PATCH v5] net: ethernet: ti: am65-cpts: update ret when ptp_clock is ERROR

2020-11-12 Thread Grygorii Strashko
fixes tag] Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- Hi I've update patch as requested and added Acked-by from Richard from v1. v4: https://lore.kernel.org/patchwork/patch/1336771/ v3: https://lore.kernel.org/patchwork/patch/1334871/ v2: https://lore.kernel.org/patchwor

[PATCH net-next 0/3] net: ethernet: ti: cpsw: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
eth0/statistics/rx_packets - server route add -host 239.255.1.3 eth0 iperf -c 239.255.1.3 -u -f m -i 5 -t 30 -l1472 -b12176 -t1 //~1pps [1] https://lore.kernel.org/patchwork/patch/1217254/ Grygorii Strashko (3): drivers: net: cpsw: ale: add broadcast/multicast rate limit support

[PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
2pps: tc qdisc add dev eth0 clsact tc filter add dev eth0 ingress flower skip_sw dst_mac 01:00:00:00:00:00 \ action police rate 9600kbit burst 64k rate 9600kbit - 2pps * 60 bytes * 8, burst - not used. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-qos.c | 148

[PATCH net-next 1/3] drivers: net: cpsw: ale: add broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
port.BCASTMCAST/_LIMIT values. This patch implements above logic in ALE and adds new ALE APIs cpsw_ale_rx_ratelimit_bc(); cpsw_ale_rx_ratelimit_mc(); Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 66 ++ drivers/net/ethernet/ti/cpsw_ale.h

[PATCH net-next 2/3] net: ethernet: ti: cpsw_new: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
2pps: tc qdisc add dev eth0 clsact tc filter add dev eth0 ingress flower skip_sw dst_mac 01:00:00:00:00:00 \ action police rate 9600kbit burst 64k rate 9600kbit - 2pps * 60 bytes * 8, burst - not used. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_new.c | 4

Re: [PATCH net-next 2/3] net: ethernet: ti: cpsw_new: enable broadcast/multicast rate limit support

2020-11-16 Thread Grygorii Strashko
On 14/11/2020 21:09, Vladimir Oltean wrote: On Sat, Nov 14, 2020 at 05:56:53AM +0200, Grygorii Strashko wrote: This patch enables support for ingress broadcast(BC)/multicast(MC) rate limiting in TI CPSW switchdev driver (the corresponding ALE support was added in previous patch) by

Re: [PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: enable broadcast/multicast rate limit support

2020-11-16 Thread Grygorii Strashko
On 14/11/2020 21:17, Vladimir Oltean wrote: On Sat, Nov 14, 2020 at 05:56:54AM +0200, Grygorii Strashko wrote: This patch enables support for ingress broadcast(BC)/multicast(MC) rate limiting in TI AM65x CPSW driver (the corresponding ALE support was added in previous patch) by implementing

[PATCH net] net: ethernet: ti: cpts: fix ethtool output when no ptp_clock registered

2020-12-24 Thread Grygorii Strashko
netifs are down. This patch ensures that -1 is returned by ethtool when PTP PHC clock is not registered any more. Fixes: 8a2c9a5ab4b9 ("net: ethernet: ti: cpts: rework initialization/deinitialization") Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpts.c | 2 ++ 1 file

[PATCH] RFC: net: phy: of phys probe/reset issue

2020-10-23 Thread Grygorii Strashko
out of reset and not allow to reset it again (more like gpio-hog) I'd be appreciated for any comments to help resolve it. May be there is better way to handle this? Cc: Florian Fainelli Signed-off-by: Grygorii Strashko --- drivers/net/phy/phy_device.c | 152 +

Re: Remove __napi_schedule_irqoff?

2020-10-23 Thread Grygorii Strashko
On 18/10/2020 11:20, Heiner Kallweit wrote: On 18.10.2020 10:02, Eric Dumazet wrote: On Sun, Oct 18, 2020 at 1:29 AM Jakub Kicinski wrote: On Sat, 17 Oct 2020 15:45:57 +0200 Heiner Kallweit wrote: When __napi_schedule_irqoff was added with bc9ad166e38a ("net: introduce napi_schedule_irqof

Re: [PATCH] RFC: net: phy: of phys probe/reset issue

2020-10-28 Thread Grygorii Strashko
hi Andrew, On 23/10/2020 23:10, Andrew Lunn wrote: Yes there is: have your Ethernet PHY compatible string be of the form "ethernet." and then there is no need for such hacking. of_get_phy_id() will parse that compatible and that will trigger of_mdiobus_register_phy() to take the phy_devi

[PATCH] net: ethernet: ti: cpsw: disable PTPv1 hw timestamping advertisement

2020-10-29 Thread Grygorii Strashko
k to SW timestamping. Fixes: e9523a5a32a1 ("net: ethernet: ti: cpsw: enable HWTSTAMP_FILTER_PTP_V1_L4_EVENT filter") Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ethtool.c | 1 - drivers/net/ethernet/ti/cpsw_priv.c| 5 + 2 files changed, 1 insertion(+), 5 dele

[PATCH net-next] selftests/net: timestamping: add ptp v2 support

2020-10-29 Thread Grygorii Strashko
nding support which can be enabled by using new parameter "PTPV2". Signed-off-by: Grygorii Strashko --- tools/testing/selftests/net/timestamping.c | 47 -- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/net/timestamping.c

[PATCH net-next v3 00/10] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode

2020-10-30 Thread Grygorii Strashko
it for one-port and multi-port devices to avoid performance losses - patch 9: fixed the case when Port 1 is disabled - Patch 7: added fix for TX csum offload v2: https://lore.kernel.org/patchwork/cover/1321608/ v1: https://lore.kernel.org/patchwork/cover/1315766/ Grygorii Strashko (10): net: et

[PATCH net-next v3 03/10] net: ethernet: ti: am65-cpsw: use cppi5_desc_is_tdcm()

2020-10-30 Thread Grygorii Strashko
Use cppi5_desc_is_tdcm() helper for teardown indicator detection instead of hard-coded value. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next v3 04/10] net: ethernet: ti: cpsw_ale: add cpsw_ale_vlan_del_modify()

2020-10-30 Thread Grygorii Strashko
Add/export cpsw_ale_vlan_del_modify() and use it in cpsw_switchdev instead of generic cpsw_ale_del_vlan() to avoid mixing 8021Q and switchdev VLAN offload. This is preparation patch equired by follow up changes. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net

[PATCH net-next v3 01/10] net: ethernet: ti: am65-cpsw: move ale selection in pdata

2020-10-30 Thread Grygorii Strashko
In preparation of adding more multi-port K3 CPSW versions move ALE selection in am65_cpsw_pdata, so it can be selected basing on DT compatibility property. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 +++- drivers/net/ethernet

[PATCH net-next v3 02/10] net: ethernet: ti: am65-cpsw: move free desc queue mode selection in pdata

2020-10-30 Thread Grygorii Strashko
In preparation of adding more multi-port K3 CPSW versions move free descriptor queue mode selection in am65_cpsw_pdata, so it can be selected basing on DT compatibility property. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4

[PATCH net-next v3 09/10] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode

2020-10-30 Thread Grygorii Strashko
No packet switching between external ports happens. - every port supports the same features as current AM65x CPSW on external device. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 129 ++- drivers/net/ethernet/ti

[PATCH net-next v3 10/10] net: ethernet: ti: am65-cpsw: handle deferred probe with dev_err_probe()

2020-10-30 Thread Grygorii Strashko
Use new dev_err_probe() API to handle deferred probe properly and simplify the code. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 28 +--- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw

[PATCH net-next v3 08/10] net: ethernet: ti: am65-cpsw: prepare xmit/rx path for multi-port devices in mac-only mode

2020-10-30 Thread Grygorii Strashko
() as every completed TX skb can have different ndev assigned (come from different netdevs). To avoid performance issues for existing one-port CPSW2g devices the above changes are done only for multi-port devices by splitting xmit path for one-port and multi-port devices. Signed-off-by: Grygorii

[PATCH net-next v3 05/10] net: ethernet: ti: am65-cpsw: fix vlan offload for multi mac mode

2020-10-30 Thread Grygorii Strashko
_ale_del_vlan() to preserve existing legacy CPSW drivers functionality. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 +--- drivers/net/ethernet/ti/cpsw_ale.c | 19 +++ 2 files changed, 20 insertions(+), 7

[PATCH net-next v3 07/10] net: ethernet: ti: am65-cpsw: fix tx csum offload for multi mac mode

2020-10-30 Thread Grygorii Strashko
and removing .ndo_set_features() callback implementation, which was used only NETIF_F_HW_CSUM feature update purposes Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 30 +--- 1 file changed, 1 insertion(+), 29 deletions(-)

[PATCH net-next v3 06/10] net: ethernet: ti: am65-cpsw: keep active if cpts enabled

2020-10-30 Thread Grygorii Strashko
eep K3 CPSW active by forbidding PM runtime if CPTS is enabled. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/t

Re: [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter

2020-11-04 Thread Grygorii Strashko
s function parameter 'skb' description in 'am65_cpts_rx_enable' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Grygorii Strashko Cc: Kurt Kanzenbach Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ti/am65-cpts.c | 2 +- 1 file ch

Re: [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-06 Thread Grygorii Strashko
On 06/11/2020 09:56, Wang Qing wrote: We always have to update the value of ret, otherwise the error value may be the previous one. Signed-off-by: Wang Qing --- drivers/net/ethernet/ti/am65-cpts.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-06 Thread Grygorii Strashko
On 06/11/2020 14:58, Kurt Kanzenbach wrote: On Fri Nov 06 2020, Arnd Bergmann wrote: On Fri, Nov 6, 2020 at 12:35 PM Grygorii Strashko wrote: On 06/11/2020 09:56, Wang Qing wrote: +++ b/drivers/net/ethernet/ti/am65-cpts.c @@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct

Re: [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA

2021-02-12 Thread Grygorii Strashko
On 12/02/2021 03:05, Vladimir Oltean wrote: From: Vladimir Oltean The initial goal of this series was to have better support for standalone ports mode on the DSA drivers like ocelot/felix and sja1105. This turned out to require some API adjustments in both directions: to the information pres

Re: [PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes

2021-02-12 Thread Grygorii Strashko
++- net/switchdev/switchdev.c | 11 --- 8 files changed, 24 insertions(+), 11 deletions(-) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes

2021-02-12 Thread Grygorii Strashko
--- 10 files changed, 129 insertions(+), 89 deletions(-) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: linux-next: manual merge of the devicetree tree with the net-next tree

2021-02-22 Thread Grygorii Strashko
On 22/02/2021 10:23, Stephen Rothwell wrote: Hi all, On Mon, 15 Feb 2021 07:53:21 +1100 Stephen Rothwell wrote: On Thu, 21 Jan 2021 13:26:45 +1100 Stephen Rothwell wrote: Today's linux-next merge of the devicetree tree got a conflict in: Documentation/devicetree/bindings/net/ti,k3

Re: Bogus struct page layout on 32-bit

2021-04-16 Thread Grygorii Strashko
Hi Ilias, All, On 10/04/2021 11:52, Ilias Apalodimas wrote: +CC Grygorii for the cpsw part as Ivan's email is not valid anymore Thanks for catching this. Interesting indeed... On Sat, 10 Apr 2021 at 09:22, Jesper Dangaard Brouer wrote: On Sat, 10 Apr 2021 03:43:13 +0100 Matthew Wilcox wrot

Re: [PATCH resend net-next 2/2] net: bridge: switchdev: include local flag in FDB notifications

2021-04-16 Thread Grygorii Strashko
| 4 ++-- include/net/switchdev.h| 1 + net/bridge/br_switchdev.c | 3 +-- net/dsa/slave.c| 2 +- 9 files changed, 15 insertions(+), 14 deletions(-) For cpsw: Reviewed-by: Gryg

[RFC PATCH v4 net-next 04/11] net: ethernet: ti: cpsw: move set of common functions in cpsw_priv

2019-06-21 Thread Grygorii Strashko
As a preparatory patch to add support for a switchdev based cpsw driver, move common functions to cpsw-priv.c so that they can be used across both drivers. Signed-off-by: Ilias Apalodimas Signed-off-by: Murali Karicheri Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c

[RFC PATCH v4 net-next 09/11] Documentation: networking: add cpsw switchdev based driver documentation

2019-06-21 Thread Grygorii Strashko
From: Ilias Apalodimas A new cpsw dirver based on switchdev was added. Add documentation about basic configuration and future features Signed-off-by: Ilias Apalodimas Signed-off-by: Grygorii Strashko --- .../device_drivers/ti/cpsw_switchdev.txt | 207 ++ 1 file changed

[PATCH] net: ethernet: ti: cpsw: fix packet leaking in dual_mac mode

2018-05-01 Thread Grygorii Strashko
need to be enabled for each external CPSW port (ALE_PORTCTLn.VID_INGRESS_CHECK) so ALE will drop ingress packets if Rx port is not VLAN member. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ti/cpsw.c

Re: [PATCH v3 next-next] drivers: net: davinci_mdio: prevent spurious timeout

2018-05-09 Thread Grygorii Strashko
Nori --- v3: simplify return path based on comment from Andrew The issue has not been personally observed by me, but has been reported by users. Sending for next-next given the non-critical nature. There is seems to be no easy way to reproduce this. Reviewed-by: Grygorii Strashko -- regards

Re: [PATCH 35/61] net: ethernet: ti: simplify getting .drvdata

2018-04-19 Thread Grygorii Strashko
On 04/19/2018 09:06 AM, Wolfram Sang wrote: We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. Please apply individually. Reviewed-by: Grygorii Strashko

Re: [net-next,v2,01/10] soc: ti: K2G: enhancement to support QMSS in NSS

2018-03-28 Thread Grygorii Strashko
Hi Murali, On 03/27/2018 11:31 AM, Murali Karicheri wrote: > Navigator Subsystem (NSS) available on K2G SoC has a cut down > version of QMSS with less number of queues, internal linking ram > with lesser number of buffers etc. It doesn't have status and > explicit push register space as in QMSS a

Re: Fwd: DA850-evm MAC Address is random

2017-08-28 Thread Grygorii Strashko
Cc: Sekhar On 08/28/2017 10:32 AM, Adam Ford wrote: The davinvi_emac MAC address seems to attempt a call to ti_cm_get_macid in cpsw-common.c but it returns the message 'davinci_emac davinci_emac.1: incompatible machine/device type for reading mac address ' and then generates a random MAC address

[PATCH 4/6] ARM: dts: am335x: switch to use phy-gmii-sel

2019-02-20 Thread Grygorii Strashko
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel. Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/am335x-baltos-ir2110.dts| 4 arch/arm/boot/dts/am335x-baltos-ir3220.dts| 4 arch/arm/boot/dts/am335x-baltos-ir5221.dts| 4 arch/arm/boot/dts

[PATCH 5/6] dt-bindings: net: ti: deprecate cpsw-phy-sel bindings

2019-02-20 Thread Grygorii Strashko
The cpsw-phy-sel driver was replaced with new PHY driver phy-gmii-sel, so deprecate cpsw-phy-sel bindings. Reviewed-by: Rob Herring Signed-off-by: Grygorii Strashko --- Documentation/devicetree/bindings/net/cpsw-phy-sel.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 6/6] net: ethernet: ti: cpsw: deprecate cpsw-phy-sel driver

2019-02-20 Thread Grygorii Strashko
Deprecate cpsw-phy-sel driver as it's been replaced with new TI phy-gmii-sel PHY driver. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/Kconfig | 6 +++--- drivers/net/ethernet/ti/cpsw.h | 6 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH 1/6] ARM: dts: dra7: switch to use phy-gmii-sel

2019-02-20 Thread Grygorii Strashko
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel. Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/dra7-l4.dtsi | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi index bb45cb7fc3b6

[PATCH 3/6] ARM: dts: am4372: switch to use phy-gmii-sel

2019-02-20 Thread Grygorii Strashko
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel. Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/am437x-l4.dtsi | 17 + arch/arm/boot/dts/am43x-epos-evm.dts | 5 + 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/arch/arm/boot/dts/am437x-l4

[PATCH 2/6] ARM: dts: dm814x: switch to use phy-gmii-sel

2019-02-20 Thread Grygorii Strashko
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel. Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/dm814x.dtsi | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/dm814x.dtsi b/arch/arm/boot/dts/dm814x.dtsi index 601c57afd4fe

[PATCH 0/6] ARM: dts: ti: cpsw: switch to phy-gmii-sel phy driver

2019-02-20 Thread Grygorii Strashko
Hi Tony, Hence prerequisite patches [1] have been merged already I'm sending final set of DT patches to complete conversation of TI CPSW driver to use phy-gmii-sel phy driver instead of cpsw-phy-sel. [1] https://lkml.org/lkml/2018/11/26/154 Grygorii Strashko (6): ARM: dts: dra7: swit

[PATCH] net: ethernet: ti: netcp_ethss: fix build

2019-05-13 Thread Grygorii Strashko
one_netcp_ethss.ko] undefined! Fixes: 16f54164828b ("net: ethernet: ti: cpsw: drop CONFIG_TI_CPSW_ALE config option") Reported-by: kbuild test robot Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-18 Thread Grygorii Strashko
On 06/14/2018 06:43 AM, Ilias Apalodimas wrote: > On Thu, Jun 14, 2018 at 01:39:58PM +0200, Jiri Pirko wrote: >> Thu, Jun 14, 2018 at 01:34:04PM CEST, ilias.apalodi...@linaro.org wrote: >>> On Thu, Jun 14, 2018 at 01:30:28PM +0200, Jiri Pirko wrote: Thu, Jun 14, 2018 at 01:11:30PM CEST, ili

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-18 Thread Grygorii Strashko
On 06/18/2018 03:19 PM, Ilias Apalodimas wrote: On Mon, Jun 18, 2018 at 06:16:27PM +0200, Andrew Lunn wrote: @@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data, if (of_property_read_bool(node, "dual_emac")) data->switch_mode = CPSW_DUAL_EMA

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-27 Thread Grygorii Strashko
On 06/22/2018 02:45 AM, Ilias Apalodimas wrote: > On Thu, Jun 21, 2018 at 05:31:31PM +0200, Arnd Bergmann wrote: >> On Thu, Jun 21, 2018 at 2:45 PM, Ilias Apalodimas >> wrote: >>> On Thu, Jun 21, 2018 at 02:19:55PM +0200, Ivan Vecera wrote: >> >>> The driver is currently widely used and that's

Re: [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW

2018-06-27 Thread Grygorii Strashko
On 06/18/2018 12:49 PM, Ilias Apalodimas wrote: > On Mon, Jun 18, 2018 at 07:30:25PM +0200, Andrew Lunn wrote: >> On Mon, Jun 18, 2018 at 07:46:02PM +0300, Ilias Apalodimas wrote: >>> On Mon, Jun 18, 2018 at 06:28:36PM +0200, Andrew Lunn wrote: > Yes, if the CPU port is added on the VLAN the

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-27 Thread Grygorii Strashko
On 06/27/2018 03:40 PM, Arnd Bergmann wrote: > On Wed, Jun 27, 2018 at 9:18 PM, Grygorii Strashko > wrote: >> On 06/22/2018 02:45 AM, Ilias Apalodimas wrote: >>> On Thu, Jun 21, 2018 at 05:31:31PM +0200, Arnd Bergmann wrote: >>>> On Thu, Jun 21, 2018 at 2:45

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-03-14 Thread Grygorii Strashko
On 02/26/2018 02:16 PM, Florian Fainelli wrote: > On 02/26/2018 12:08 PM, Grygorii Strashko wrote: >> Hi Florian, >> >> The TI CPSW driver produces warning as below when booted in switch mode: >> [8.882295] sysfs: cannot create duplicate filename >> '/

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-03-14 Thread Grygorii Strashko
On 03/14/2018 02:50 PM, Florian Fainelli wrote: > On 03/14/2018 12:40 PM, Grygorii Strashko wrote: >> >> >> On 02/26/2018 02:16 PM, Florian Fainelli wrote: >>> On 02/26/2018 12:08 PM, Grygorii Strashko wrote: >>>> Hi Florian, >>>> >>&g

[PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-14 Thread Grygorii Strashko
_link_nowarn() and adds debug message instead. This is stable material 4.13+. Cc: Florian Fainelli Grygorii Strashko (2): sysfs: symlink: export sysfs_create_link_nowarn() net: phy: relax error checking when creating sysfs link netdev->phydev drivers/net/phy/phy_device.c | 15 +++

[PATCH 1/2] sysfs: symlink: export sysfs_create_link_nowarn()

2018-03-14 Thread Grygorii Strashko
ned-off-by: Grygorii Strashko --- "Fixes" added as there is dependency this and subsequent patch. fs/sysfs/symlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c index 8664db2..215c225 100644 --- a/fs/sysfs/symlink.c +++ b/fs/sysfs/symlin

[PATCH 2/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-14 Thread Grygorii Strashko
by using sysfs_create_link_nowarn() and adding debug message instead. Cc: Florian Fainelli Fixes: a3995460491d ("net: phy: Relax error checking on sysfs_create_link()") Signed-off-by: Grygorii Strashko --- drivers/net/phy/phy_device.c | 15 +++ 1 file changed, 11 inserti

Re: [PATCH 2/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-15 Thread Grygorii Strashko
On 03/14/2018 09:26 PM, Greg Kroah-Hartman wrote: > On Wed, Mar 14, 2018 at 05:26:24PM -0500, Grygorii Strashko wrote: >> Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per >> one netdevice, as result such drivers will produce warning during system &

Re: [PATCH v2] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface

2018-03-15 Thread Grygorii Strashko
--- Changes from v1: - Use phy_interface_is_rgmii helper function - Remove blank line Reviewed-by: Grygorii Strashko drivers/net/ethernet/ti/cpsw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index

Re: [PATCH v2] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface

2018-03-15 Thread Grygorii Strashko
On 03/15/2018 12:39 PM, Grygorii Strashko wrote: On 03/15/2018 11:56 AM, SZ Lin (林上智) wrote: According to AM335x TRM[1] 14.3.6.2, AM437x TRM[2] 15.3.6.2 and DRA7 TRM[3] 24.11.4.8.7.3.3, in-band mode in EXT_EN(bit18) register is only available when PHY is configured in RGMII mode with

Re: [PATCH v2] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface

2018-03-15 Thread Grygorii Strashko
On 03/15/2018 01:29 PM, Florian Fainelli wrote: > On 03/15/2018 11:18 AM, Grygorii Strashko wrote: >> >> >> On 03/15/2018 12:39 PM, Grygorii Strashko wrote: >>> >>> >>> On 03/15/2018 11:56 AM, SZ Lin (林上智) wrote: >>>> According to AM33

[PATCH net-next] net: ethernet: ti: cpsw: enable vlan rx vlan offload

2018-03-15 Thread Grygorii Strashko
; - otherwise fill SKB with VLAN info using __vlan_hwaccel_put_tag(); - PKT_Type = 0x00 (VLAN-tagged) then strip out VLAN header from SKB. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 67 +++-- drivers/net/ethernet/ti/davinci_cpdma.c

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-16 Thread Grygorii Strashko
On 03/16/2018 12:34 PM, Florian Fainelli wrote: > > > On 03/16/2018 10:22 AM, Andrew Lunn wrote: >> On Wed, Mar 14, 2018 at 05:26:22PM -0500, Grygorii Strashko wrote: >>> Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per >>> one ne

Re: [PATCH net-next] net: ethernet: ti: cpsw: enable vlan rx vlan offload

2018-03-16 Thread Grygorii Strashko
On 03/16/2018 01:37 PM, David Miller wrote: From: Andrew Lunn Date: Fri, 16 Mar 2018 01:29:35 +0100 On Thu, Mar 15, 2018 at 03:15:50PM -0500, Grygorii Strashko wrote: In VLAN_AWARE mode CPSW can insert VLAN header encapsulation word on Host port 0 egress (RX) before the packet data if

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-16 Thread Grygorii Strashko
On 03/16/2018 02:54 PM, Andrew Lunn wrote: >> The phydrv->mdiodrv.flags can be accessible only after call to >> of_phy_connect()/phy_connect(), > > You need to use a function like of_phy_find_device() to get the > phydev, set the flag, and then call phy_connect_direct(). So, do you propose me

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-16 Thread Grygorii Strashko
On 03/16/2018 02:11 PM, Florian Fainelli wrote: > On March 16, 2018 11:42:21 AM PDT, Grygorii Strashko > wrote: >> >> >> On 03/16/2018 12:34 PM, Florian Fainelli wrote: >>> >>> >>> On 03/16/2018 10:22 AM, Andrew Lunn wrote: >>>> On

[PATCH v2 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-16 Thread Grygorii Strashko
essages updated. v1: https://patchwork.ozlabs.org/cover/886058/ Cc: Florian Fainelli Cc: Andrew Lunn Grygorii Strashko (2): sysfs: symlink: export sysfs_create_link_nowarn() net: phy: relax error checking when creating sysfs link netdev->phydev drivers/net/phy/phy_device.c | 15 +++ f

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-16 Thread Grygorii Strashko
On 03/16/2018 04:14 PM, Andrew Lunn wrote: I agree, let's not have you run into circles, let's just use your patches as they are since they fix the problem and are not intrusive in any way. Agreed, this is too complex, for little gain. Thanks. v2 posted. -- regards, -grygorii

[PATCH v2 1/2] sysfs: symlink: export sysfs_create_link_nowarn()

2018-03-16 Thread Grygorii Strashko
_link()") Signed-off-by: Grygorii Strashko --- "Fixes" added as there is dependency this and subsequent patch. fs/sysfs/symlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c index 8664db2..215c225 100644 --- a/fs/sysfs/symlink.c +++

[PATCH v2 2/2] net: phy: relax error checking when creating sysfs link netdev->phydev

2018-03-16 Thread Grygorii Strashko
et: phy: Relax error checking on sysfs_create_link()") Signed-off-by: Grygorii Strashko --- drivers/net/phy/phy_device.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 478405e..fe16f58 100

Re: [PATCH] net: ethernet: ti: cpsw: fix tx vlan priority mapping

2018-04-12 Thread Grygorii Strashko
tagged packets, like prio 2 -> prio 5" > > Signed-off-by: Ivan Khoronzhuk > --- > Based on net/master Fixes: e05 107 e6b 747 ("net: ethernet: ti: cpsw: add multi queue support") Reviewed-by: Grygorii Strashko > > drivers/net/ethernet/ti/cpsw.c | 2

regression?: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-02-26 Thread Grygorii Strashko
Sry, for the late report - in LKML most of dual port TI platforms configured to work in dual mac mode, therefore two network devices are created and warning not displayed. -- regards, -grygorii -- >From ef2e612652cb7afa844993b23156315f0df7d24f Mon Sep 17 00:00:00 2001 From: Grygorii Str

Re: [PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle

2018-08-29 Thread Grygorii Strashko
? Another option is to use phy, but it'd be complicated. > > Cc: devicet...@vger.kernel.org > Cc: Andrew Lunn > Cc: Grygorii Strashko > Cc: Ivan Khoronzhuk > Cc: Mark Rutland > Cc: Murali Karicheri > Cc: Rob Herring > Signed-off-by: Tony Lindgren > --- >

Re: [PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle

2018-08-30 Thread Grygorii Strashko
On 08/29/2018 07:47 PM, Tony Lindgren wrote: * Grygorii Strashko [180830 00:12]: Hi Tony, On 08/29/2018 10:00 AM, Tony Lindgren wrote: The current cpsw usage for cpsw-phy-sel is undocumented but is used for all the boards using cpsw. And cpsw-phy-sel is not really a child of the cpsw

[PATCH] net: phy: micrel: ksz9031: reconfigure autoneg after phy autoneg workaround

2017-12-20 Thread Grygorii Strashko
quot;) Signed-off-by: Grygorii Strashko --- drivers/net/phy/micrel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index ab46141..422ff63 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -624,6 +624,7 @@ static int ksz903

Re: [PATCH] net: phy: micrel: ksz9031: reconfigure autoneg after phy autoneg workaround

2017-12-21 Thread Grygorii Strashko
On 12/21/2017 03:21 AM, Andrew Lunn wrote: > On Wed, Dec 20, 2017 at 06:45:10PM -0600, Grygorii Strashko wrote: >> Under some circumstances driver will perform PHY reset in >> ksz9031_read_status() to fix autoneg failure case (idle error count = >> 0xFF). When this hap

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-01 Thread Grygorii Strashko
Hi Ilias, On 05/24/2018 01:56 AM, Ilias Apalodimas wrote: > Hello, > > This is adding a new mode on the cpsw driver based around switchdev. > In order to enable this you need to enable CONFIG_NET_SWITCHDEV, > CONFIG_BRIDGE_VLAN_FILTERING, CONFIG_TI_CPSW_SWITCHDEV > and add to udev config: > > SU

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-02 Thread Grygorii Strashko
Hi All, Sry, for delayed reply. On 05/24/2018 09:08 AM, Ilias Apalodimas wrote: > On Thu, May 24, 2018 at 03:44:54PM +0200, Ivan Vecera wrote: >> On 24.5.2018 14:54, Andrew Lunn wrote: >>> On Thu, May 24, 2018 at 11:48:31AM +0300, Ilias Apalodimas wrote: On Thu, May 24, 2018 at 10:05:28AM +0

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 05:34 AM, Ilias Apalodimas wrote: > Hi Florian, > > Thanks for taking time to look into this > > On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: >> >> >> On 05/24/2018 09:56 PM, Ilias Apalodimas wrote: >>> On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn wr

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 07:08 PM, Andrew Lunn wrote: > On Sat, Jun 02, 2018 at 06:28:22PM -0500, Grygorii Strashko wrote: > > Hi Grygorii > > I'm just picking out one thing here... there is lots more good stuff here. > >> Additional headache is PTP: we have on PHC, but bo

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 07:37 PM, Andrew Lunn wrote: >> 1) boot, ping no vlan >> >> # ip link add name br0 type bridge >> # echo 0 > /sys/class/net/br0/bridge/default_pvid >> # ip link set dev eth2 master br0 >> # ip link set dev eth0 master br0 >> # ip link set dev eth1 master br0 >> # ifconfig br0 192.1

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
On 06/05/2018 04:28 PM, Andrew Lunn wrote: I hope you are right - question is always in number of available options and which one to select - and, most important, explain it to the end user :( The end customer being ptp4linux? At least for Marvell switches, it is happy about everything excep

  1   2   3   4   5   6   7   >