[PATCH net-next v2 12/19] bna: remove TX_E_PRIO_CHANGE event and BNA_TX_F_PRIO_CHANGED flag

TX_E_PRIO_CHANGE event is never sent for bna_tx so it doesn't need to be handled. After this change bna_tx->flags cannot contain BNA_TX_F_PRIO_CHANGED flag and it can be also eliminated. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna_tx_r

[PATCH net-next v2 15/19] bna: remove useless pointer assignment

Pointer cmpl used to iterate through completion entries is updated at the beginning of while loop as well as at the end. The update at the end of the loop is useless. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bnad.c | 1 - 1 file changed, 1 deletion(-) diff --git a

[PATCH net-next v2 19/19] bna: use netdev_* and dev_* instead of printk and pr_*

...and remove some of them. It is not necessary to log when .probe() and .remove() are called or when TxQ is started or stopped. Also log level of some of them was changed to more appropriate one (link up/down, firmware loading failure. Signed-off-by: Ivan Vecera --- drivers/net/ethernet

[PATCH net-next v2 18/19] bna: fix timeout API argument type

Timeout functions are defined with 'void *' ptr argument. They should be defined directly with 'struct bfa_ioc *' type to avoid type conversions. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 16 +--- drivers/net/ethernet/brocad

[PATCH net-next v2 03/19] bna: replace pragma(pack) with attribute __packed

Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bfa_defs.h| 6 +- drivers/net/ethernet/brocade/bna/bfa_defs_cna.h| 14 +-- .../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 6 +- drivers/net/ethernet/brocade/bna/bfi.h | 70 +++--- drivers

[PATCH net-next v2 16/19] bna: get rid of private macros for manipulation with lists

Remove macros for manipulation with struct list_head and replace them with standard ones. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bfa_cee.c | 1 - drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10 +- drivers/net/ethernet/brocade/bna/bfa_msgq.c | 10 +- drivers

[PATCH net-next v2 14/19] bna: use memdup_user to copy userspace buffers

Patch converts kzalloc->copy_from_user sequence to memdup_user. There is also one useless assignment of NULL to bnad->regdata as it is followed by assignment of kzalloc output. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 27 -

[PATCH net-next v2 08/19] bna: remove oper_state_cbfn from struct bna_rxf

Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna.h | 15 --- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 6 -- drivers/net/ethernet/brocade/bna/bna_types.h | 4 3 files changed, 25 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna

[PATCH net-next v2 17/19] bna: use list_for_each_entry where appropriate

Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 5 +- drivers/net/ethernet/brocade/bna/bna.h | 41 -- drivers/net/ethernet/brocade/bna/bna_enet.c | 23 -- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 117 +-- 4 files

[PATCH net-next v2 01/19] bna: use ether_addr_copy instead of memcpy

struct sockaddr *. v2: added __aligned directive to bnad_bcast_addr, renamed parameter of bnad_set_mac_address() (thx j...@perches.com) Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 12 ++-- drivers/net/ethernet/brocade/bna/bnad.c | 22

[PATCH net-next v2 06/19] bna: remove unused cbfn parameter

removed: bna_rx_ucast_add bna_rx_ucast_del simplified: bna_enet_pause_config bna_rx_mcast_delall bna_rx_mcast_listset bna_rx_mode_set bna_rx_ucast_listset bna_rx_ucast_set Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna.h | 24 + drivers/net

[PATCH net-next v2 05/19] bna: use BIT(x) instead of (1 << x)

Signed-off-by: Ivan Vecera --- .../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +- drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 2 +- drivers/net/ethernet/brocade/bna/bfi_enet.h| 66 ++-- drivers/net/ethernet/brocade/bna/bna_enet.c| 4 +- drivers

[PATCH net-next v2 00/19] bna: clean-up

The patches clean the bna driver. v2: changes & comments requested by Joe Ivan Vecera (19): bna: use ether_addr_copy instead of memcpy bna: get rid of mac_t bna: replace pragma(pack) with attribute __packed bna: get rid of duplicate and unused macros bna: use BIT(x) instead of (1

[PATCH net-next v2 04/19] bna: get rid of duplicate and unused macros

FT BNA_{C,RX,TX}Q_QPGE_PTR_GET BNA_IOC_TIMER_FREQ BNA_MESSAGE_SIZE BNA_QE_INDX_2_PTR BNA_QE_INDX_RANGE BNA_Q_GET_{C,P}I BNA_Q_{C,P}I_ADD BNA_Q_FREE_COUNT BNA_Q_IN_USE_COUNT BNA_TO_POWER_OF_2 containing_rec Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bfa_cs.h | 14 dr

[PATCH net-next v2 09/19] bna: remove prio_change_cbfn oper_state_cbfn from struct bna_tx

Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 13 - drivers/net/ethernet/brocade/bna/bna_types.h | 3 --- 2 files changed, 16 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c index

[PATCH net-next v2 11/19] bna: remove paused from bna_rx_config and flags from bna_rxf

The bna_rx_config struct member paused can be removed as it is never written and as it cannot have non-zero value the bna_rxf struct member flags also cannot have BNA_RXF_F_PAUSED value and is always zero. So the flags member can be removed as well as bna_rxf_flags enum and the code-paths that need

[PATCH net-next v2 13/19] bna: correct comparisons/assignments to bool

Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index 29e0428..52fc439 100644 --- a/drivers/net/ethernet

[PATCH net-next v2 07/19] bna: remove pause_cbfn from struct bna_enet

Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna_enet.c | 15 --- drivers/net/ethernet/brocade/bna/bna_types.h | 3 --- 2 files changed, 18 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bna_enet.c b/drivers/net/ethernet/brocade/bna/bna_enet.c index

[PATCH net-next v2 10/19] bna: remove RXF_E_PAUSE and RXF_E_RESUME events

RXF_E_PAUSE & RXF_E_RESUME events are never sent for bna_rxf object so they needn't to be handled. The bna_rxf's state bna_rxf_sm_fltr_clr_wait and function bna_rxf_fltr_clear are unused after this so remove them also. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/b

Re: [PATCH net-next v2 05/19] bna: use BIT(x) instead of (1 << x)

On 06/12/2015 03:30 PM, David Laight wrote: From: Ivan Vecera ... diff --git a/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h b/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h index 679a503..16090fd 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_defs_mfg_comm.h +++ b/drivers/net

[PATCH net-next 3/3] bna: remove superfluous parentheses

Signed-off-by: Ivan Vecera --- .../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10 +-- drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 98 +++--- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 4

[PATCH net-next 1/3] bna: remove unnecessary cast of BIT value

BIT value is already unsigned so casting is not necessary. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 3 +-- drivers/net/ethernet/brocade/bna/bna_enet.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/brocade

[PATCH net-next 2/3] bna: make pointers to read-only inputs const

Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna.h | 19 +-- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 14 +++--- drivers/net/ethernet/brocade/bna/bnad.c | 6 +++--- drivers/net/ethernet/brocade/bna/bnad.h | 2 +- 4 files changed

[PATCH net-next 0/3] bna: clean-up 2

Next round of cleaning patches. Ivan Vecera (3): bna: remove unnecessary cast of BIT value bna: make pointers to read-only inputs const bna: remove superfluous parentheses .../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10

[PATCH net] be2net: check properly status in lancer_cmd_get_file_len()

The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get the current size of registers for ethtool registers dump. The size is stored in data_read but only when the returned status is 0 otherwise it is uninitialized thus random. Signed-off-by: Ivan Vecera --- drivers/net/ethernet

[PATCH net-next 2/2] be2net: replace hardcoded values with existing define

Signed-off-by: Ivan Vecera --- drivers/net/ethernet/emulex/benet/be_ethtool.c | 3 ++- drivers/net/ethernet/emulex/benet/be_main.c| 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet

[PATCH net-next 1/2] be2net: remove unused local rsstable array

Remove rsstable array and its initialization from be_set_rss_hash_opts(). The array became unused after "e255787 be2net: Support for configurable RSS hash key". The initial RSS table is now filled and stored for later usage during Rx queue creation. Signed-off-by: Ivan Vecera --- d

Re: [PATCH net] be2net: check properly status in lancer_cmd_get_file_len()

On 11/16/2015 09:57 AM, Sathya Perla wrote: On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera wrote: The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get the current size of registers for ethtool registers dump. The size is stored in data_read but only when the returned status is 0

[PATCH net-next] be2net: remove local variable 'status'

. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/emulex/benet/be_ethtool.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c index 734f655..d2a5baf 100644 --- a/drivers/net

[PATCH net] r8169: enforce RX_MULTI_EN on rtl8168ep/8111ep chips

r for these chips. Signed-off-by: Ivan Vecera Tested-by: Alexander Lindqvist --- drivers/net/ethernet/realtek/r8169.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3df51fa..f790f61 100644

Re: [PATCH] r8169:Fill with zero Tx descriptors

On 5.8.2015 12:46, Corcodel Marian wrote: This patch fill with zero Tx descriptors before use.Is only onpart by more patches but is critical.(critical) Signed-off-by: Corcodel Marian diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3df51f

[PATCH net] bna: fix interrupts storm caused by erroneous packets

. As these packets are never acked the firmware fires IRQs for them again and again. Fixes: e29aa33 bna: Enable Multi Buffer RX Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bnad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/brocade/bna

[PATCH net] be2net: avoid vxlan offloading on multichannel configs

--- 172.30.10.254 ping statistics --- 3 packets transmitted, 3 received, 0% packet loss, time 2000ms rtt min/avg/max/mdev = 0.194/0.236/0.318/0.057 ms Cc: Sathya Perla Cc: Ajit Khaparde Cc: Padmanabh Ratnakar Cc: Sriharsha Basavapatna Signed-off-by: Ivan Vecera --- drivers/net/ethernet/emulex/benet

Re: [PATCH net-next]:r8169: Add and modify some parameters

On 17.8.2015 12:26, Corcodel Marian wrote: Set InterFrame Gap time as largest posible for comp. Add InterFrameGap2 bit set on start. Why? Signed-off-by: Corcodel Marian diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index eb2d2a4..ea0f327 1006

Re: [PATCH net-next] r8169: Add tx_buf_sz and rx_buf_coef on rtl_cfg_info

On 17.8.2015 13:10, Corcodel Marian wrote: Put rx_buf_sz on rtl_cfg_info structure and add new parameter rx_buf_coef.Param rx_buf_sz may be different by nic's and same rx_buf_coef On RTL 8101 series rx_buf_coef is not equal with rx_buf_sz. Add --whitespace=warn on git Signed-off-by: Corc

[PATCH net] bna: check for dma mapping errors

Check for DMA mapping errors, recover from them and register them in ethtool stats like other errors. Cc: Rasesh Mody Signed-off-by: Ivan Vecera --- drivers/net/ethernet/brocade/bna/bna_tx_rx.c| 2 ++ drivers/net/ethernet/brocade/bna/bna_types.h| 1 + drivers/net/ethernet/brocade/bna

[PATCH net] macvtap: fix network header pointer for VLAN tagged pkts

Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. Signed-off-by: Ivan Vecera --- drivers/net/macvtap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c

Re: [PATCH net] macvtap: fix network header pointer for VLAN tagged pkts

On 07/20/2015 06:42 PM, Vlad Yasevich wrote: On 07/20/2015 11:44 AM, Ivan Vecera wrote: Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. Signed-off-by: Ivan Vecera --- drivers/net/macvtap.c | 6

[PATCH net v2] macvtap: fix network header pointer for VLAN tagged pkts

Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. v2: leave skb->protocol untouched (thx Vlad), comment added Signed-off-by: Ivan Vecera --- drivers/net/macvtap.c | 7 +++ 1 file changed, 7 inserti

[PATCH net v3] macvtap: fix network header pointer for VLAN tagged pkts

Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. v2: leave skb->protocol untouched (thx Vlad), comment added v3: moved after skb_probe_transport_header() call (thx Toshiaki) Signed-off-by: Ivan Vec

<    1   2   3