ned-off-by: Willem de Bruijn
Cc: linux-stable
Signed-off-by: Marc Kleine-Budde
---
net/can/af_can.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/can/af_can.c b/net/can/af_can.c
index 743470680127..80281ef2ccbd 100644
--- a/net/can/af_can.c
+++ b/net/can/af_can.c
@@ -99,6 +99,7 @@ EXP
f 100,
flexcan_probe() fails on the MPC8309, which requires a value of at least
140 to work reliably. 250 works for everyone.
Signed-off-by: Joakim Zhang
Reviewed-by: Dong Aisheng
Cc: linux-stable
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/flexcan.c | 2 +-
1 file changed, 1 insertion(+), 1 del
From: Sean Nyekjaer
Fully compatible with mcp2515, the mcp25625 have integrated transceiver.
This patch adds support for the mcp25625 to the existing mcp251x driver.
Signed-off-by: Sean Nyekjaer
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/spi/Kconfig | 5 +++--
drivers/net/can
use.
Fix that.
Tested with CAN FD core on a ZynqMP board.
Fixes: 9e5f1b273e6a ("can: xilinx_can: add support for Xilinx CAN FD core")
Reported-by: Shubhrajyoti Datta
Signed-off-by: Anssi Hannula
Cc: Michal Simek
Reviewed-by: Shubhrajyoti Datta
Cc: linux-stable
Signed-off-b
From: Sean Nyekjaer
Fully compatible with mcp2515, the mcp25625 have integrated transceiver.
This patch add the mcp25625 to the device tree bindings documentation.
Signed-off-by: Sean Nyekjaer
Signed-off-by: Marc Kleine-Budde
---
Documentation/devicetree/bindings/net/can/microchip
From: YueHaibing
This patch add error path for can_init() to avoid possible crash if some
error occurs.
Fixes: 0d66548a10cb ("[CAN]: Add PF_CAN core module")
Signed-off-by: YueHaibing
Acked-by: Oliver Hartkopp
Signed-off-by: Marc Kleine-Budde
---
net/can/af_
y."
Instead of passing %pK, which can print the correct address, simply
remove the entire message as it is not really that useful.
Signed-off-by: Fabio Estevam
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/flexcan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers
From: Alexander Dahl
This seems to have slipped in by accident when sorting the entries.
Fixes: ffbdd9172ee2f53020f763574b4cdad8d9760a4f
Signed-off-by: Alexander Dahl
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/usb/Kconfig | 6 --
1 file changed, 6 deletions(-)
diff --git a
Hello David,
this is a pull reqeust of 9 patches for net/master.
The first patch is by Alexander Dahl and removes a duplicate menu entry from
the Kconfig. The next patch by Joakim Zhang fixes the timeout in the flexcan
driver when setting small bit rates. Anssi Hannula's patch for the xilinx_can
-by: Ludovic Desroches
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/m_can/m_can.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 9b449400376b..deb274a19ba0 100644
--- a/drivers/net/can/m_can
oen Hofstee (1):
can: ti_hecc: use timestamp based rx-offloading
Ji-Ze Hong (Peter Hong) (1):
can: sja1000: f81601: add Fintek F81601 support
Marc Kleine-Budde (2):
MAINTAINERS: can: add missing files to CAN NETWORK DRIVERS and CAN
NETWORK LAYER
can: sja1000: Makefile/Kconfig:
nsive
> testing since then.
Good.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http:
;.
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/?h=linux-can-fixes-for-5.3-20190724
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | F
ought down.
Make sure the LED always reflects the state of the CAN device.
Signed-off-by: Rasmus Villemoes
Acked-by: Willem de Bruijn
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
,
can_get_echo_skb() are called, for each aborted URB.
Fixes: bb4785551f64 ("can: usb: PEAK-System Technik USB adapters driver core")
Signed-off-by: Stephane Grosjean
Cc: linux-stable
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/usb/peak_usb/pcan_usb_core.c | 8
1 file
t;can: flexcan: add self wakeup support")
Reported-by: Marc Kleine-Budde
Signed-off-by: Joakim Zhang
Cc: linux-stable # >= v5.0
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/flexcan.c | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/dr
("can: rcar_canfd: Add Renesas R-Car CAN FD driver")
Signed-off-by: Nikita Yushchenko
Cc: linux-stable
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/rcar/rcar_canfd.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/rcar/rcar_canfd.c
b/d
Hello David,
this is a pull reqeust of 7 patches for net/master.
The first patch is by Rasmus Villemoes add a missing netif_carrier_off() to
register_candev() so that generic netdev trigger based LEDs are initially off.
Nikita Yushchenko's patch for the rcar_canfd driver fixes a possible IRQ sto
f-by: Marc Kleine-Budde
---
drivers/net/can/spi/mcp251x.c | 49 ---
1 file changed, 22 insertions(+), 27 deletions(-)
diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
index 44e99e3d7134..2aec934fab0c 100644
--- a/drivers/net/can/spi/mcp25
From: YueHaibing
This patch add error path for cgw_module_init to avoid possible crash if
some error occurs.
Fixes: c1aabdf379bc ("can-gw: add netlink based CAN routing")
Signed-off-by: YueHaibing
Acked-by: Oliver Hartkopp
Signed-off-by: Marc Kleine-Budde
---
net/can
From: Wen Yang
The gpr_np variable is still being used in dev_dbg() after the
of_node_put() call, which may result in use-after-free.
Fixes: de3578c198c6 ("can: flexcan: add self wakeup support")
Signed-off-by: Wen Yang
Cc: linux-stable # >= v5.0
Signed-off-by: Marc Kleine-Budde
> Flexcan CAN FD? And this Flexcan CAN FD patch set is based on these
> patches.
Yes, these patches will be added back.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
On 7/25/19 9:53 AM, Marc Kleine-Budde wrote:
> On 7/25/19 9:38 AM, Joakim Zhang wrote:
>> Kindly pinging...
>>
>> After you git pull request for linux-can-next-for-5.4-20190724, some patches
>> are missing from linux-can-next/testing.
>> can: flexcan: f
kport this patch to v4.9.186 and send it to Sasha
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2
Fixes: 60649d4e0af ("can: remove obsolete empty ioctl() handler")
> Signed-off-by: Oliver Hartkopp
David Miller has already applied the patch.
| commit 473d924d7d46cb57aa4c1863261d18366af345af
| Author: Oliver Hartkopp
| Date: Mon Jul 29 22:40:56 2019 +0200
Thanks,
Marc
--
Pengutron
o dma on the stack")
Cc: linux-stable
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c
b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c
index 17
t for PEAK new CANFD USB
adapters")
Cc: linux-stable
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
b/drivers/net/can/usb/peak_usb/pcan_usb_
.
Signed-off-by: Wang Xiayang
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/usb/peak_usb/pcan_usb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c
b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
index 22b9c8e6d040
lle script.
Signed-off-by: Wang Xiayang
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/sja1000/peak_pcmcia.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/sja1000/peak_pcmcia.c
b/drivers/net/can/sja1000/peak_pcmcia.c
index 185c7f7d38a4..5e0d5e8101c8 10
Hello David,
this is a pull request of 4 patches for net/master.
The first two patches are by Wang Xiayang, they force that the string buffer
during a dev_info() is properly NULL terminated.
The last two patches are by Tomas Bortoli and fix both a potential info leak of
kernel memory to USB devi
by: Oliver Neukum
>
> Please CC: the CAN subsystem maintainers, as this is clearly listed in the
> MAINTAINERS file.
The issue is already fixed and already mainline (stable@v.k.o is on Cc):
30a8beeb3042 can: peak_usb: pcan_usb_fd: Fix info-leaks to USB devices
Marc
--
Pengutronix
mcp25xxfd: add driver for Microchip MCP25xxFD SPI
> CAN")
> Signed-off-by: Qinglang Miao
applied to linux-can/testing
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dor
ong tree. Using the correct tree it compiles.
regards,
Marc
[1] The submitter already knows to include that next time.
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-23
packet_idx;
> + u16 echo_skb_tail_idx;
> + u16 echo_skb_head_idx;
> + u16 num_echo_skb;
Can you explain me how the tx-path works, especially why you need the
current_packet_idx.
In the mcp251xfd driver, the number of TX buffers is a power of two, that makes
things easier. tx_heads % len
to minimize the
> number of spinlock: only one per bulk send or bulk receive.
With queue size being power of two the modulo can be written as a mask
operation, so it's reasonable fast. So you only need to care about tx_head and
tx_tail, and there is only one writer for each variable. With a little dance and
barriers when stopping and starting the queue it's race-free without spinlocks.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
signature.asc
Description: OpenPGP digital signature
bit more of how to improve that.
For the echo_skb rounding up might work, but you should round down, so that your
can directly use the masked value.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertret
This patch moves the CAN driver related infrastructure into a separate subdir.
It will be split into more files in the coming patches.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-3-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can
Hello Jakub, hello David,
this is a pull request of 2 patches for net/master.
The first patch is by Oliver Hartkopp for the CAn ISO-TP protocol and fixes a
kernel information leak to userspace.
The last patch is by Qinglang Miao for the mcp251xfd driver and fixes a NULL
pointer check to work on
kopp
Link: https://lore.kernel.org/r/20210112091643.11789-1-socket...@hartkopp.net
Signed-off-by: Marc Kleine-Budde
---
net/can/isotp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/can/isotp.c b/net/can/isotp.c
index 7839c3b9e5be..3ef7f78e553b 100644
--- a/net/can/isotp.c
+++ b/net/c
/20210111061335.39983-1-mailhol.vinc...@wanadoo.fr
Signed-off-by: Marc Kleine-Budde
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-13-...@pengutronix.de
Signed-off-by: Vincent Mailhol
---
drivers/net/can/at91_can.c | 2 +-
drivers/net/can/c_can/c_can.c
FD SPI
CAN")
Signed-off-by: Qinglang Miao
Reviewed-by: Manivannan Sadhasivam
Link: https://lore.kernel.org/r/20210113073100.79552-1-miaoqingl...@huawei.com
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
: https://lore.kernel.org/r/20210112095437.6488-2-mailhol.vinc...@wanadoo.fr
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/skb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/can/dev/skb.c b/drivers/net/can/dev/skb.c
index 53683d4312f1..6a64fe410987 100644
--- a
Santhanam
Signed-off-by: Arunachalam Santhanam
Co-developed-by: Vincent Mailhol
Signed-off-by: Vincent Mailhol
Acked-by: Vincent Mailhol
Reviewed-by: Vincent Mailhol
Co-developed-by: Marc Kleine-Budde
Link: https://lore.kernel.org/r/2021041930.693847-11-...@pengutronix.de
Signed-off-by
Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-9-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/length.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/dev/length.c b/drivers/net/can/dev/length.c
index
p_buf.
Suggested-by: Jakub Kicinski
Link: https://lore.kernel.org/r/20210113203955.912916-1-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/m_can/tcan4x5x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/m_can/tcan4x5x.h b/drivers/ne
users of this function, too.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-15-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/rx-offload.c | 5 +++--
drivers/net/can/flexcan.c | 5 +++--
drivers
extend __can_get_echo_skb() to return that
value.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-12-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/rx-offload.c | 2 +-
drivers/net/can/dev/skb.c| 9 +++--
include/linux
This patch converts the file into the kernel coding style.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-8-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/length.c | 28
1 file changed, 16 insertions
this function, too.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-14-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/at91_can.c| 2 +-
drivers/net/can/c_can/c_can.c | 2 +-
drivers/net/can
.693847-10-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
include/linux/can/length.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/can/length.h b/include/linux/can/length.h
index 156b9d17969a..b2313b2a0b02 100644
--- a/include/linux/can/length.h
+++ b/include/linux/can/length.
This patch moves the netlink related code of the CAN device infrastructure into
a separate file.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-7-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/Makefile | 1 +
drivers/net/can
This patch moves all CAN frame length related code of the CAN device
infrastructure into a separate file.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-5-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
MAINTAINERS | 1 +
drivers
This patch moves the bittiming related code of the CAN device infrastructure
into a separate file.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-4-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
MAINTAINERS | 1 +
drivers/net
This patch moves the skb related code of the CAN device infrastructure into a
separate file.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-6-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/Makefile | 1 +
drivers/net/can/dev
ned-off-by: Marc Kleine-Budde
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 54fcd5fe572d..c3091a91ebbf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3960,6 +3960,7 @@ W:https://github.com/linux-can
T: git git://git.kernel.org/pub
10113
Lukas Bulwahn (1):
MAINTAINERS: adjust entry to tcan4x5x file split
Marc Kleine-Budde (13):
MAINTAINERS: CAN network layer: add missing header file can-ml.h
can: dev: move driver related infrastructure into separate subdir
can: dev: move bittiming related
n4x5x: move regmap code into seperate file")
Fixes: 7813887ea972 ("can: tcan4x5x: rename tcan4x5x.c -> tcan4x5x-core.c")
Link: https://lore.kernel.org/r/20210108073932.20804-1-lukas.bulw...@gmail.com
Signed-off-by: Marc Kleine-Budde
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion
On 1/13/21 10:13 PM, Marc Kleine-Budde wrote:
> Hello Jakub, hello David,
>
> this is a pull request of 17 patches for net-next/master.
>
> The first two patches update the MAINTAINERS file, Lukas Bulwahn's patch fixes
> the files entry for the tcan4x5x driver, which was b
On 1/14/21 2:59 AM, Vincent MAILHOL wrote:
> On Tue. 14 Jan 2021 at 06:14, Marc Kleine-Budde wrote:
>>
>> If the length paramter in len2dlc() exceeds the size of the len2dlc array, we
>> return 0xF. This is equal to the last 16 members of the array.
>>
>> This pat
2-20210114
Lukas Bulwahn (1):
MAINTAINERS: adjust entry to tcan4x5x file split
Marc Kleine-Budde (13):
MAINTAINERS: CAN network layer: add missing header file can-ml.h
can: dev: move driver related infrastructure int
This patch moves all CAN frame length related code of the CAN device
infrastructure into a separate file.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-5-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
MAINTAINERS | 1 +
drivers
n4x5x: move regmap code into seperate file")
Fixes: 7813887ea972 ("can: tcan4x5x: rename tcan4x5x.c -> tcan4x5x-core.c")
Link: https://lore.kernel.org/r/20210108073932.20804-1-lukas.bulw...@gmail.com
Signed-off-by: Marc Kleine-Budde
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion
This patch moves the netlink related code of the CAN device infrastructure into
a separate file.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-7-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/Makefile | 1 +
drivers/net/can
This patch moves the skb related code of the CAN device infrastructure into a
separate file.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-6-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/Makefile | 1 +
drivers/net/can/dev
: https://lore.kernel.org/r/20210112095437.6488-2-mailhol.vinc...@wanadoo.fr
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/skb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/can/dev/skb.c b/drivers/net/can/dev/skb.c
index 53683d4312f1..6a64fe410987 100644
--- a
p_buf.
Suggested-by: Jakub Kicinski
Link: https://lore.kernel.org/r/20210113203955.912916-1-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/m_can/tcan4x5x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/m_can/tcan4x5x.h b/drivers/ne
ned-off-by: Marc Kleine-Budde
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 54fcd5fe572d..c3091a91ebbf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3960,6 +3960,7 @@ W:https://github.com/linux-can
T: git git://git.kernel.org/pub
This patch moves the CAN driver related infrastructure into a separate subdir.
It will be split into more files in the coming patches.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-3-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can
This patch moves the bittiming related code of the CAN device infrastructure
into a separate file.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-4-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
MAINTAINERS | 1 +
drivers/net
extend __can_get_echo_skb() to return that
value.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-12-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/rx-offload.c | 2 +-
drivers/net/can/dev/skb.c| 9 +++--
include/linux
This patch converts the file into the kernel coding style.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-8-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/length.c | 28
1 file changed, 16 insertions
.693847-10-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
include/linux/can/length.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/can/length.h b/include/linux/can/length.h
index 156b9d17969a..b2313b2a0b02 100644
--- a/include/linux/can/length.h
+++ b/include/linux/can/length.
/20210111061335.39983-1-mailhol.vinc...@wanadoo.fr
Signed-off-by: Marc Kleine-Budde
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-13-...@pengutronix.de
Signed-off-by: Vincent Mailhol
---
drivers/net/can/at91_can.c | 2 +-
drivers/net/can/c_can/c_can.c
this function, too.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-14-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/at91_can.c| 2 +-
drivers/net/can/c_can/c_can.c | 2 +-
drivers/net/can
Santhanam
Signed-off-by: Arunachalam Santhanam
Co-developed-by: Vincent Mailhol
Signed-off-by: Vincent Mailhol
Acked-by: Vincent Mailhol
Reviewed-by: Vincent Mailhol
Co-developed-by: Marc Kleine-Budde
Link: https://lore.kernel.org/r/2021041930.693847-11-...@pengutronix.de
Signed-off-by
users of this function, too.
Reviewed-by: Vincent Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-15-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/rx-offload.c | 5 +++--
drivers/net/can/flexcan.c | 5 +++--
drivers
Mailhol
Link: https://lore.kernel.org/r/2021041930.693847-9-...@pengutronix.de
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev/length.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/dev/length.c b/drivers/net/can/dev/length.c
index
ructure.
>
> Would make sense to me to add the tdco (Transmitter Delay
> Compensation Offset). Ref: ISO 11898-1 section
> 11.3.3 "Transmitter delay compensation"
>
> I would just like your opinion on one topic: the tdco is specific
> to CAN FD. If we add it, we have
While in:
| ca4c6ebeeb50 can: mcp251xfd: mcp251xfd_handle_rxif_one():
| fix wrong NULL pointer check
a real problem has been fixed.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West
CAN Network device driver and Netlink interface")
Link:
https://lore.kernel.org/r/20210120114137.200019-2-mailhol.vinc...@wanadoo.fr
Signed-off-by: Vincent Mailhol
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
rnel.org/r/20210120114137.200019-3-mailhol.vinc...@wanadoo.fr
Signed-off-by: Vincent Mailhol
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/vxcan.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c
index fa47bab510bb..f9a524c5f6d6 10
tch forward.
> Reference: 3e77f70e7345 ("can: dev: move driver related infrastructure
> into separate subdir")
I've send a pull request to Jakub and David. Let's see what happens :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded
K new CANFD USB
adapters")
Link:
https://lore.kernel.org/r/20210120114137.200019-4-mailhol.vinc...@wanadoo.fr
Signed-off-by: Vincent Mailhol
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
di
Hello Jakub, hello David,
this is a pull request of 3 patches for net/master.
All three patches are by Vincent Mailhol and fix a potential use after free bug
in the CAN device infrastructure, the vxcan driver, and the peak_usk driver. In
the TX-path the skb is used to read from after it was passe
gt;
> Thanks for the note, I'm sending the PR to Linus now, so I think
> linux-next may never see the the conflict.
thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/D
/can/usb/peak_usb/pcan_usb_fd.c | 8
> drivers/net/can/vxcan.c| 6 --
> 3 files changed, 10 insertions(+), 8 deletions(-)
Applied to linux-can-testing. I don't know why 2/3 hasn't made it to the mail
archive yet.
Marc
--
Pengutronix e.K.
now, so I think
>>> linux-next may never see the the conflict.
>
> The merge has been done now, could you double check?
Looks good!
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.d
[-Werror=return-type]
188 | }
| ^
cc1: some warnings being treated as errors
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsger
&priv->regs_status,
> sizeof(priv->regs_status) /
> -sizeof(u32));
> +val_bytes);
> if (err)
> goto o
964 980 +16
> > Total: Before=20832, After=20936, chg +0.50%
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
signature.asc
Description: PGP signature
,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
signature.asc
Description: O
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
signature.asc
Description
urn_t mcp251xfd_irq(int irq, void *dev_id)
> err = regmap_bulk_read(priv->map_reg, MCP251XFD_REG_INT,
> &priv->regs_status,
> sizeof(priv->regs_status) /
> -sizeof(u32));
> +
conditionally anyhow.
>
> Signed-off-by: Uwe Kleine-König
> ---
> drivers/net/can/sja1000/tscan1.c | 4 +---
For the can driver:
Acked-by: Marc Kleine-Budde
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://
On 1/22/21 8:59 AM, Su wrote:
>
> 在 2021/1/22 下午3:26, Marc Kleine-Budde 写道:
>> On 1/22/21 4:02 AM, Su Yanjun wrote:
>>> Recently i use mcp2518fd on 4.x kernel which multiple write is not
>>> backported, regmap_raw_write will cause old kernel crash because the
>
u Yanjun
Applied to linux-can-next/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 268
e types which are limited by all being
> ARPHDR_ETHER can start using ml_priv as well?
>
> > +#if IS_ENABLED(CONFIG_CAN)
> > + struct can_ml_priv *can;
> > +#endif
>
> Perhaps put it next to all the _ptr fields?
Makes sense. Oleksij will resping the series
lost.
To fix this problem the NO_FRAME interrupt is not enabled. At least in our
testcase with edge triggered interrupts link change events are now properly
detected.
Cc: Dan Murphy
Signed-off-by: Marc Kleine-Budde
---
drivers/net/phy/dp83tc811.c | 1 -
1 file changed, 1 deletion(-)
diff
On 1/22/21 4:03 PM, Marc Kleine-Budde wrote:
> In our setup the dp83tc811 is configure to master mode. When there is no slave
> connected the dp83tc811 triggers an interrupt is triggerd, several bits in the
> status registers are set, and te INT_N pin goes low. One of interrupt bits
phydev, LAN88XX_INT_STS);
> +
> + /* enable phy interrupt back */
> + temp = phy_read(phydev, LAN88XX_INT_MASK);
> + temp |= LAN88XX_INT_MASK_MDINTPIN_EN_;
> + ret = phy_write(phydev, LAN88XX_INT_MASK, temp);
> + }
> }
regards,
Marc
--
Pengut
1 - 100 of 1239 matches
Mail list logo