Re: [[RESEND]PATCH v7 0/2] Add CAN FD driver support to r8a7795 SoC

2016-06-17 Thread Marc Kleine-Budde
Marc K appears to be inactive and we haven't heard from him since March. I'll take the patch. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-555

Re: [PATCH can-next v2 0/2] CAN: rcar: add fallback and r8a779[234] bindings

2016-02-24 Thread Marc Kleine-Budde
aner consistent with that progressively being used > for drivers for other IP blocks used by Renesas SoCs. > > For changes since v1 see individial patch changelogs. > > Based on linux-can-next/master Applied to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Klein

Re: [PATCH can-next 1/2] CAN: rcar: add gen[12] fallback compatibility strings

2016-02-22 Thread Marc Kleine-Budde
You can add one that identifies your SoC's IP core in front of it. So there's no need to modify the driver until an IP core needs different handling. In your case you'd identify the oldest SoC that implements the Gen1 IP core and use this instead of "renesas,can-gen1. Same f

Re: [PATCH] can: ems_usb: Fix possible tx overflow

2016-02-22 Thread Marc Kleine-Budde
On 02/22/2016 01:11 PM, Sergei Shtylyov wrote: > Hello. > > On 2/21/2016 6:27 PM, Marc Kleine-Budde wrote: > >> From: Gerhard Uttenthaler <uttentha...@ems-wuensche.com> >> >> This patch fixes the problem that more CAN messages could be sent to the >>

pull-request: can-next 2016-02-26

2016-02-25 Thread Marc Kleine-Budde
Marc Kleine-Budde (1): can: ems_usb: fix coding style Simon Horman (2): can: rcar: add gen[12] fallback compatibility strings can: rcar: add device tree support for r8a779[234] Documentation/devicetree/bindings/net/can/rcar_can.txt | 11 ++- drivers/net/can

pull-request: can 2016-02-26

2016-02-25 Thread Marc Kleine-Budde
Hello David, this is a pull request of one patch for net. The patch by Maximilain Schneider fixes a kfree() problem during disconnect in the gs_usb driver. regrds, Marc --- The following changes since commit 4c0b6eaf373a5323f03a3a20c42fc435715b073d: net: thunderx: Fix for Qset error due to

[PATCH] can: gs_usb: fixed disconnect bug by removing erroneous use of kfree()

2016-02-25 Thread Marc Kleine-Budde
g when gs_destroy_candev() is called. Only the struct gs_usb * which is allocated through kzalloc() should be freed using kfree() when the device is disconnected. Signed-off-by: Maximilian Schneider <m...@schneidersoft.net> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde &l

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 11:00 AM, Marc Kleine-Budde wrote: > I think it's better to fix the algorithm. I'll look into it. What about: > ./can-calc-bit-timing -c 3998 rcar_can > > Bit timing parameters for rcar_can with 39.98 M

Re: [PATCH 0/2] Add CAN support to r8a7795 SoC

2016-02-29 Thread Marc Kleine-Budde
; arch/arm64/boot/dts/renesas/r8a7795.dtsi | 30 > ++ > drivers/net/can/Kconfig| 2 +- > drivers/net/can/rcar_can.c | 7 - > 4 files changed, 49 insertions(+), 2 deletions(-) > Marc -- Pengutronix e.K.

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 10:21 AM, Ramesh Shanmugasundaram wrote: > Added r8a7795 SoC support. > > For smoother bit timing calculation, the rounded clock frequency is used. Why this? From my point of view this introduces a clock error. Marc -- Pengutronix e.K. | Marc Kle

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
ll > bitrates. > > Below is an e.g. from my board for an input clock differs by 2Hz. I think it's better to fix the algorithm. I'll look into it. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 |

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 10:56 AM, Ramesh Shanmugasundaram wrote: > root@salvator-x:~# can-calc-bit-timing -c 3998 rcar_can Can you send me the patches to support the rcar_can. On the linux-can ML or github pull request. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Bu

Re: [PATCH v3] can: c_can: add xceiver enable/disable support

2016-01-21 Thread Marc Kleine-Budde
tree ML on Cc. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

Re: [PATCH v6 3/3] can: sja1000: of: add compatibility with Technologic Systems version

2016-01-21 Thread Marc Kleine-Budde
er. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc De

Re: [PATCH V3 5/5] net: can: ifi: Add IFI CANFD IP support

2016-01-20 Thread Marc Kleine-Budde
wrong though. >> >> /me too > > I think that will do the trick too. Do you want a V4 patch or will you fix it? I'll fix this. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/

Re: [PATCH v5 1/3] can: sja1000: of: add per-compatible init hook

2016-01-20 Thread Marc Kleine-Budde
{.compatible = "nxp,sja1000"}, > > has disappeared of sp_of_table in v5. Doh! This is of course broken. Wait for v6, please. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dor

[PATCH v6 2/3] can: sja1000: add documentation for Technologic Systems version

2016-01-20 Thread Marc Kleine-Budde
; Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- Documentation/devicetree/bindings/net/can/sja1000.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/can/sja1000.txt b/Documentation/devicetree/bindings/net/can/sja1000.txt

[PATCH v6 3/3] can: sja1000: of: add compatibility with Technologic Systems version

2016-01-20 Thread Marc Kleine-Budde
d/write base + 0x2: 8-bit register value This commit adds a new compatible device, "technologic,sja1000", with read and write functions using the window mechanism. Signed-off-by: Damien Riegel <damien.rie...@savoirfairelinux.com> Signed-off-by: Marc Kleine-Budde <m...@p

[PATCH v6 0/3] can: sja1000: support for technologic version

2016-01-20 Thread Marc Kleine-Budde
This is Damien Riegel's series with minor changes. regards, Marc --- This patchset introduces support for the technologic version of the SJA1000. Access to IP's registers are proxied through a window, requiring two bus accesses to read or write a register. These accesses must be protected by a

[PATCH v6 1/3] can: sja1000: of: add per-compatible init hook

2016-01-20 Thread Marc Kleine-Budde
e tree properties. Signed-off-by: Damien Riegel <damien.rie...@savoirfairelinux.com> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/sja1000/sja1000_platform.c | 40 +++--- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/drive

pull-request: can-next 2016-02-20

2016-02-20 Thread Marc Kleine-Budde
Damien Riegel (3): can: sja1000: of: add per-compatible init hook can: sja1000: add documentation for Technologic Systems version can: sja1000: of: add compatibility with Technologic Systems version Marc Kleine-Budde (1

[PATCH] can: ems_usb: Fix possible tx overflow

2016-02-21 Thread Marc Kleine-Budde
avy TX load this produced another bulk transfer without checking the free_slots variable and hence caused the overflow in the interface. Signed-off-by: Gerhard Uttenthaler <uttentha...@ems-wuensche.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde &l

pull-request: can 2016-02-21

2016-02-21 Thread Marc Kleine-Budde
Hello David, this is a pull reqeust of one patch for net/master. The patch is by Gerhard Uttenthaler and fixes a potential tx overflow in the ems_usb driver. regards, Marc --- The following changes since commit d07c0278da1f4cfc91c3d46d0d07a0d13a949892: net: bcmgenet: Fix internal PHY link

Re: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-01 Thread Marc Kleine-Budde
ller can use is 3584 > bytes. It is mentioned 10752 bytes in the manual. > > Signed-off-by: Ramesh Shanmugasundaram > <ramesh.shanmugasunda...@bp.renesas.com> Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Ph

pull-request: can-next 2016-03-10

2016-03-10 Thread Marc Kleine-Budde
(-) -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP

Re: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-15 Thread Marc Kleine-Budde
oved > check in rcar_canfd_start (as suggested by Oliver H) > (Refer: http://comments.gmane.org/gmane.linux.can/9126 & > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg01867.html) > * Clubbed Renesas controller drivers to driver/net/

Re: [PATCH] can: mcp251x: Replace create_freezable_workqueue with alloc_workqueue

2016-04-11 Thread Marc Kleine-Budde
t; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> > Acked-by: Tejun Heo <t...@kernel.org> Applied to can-next/master. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Ver

pull-request: can 2016-03-04

2016-03-03 Thread Marc Kleine-Budde
Hello David, this is a pull request for net/master. There is one patch from Ed Spiridonov, which increases the performance of the mcp251x SPI CAN driver, by avoiding to write to error flag register if it's unnecessary. regards, Marc --- The following changes since commit

[PATCH] can: mcp251x: avoid write to error flag register if it's unnecessary

2016-03-03 Thread Marc Kleine-Budde
From: Ed Spiridonov <edo@gmail.com> Only two bits (RX0OVR and RX1OVR) are writable in EFLG, write is useless if these bits aren't set. Signed-off-by: Ed Spiridonov <edo@gmail.com> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/spi/mcp251

Re: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-02 Thread Marc Kleine-Budde
networking subsystem may send one frame to each controller at the same time. > However, looking at it again, I should move the incrementing of head > after the "sts" handing to be apt. What do you think? With one producer (one SW instance) and one consumer (the HW) you can write

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-07 Thread Marc Kleine-Budde
eck? >> >> A CAN FD capable CAN controller can be either configured to run as CAN 2.0 >> (Classic CAN) or as CAN FD controller. >> >> So why are to throwing an error here and produce an initialization >> failure? > > When this controller is configured in F

Re: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-02 Thread Marc Kleine-Budde
Ok - I haven't looked at the code in depth yet. Now it's clear, that just the tx interrupt is shared. > Sorry if I am annoying. I have tested this with two channels > transmitting & receiving at the same time and it works fine. If I am > missing lock, I would like to understand it thoroughly

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-04-01 Thread Marc Kleine-Budde
On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote: > This patch adds support for the CAN FD controller found in Renesas R-Car > SoCs. The controller operates in CAN FD mode by default. > > CAN FD mode supports both Classical CAN & CAN FD frame formats. The > controller supports ISO

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-09 Thread Marc Kleine-Budde
* prevent tx timeout */ > - netdev->trans_start = jiffies; > + netif_trans_update(netdev); > break; > > default: > @@ -373,7 +373,7 @@ static netdev_tx_t peak_usb_ndo_start_xmit(struct sk_buff > *skb, > s

pull-request: can-next 2016-05-09

2016-05-09 Thread Marc Kleine-Budde
.c | 6 +- drivers/net/can/spi/mcp251x.c | 3 +- drivers/net/can/usb/gs_usb.c | 3 +- include/linux/can/dev.h | 22 +++- 9 files changed, 367 insertions(+), 80 deletions(-) -- Pengutronix e.K. | Marc Kleine-Budde | Industrial

Re: linux-next: manual merge of the akpm tree with the net-next tree

2017-02-07 Thread Marc Kleine-Budde
^^^ Should be "Disable". I'll send David Miller a fix for the typo. > +#define FLEXCAN_QUIRK_USE_OFF_TIMESTAMP BIT(5) /* Use timestamp based > offloading */ > > /* Structure of the message buffer */ > struct flexcan_mb { Marc -- Pengutr

pull-request: can-next 2017-02-06

2017-02-06 Thread Marc Kleine-Budde
David Jander (1): can: rx-offload: Add support for HW fifo based irq offloading Marc Kleine-Budde (15): can: rx-offload: Add support for timestamp based irq offloading can: flexcan: add missing register definitions can: flexcan: remove write-only member pdata

Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06

2017-02-06 Thread Marc Kleine-Budde
On 02/06/2017 05:12 PM, David Miller wrote: > From: Marc Kleine-Budde <m...@pengutronix.de> > Date: Mon, 6 Feb 2017 15:50:48 +0100 > >> this is a pull request of 16 patches for net-next/master. >> >> The first two patches by David Jander and me add the rx-off

[PATCH] can: bcm: fix hrtimer/tasklet termination in bcm op removal

2017-01-30 Thread Marc Kleine-Budde
el.josenh...@web.de> Signed-off-by: Oliver Hartkopp <socket...@hartkopp.net> Tested-by: Michael Josenhans <michael.josenh...@web.de> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- net/can/bcm.c | 23 ---

pull-request: can 2017-01-30

2017-01-30 Thread Marc Kleine-Budde
Hello David, this is a pull request of one patch. The patch is by Oliver Hartkopp and fixes the hrtimer/tasklet termination in bcm op removal. regards, Marc --- The following changes since commit d1156b489fa734d1af763d6a07b1637c01bb0aed: net: adaptec: starfire: add checks for dma mapping

Re: pull-request: can 2017-01-27

2017-01-30 Thread Marc Kleine-Budde
On 01/30/2017 12:46 AM, David Miller wrote: > From: Marc Kleine-Budde <m...@pengutronix.de> > Date: Fri, 27 Jan 2017 21:46:26 +0100 > >> this is a pull request for net/master. >> >> It consists of a single patch by Eric Dumazet, it fixes a kernel panic at >&

pull-request: can-next 2017-01-24

2017-01-27 Thread Marc Kleine-Budde
and -ENODEV return Marc Kleine-Budde (2): can: dev: can_changelink: allow to set bitrate on devices not providing {data_,}bittiming_const can: dev: add CAN interface API for fixed bitrates Oliver Hartkopp (1): can: dev: add CAN interface termination API drivers/net/can/dev.c

pull-request: can 2017-01-27

2017-01-27 Thread Marc Kleine-Budde
Hello David, this is a pull request for net/master. It consists of a single patch by Eric Dumazet, it fixes a kernel panic at security_sock_rcv_skb. regards, Marc --- The following changes since commit 950eabbd6ddedc1b08350b9169a6a51b130ebaaf: ISDN: eicon: silence misleading array-bounds

[PATCH] can: Fix kernel panic at security_sock_rcv_skb

2017-01-27 Thread Marc Kleine-Budde
/0x6f0 [] ? rescuer_thread+0x480/0x480 [] kthread+0x12c/0x150 [] ret_from_fork+0x3f/0x70 Reported-by: Zhang Yanmin <yanmin.zh...@intel.com> Signed-off-by: Eric Dumazet <eduma...@google.com> Acked-by: Oliver Hartkopp <socket...@hartkopp.net> Cc: linux-stable <sta...@vger.kernel.org&

Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

2017-02-20 Thread Marc Kleine-Budde
<< BTR_TSEG2_SHIFT); > + > + if (m_can_read_core_rev(priv) < M_CAN_COREREL_3_1_0) > + reg_btp = (brp << BTR_BRP_SHIFT) | (sjw << BTR_SJW_SHIFT) | > + (tseg1 << BTR_TSEG1_SHIFT) | > + (ts

Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

2017-02-20 Thread Marc Kleine-Budde
an incomplete fix for only one change of eleven. > Well, having something working right now is still better that nothing. I > think it is worth having that patch now so CAN is working on our > platforms. > > Everything else can probably be built on top of it anyway. Marc -- Peng

Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06,Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06

2017-02-09 Thread Marc Kleine-Budde
offload, i, offload->mb_last); >can_rx_offload_inc(offload, )) { So we never wrap around. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsge

Re: [PATCH] can: ti_hecc: add missing prepare and unprepare of the clock

2017-01-18 Thread Marc Kleine-Budde
_hecc_priv *priv = netdev_priv(dev); > > - clk_enable(priv->clk); > + clk_prepare_enable(priv->clk); > > hecc_clear_bit(priv, HECC_CANMC, HECC_CANMC_PDR); > priv->can.state = CAN_STATE_ERROR_ACTIVE; > -- Pengutronix e.K.

Re: [PATCH v2] can: ti_hecc: add missing prepare and unprepare of the clock

2017-01-18 Thread Marc Kleine-Budde
pare(). > > Also add error checking for clk_prepare_enable(). > > Signed-off-by: Yegor Yefremov <yegorsli...@googlemail.com> > --- > Changes v1 -> v2: > - add error checking for clk_prepare_enable (Marc Kleine-Budde) > > drivers/net/can/ti_hecc.c

[PATCH 1/2] can: c_can_pci: fix null-pointer-deref in c_can_start() - set device pointer

2017-01-18 Thread Marc Kleine-Budde
lso cause the pm_runtime_*() functions in c_can.c to actually be executed for c_can_pci devices - they are the only other place where priv->device is used, but they all contain a null check. Signed-off-by: Einar Jón <tolvupos...@gmail.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-o

[PATCH 2/2] can: ti_hecc: add missing prepare and unprepare of the clock

2017-01-18 Thread Marc Kleine-Budde
fremov <yegorsli...@googlemail.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/ti_hecc.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/ti_hecc.c b/d

pull-request: can 2017-01-18

2017-01-18 Thread Marc Kleine-Budde
Hello David, this is a pull request for net/master consisting of two patches. In the first patch Einar Jón fixes a NULL-pointer-deref in the c_can_pci driver. In the second patch Yegor Yefremov fixes the clock handling in the ti_hecc driver. regards, Marc --- The following changes since

Re: [PATCH] softingcs: ret is never non-zero, so remove non-zero check and -ENODEV return

2017-01-18 Thread Marc Kleine-Budde
. Remove it and just > return ret. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied to can-next. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West

pull-request: can 2016-09-21

2016-09-21 Thread Marc Kleine-Budde
Hello David, this is another pull request of one patch for the upcoming linux-4.8 release. Marek Vasut fixes the CAN-FD bit rate switch in the ifi driver by configuring the transmitter delay. regards, Marc --- The following changes since commit b5036cd4ed3173ab8cdbc85e2ba74acf46bafb51:

[PATCH] net: can: ifi: Configure transmitter delay

2016-09-21 Thread Marc Kleine-Budde
ed-off-by: Marek Vasut <ma...@denx.de> Cc: Marc Kleine-Budde <m...@pengutronix.de> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Oliver Hartkopp <socket...@hartkopp.net> Cc: Wolfgang Grandegger <w...@grandegger.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-

pull-request: can 2016-09-19

2016-09-19 Thread Marc Kleine-Budde
Hello David, this is a pull request of one patch for the upcoming linux-4.8 release. The patch by Fabio Estevam fixes the pm handling in the flexcan driver. regards, Marc --- The following changes since commit 7ac327318e09a53e3df431dfd3f664dac7aba4df: Merge tag

[PATCH] can: flexcan: fix resume function

2016-09-19 Thread Marc Kleine-Budde
Fabio Estevam <fabio.este...@nxp.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/flexcan.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/flexcan.c b/drivers

pull-request: can 2016-09-22

2016-09-22 Thread Marc Kleine-Budde
Hello David, this is a pull request of one patch for the upcoming linux-4.8 release. The patch by Sergei Miroshnichenko fixes a potential deadlock in the generic CAN device code that cann occour after a bus-off. regards, Marc --- The following changes since commit

[PATCH] can: dev: fix deadlock reported after bus-off

2016-09-22 Thread Marc Kleine-Budde
lt;sergei...@emcraft.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/dev.c | 27 +-- include/linux/can/dev.h | 3 ++- 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-27 Thread Marc Kleine-Budde
nt we need to call proc_create_data() once per socket, >> so we need a check before proc_create_data() too. > > Hmm, bo->bound should guarantee it, so never mind, your patch > looks fine. Can I add your Acked-by? Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-27 Thread Marc Kleine-Budde
with stable on Cc. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

pull-request: can 2016-11-23

2016-11-23 Thread Marc Kleine-Budde
Hello David, this is a pull request for net/master. The patch by Oliver Hartkopp for the broadcast manager (bcm) fixes the CAN-FD support, which may cause an out-of-bounds access otherwise. regards, Marc --- The following changes since commit c9b8af1330198ae241cd545e1f040019010d44d9:

[PATCH] can: bcm: fix support for CAN FD frames

2016-11-23 Thread Marc Kleine-Budde
et> Tested-by: Andrey Konovalov <andreyk...@google.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- net/can/bcm.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm

Re: [PATCH] can: bcm: fix support for CAN FD frames

2016-11-23 Thread Marc Kleine-Budde
.@google.com> > Signed-off-by: Oliver Hartkopp <socket...@hartkopp.net> Added to can and send a pull request to David. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/

Re: [PATCH v2 0/2] can: Add r8a7796 support to CAN/CAN FD

2016-11-24 Thread Marc Kleine-Budde
anges. > - Rebased on renesas-devel-20161123v2-v4.9-rc6. > > > Chris Paterson (2): > can: rcar_can: Add r8a7796 support > can: rcar_canfd: Add r8a7796 support Both added to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial

pull-request: can 2016-10-31

2016-10-31 Thread Marc Kleine-Budde
Hello David, this is a pull request of two patches for the upcoming v4.9 release. The first patch is by Lukas Resch for the sja1000 plx_pci driver that adds support for Moxa CAN devices. The second patch is by Oliver Hartkopp and fixes a potential kernel panic in the CAN broadcast manager.

[PATCH 2/2] can: bcm: fix warning in bcm_connect/proc_register

2016-10-31 Thread Marc Kleine-Budde
google.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- net/can/bcm.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index 8e999ffdf28b..8af9d25ff98

[PATCH 1/2] can: sja1000: plx_pci: Add support for Moxa CAN devices

2016-10-31 Thread Marc Kleine-Budde
From: Lukas Resch <l.re...@incubedit.com> This patch adds support for Moxa CAN devices. Signed-off-by: Lukas Resch <l.re...@incubedit.com> Signed-off-by: Christoph Zehentner <c.zehent...@incubedit.com> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/n

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-28 Thread Marc Kleine-Budde
On 10/27/2016 06:28 PM, Cong Wang wrote: >>> Hmm, bo->bound should guarantee it, so never mind, your patch >>> looks fine. >> >> Can I add your Acked-by? > > Of course. > > Acked-by: Cong Wang <xiyou.wangc...@gmail.com> Thanks, Marc -- Pe

pull-request: can 2016-12-08

2016-12-08 Thread Marc Kleine-Budde
Hello David, this is a pull request for one patch. Jiho Chu found and fixed a use-after-free error in the cleanup path in the peak pcan USB CAN driver. regards, Marc --- The following changes since commit ec988ad78ed6d184a7f4ca6b8e962b0e8f1de461: phy: Don't increment MDIO bus refcount

[PATCH] can: peak: fix bad memory access and free sequence

2016-12-08 Thread Marc Kleine-Budde
g.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/driv

[PATCH] can: raw: raw_setsockopt: limit number of can_filter that can be set

2016-12-07 Thread Marc Kleine-Budde
t; Tested-by: Andrey Konovalov <andreyk...@google.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- include/uapi/linux/can.h | 1 + net/can/raw.c| 3 +++ 2 files changed, 4 insertions(+) diff --git a/include/uapi

pull-request: can 2016-12-07

2016-12-07 Thread Marc Kleine-Budde
(2016-12-07 10:45:57 +0100) linux-can-fixes-for-4.9-20161207 Marc Kleine-Budde (1): can: raw: raw_setsockopt: limit number of can_filter that can be set include

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

2016-12-15 Thread Marc Kleine-Budde
Acked-by: Marc Kleine-Budde <m...@pengutronix.de> regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht H

Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath

2016-12-02 Thread Marc Kleine-Budde
unt > 1) { > /* filter does not fit into dfilter => alloc space */ > filter = memdup_user(optval, optlen); > if (IS_ERR(filter)) > return PTR_ERR(filter); > } else if (count == 1) { >

Re: [PATCH] can: rcar_canfd: Correct order of interrupt specifiers

2016-12-01 Thread Marc Kleine-Budde
d-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Added to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht

Re: [PATCH net-next] net: can: usb: kvaser_usb: fix spelling mistake of "outstanding"

2016-12-01 Thread Marc Kleine-Budde
anonical.com> Added to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengut

pull-request: can-next 2016-12-01

2016-12-01 Thread Marc Kleine-Budde
drivers/net/can/usb/kvaser_usb.c | 4 ++-- 3 files changed, 17 insertions(+), 13 deletions(-) -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax:

[PATCH 2/2] can: peak: Add support for PCAN-USB X6 USB interface

2016-12-02 Thread Marc Kleine-Budde
d-by: Oliver Hartkopp <socket...@hartkopp.net> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 2 + drivers/net/can/usb/peak_usb/pcan_usb_core.h | 2 + drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 72 +

[PATCH 1/2] can: peak: Fix bittiming fields size in bits

2016-12-02 Thread Marc Kleine-Budde
34 data SJW 24 Note that this has no other consequences than offering larger choice to bitrate encoding. Signed-off-by: Stephane Grosjean <s.grosj...@peak-system.com> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/pe

pull-request: can 2016-12-02

2016-12-02 Thread Marc Kleine-Budde
Hello David, this is a pull request for net/master. THere are two patches by Stephane Grosjean, who adds support for the new PCAN-USB X6 USB interface to the pcan_usb driver. regards, Marc --- The following changes since commit aa196eed3d80d4b003b04a270712b978a012a939: macvtap: handle ubuf

Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath

2016-12-05 Thread Marc Kleine-Budde
On 12/02/2016 06:05 PM, Oliver Hartkopp wrote: > > > On 12/02/2016 04:42 PM, Marc Kleine-Budde wrote: >> On 12/02/2016 04:11 PM, Oliver Hartkopp wrote: >>> >>> >>> On 12/02/2016 02:24 PM, Marc Kleine-Budde wrote: >>&

Re: [PATCH 18/39] Annotate hardware config module parameters in drivers/net/can/

2016-12-01 Thread Marc Kleine-Budde
; Suggested-by: One Thousand Gnomes <gno...@lxorguk.ukuu.org.uk> > Signed-off-by: David Howells <dhowe...@redhat.com> > cc: Wolfgang Grandegger <w...@grandegger.com> > cc: Marc Kleine-Budde <m...@pengutronix.de> > cc: linux-...@vger.kernel.org > cc: netdev@

Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath

2016-12-02 Thread Marc Kleine-Budde
On 12/02/2016 04:11 PM, Oliver Hartkopp wrote: > > > On 12/02/2016 02:24 PM, Marc Kleine-Budde wrote: >> On 12/02/2016 01:43 PM, Andrey Konovalov wrote: > > >>> [] raw_setsockopt+0x1be/0x9f0 net/can/raw.c:506 >> >> We should add a check f

Re: [PATCH 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-01-03 Thread Marc Kleine-Budde
(PAGE_SIZE / 2)); > + } else { > + /* Fall back to non-DMA */ > + hi3110_enable_dma = 0; > + } > + } > + > + /* Allocate non-DMA buffers */ > + if (!hi3110_enable

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-04-04 Thread Marc Kleine-Budde
uct net_device *net) > > return 0; > > -out_free_irq: > + out_free_wq: > + destroy_workqueue(priv->wq); > + out_free_irq: > free_irq(spi->irq, priv); > hi3110_hw_sleep(spi); > - > -out_close: > + out_close: >

pull-request: can-next 2017-03-03

2017-04-04 Thread Marc Kleine-Budde
/linux/can/platform/ti_hecc.h create mode 100644 include/net/netns/can.h -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 26

pull-request: can 2017-04-04

2017-04-04 Thread Marc Kleine-Budde
Hello David, this is a pull request of two patches for net/master. The first patch by Markus Marb fixes a register read access in the ifi driver. The second patch by Geert Uytterhoeven for the rcar driver remove the printing of a kernel virtual address. regards, Marc --- The following changes

[PATCH 2/2] can: rcar_can: Do not print virtual addresses

2017-04-04 Thread Marc Kleine-Budde
physical address is already printed as part of the device name. Fixes: fd1159318e55e901 ("can: add Renesas R-Car CAN driver") Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Marc Kleine-Budde

[PATCH 1/2] can: ifi: use correct register to read rx status

2017-04-04 Thread Marc Kleine-Budde
From: Markus Marb <mar...@marb.org> The incorrect offset was used when trying to read the RXSTCMD register. Signed-off-by: Markus Marb <mar...@marb.org> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/i

Re: [PATCH] can: rcar_can: Do not print virtual addresses

2017-04-04 Thread Marc Kleine-Budde
g it. The (useful) physical address is already > printed as part of the device name. > > Fixes: fd1159318e55e901 ("can: add Renesas R-Car CAN driver") > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Thanks, applied and included in pull request. Mar -

Re: pull-request: can 2017-04-04

2017-04-07 Thread Marc Kleine-Budde
On 04/05/2017 07:37 PM, David Miller wrote: > From: Marc Kleine-Budde <m...@pengutronix.de> > Date: Tue, 4 Apr 2017 17:59:47 +0200 > >> this is a pull request of two patches for net/master. > ... >> The following changes since commit 0b9aefea860063bb39e36bd

Re: [PATCH 18/38] Annotate hardware config module parameters in drivers/net/can/

2017-04-14 Thread Marc Kleine-Budde
t; Suggested-by: Alan Cox <gno...@lxorguk.ukuu.org.uk> > Signed-off-by: David Howells <dhowe...@redhat.com> > Acked-by: Marc Kleine-Budde <m...@pengutronix.de> > cc: Wolfgang Grandegger <w...@grandegger.com> > cc: linux-...@vger.kernel.org > cc: netdev@vger.ker

Re: [PATCH] net: can: Introduce MEN 16Z192-00 CAN controller driver

2017-04-14 Thread Marc Kleine-Budde
; > + void __iomem *dev_base; > + struct resource *mem; > + u32 timebase; > + int ret = 0; > + int irq; > + > + mem = mcb_request_mem(mdev, dev_name(dev)); > + if (IS_ERR(mem)) { > + dev_err(dev, "failed to reque

Re: [PATCH v2] can: m_can: enable transmission of FD frame on latest version

2017-03-06 Thread Marc Kleine-Budde
silicon? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Descr

[PATCH 3/4] can: usb_8dev: Fix memory leak of priv->cmd_msg_buffer

2017-03-03 Thread Marc Kleine-Budde
The priv->cmd_msg_buffer is allocated in the probe function, but never kfree()ed. This patch converts the kzalloc() to resource-managed kzalloc. Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/usb_8dev.c |

[PATCH 2/4] can: gs_usb: fix coding style

2017-03-03 Thread Marc Kleine-Budde
From: Ethan Zonca <e...@ethanzonca.com> This patch fixes five minor style issues, spaces are between bitwise OR operators. Signed-off-by: Ethan Zonca <e...@ethanzonca.com> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/gs_usb.c | 11 +--

pull-request: can 2017-03-03

2017-03-03 Thread Marc Kleine-Budde
-20170303 Ethan Zonca (2): can: gs_usb: Don't use stack memory for USB transfers can: gs_usb: fix coding style Marc Kleine-Budde (2): can: usb_8dev: Fix memory leak of priv->cmd_msg_buffer can: flexcan: fix t

[PATCH 4/4] can: flexcan: fix typo in comment

2017-03-03 Thread Marc Kleine-Budde
This patch fixes the typo "Disble" -> "Disable". Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index ea57

[PATCH 1/4] can: gs_usb: Don't use stack memory for USB transfers

2017-03-03 Thread Marc Kleine-Budde
locate memory for the transfer buffers. Signed-off-by: Ethan Zonca <e...@ethanzonca.com> Cc: linux-stable <sta...@vger.kernel.org> # >= v4.8 Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/gs_usb.c | 40 +--- 1

<    1   2   3   4   5   >