Re: [PATCH] can: don't count arbitration lose as an error

2020-11-27 Thread Marc Kleine-Budde
kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/?h=sja1000 regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hil

Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-28 Thread Marc Kleine-Budde
On 11/27/20 5:27 PM, Jakub Kicinski wrote: > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote: >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. >>> These are simple defines so they co

Re: [PATCH v5 8/8] can-dev: add len8_dlc support for various CAN USB adapters

2020-11-09 Thread Marc Kleine-Budde
; > if (cf->can_id & CAN_EFF_FLAG) > msg->flags |= USB_8DEV_EXTID; > > msg->id = cpu_to_be32(cf->can_id & CAN_ERR_MASK); > - msg->dlc = cf->len; > + msg->dlc = can_get_cc_dlc(priv->can.ctrlmode, cf-&

Re: [PATCH v5 8/8] can-dev: add len8_dlc support for various CAN USB adapters

2020-11-09 Thread Marc Kleine-Budde
es a canfd_frame, so that we don't need to >> cast > > No. The len8_dlc element is from struct can_frame. When people use the > struct canfd_frame in their driver this might have some benefits for them. > But when it comes to access the len8_dlc element this

Re: [PATCH v6 7/8] can-dev: introduce helpers to access Classical CAN DLC values

2020-11-10 Thread Marc Kleine-Budde
c; > +} > + > /* helper to define static CAN controller features at device creation time */ > static inline void can_set_static_ctrlmode(struct net_device *dev, > u32 static_mode) > { > struct can_priv *priv = netdev_priv(dev); > Marc --

pull-request: can 2020-11-11

2020-11-11 Thread Marc Kleine-Budde
Hello, after v5.10-rc1 the flexcan bindings were converted to yaml. This causes several unneeded regressions on i.MX53 based boards and/or SoC specifying the fsl,stop-mode property in their flexcan node. This series fixes these problems by first updating the affected i.MX SoC dtsi files and then

[net v2 4/4] dt-bindings: can: fsl,flexcan.yaml: fix fsl,stop-mode

2020-11-11 Thread Marc Kleine-Budde
-mode: [[1, 52, 28]] is too short From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml Cc: Oleksij Rempel Cc: devicet...@vger.kernel.org Reported-by: Rob Herring Fixes: e5ab9aa7e49b ("dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml") Signed

[net v2 1/4] ARM: dts: imx: fix can fsl,stop-mode

2020-11-11 Thread Marc Kleine-Budde
boot/dts/imx6dl-apf6dev.dt.yaml: flexcan@209: fsl,stop-mode:0: [1, 52, 28, 16, 17] is too long From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml This patch fixes the error by removing the obsolete values. Cc: Shawn Guo Cc: devicet...@vger.kernel.org Signed-off-by: Ma

[net v2 2/4] ARM: dts: imx: Change flexcan node name to "can"

2020-11-11 Thread Marc Kleine-Budde
excan@209' does not match '^can(@.*)?$' From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml Cc: Shawn Guo Cc: devicet...@vger.kernel.org Signed-off-by: Marc Kleine-Budde --- arch/arm/boot/dts/imx6qdl.dtsi | 4 ++-- arch/arm/boot/dts/imx6ul.dtsi | 4 ++--

[net v2 3/4] dt-bindings: can: fsl,flexcan.yaml: fix compatible for i.MX35 and i.MX53

2020-11-11 Thread Marc Kleine-Budde
can' was expected 'fsl,lx2160ar1-flexcan' was expected From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml Cc: Oleksij Rempel Cc: devicet...@vger.kernel.org Reported-by: Rob Herring Fixes: e5ab9aa7e49b ("dt-bindings: can: flexcan: convert fsl,*

Re: [PATCH v3 2/2] dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml

2020-11-11 Thread Marc Kleine-Budde
t;> Link: >> https://lore.kernel.org/r/20201016073315.16232-3-o.rem...@pengutronix.de >> Signed-off-by: Marc Kleine-Budde >> --- >> .../bindings/net/can/fsl,flexcan.yaml | 135 ++ >> .../bindings/net/can/fsl-flexcan.txt | 57 >&g

Re: [PATCH v8] can-dev: add len8_dlc support for various CAN adapters

2020-11-11 Thread Marc Kleine-Budde
Signed-off-by: Oliver Hartkopp > Tested-by: Oliver Hartkopp > Link: https://lore.kernel.org/r/20201110101852.1973-9-socket...@hartkopp.net > Signed-off-by: Marc Kleine-Budde I've pushed the changes to linux-can-next/testing. Marc -- Pengutronix e.K. |

Re: pull-request: can 2020-11-11

2020-11-11 Thread Marc Kleine-Budde
flexcan.yaml > > Either the imx5-clock.yaml example needs changing or the schema does. > I'm guessing it's the former. Ack. I've created a patch to fix this: http://lore.kernel.org/r/2020213548.1621094-1-...@pengutronix.de > I've applied the 2 schema

Re: [PATCH v2] can: flexcan: fix reference count leak in flexcan ops

2020-11-11 Thread Marc Kleine-Budde
time_put_noidle. > > Fixes: ca10989632d88 ("can: flexcan: implement can Runtime PM") > Signed-off-by: Zhang Qilong > --- > Changelog: > v2 > - removed empty lines between tags. > --- Applied to linux-can/testing. Tnx, Marc -- Pengutronix e.K.

Re: [PATCH v2] can: m_can: Set device to software init mode before closing

2020-11-11 Thread Marc Kleine-Budde
move the device to init state before potentially > powering it down. > > Signed-off-by: Faiz Abbas Added to linux-can/testing. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung We

Re: [PATCH] can: ti_hecc: Fix memleak in ti_hecc_probe

2020-11-14 Thread Marc Kleine-Budde
x-can/testing. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |

pull-request: can 2020-11-14

2020-11-14 Thread Marc Kleine-Budde
SPI with depends on SPI Faiz Abbas (1): can: m_can: m_can_stop(): set device to software init mode before closing Marc Kleine-Budde (4): can: mcba_usb: mcba_usb_start_xmit(): first fill skb, then pass to can_put_echo_skb() can: flexcan: flexcan_setup_stop_mode(): add missing

[net 10/15] can: tcan4x5x: tcan4x5x_can_probe(): add missing error checking for devm_regmap_init()

2020-11-14 Thread Marc Kleine-Budde
This patch adds the missing error checking when initializing the regmap interface fails. Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel") Cc: Dan Murphy Link: http://lore.kernel.org/r/20201019154233.1262589-7-...@pengutronix.de Signed-off-by: Marc Kl

[net 08/15] can: flexcan: fix failure handling of pm_runtime_get_sync()

2020-11-14 Thread Marc Kleine-Budde
excan: implement can Runtime PM") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20201108083000.2599705-1-zhangqilo...@huawei.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/can

[net 11/15] can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration

2020-11-14 Thread Marc Kleine-Budde
1262589-10-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c index f058bd9104e9..4fdb7121403a 100644 --- a/drivers/net

[net 07/15] can: flexcan: flexcan_setup_stop_mode(): add missing "req_bit" to stop mode property comment

2020-11-14 Thread Marc Kleine-Budde
it. Fixes: d9b081e3fc4b ("can: flexcan: remove ack_grp and ack_bit handling from driver") Reported-by: Joakim Zhang Link: http://lore.kernel.org/r/20201014114810.2911135-1-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 i

[net 12/15] can: m_can: m_can_handle_state_change(): fix state change

2020-11-14 Thread Marc Kleine-Budde
CAN_STATE_ERROR_WARNING. Signed-off-by: Wu Bo Link: http://lore.kernel.org/r/20200129022330.21248-2-wubo.o...@gmail.com Cc: Dan Murphy Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 4 ++-- 1 file

[net 13/15] can: m_can: m_can_class_free_dev(): introduce new function

2020-11-14 Thread Marc Kleine-Budde
From: Dan Murphy This patch creates a common function that peripherials can call to free the netdev device when failures occur. Fixes: d42f4e1d06d9 ("can: m_can: Create a m_can platform framework") Reported-by: Marc Kleine-Budde Signed-off-by: Dan Murphy Link: http://lore.ke

[net 05/15] can: mcba_usb: mcba_usb_start_xmit(): first fill skb, then pass to can_put_echo_skb()

2020-11-14 Thread Marc Kleine-Budde
ink: https://lore.kernel.org/r/2020221204.1639007-1-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/mcba_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c index 58

[net 02/15] can: af_can: prevent potential access of uninitialized member in canfd_rcv()

2020-11-14 Thread Marc Kleine-Budde
: replace WARN_ONCE by pr_warn_once") Reported-by: syzbot+9bcb0c9409066696d...@syzkaller.appspotmail.com Tested-by: Anant Thazhemadam Signed-off-by: Anant Thazhemadam Link: https://lore.kernel.org/r/20201103213906.24219-3-anant.thazhema...@gmail.com Signed-off-by: Marc Kleine-Budde --- net/can/

[net 14/15] can: m_can: Fix freeing of can device from peripherials

2020-11-14 Thread Marc Kleine-Budde
From: Dan Murphy Fix leaking netdev device from peripherial devices. The call to allocate the netdev device is made from and managed by the peripherial. Fixes: d42f4e1d06d9 ("can: m_can: Create a m_can platform framework") Reported-by: Marc Kleine-Budde Signed-off-by: Dan Murphy

[net 04/15] can: ti_hecc: Fix memleak in ti_hecc_probe

2020-11-14 Thread Marc Kleine-Budde
-zhangqilo...@huawei.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/ti_hecc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c index 9913f5458279..2c22f40e12bd 100644 --- a/drivers/net/can/ti_hecc.c +++ b/d

[net 09/15] can: tcan4x5x: replace depends on REGMAP_SPI with depends on SPI

2020-11-14 Thread Marc Kleine-Budde
) Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig index 48be627c85c2..5f9f8192dd0b 100644 --- a/drivers/net/can/m_can/Kconfig +++ b/drivers/net/ca

[net 15/15] can: m_can: m_can_stop(): set device to software init mode before closing

2020-11-14 Thread Marc Kleine-Budde
powering it down. Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support") Signed-off-by: Faiz Abbas Acked-by: Dan Murphy Link: https://lore.kernel.org/r/20200825055442.16994-1-faiz_ab...@ti.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 3 +

[net 01/15] can: af_can: prevent potential access of uninitialized member in can_rcv()

2020-11-14 Thread Marc Kleine-Budde
_ONCE by pr_warn_once") Reported-by: syzbot+9bcb0c9409066696d...@syzkaller.appspotmail.com Tested-by: Anant Thazhemadam Signed-off-by: Anant Thazhemadam Link: https://lore.kernel.org/r/20201103213906.24219-2-anant.thazhema...@gmail.com Signed-off-by: Marc Kleine-Budde --- net/can/af_can.c

[net 06/15] can: peak_usb: fix potential integer overflow on shift of a int

2020-11-14 Thread Marc Kleine-Budde
macro instead. Fixes: bb4785551f64 ("can: usb: PEAK-System Technik USB adapters driver core") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20201105112427.40688-1-colin.k...@canonical.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb_core.c

[net 03/15] can: dev: can_restart(): post buffer from the right context

2020-11-14 Thread Marc Kleine-Budde
river and Netlink interface") Co-developed-by: Loris Fauster Signed-off-by: Loris Fauster Signed-off-by: Alejandro Concepcion Rodriguez Link: https://lore.kernel.org/r/4e84162b-fb31-3a73-fa9a-9438b4bd5...@acoro.eu [mkl: use netif_rx_ni() instead of netif_rx_any_context()] Signed-off-by: Marc Kl

Re: pull-request: can 2020-11-14

2020-11-15 Thread Marc Kleine-Budde
roduce new > function") > Fixes tag: Fixes: d42f4e1d06d9 ("can: m_can: Create a m_can platform > framework") > Has these problem(s): > - Target SHA1 does not exist regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde |

pull-request: can 2020-11-15

2020-11-15 Thread Marc Kleine-Budde
replace depends on REGMAP_SPI with depends on SPI Faiz Abbas (1): can: m_can: m_can_stop(): set device to software init mode before closing Marc Kleine-Budde (4): can: mcba_usb: mcba_usb_start_xmit(): first fill skb, then pass to can_put_echo_skb() can: flexcan: flexcan_setu

[net 14/15] can: m_can: Fix freeing of can device from peripherials

2020-11-15 Thread Marc Kleine-Budde
From: Dan Murphy Fix leaking netdev device from peripherial devices. The call to allocate the netdev device is made from and managed by the peripherial. Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Reported-by: Marc Kleine-Budde Signed-off-by: Dan Murphy

[net 09/15] can: tcan4x5x: replace depends on REGMAP_SPI with depends on SPI

2020-11-15 Thread Marc Kleine-Budde
) Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig index 48be627c85c2..5f9f8192dd0b 100644 --- a/drivers/net/can/m_can/Kconfig +++ b/drivers/net/ca

[net 08/15] can: flexcan: fix failure handling of pm_runtime_get_sync()

2020-11-15 Thread Marc Kleine-Budde
excan: implement can Runtime PM") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20201108083000.2599705-1-zhangqilo...@huawei.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/can

[net 03/15] can: dev: can_restart(): post buffer from the right context

2020-11-15 Thread Marc Kleine-Budde
river and Netlink interface") Co-developed-by: Loris Fauster Signed-off-by: Loris Fauster Signed-off-by: Alejandro Concepcion Rodriguez Link: https://lore.kernel.org/r/4e84162b-fb31-3a73-fa9a-9438b4bd5...@acoro.eu [mkl: use netif_rx_ni() instead of netif_rx_any_context()] Signed-off-by: Marc Kl

[net 10/15] can: tcan4x5x: tcan4x5x_can_probe(): add missing error checking for devm_regmap_init()

2020-11-15 Thread Marc Kleine-Budde
This patch adds the missing error checking when initializing the regmap interface fails. Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel") Cc: Dan Murphy Link: http://lore.kernel.org/r/20201019154233.1262589-7-...@pengutronix.de Signed-off-by: Marc Kl

[net 02/15] can: af_can: prevent potential access of uninitialized member in canfd_rcv()

2020-11-15 Thread Marc Kleine-Budde
: replace WARN_ONCE by pr_warn_once") Reported-by: syzbot+9bcb0c9409066696d...@syzkaller.appspotmail.com Tested-by: Anant Thazhemadam Signed-off-by: Anant Thazhemadam Link: https://lore.kernel.org/r/20201103213906.24219-3-anant.thazhema...@gmail.com Signed-off-by: Marc Kleine-Budde --- net/can/

[net 15/15] can: m_can: m_can_stop(): set device to software init mode before closing

2020-11-15 Thread Marc Kleine-Budde
powering it down. Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support") Signed-off-by: Faiz Abbas Acked-by: Dan Murphy Link: https://lore.kernel.org/r/20200825055442.16994-1-faiz_ab...@ti.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 3 +

[net 01/15] can: af_can: prevent potential access of uninitialized member in can_rcv()

2020-11-15 Thread Marc Kleine-Budde
_ONCE by pr_warn_once") Reported-by: syzbot+9bcb0c9409066696d...@syzkaller.appspotmail.com Tested-by: Anant Thazhemadam Signed-off-by: Anant Thazhemadam Link: https://lore.kernel.org/r/20201103213906.24219-2-anant.thazhema...@gmail.com Signed-off-by: Marc Kleine-Budde --- net/can/af_can.c

[net 12/15] can: m_can: m_can_handle_state_change(): fix state change

2020-11-15 Thread Marc Kleine-Budde
CAN_STATE_ERROR_WARNING. Signed-off-by: Wu Bo Link: http://lore.kernel.org/r/20200129022330.21248-2-wubo.o...@gmail.com Cc: Dan Murphy Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 4 ++-- 1 file

[net 13/15] can: m_can: m_can_class_free_dev(): introduce new function

2020-11-15 Thread Marc Kleine-Budde
From: Dan Murphy This patch creates a common function that peripherials can call to free the netdev device when failures occur. Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Reported-by: Marc Kleine-Budde Signed-off-by: Dan Murphy Link: http://lore.ke

[net 11/15] can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration

2020-11-15 Thread Marc Kleine-Budde
1262589-10-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c index f058bd9104e9..4fdb7121403a 100644 --- a/drivers/net

[net 05/15] can: mcba_usb: mcba_usb_start_xmit(): first fill skb, then pass to can_put_echo_skb()

2020-11-15 Thread Marc Kleine-Budde
ink: https://lore.kernel.org/r/2020221204.1639007-1-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/mcba_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c index 58

[net 06/15] can: peak_usb: fix potential integer overflow on shift of a int

2020-11-15 Thread Marc Kleine-Budde
macro instead. Fixes: bb4785551f64 ("can: usb: PEAK-System Technik USB adapters driver core") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20201105112427.40688-1-colin.k...@canonical.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb_core.c

[net 04/15] can: ti_hecc: Fix memleak in ti_hecc_probe

2020-11-15 Thread Marc Kleine-Budde
-zhangqilo...@huawei.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/ti_hecc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c index 9913f5458279..2c22f40e12bd 100644 --- a/drivers/net/can/ti_hecc.c +++ b/d

[net 07/15] can: flexcan: flexcan_setup_stop_mode(): add missing "req_bit" to stop mode property comment

2020-11-15 Thread Marc Kleine-Budde
it. Fixes: d9b081e3fc4b ("can: flexcan: remove ack_grp and ack_bit handling from driver") Reported-by: Joakim Zhang Link: http://lore.kernel.org/r/20201014114810.2911135-1-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 i

Re: pull-request: can 2020-11-14

2020-11-15 Thread Marc Kleine-Budde
On 11/15/20 5:58 PM, Marc Kleine-Budde wrote: > On 11/15/20 2:39 AM, Jakub Kicinski wrote: >> On Sat, 14 Nov 2020 17:35:01 -0800 Jakub Kicinski wrote: >>> Two invalid fixes tags here, do you want to respin or should I pull? > > Let me respin this. It'll have th

Re: [PATCH v6] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2020-11-15 Thread Marc Kleine-Budde
member named ‘dql’ 2380 | netdev_get_tx_queue(netdev, 0)->dql.min_limit = |^~ regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund

Re: [PATCH v6] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2020-11-16 Thread Marc Kleine-Budde
On 11/16/20 3:44 PM, Vincent MAILHOL wrote: > On Mon. 16 Nov 2020 at 03:55, Marc Kleine-Budde wrote: >> On 11/14/20 4:22 PM, Vincent Mailhol wrote: >>> This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from >>> ETAS GmbH (https://www.etas.com/en/prod

Re: [PATCH] can: mcp251xfd: remove useless code in mcp251xfd_chip_softreset

2020-11-17 Thread Marc Kleine-Budde
)' and last 'return -ETIMEDOUT' statements are > useless. Romove them. > > Reported-by: Tosk Robot > Signed-off-by: Kaixu Xia Applied to linux-can-next/testing. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux

Re: [net 11/15] can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration

2020-11-17 Thread Marc Kleine-Budde
On 11/17/20 3:00 PM, Dan Murphy wrote: > Reviewed-by: Dan Murphy Thanks. The patches are already mainline. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Ph

Re: [PATCH 3/7] can: kvaser_pciefd: select CONFIG_CRC32

2021-01-04 Thread Marc Kleine-Budde
e to `crc32_be' > > Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan > devices") > Signed-off-by: Arnd Bergmann Acked-by: Marc Kleine-Budde regrards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux

Re: [PATCH] can: rcar: Update help description for CAN_RCAR config

2021-01-04 Thread Marc Kleine-Budde
? Sounds good. Better make the description more generic instead of updating it each time a new SoC comes along. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49

Re: [PATCH v2] can: rcar: Update help description for CAN_RCAR config

2021-01-04 Thread Marc Kleine-Budde
On 1/4/21 10:03 AM, Lad Prabhakar wrote: > The rcar_can driver also supports RZ/G SoC's, update the description to > reflect this. > > Signed-off-by: Lad Prabhakar applied to linux-can/testing Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde

[net-next 19/19] can: flexcan: add CAN wakeup function for i.MX8QM

2021-01-07 Thread Marc Kleine-Budde
/20201106105627.31061-6-qiangqing.zh...@nxp.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 123 -- 1 file changed, 106 insertions(+), 17 deletions(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 038fe1036df2..7ab20a6b0d1d

[net-next 11/19] can: tcan4x5x: fix max register value

2021-01-07 Thread Marc Kleine-Budde
This patch fixes the max register value for the regmap. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-12-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x-regmap.c | 2 +- 1 file changed, 1

[net-next 17/19] can: raw: return -ERANGE when filterset does not fit into user space buffer

2021-01-07 Thread Marc Kleine-Budde
Signed-off-by: Oliver Hartkopp Tested-By: Phillip Schichtel Link: https://lore.kernel.org/r/20201216174928.21663-1-socket...@hartkopp.net Signed-off-by: Marc Kleine-Budde --- net/can/raw.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/net/can/raw.c b/net/can

[net-next 05/19] can: tcan4x5x: mark struct regmap_bus tcan4x5x_bus as constant

2021-01-07 Thread Marc Kleine-Budde
This patch marks the struct regmap_bus tcan4x5x_bus as constant. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-6-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x-regmap.c | 2 +- 1 file changed, 1

[net-next 14/19] can: tcan4x5x: add {wr,rd}_table

2021-01-07 Thread Marc Kleine-Budde
The memory space of the chip is not fully populated, so add a regmap range table to document this. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-15-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x

[net-next 01/19] can: tcan4x5x: replace DEVICE_NAME by KBUILD_MODNAME

2021-01-07 Thread Marc Kleine-Budde
This patch replaces the DEVICE_NAME macro by KBUILD_MODNAME and removed the superfluous DEVICE_NAME. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can

[net-next 10/19] can: tcan4x5x: tcan4x5x_regmap_init(): use spi as context pointer

2021-01-07 Thread Marc Kleine-Budde
-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x-regmap.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/m_can/tcan4x5x-regmap.c b/drivers/net/can/m_can/tcan4x5x-regmap.c index 6345bcb7704f..4d43c145fdec 100644 --- a/drivers/net/can/m_can

[net-next 06/19] can: tcan4x5x: tcan4x5x_bus: remove not needed read_flag_mask

2021-01-07 Thread Marc Kleine-Budde
With C99 initializers, all non mentioned members are initialzied to 0, so remove not needed initialization of read_flag_mask. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-7-...@pengutronix.de Signed-off-by: Marc Kleine-Budde

[net-next 13/19] can: tcan4x5x: add max_raw_{read,write} of 256

2021-01-07 Thread Marc Kleine-Budde
The tcan4x5x chip support bulk read/write, but as the length field is only 8 bits wide, the maximum is 256. A length of 0 is treated as 256. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-14-...@pengutronix.de Signed-off-by: Marc Kleine

[net-next 07/19] can: tcan4x5x: remove regmap async support

2021-01-07 Thread Marc Kleine-Budde
The driver doesn't use regmap async support, so remove the stubs. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-8-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x-regmap.c | 15 -

[net-next 18/19] dt-bindings: can: fsl,flexcan: add fsl,scu-index property to indicate a resource

2021-01-07 Thread Marc Kleine-Budde
From: Joakim Zhang For SoCs with SCU support, need setup stop mode via SCU firmware, so this property can help indicate a resource in SCU firmware. Signed-off-by: Joakim Zhang Link: https://lore.kernel.org/r/20201106105627.31061-3-qiangqing.zh...@nxp.com Signed-off-by: Marc Kleine-Budde

[net-next 08/19] can: tcan4x5x: rename regmap_spi_gather_write() -> tcan4x5x_regmap_gather_write()

2021-01-07 Thread Marc Kleine-Budde
.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x-regmap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/m_can/tcan4x5x-regmap.c b/drivers/net/can/m_can/tcan4x5x-regmap.c index 8905fc36b00a..8f718f4395c3 100644 --- a/drive

pull-request: can-next 2021-01-06

2021-01-07 Thread Marc Kleine-Budde
: add fsl,scu-index property to indicate a resource can: flexcan: add CAN wakeup function for i.MX8QM Marc Kleine-Budde (16): can: tcan4x5x: replace DEVICE_NAME by KBUILD_MODNAME can: tcan4x5x: beautify indention of tcan4x5x_of_match and tcan4x5x_id_table can: tcan4x5x

[net-next 03/19] can: tcan4x5x: rename tcan4x5x.c -> tcan4x5x-core.c

2021-01-07 Thread Marc Kleine-Budde
This is a preparation patch to move the regmap related code into a seperate file. This patch removes the tcan4x5x.c to tcan4x5x-core.c. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde

[net-next 02/19] can: tcan4x5x: beautify indention of tcan4x5x_of_match and tcan4x5x_id_table

2021-01-07 Thread Marc Kleine-Budde
This patch beautifies the indention of the tcan4x5x_of_match and tcan4x5x_id_table. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x.c | 13

[net-next 16/19] can: tcan4x5x: add support for half-duplex controllers

2021-01-07 Thread Marc Kleine-Budde
This patch adds back support for half-duplex controllers, which was removed in the last patch. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-17-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x

[net-next 15/19] can: tcan4x5x: rework SPI access

2021-01-07 Thread Marc Kleine-Budde
rg/r/20201215231746.1132907-16-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x-core.c | 2 +- drivers/net/can/m_can/tcan4x5x-regmap.c | 87 + drivers/net/can/m_can/tcan4x5x.h| 23 +++ 3 files changed, 84 insertions(+), 28 deletion

[net-next 09/19] can: tcan4x5x: tcan4x5x_regmap_write(): remove not needed casts and replace 4 by sizeof

2021-01-07 Thread Marc Kleine-Budde
This patch simplifies the tcan4x5x_regmap_write(0 function by removing not needed casts and replaces hardcoded "4" by appropriate sizeof()s. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-10-...@pengutronix.de Signed-off-by: M

[net-next 04/19] can: tcan4x5x: move regmap code into seperate file

2021-01-07 Thread Marc Kleine-Budde
This patch moves the regmap code into a seperate file. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/Makefile | 1 + drivers/net/can/m_can

[net-next 12/19] can: tcan4x5x: tcan4x5x_regmap: set reg_stride to 4

2021-01-07 Thread Marc Kleine-Budde
This patch sets the regmap stide to 4, as the chip only supports access on 32 bit alligned access. Reviewed-by: Dan Murphy Tested-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215231746.1132907-13-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x

pull-request: can 2021-01-07

2021-01-07 Thread Marc Kleine-Budde
r: Kconfig: update help description for CAN_RCAR config Marc Kleine-Budde (4): can: m_can: m_can_class_unregister(): remove erroneous m_can_clk_stop() can: tcan4x5x: fix bittiming const, use common bittiming from m_can driver can: mcp251xfd: mcp251xfd_handle_tefif(): fix TEF v

[net 4/6] can: mcp251xfd: mcp251xfd_handle_rxif_ring(): first increment RX tail pointer in HW, then in driver

2021-01-07 Thread Marc Kleine-Budde
ned-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c index 85a1a8b7c0e7..36235afb0bc6 100644 --- a/d

[net 6/6] MAINTAINERS: Update MCAN MMIO device driver maintainer

2021-01-07 Thread Marc Kleine-Budde
From: Sriram Dash Update Pankaj Sharma as maintainer for mcan mmio device driver as I will be moving to a different role. Signed-off-by: Sriram Dash Acked-by: Pankaj Sharma Link: https://lore.kernel.org/r/20210104123134.16930-1-sriram.d...@samsung.com Signed-off-by: Marc Kleine-Budde

[net 5/6] can: rcar: Kconfig: update help description for CAN_RCAR config

2021-01-07 Thread Marc Kleine-Budde
From: Lad Prabhakar The rcar_can driver also supports RZ/G SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20210104090327.6547-1-prabhakar.mahadev-lad...@bp.renesas.com Signed-off-by: Marc K

[net 3/6] can: mcp251xfd: mcp251xfd_handle_tefif(): fix TEF vs. TX race condition

2021-01-07 Thread Marc Kleine-Budde
This patch changes the order to fix the problem. Fixes: 68c0c1c7f966 ("can: mcp251xfd: tef-path: reduce number of SPI core requests to set UINC bit") Link: https://lore.kernel.org/r/20210105214138.3150886-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi

[net 1/6] can: m_can: m_can_class_unregister(): remove erroneous m_can_clk_stop()

2021-01-07 Thread Marc Kleine-Budde
") Cc: Dan Murphy Cc: Sriram Dash Reviewed-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215103238.524029-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/d

[net 2/6] can: tcan4x5x: fix bittiming const, use common bittiming from m_can driver

2021-01-07 Thread Marc Kleine-Budde
es in the m_can driver, which are selected according to core revision. Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel") Cc: Dan Murphy Reviewed-by: Sean Nyekjaer Link: https://lore.kernel.org/r/20201215103238.524029-3-...@pengutronix.de Signed-off-by: Marc Klein

Re: [net-next 15/19] can: tcan4x5x: rework SPI access

2021-01-07 Thread Marc Kleine-Budde
On 1/7/21 8:00 PM, Jakub Kicinski wrote: > On Thu, 7 Jan 2021 10:48:56 +0100 Marc Kleine-Budde wrote: >> +struct __packed tcan4x5x_map_buf { >> +struct tcan4x5x_buf_cmd cmd; >> +u8 data[256 * sizeof(u32)]; >> +} cacheline_aligned; > > Intere

Re: [net-next 15/19] can: tcan4x5x: rework SPI access

2021-01-07 Thread Marc Kleine-Budde
On 1/7/21 8:06 PM, Jakub Kicinski wrote: > On Thu, 7 Jan 2021 11:00:35 -0800 Jakub Kicinski wrote: >> On Thu, 7 Jan 2021 10:48:56 +0100 Marc Kleine-Budde wrote: >>> +struct __packed tcan4x5x_map_buf { >>> + struct tcan4x5x_buf_cmd cmd; >&

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Marc Kleine-Budde
Applied to linux-can-next/testing (ontop of my dev infrastructure cleanup). regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Marc Kleine-Budde
| Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature

Re: [PATCH] can: isotp: fix isotp_getname() leak

2021-01-12 Thread Marc Kleine-Budde
xes: tag? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description:

Re: [PATCH v2] can: isotp: fix isotp_getname() leak

2021-01-12 Thread Marc Kleine-Budde
6 transport protocol") > Signed-off-by: Oliver Hartkopp Applied to linux-can/testing Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 |

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Marc Kleine-Budde
y: https://lkml.org/lkml/2021/1/10/54 > > * About Tx hardware timestamps > > https://lore.kernel.org/linux-can/2021071152.gb11...@hoboy.vegasvil.org/ > > Signed-off-by: Vincent Mailhol Applied to linux-can-next/testing tnx, Marc -- Pengutronix e.K. | Marc Kleine

Re: [net-next 15/19] can: tcan4x5x: rework SPI access

2021-01-12 Thread Marc Kleine-Budde
On 1/7/21 11:38 PM, Jakub Kicinski wrote: > On Thu, 7 Jan 2021 22:17:15 +0100 Marc Kleine-Budde wrote: >>> +struct __packed tcan4x5x_buf_cmd { >>> + u8 cmd; >>> + __be16 addr; >>> + u8 len; >>> +}; >> >> This has to be

Re: [net-next 15/19] can: tcan4x5x: rework SPI access

2021-01-12 Thread Marc Kleine-Budde
On 1/8/21 10:53 PM, David Laight wrote: >> On 1/7/21 8:06 PM, Jakub Kicinski wrote: >>> On Thu, 7 Jan 2021 11:00:35 -0800 Jakub Kicinski wrote: >>>> On Thu, 7 Jan 2021 10:48:56 +0100 Marc Kleine-Budde wrote: >>>>> +struct __packed tcan4x5x_map_buf { >&

Re: [RFC] can: can_create_echo_skb(): fix echo skb generation: always use skb_clone()

2020-10-18 Thread Marc Kleine-Budde
On 10/18/20 10:46 AM, Oliver Hartkopp wrote: > Oh, answering myself ... > > On 17.10.20 21:13, Oliver Hartkopp wrote: >> >> >> On 16.10.20 21:36, Marc Kleine-Budde wrote: >>> On 2/14/20 1:09 PM, Oleksij Rempel wrote: >>>> Hi all, >>>>

Re: [PATCH V2 8/8] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-19 Thread Marc Kleine-Budde
ed_register; > } > > + err = flexcan_setup_stop_mode(pdev); > + if (err < 0) { > + dev_err(&pdev->dev, "setup stop mode failed\n"); > + goto failed_canregister; > + } > + > of_can_transceiver(dev); > devm_

Re: [PATCH V2 8/8] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-19 Thread Marc Kleine-Budde
lease explain more? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |

Re: [PATCH V2 8/8] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-19 Thread Marc Kleine-Budde
_SC_R_DMA_1_CH0 108 > #define IMX_SC_R_DMA_1_CH1 109 > #define IMX_SC_R_DMA_1_CH2 110 > > Add @Aisheng Dong, could above code changes can be accepted by you? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux

Re: [PATCH v4 0/4] can: add support for ETAS ES58X CAN USB

2020-10-19 Thread Marc Kleine-Budde
unctions. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.

Re: [PATCH] can: mcp251xfd: fix semicolon.cocci warnings

2020-10-19 Thread Marc Kleine-Budde
f4f77366f21d ("can: mcp251xfd: rename all user facing strings to > mcp251xfd") The correct fixes tag is: Fixes: 875347fe5756 ("can: mcp25xxfd: add regmap infrastructure") > Signed-off-by: kernel test robot Applied with that to linux-can. tnx, Marc -- Pengutronix e.K.

Re: [PATCH] can: j1939: rename jacd tool

2020-10-20 Thread Marc Kleine-Budde
On 10/20/20 10:11 AM, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Due to naming conflicts, jacd was renamed to j1939acd. > > Signed-off-by: Yegor Yefremov Applied to linux-can. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde |

<    1   2   3   4   5   6   7   8   9   10   >