Re: [PATCH V3 06/10] can: flexcan: disable wakeup in flexcan_remove()

2020-10-20 Thread Marc Kleine-Budde
alse); > + device_set_wakeup_capable(&pdev->dev, false); > unregister_flexcandev(dev); > pm_runtime_disable(&pdev->dev); > free_candev(dev); > -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengu

Re: [PATCH V3 00/10] can: flexcan: add stop mode support for i.MX8QM

2020-10-20 Thread Marc Kleine-Budde
c -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature

Re: [PATCH V3 06/10] can: flexcan: disable wakeup in flexcan_remove()

2020-10-20 Thread Marc Kleine-Budde
ronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature

Re: [PATCH] can: j1939: fix syntax and spelling

2020-10-20 Thread Marc Kleine-Budde
ns the local address, i.e. the source address > when > sending packages. If a PGN during bind(2) is set, it's used as a RX filter. > -I.e. only packets with a matching PGN are received. If an ADDR or NAME is > set > +I.e. only packets with a matching PGN are received. If an AD

Re: [PATCH V3 10/10] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-20 Thread Marc Kleine-Budde
compatible = "fsl,imx8mp-flexcan", .data = &fsl_imx8mp_devtype_data, > }, > @@ -2040,17 +2130,20 @@ static int flexcan_probe(struct platform_device *pdev) > goto failed_register; > } > > + err = flexcan_setup_stop_mode(pdev); > +

Re: [PATCH] can: isotp: make const array static, makes object smaller

2020-10-20 Thread Marc Kleine-Budde
linux-can/testing. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature

Re: [PATCH] can: j1939: swap addr and pgn in the send example

2020-10-22 Thread Marc Kleine-Budde
On 10/22/20 10:37 AM, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > The address was wrongly assigned to the PGN field and vice versa. > > Signed-off-by: Yegor Yefremov > --- applied to linux-can/testing Marc -- Pengutronix e.K. |

Re: [PATCH] can: j1939: convert PGN structure to a table

2020-10-22 Thread Marc Kleine-Budde
ere PF >= 240). Furthermore, when using the PDU2 format, the > PS-field > Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature

Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-22 Thread Marc Kleine-Budde
On 10/22/20 7:34 PM, Oliver Hartkopp wrote: > @Marc: Can you please make sure that it doesn't get into upstream? Tnx! Ok, I've removed can: vxcan: Fix memleak in vxcan_newlink [Dinghao Liu] from my linux-can/testing. Marc -- Pengutronix e.K. | Marc

Re: [RFC PATCH v1 0/6] add initial CAN PHY support

2020-10-23 Thread Marc Kleine-Budde
figure the MUX to select the correct transceiver. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686

Re: [RFC PATCH v1 0/6] add initial CAN PHY support

2020-10-23 Thread Marc Kleine-Budde
On 10/23/20 2:22 PM, Russell King - ARM Linux admin wrote: > On Fri, Oct 23, 2020 at 02:14:09PM +0200, Marc Kleine-Budde wrote: >> On 10/23/20 1:45 PM, Russell King - ARM Linux admin wrote: >>> On Fri, Oct 23, 2020 at 12:56:20PM +0200, Oleksij Rempel wrote: >>>> - Th

Re: [PATCH] can: j1939: use backquotes for code samples

2020-10-26 Thread Marc Kleine-Budde
atches to linux-can/testing. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +

Re: [PATCH] can: j1939: use backquotes for code samples

2020-10-26 Thread Marc Kleine-Budde
On 10/26/20 11:45 AM, Yegor Yefremov wrote: > On Mon, Oct 26, 2020 at 11:23 AM Marc Kleine-Budde > wrote: >> >> On 10/26/20 10:44 AM, yegorsli...@googlemail.com wrote: >>> From: Yegor Yefremov >>> >>> Signed-off-by: Yegor Yefremov >> >

Re: [PATCH net] can: peak_usb: add range checking in decode operations

2020-10-26 Thread Marc Kleine-Budde
On 10/26/20 2:28 PM, Stéphane Grosjean wrote: > ​​Hello Dan, > > You have my Ack. > > Acked-by: Stephane Grosjean Applied to linux-can/testing. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www

Re: [PATCH] can: j1939: convert PGN structure to a table

2020-10-27 Thread Marc Kleine-Budde
it so. > [1] > https://de.wikipedia.org/wiki/SAE_J1939#/media/Datei:J1939_Aufsplittung_CAN-Identifier.png regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund

Re: [PATCH v4 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-29 Thread Marc Kleine-Budde
+maxItems: 1 > + > + local-mac-address: true > + > + mac-address: true > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + - interrupts > + - interrupt-parrent ^^ typo? Marc -- Pengutronix e.K. |

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Marc Kleine-Budde
spi, u8 reg) > +{ > + u8 tx_buf[4]; > + u16 rx_buf = 0; > + int ret; > + int len = ax_spi->comp ? 3 : 4; > + > + tx_buf[0] = 0x03; /* OP code read register */ > + tx_buf[1] = reg;/* register address */ > + tx_buf[2] = 0xFF;

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-10-31 Thread Marc Kleine-Budde
#x27;uint32_t' #898: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:898: + uint32_t u32; CHECK: Prefer kernel type 'u32' over 'uint32_t' #906: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:906: + uint32_t u32; CHECK: Prefer kernel type 'u32' over &#x

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-10-31 Thread Marc Kleine-Budde
ore. * - * Reads timestamp twice and checks consistency betwen upper and + * Reads timestamp twice and checks consistency between upper and * lower timestamp word. * * @priv: Private info Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Li

Re: [PATCH] net: can: prevent potential access of uninitialized value in canfd_rcv()

2020-11-01 Thread Marc Kleine-Budde
ped non conform CAN FD skbuff: dev > type %d, len %d, datalen %d\n", >dev->type, skb->len, cfd->len); > - kfree_skb(skb); > - return NET_RX_DROP; > + goto free_skb; > } > > can_receive(skb, dev

Re: [PATCH] net: can: prevent potential access of uninitialized value in canfd_rcv()

2020-11-02 Thread Marc Kleine-Budde
On 11/2/20 8:44 AM, Anant Thazhemadam wrote: > > On 02-11-2020 12:40, Marc Kleine-Budde wrote: >> On 11/2/20 4:13 AM, Anant Thazhemadam wrote: >>> In canfd_rcv(), cfd->len is uninitialized when skb->len = 0, and this >>> uninitialized cfd->len

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-11-03 Thread Marc Kleine-Budde
On 11/3/20 11:00 AM, Pavel Pisa wrote: > On Saturday 31 of October 2020 12:35:11 Marc Kleine-Budde wrote: >> On 10/30/20 11:19 PM, Pavel Pisa wrote: >>> This driver adds support for the CTU CAN FD open-source IP core. >> >> Please fix the following checkpatch warni

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-11-03 Thread Marc Kleine-Budde
he HW abstraction yet, but will do next. Usually Linux is considered the HW abstraction layer :) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924

[net 05/27] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

2020-11-03 Thread Marc Kleine-Budde
t;can: CAN Network device driver and Netlink interface") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index b70ded3760f2..73cfcd7e9517 100644 --- a/drivers/n

[net 04/27] can: rx-offload: don't call kfree_skb() from IRQ context

2020-11-03 Thread Marc Kleine-Budde
load_queue_tail(): fix error handling, avoid skb mem leak") Link: http://lore.kernel.org/r/20201019190524.1285319-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/rx-offload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/rx

[net 15/27] can: isotp: padlen(): make const array static, makes object smaller

2020-11-03 Thread Marc Kleine-Budde
dec hex filename 255092039 64 276126bdc net/can/isotp.o (gcc version 10.2.0) Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20201020154203.54711-1-colin.k...@canonical.com Signed-off-by: Marc Kleine-Budde --- net/can/isotp.c | 18 ++ 1 file change

[net 27/27] can: flexcan: flexcan_remove(): disable wakeup completely

2020-11-03 Thread Marc Kleine-Budde
") Fixes: 915f9666421c ("can: flexcan: add support for DT property 'wakeup-source'") Signed-off-by: Joakim Zhang Link: https://lore.kernel.org/r/20201020184527.8190-1-qiangqing.zh...@nxp.com [mkl: streamlined commit message] Signed-off-by: Marc Kleine-Budde --- drivers

[net 25/27] can: flexcan: add ECC initialization for LX2160A

2020-11-03 Thread Marc Kleine-Budde
, had better use FLEXCAN_QUIRK_SUPPORT_ECC quirk to initialize all memory. Fixes: 2c19bb43e5572 ("can: flexcan: add lx2160ar1 support") Cc: Pankaj Bansal Signed-off-by: Joakim Zhang Link: https://lore.kernel.org/r/20201020155402.30318-5-qiangqing.zh...@nxp.com Signed-off-by: Marc Kl

[net 07/27] can: can_create_echo_skb(): fix echo skb generation: always use skb_clone()

2020-11-03 Thread Marc Kleine-Budde
ixes: 0ae89beb283a ("can: add destructor for self generated skbs") Signed-off-by: Oleksij Rempel Link: http://lore.kernel.org/r/20200124132656.22156-1-o.rem...@pengutronix.de Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- include/linux/can/skb.h | 20

[net 16/27] can: ti_hecc: ti_hecc_probe(): add missed clk_disable_unprepare() in error path

2020-11-03 Thread Marc Kleine-Budde
-email-zhangchangzh...@huawei.com Fixes: befa60113ce7 ("can: ti_hecc: add missing prepare and unprepare of the clock") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/ti_hecc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/ti_hecc.c b/drive

[net 09/27] can: j1939: fix syntax and spelling

2020-11-03 Thread Marc Kleine-Budde
From: Yegor Yefremov This patches fixes the syntax an spelling of the j1939 documentation. Signed-off-by: Yegor Yefremov Link: https://lore.kernel.org/r/20201020101043.6369-1-yegorsli...@googlemail.com Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Signed-off-by: M

[net 21/27] can: mcp251xfd: mcp251xfd_regmap_crc_read(): increase severity of CRC read error messages

2020-11-03 Thread Marc Kleine-Budde
Sadhasivam Cc: Thomas Kopp Link: http://lore.kernel.org/r/20201019190524.1285319-15-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/can/spi

[net 06/27] can: dev: __can_get_echo_skb(): fix real payload length return value for RTR frames

2020-11-03 Thread Marc Kleine-Budde
f CAN frame") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index 73cfcd7e9517..6dee4f8f2024 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c

[net 24/27] can: flexcan: remove FLEXCAN_QUIRK_DISABLE_MECR quirk for LS1021A

2020-11-03 Thread Marc Kleine-Budde
Signed-off-by: Joakim Zhang Link: https://lore.kernel.org/r/20201020155402.30318-4-qiangqing.zh...@nxp.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c ind

[net 26/27] can: flexcan: add ECC initialization for VF610

2020-11-03 Thread Marc Kleine-Budde
exCAN") Signed-off-by: Joakim Zhang Link: https://lore.kernel.org/r/20201020155402.30318-6-qiangqing.zh...@nxp.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexc

[net 14/27] can: isotp: isotp_rcv_cf(): enable RX timeout handling in listen-only mode

2020-11-03 Thread Marc Kleine-Budde
: Oliver Hartkopp Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol") Link: https://github.com/hartkopp/can-isotp/issues/34 Link: https://lore.kernel.org/r/20201019120229.89326-1-socket...@hartkopp.net Signed-off-by: Marc Kleine-Budde --- net/can/isotp.c | 8 1 file

[net 17/27] can: xilinx_can: handle failure cases of pm_runtime_get_sync

2020-11-03 Thread Marc Kleine-Budde
: 4716620d1b62 ("can: xilinx: Convert to runtime_pm") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/xilinx_can.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 6c4d00d2dbdc..48d746e18

[net 18/27] can: peak_usb: add range checking in decode operations

2020-11-03 Thread Marc Kleine-Budde
ean Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 48 +- 1 file changed, 37 insertions(+), 11 deletions(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c index ab63fd9eb982..d29d20525588

[net 22/27] can: mcp251xfd: mcp251xfd_regmap_nocrc_read(): fix semicolon.cocci warnings

2020-11-03 Thread Marc Kleine-Budde
obot Link: https://lore.kernel.org/r/20201019120805.GA63693@ae4257e0ab22 Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c b/drivers/net/can/spi

[net 20/27] can: peak_canfd: pucan_handle_can_rx(): fix echo management when loopback is on

2020-11-03 Thread Marc Kleine-Budde
ds") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/peak_canfd/peak_canfd.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/peak_canfd/peak_canfd.c b/drivers/net/can/peak_canfd/peak_canfd.c index 10aa3e457c33..40c33b8a5fda 100644 -

[net 12/27] can: j1939: j1939_sk_bind(): return failure if netdev is down

2020-11-03 Thread Marc Kleine-Budde
c7009 ("can: add support of SAE J1939 protocol") Signed-off-by: Zhang Changzhong Link: https://lore.kernel.org/r/1599460308-18770-1-git-send-email-zhangchangzh...@huawei.com Acked-by: Oleksij Rempel Signed-off-by: Marc Kleine-Budde --- net/can/j1939/socket.c | 6 ++ 1 file changed, 6

[net 13/27] can: isotp: Explain PDU in CAN_ISOTP help text

2020-11-03 Thread Marc Kleine-Budde
ion or not. Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20201013141341.28487-1-geert+rene...@glider.be Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- net/can/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/can/Kconfig b/net/c

[net 23/27] can: mcp251xfd: remove unneeded break

2020-11-03 Thread Marc Kleine-Budde
From: Tom Rix A break is not needed if it is preceded by a return. Signed-off-by: Tom Rix Link: https://lore.kernel.org/r/20201019172412.31143-1-t...@redhat.com Signed-off-by: Marc Kleine-Budde --- .../net/can/spi/mcp251xfd/mcp251xfd-core.c| 22 +-- 1 file changed, 11

[net 19/27] can: peak_usb: peak_usb_get_ts_time(): fix timestamp wrapping

2020-11-03 Thread Marc Kleine-Budde
...@peak-system.com Fixes: bb4785551f64 ("can: usb: PEAK-System Technik USB adapters driver core") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 51 ++-- 1 file changed, 46 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/us

[net 10/27] can: j1939: swap addr and pgn in the send example

2020-11-03 Thread Marc Kleine-Budde
From: Yegor Yefremov The address was wrongly assigned to the PGN field and vice versa. Signed-off-by: Yegor Yefremov Link: https://lore.kernel.org/r/20201022083708.8755-1-yegorsli...@googlemail.com Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") Signed-off-by: Marc Kl

[net 02/27] dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml

2020-11-03 Thread Marc Kleine-Budde
From: Oleksij Rempel In order to automate the verification of DT nodes convert fsl-flexcan.txt to fsl,flexcan.yaml Signed-off-by: Oleksij Rempel Reviewed-by: Rob Herring Link: https://lore.kernel.org/r/20201022075218.11880-3-o.rem...@pengutronix.de Signed-off-by: Marc Kleine-Budde

[net 11/27] can: j1939: use backquotes for code samples

2020-11-03 Thread Marc Kleine-Budde
From: Yegor Yefremov This patch adds backquotes for code samples. Signed-off-by: Yegor Yefremov Link: https://lore.kernel.org/r/20201026094442.16587-1-yegorsli...@googlemail.com Signed-off-by: Marc Kleine-Budde --- Documentation/networking/j1939.rst | 88 +++--- 1

[net 08/27] can: j1939: rename jacd tool

2020-11-03 Thread Marc Kleine-Budde
/199 Signed-off-by: Marc Kleine-Budde --- Documentation/networking/j1939.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst index f5be243d250a..081dfc2e0452 100644 --- a/Documentation/networking/j1939.rst

[net 01/27] dt-bindings: can: add can-controller.yaml

2020-11-03 Thread Marc Kleine-Budde
From: Oleksij Rempel For now we have only node name as common rule for all CAN controllers Signed-off-by: Oleksij Rempel Reviewed-by: Rob Herring Link: https://lore.kernel.org/r/20201022075218.11880-2-o.rem...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- .../bindings/net/can/can

pull-request: can 2020-11-03

2020-11-03 Thread Marc Kleine-Budde
can: flexcan: add ECC initialization for VF610 can: flexcan: flexcan_remove(): disable wakeup completely Marc Kleine-Budde (2): can: rx-offload: don't call kfree_skb() from IRQ context can: mcp251xfd: mcp251xfd_regmap_crc_read(): increase severity of CRC read error messa

[net 03/27] can: proc: can_remove_proc(): silence remove_proc_entry warning

2020-11-03 Thread Marc Kleine-Budde
() if can proc_dir does not exists. Signed-off-by: Zhang Changzhong Link: https://lore.kernel.org/r/1594709090-3203-1-git-send-email-zhangchangzh...@huawei.com Fixes: 8e8cda6d737d ("can: initial support for network namespaces") Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --

Re: [PATCH 0/2] prevent potential access of uninitialized members in can_rcv() and canfd_rcv()

2020-11-03 Thread Marc Kleine-Budde
ccess of uninitialized member in > canfd_rcv() > > net/can/af_can.c | 38 -- > 1 file changed, 28 insertions(+), 10 deletions(-) > Applied both to linux-can/testing Tnx, Marc -- Pengutronix e.K. | Marc Kl

Re: [PATCH] can: j1939: add tables for the CAN identifier and its fields

2020-11-04 Thread Marc Kleine-Budde
=== > + Priority PGN SA (Source Address) > + == Here you introduce trailing whitespace. I've removed them while applying the patch to linux-can/testing Marc -- Pengutronix e.K.

Re: [net 05/27] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

2020-11-04 Thread Marc Kleine-Budde
nto the rx-offload queue and triggers NAPI. The rx-offload pushed the skb into the networking stack via NAPI. Here the code in the mcp251xfd driver: https://elixir.bootlin.com/linux/v5.10-rc2/source/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c#L1237 Marc -- Pengutronix e.K. |

Re: [PATCH][next] can: usb: fix potential integer overflow on shift of a int

2020-11-05 Thread Marc Kleine-Budde
Applied to linux-can/testing (not to next). Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +

Re: [net 21/27] can: mcp251xfd: mcp251xfd_regmap_crc_read(): increase severity of CRC read error messages

2020-11-05 Thread Marc Kleine-Budde
On 11/5/20 5:24 PM, Manivannan Sadhasivam wrote: > Hi Marc, > > On Tue, Nov 03, 2020 at 11:06:30PM +0100, Marc Kleine-Budde wrote: >> During debugging it turned out that some people have setups where the SPI >> communication is more prone to CRC errors. >> >>

Re: [net 21/27] can: mcp251xfd: mcp251xfd_regmap_crc_read(): increase severity of CRC read error messages

2020-11-06 Thread Marc Kleine-Budde
On 11/5/20 7:14 PM, Manivannan Sadhasivam wrote: > On Thu, Nov 05, 2020 at 05:39:31PM +0100, Marc Kleine-Budde wrote: >> On 11/5/20 5:24 PM, Manivannan Sadhasivam wrote: >>> Hi Marc, >>> >>> On Tue, Nov 03, 2020 at 11:06:30PM +0100, Marc Kleine-Budde wrote: >

Re: [PATCH V5 0/5] can: flexcan: add stop mode support for i.MX8QM

2020-11-06 Thread Marc Kleine-Budde
| 131 +++--- > include/dt-bindings/firmware/imx/rsrc.h | 1 + > 3 files changed, 124 insertions(+), 23 deletions(-) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung We

Re: [PATCH net v1 3/3] [RFC] mac80211: ieee80211_store_ack_skb(): make use of skb_clone_sk_optional()

2021-02-22 Thread Marc Kleine-Budde
_wifi_ack() at TX status time, which is supposed to put > it into the socket's error queue, but if the socket is closed ... no > point in that. We haven't looked at the callers of ieee80211_store_ack_skb(). Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH net v3 1/1] can: can_skb_set_owner(): fix ref counting if socket was closed before setting skb ownership

2021-02-24 Thread Marc Kleine-Budde
by user space, the refcount may already be 0 (and the socket will be freed after the last TX skb has been freed). So only increase socket refcount if the refcount is > 0. regards Marc P.S.: Have you had time to look at my ISOTOP RFC patch? -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature

Re: [PATCH 5/6] can: c_can: prepare to up the message objects number

2021-02-24 Thread Marc Kleine-Budde
dev(dev); > + return NULL; > + } > + > + netif_napi_add(dev, &priv->napi, c_can_poll, priv->msg_obj_rx_num); Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature

Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-02-26 Thread Marc Kleine-Budde
_MSG_OBJ_RX_NUM - 1) > - > -#define C_CAN_MSG_OBJ_TX_FIRST (C_CAN_MSG_OBJ_RX_LAST + 1) > - > -#define RECEIVE_OBJECT_BITS 0x > > enum reg { > C_CAN_CTRL_REG = 0, > @@ -193,6 +182,14 @@ struct c_can_priv { > struct napi_struct napi; >

Re: [PATCH v2 6/6] can: c_can: add support to 64 message objects

2021-02-26 Thread Marc Kleine-Budde
can_pci.c > @@ -31,6 +31,8 @@ enum c_can_pci_reg_align { > struct c_can_pci_data { > /* Specify if is C_CAN or D_CAN */ > enum c_can_dev_id type; > + /* Number of message objects */ > + int msg_obj_num; unsigned int Marc -- Pengutronix e.K. |

Re: [PATCH v2 3/6] can: c_can: fix control interface used by c_can_do_tx

2021-02-26 Thread Marc Kleine-Budde
n_inval_tx_object(dev, IF_TX, obj); > can_get_echo_skb(dev, idx, NULL); > bytes += priv->dlc[idx]; > pkts++; > -- > 2.17.1 > > -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux |

Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-02-26 Thread Marc Kleine-Budde
uot;1UL", if you are sure that rx_mask would never exceed 32 bit. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature

pull-request: can 2021-03-29

2021-03-29 Thread Marc Kleine-Budde
) linux-can-fixes-for-5.12-20210329 Marc Kleine-Budde (1): can: uapi: can.h: mark union inside struct can_frame packed Oliver Hartkopp (2): can: bcm/raw: fix

[net 3/3] can: uapi: can.h: mark union inside struct can_frame packed

2021-03-29 Thread Marc Kleine-Budde
g/linux-can/2c82ec23-3551-61b5-1bd8-178c3407e...@hartkopp.net/ Link: https://lore.kernel.org/r/20210325125850.1620-3-socket...@hartkopp.net Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- include/uapi/linux/can.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net 2/3] can: isotp: fix msg_namelen values depending on CAN_REQUIRED_SIZE

2021-03-29 Thread Marc Kleine-Budde
rger Acked-by: Kurt Van Dijck Link: https://lore.kernel.org/linux-can/1135648123.112255.1616613706554.javamail.zim...@nod.at/T/#t Link: https://lore.kernel.org/r/20210325125850.1620-2-socket...@hartkopp.net Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- net/can/isotp.c | 11

[net 1/3] can: bcm/raw: fix msg_namelen values depending on CAN_REQUIRED_SIZE

2021-03-29 Thread Marc Kleine-Budde
einberger Tested-by: Richard Weinberger Acked-by: Kurt Van Dijck Link: https://lore.kernel.org/linux-can/1135648123.112255.1616613706554.javamail.zim...@nod.at/T/#t Link: https://lore.kernel.org/r/20210325125850.1620-1-socket...@hartkopp.net Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kl

[net-next 01/39] MAINTAINERS: remove Dan Murphy from m_can and tcan4x5x

2021-03-30 Thread Marc Kleine-Budde
Dan Murphy's email address at ti.com doesn't work anymore, mails bounce with: | 550 Invalid recipient (#5.1.1) For now remove all CAN related entries of Dan from the Maintainers file. Link: https://lore.kernel.org/r/20210228094218.40015-1-...@pengutronix.de Signed-off-by: Marc Kl

pull-request: can-next 2021-03-30

2021-03-30 Thread Marc Kleine-Budde
can: c_can: use 32-bit write to set arbitration register can: c_can: prepare to up the message objects number can: c_can: add support to 64 message objects Marc Kleine-Budde (17): MAINTAINERS: remove Dan Murphy from m_can and tcan4x5x can: dev: always create TX echo skb

[net-next 02/39] MAINTAINERS: Update MCAN MMIO device driver maintainer

2021-03-30 Thread Marc Kleine-Budde
From: Pankaj Sharma Update Chandrasekar Ramakrishnan as maintainer for mcan mmio device driver as I will be moving to a different role. Signed-off-by: Pankaj Sharma Signed-off-by: Marc Kleine-Budde --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next 05/39] can: dev: can_free_echo_skb(): extend to return can frame length

2021-03-30 Thread Marc Kleine-Budde
this function, too. This patch is the natural extension of commit: | 9420e1d495e2 ("can: dev: can_get_echo_skb(): extend to return can |frame length") Link: https://lore.kernel.org/r/20210319142700.305648-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drive

[net-next 06/39] can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)

2021-03-30 Thread Marc Kleine-Budde
70/V70/V71 Family: https://www.mouser.com/datasheet/2/268/60001527A-1284321.pdf Link: https://lore.kernel.org/r/20210224002008.4158-2-mailhol.vinc...@wanadoo.fr Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- include/linux/can/bittiming.h | 65 ++

[net-next 03/39] can: dev: always create TX echo skb

2021-03-30 Thread Marc Kleine-Budde
-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/skb.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/dev/skb.c b/drivers/net/can/dev/skb.c index 6a64fe410987..22b0472a5fad 100644 --- a/drivers/net/can/dev/skb.c +++ b/drivers

[net-next 07/39] can: dev: reorder struct can_priv members for better packing

2021-03-30 Thread Marc Kleine-Budde
: 31 */ /* sum members: 426, holes: 2, sum holes: 6 */ /* paddings: 1, sum paddings: 4 */ /* last cacheline: 48 bytes */ }; Link: https://lore.kernel.org/r/20210224002008.4158-3-mailhol.vinc...@wanadoo.fr Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde

[net-next 04/39] can: dev: can_free_echo_skb(): don't crash the kernel if can_priv::echo_skb is accessed out of bounds

2021-03-30 Thread Marc Kleine-Budde
echo_skb is accessed out of bounds") Link: https://lore.kernel.org/r/20210319142700.305648-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/skb.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/dev/skb.c b/driver

[net-next 08/39] can: netlink: move '=' operators back to previous line (checkpatch fix)

2021-03-30 Thread Marc Kleine-Budde
/lore.kernel.org/r/20210224002008.4158-4-mailhol.vinc...@wanadoo.fr Signed-off-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/netlink.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/net/can/dev/netlink

[net-next 10/39] can: bittiming: add CAN_KBPS, CAN_MBPS and CAN_MHZ macros

2021-03-30 Thread Marc Kleine-Budde
-by: Vincent Mailhol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/bittiming.c | 4 ++-- include/linux/can/bittiming.h | 8 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/dev/bittiming.c b/drivers/net/can/dev/bittiming.c index 2907e60c9a57

[net-next 09/39] can: bittiming: add calculation for CAN FD Transmitter Delay Compensation (TDC)

2021-03-30 Thread Marc Kleine-Budde
hol Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/bittiming.c | 24 drivers/net/can/dev/netlink.c | 2 ++ include/linux/can/bittiming.h | 6 ++ 3 files changed, 32 insertions(+) diff --git a/drivers/net/can/dev/bittiming.c b/drivers/net/can/

[net-next 11/39] can: grcan: add missing Kconfig dependency to HAS_IOMEM

2021-03-30 Thread Marc Kleine-Budde
On ARCHs without IOMEM support the grcan driver fails to link due to missing iomem functionality. This patch adds the missing Kconfig dependency to HAS_IOMEM. Link: https://lore.kernel.org/r/20210309140424.3331010-1-...@pengutronix.de Reported-by: kernel test robot Signed-off-by: Marc Kleine

[net-next 15/39] can: peak_usb: add support of ethtool set_phys_id()

2021-03-30 Thread Marc Kleine-Budde
] Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb.c | 47 drivers/net/can/usb/peak_usb/pcan_usb_core.c | 4 ++ drivers/net/can/usb/peak_usb/pcan_usb_core.h | 2 + drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 34 ++ drivers/net/can/usb

[net-next 13/39] can: ucan: fix alignment constraints

2021-03-30 Thread Marc Kleine-Budde
ructure to have the same alignment as the inner one. Link: https://lore.kernel.org/r/20210204162625.3099392-1-a...@kernel.org Signed-off-by: Arnd Bergmann Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/ucan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[net-next 18/39] can: m_can: add infrastructure for internal timestamps

2021-03-30 Thread Marc Kleine-Budde
From: Torin Cooper-Bennun Add infrastucture to allow internal timestamps from the M_CAN to be configured and retrieved. Link: https://lore.kernel.org/r/20210308102427.63916-2-to...@maxiluxsystems.com Signed-off-by: Torin Cooper-Bennun Signed-off-by: Marc Kleine-Budde --- drivers/net/can

[net-next 16/39] can: peak_usb: add support of ONE_SHOT mode

2021-03-30 Thread Marc Kleine-Budde
From: Stephane Grosjean This patch adds "ONE-SHOT" mode support to the following CAN-USB PEAK-System GmbH interfaces: - PCAN-USB X6 - PCAN-USB FD - PCAN-USB Pro FD - PCAN-Chip USB - PCAN-USB Pro Signed-off-by: Stephane Grosjean [mkl: split into two patches] Signed-off-by: Marc Kl

[net-next 12/39] can: xilinx_can: Simplify code by using dev_err_probe()

2021-03-30 Thread Marc Kleine-Budde
rnel.org/r/91af0945ed7397b08f1af0c829450620bd92b804.1612442564.git.michal.si...@xilinx.com Signed-off-by: Michal Simek Signed-off-by: Marc Kleine-Budde --- drivers/net/can/xilinx_can.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 37

[net-next 20/39] can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context

2021-03-30 Thread Marc Kleine-Budde
the correct context, with h/w timestamping to ensure correct ordering. Link: https://lore.kernel.org/r/20210308102427.63916-4-to...@maxiluxsystems.com Signed-off-by: Torin Cooper-Bennun [mkl: m_can_class_register(): update error handling] Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can

[net-next 23/39] can: mcp251xfd: simplify UINC handling

2021-03-30 Thread Marc Kleine-Budde
0. Link: https://lore.kernel.org/r/20210304160328.2752293-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- .../net/can/spi/mcp251xfd/mcp251xfd-core.c| 69 ++- 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd

[net-next 17/39] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment

2021-03-30 Thread Marc Kleine-Budde
Kleine-Budde --- drivers/net/can/m_can/m_can.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 2ae3da16cbfe..12a75ebe9ce1 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1787,11 +1787,6

[net-next 26/39] can: mcp251xfd: add HW timestamp infrastructure

2021-03-30 Thread Marc Kleine-Budde
, timecounter and delayed worker infrastructure (which runs every 45 seconds) to convert the timer into a proper 64 bit based ns timestamp. Link: https://lore.kernel.org/r/20210304160328.2752293-6-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/Makefile

[net-next 24/39] can: mcp251xfd: move netdevice.h to mcp251xfd.h

2021-03-30 Thread Marc Kleine-Budde
The netdevice.h header is needed in mcp251xfd.h, so that it can be included without further headers. Link: https://lore.kernel.org/r/20210304160328.2752293-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 1 - drivers/net/can/spi

[net-next 14/39] can: peak_usb: pcan_usb_pro_encode_msg(): use macros for flags instead of plain integers

2021-03-30 Thread Marc Kleine-Budde
] Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c index 18fa180ecc81..902900d4f7c1 100644 --- a/drivers/net

[net-next 22/39] can: mcp251xfd: add dev coredump support

2021-03-30 Thread Marc Kleine-Budde
e TEF-, RX- and TX-FIFOs, it can be analyzed with the mcp251xfd-dump tool of the can-utils: https://github.com/linux-can/can-utils/tree/master/mcp251xfd Link: https://lore.kernel.org/r/20210304160328.2752293-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp2

[net-next 25/39] can: mcp251xfd: mcp251xfd_get_timestamp(): move to mcp251xfd.h

2021-03-30 Thread Marc Kleine-Budde
This is a preparation patch, it moves the mcp251xfd_get_timestamp() function into the mcp251xfd.h file. Link: https://lore.kernel.org/r/20210304160328.2752293-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 6 -- drivers/net/can/spi

[net-next 19/39] can: m_can: m_can_chip_config(): enable and configure internal timestamps

2021-03-30 Thread Marc Kleine-Budde
highest prescalar so that the timestamp wraps every 2^20 bit times, or 209 ms at a bus speed of 5 Mbit/s. Timestamps will have a precision of 16 bit times. Link: https://lore.kernel.org/r/20210308102427.63916-3-to...@maxiluxsystems.com Signed-off-by: Torin Cooper-Bennun Signed-off-by: Marc Kleine

[net-next 28/39] can: c_can: convert block comments to network style comments

2021-03-30 Thread Marc Kleine-Budde
This patch converts all block comments to network subsystem style block comments. Link: https://lore.kernel.org/r/20210304154240.2747987-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 52 ++- drivers/net/can/c_can

[net-next 21/39] can: tcan4x5x: remove duplicate include of regmap.h

2021-03-30 Thread Marc Kleine-Budde
ned-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/tcan4x5x.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/m_can/tcan4x5x.h b/drivers/net/can/m_can/tcan4x5x.h index c66da829b795..e62c030d3e1e 100644 --- a/drivers/net/can/m_can/tcan4x5x.h +++ b/drivers/net/can/m_can/

[net-next 31/39] can: c_can: fix print formating string

2021-03-30 Thread Marc Kleine-Budde
This patch fixes the print format string in the driver, so that it stays in a single line. Link: https://lore.kernel.org/r/20210304154240.2747987-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[net-next 30/39] can: c_can: fix indention

2021-03-30 Thread Marc Kleine-Budde
This patch fixes the indention in the driver. Link: https://lore.kernel.org/r/20210304154240.2747987-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 12 ++-- drivers/net/can/c_can/c_can.h | 10 +- drivers/net/can/c_can

[net-next 35/39] can: c_can: fix indentation

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi Commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind wrong indentation, fix it. Link: https://lore.kernel.org/r/20210302215435.18286-3-dario...@libero.it Signed-off-by: Dario Binacchi Signed-off-by: Marc Kl

<    1   2   3   4   5   6   7   8   9   10   >