[PATCH 1/2] can: hi311x: Acquire SPI lock on ->do_get_berr_counter

2018-05-10 Thread Marc Kleine-Budde
s but found no others. Cc: Mathias Duckeck <m.duck...@kunbus.de> Cc: Akshay Bhat <akshay.b...@timesys.com> Cc: Casey Fitzpatrick <casey.fitzpatr...@timesys.com> Cc: Stef Walter <st...@redhat.com> Cc: Karel Zak <k...@redhat.com> Cc: sta...@vger.kernel.org # v4.12+ Signed-o

Re: [PATCH] can: cc770: fix spelling mistake: "comptibility" -> "compatibility"

2018-04-30 Thread Marc Kleine-Budde
, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

Re: [PATCH net-next] can: dev: use skb_put_zero to simplfy code

2018-04-30 Thread Marc Kleine-Budde
On 04/28/2018 09:49 AM, YueHaibing wrote: > use helper skb_put_zero to replace the pattern of skb_put() && memset() > > Signed-off-by: YueHaibing <yuehaib...@huawei.com> Applied to linux-can-next. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

2018-04-30 Thread Marc Kleine-Budde
On 04/27/2018 08:53 PM, Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC support in the R-Car CAN-FD bindings. > > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Applied to linux-can. tnx, Marc -- Pengutronix e.K. | Ma

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings

2018-04-30 Thread Marc Kleine-Budde
>> >> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > > Reviewed-by: Ramesh Shanmugasundaram <ramesh.shanmugasunda...@bp.renesas.com> Applied to linux-can. tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Marc Kleine-Budde
On 10/19/2017 03:54 PM, Franklin S Cooper Jr wrote: > On 10/19/2017 06:32 AM, Marc Kleine-Budde wrote: >> On 10/19/2017 01:09 PM, Sekhar Nori wrote: >>> On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: >>>> On 10/19/2017 07:07 AM, Sekhar Nori wrote: >

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Marc Kleine-Budde
On 10/19/2017 01:09 PM, Sekhar Nori wrote: > On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: >> On 10/19/2017 07:07 AM, Sekhar Nori wrote: >>>>>> Sounds reasonable. What's the status of this series? >>>>> >>>>> I have had

Re: pull-request: can 2018-01-04

2018-01-08 Thread Marc Kleine-Budde
On 01/05/2018 07:48 PM, David Miller wrote: > From: Marc Kleine-Budde <m...@pengutronix.de> > Date: Thu, 4 Jan 2018 16:33:51 +0100 > >> this is a pull request for net/master consisting of 4 patches. >> >> The first patch is by Oliver Hartkopp, it impr

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

2018-01-03 Thread Marc Kleine-Budde
On 01/03/2018 01:39 PM, Faiz Abbas wrote: > On Tuesday 02 January 2018 09:37 PM, Marc Kleine-Budde wrote: >> On 12/22/2017 02:31 PM, Faiz Abbas wrote: >>> From: Franklin S Cooper Jr <fcoo...@ti.com> >>> >>> Add support for PM Runtime which is the new

pull-request: can-next 2017-12-01

2018-01-05 Thread Marc Kleine-Budde
2:08 +0100) linux-can-next-for-4.16-20180105 ---- Marc Kleine-Budde (7): can: rx-offload: can_rx_offload_add_timestamp: remove duplicate semicolon at return statement

[PATCH 3/4] can: flex_can: Correct the checking for frame length in flexcan_start_xmit()

2018-01-04 Thread Marc Kleine-Budde
length with 3. Because the register length is 4. Signed-off-by: Luu An Phu <phu.lu...@nxp.com> Reviewed-by: Oliver Hartkopp <socket...@hartkopp.net> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH 1/4] can: vxcan: improve handling of missing peer name attribute

2018-01-04 Thread Marc Kleine-Budde
kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/vxcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c index 8404e8852a0f..b4c4a2c76437 100644 --- a/drivers/net/can/vxcan.c +++ b/

pull-request: can 2018-01-04

2018-01-04 Thread Marc Kleine-Budde
Hello David, this is a pull request for net/master consisting of 4 patches. The first patch is by Oliver Hartkopp, it improves the error checking during the creation of a vxcan link. Wolfgang Grandegger's patch for the gs_usb driver fixes the return value of the "set_bittiming" callback. Luu An

[PATCH 2/4] can: gs_usb: fix return value of the "set_bittiming" callback

2018-01-04 Thread Marc Kleine-Budde
by: Wolfgang Grandegger <w...@grandegger.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/gs_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/usb/gs_usb.c b/dri

[PATCH 4/4] can: ems_usb: improve error reporting for error warning and error passive

2018-01-04 Thread Marc Kleine-Budde
From: Martin Lederhilger <m.lederhil...@ds-automotion.com> This patch adds the missing CAN_ERR_CRTL to cf->can_id in case of CAN_STATE_ERROR_WARNING or CAN_STATE_ERROR_PASSIVE Signed-off-by: Martin Lederhilger <m.lederhil...@ds-automotion.com> Signed-off-by: Marc

Re: [PATCH v7 0/8] Add MCAN Support for Dra76 platform

2018-01-15 Thread Marc Kleine-Budde
rebased to the latest kernel. I've added patches 1-3 to linux-can-next/testing. But stopped at 4, due to the problems with the error handling. You can include 1-3 in your next posting if you like, otherwise I'll takes the ones I've already applied. Marc -- Pengutronix e.K.

Re: WARNING in can_rcv

2018-01-17 Thread Marc Kleine-Budde
hy not :) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

Re: [PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused

2018-01-18 Thread Marc Kleine-Budde
rndb.de> Tnx - applied. However all archs using this driver have mandatory PM support and the driver depends on it. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49

Re: pull-request: can-next 2017-12-01,Re: pull-request: can-next 2017-12-01

2018-01-15 Thread Marc Kleine-Budde
On 01/15/2018 06:55 PM, David Miller wrote: > From: Marc Kleine-Budde <m...@pengutronix.de> > Date: Mon, 15 Jan 2018 14:02:23 +0100 > >> Hello David, >> >> >> On 01/05/2018 12:08 PM, Marc Kleine-Budde wrote: >>> Hello David, >>> &g

Re: pull-request: can-next 2017-12-01

2018-01-15 Thread Marc Kleine-Budde
Hello David, On 01/05/2018 12:08 PM, Marc Kleine-Budde wrote: > Hello David, > > this is a pull request of 7 patches for net-next/master. > > All patches are by me. Patch 6 is for the "can_raw" protocol and add > error checking to the bind() function. All other p

Re: [PATCH v7 1/8] can: dev: Add support for limiting configured bitrate

2018-01-15 Thread Marc Kleine-Budde
ONFIG_OF > +void of_can_transceiver(struct net_device *dev); > +#else > +static inline void of_can_transceiver(struct net_device *dev) { } > +#endif > + > struct sk_buff *alloc_can_skb(struct net_device *dev, struct can_frame **cf); > struct sk_buff *alloc_canfd_skb(struct net_device *de

Re: [PATCH v7 4/8] can: m_can: Move allocation of net device to probe

2018-01-15 Thread Marc Kleine-Budde
The error handling in m_can_plat_probe() is broken, too. If pm_runtime_get_sync(>dev) fails, you don't free the candev. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax:

Re: [PATCH v7 5/8] can: m_can: Add PM Support

2018-01-15 Thread Marc Kleine-Budde
dev_get_drvdata(dev); > + struct m_can_priv *priv = netdev_priv(ndev); > + > + clk_disable_unprepare(priv->cclk); > + clk_disable_unprepare(priv->hclk); > + > + return 0; > +} > + > +int m_can_runtime_resume(struct device *dev) > +{ > + struct net_device *ndev

Re: [PATCH v8 4/5] can: m_can: Add PM Support

2018-01-16 Thread Marc Kleine-Budde
me_suspend' was not declared. Should it be static? drivers/net/can/m_can/m_can.c:1763:5: warning: symbol 'm_can_runtime_resume' was not declared. Should it be static? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-282

Re: [PATCH v8 0/5] Add MCAN Support for Dra76 platform

2018-01-16 Thread Marc Kleine-Budde
rebased to the latest kernel. Added all remaining patches to linux-can-next/testing. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsge

Re: WARNING in can_rcv

2018-01-16 Thread Marc Kleine-Budde
ic_on_warn active. Should we better silently drop these CAN packages? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA

pull-request: can-next 2018-01-16

2018-01-19 Thread Marc Kleine-Budde
): can: m_can: mark runtime-PM handlers as __maybe_unused drivers/net/can/m_can/m_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2018-01-26 Thread Marc Kleine-Budde
On 01/25/2018 09:53 AM, Marc Kleine-Budde wrote: > On 01/24/2018 06:22 PM, Fabrizio Castro wrote: >> thank you for Acking the patch, just wondering if this patch has any >> chance to end up in v4.16? > > I can take this via the linux-can tree, if no one else takes

pull-request: can-next 2018-01-26

2018-01-26 Thread Marc Kleine-Budde
: rcar_can: document r8a774[35] can support Marc Kleine-Budde (1): Documentation/devicetree: mpc5200.txt: fix pointer to location of fsl,mpc5200-mscan node Robert Schwebel (1): can: migrate documentation to restructured text .../devicetree/bindings/net/can/rcar_can.txt |7

Re: [PATCH v8 3/5] can: m_can: Move allocation of net device to probe

2018-01-16 Thread Marc Kleine-Budde
On 01/16/2018 02:03 PM, Marc Kleine-Budde wrote: >> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c >> index 893edbb..ebb74de 100644 >> --- a/drivers/net/can/m_can/m_can.c >> +++ b/drivers/net/can/m_can/m_can.c >> @@ -1207,25 +1207,20 @@ st

pull-request: can-next 2018-01-16

2018-01-16 Thread Marc Kleine-Budde
call to of_can_transceiver Marc Kleine-Budde (1): can: m_can: get rid of function free_m_can_dev() .../bindings/net/can/can-transceiver.txt | 24 +++ .../devicetree/bindings/net/can/m_can.txt | 9 + drivers/net/can/dev.c | 45

Re: [PATCH v8 3/5] can: m_can: Move allocation of net device to probe

2018-01-16 Thread Marc Kleine-Budde
p() for consistent namespace. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

pull-request: can 2018-01-16

2018-01-16 Thread Marc Kleine-Budde
Hello David, this is a pull reqeust of a single patch for net/master: This patch by Stephane Grosjean fixes a potential bug in the packet fragmentation in the peak USB driver. regards, Marc --- The following changes since commit 6311b7ce42e0c1d6d944bc099dc47e936c20cf11: netlink: extack:

[PATCH] can: peak: fix potential bug in packet fragmentation

2018-01-16 Thread Marc Kleine-Budde
d when the underlying USB controller is not a high-speed one. Signed-off-by: Stephane Grosjean <s.grosj...@peak-system.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 21 +

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2018-01-25 Thread Marc Kleine-Budde
On 01/24/2018 06:22 PM, Fabrizio Castro wrote: > thank you for Acking the patch, just wondering if this patch has any > chance to end up in v4.16? I can take this via the linux-can tree, if no one else takes it. Marc -- Pengutronix e.K. | Marc Kleine

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marc Kleine-Budde
On 02/08/2018 08:22 PM, Marek Vasut wrote: > On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >> On 02/08/2018 07:47 AM, Heiko Schocher wrote: >>> the driver reads in the ISR first the IRQpending register, >>> and clears after that in a write *all* bits in it. >>&

Re: [PATCH] can: m_can: change comparison to bitshift when dealing with a mask

2018-02-08 Thread Marc Kleine-Budde
tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc D

Re: [PATCH] can: m_can: change comparison to bitshift when dealing with a mask

2018-02-08 Thread Marc Kleine-Budde
nly build tested. Applied to can. Luckily that define is not used :) Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsger

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marc Kleine-Budde
de> > Reviewed-by: Marek Vasut <ma...@denx.de> Applied both to linux-can. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

2018-01-02 Thread Marc Kleine-Budde
+1688,11 @@ static int m_can_plat_probe(struct platform_device > *pdev) > clk_disable_unprepare(cclk); > disable_hclk_ret: > clk_disable_unprepare(hclk); > +pm_runtime_put: > + pm_runtime_put_sync(>dev); > +pm_runtime_fail: > + if (ret) > + pm_runti

Re: [PATCH v6 1/6] can: dev: Add support for limiting configured bitrate

2018-01-02 Thread Marc Kleine-Budde
ctions: can_get_size() and can_fill_info(). Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de

Re: [PATCH v6 1/6] can: dev: Add support for limiting configured bitrate

2018-01-02 Thread Marc Kleine-Budde
> > /* CAN controller features - see include/uapi/linux/can/netlink.h */ > @@ -166,6 +168,12 @@ void can_put_echo_skb(struct sk_buff *skb, struct > net_device *dev, > unsigned int can_get_echo_skb(struct net_device *dev, unsigned int idx); > void can_free_echo_skb(struct net_device

Re: [PATCH v6 4/6] can: m_can: Support higher speed CAN-FD bitrates

2018-01-02 Thread Marc Kleine-Budde
SHIFT); > + } > + } > + > reg_btp = (brp << DBTP_DBRP_SHIFT) | (sjw << DBTP_DSJW_SHIFT) | > (tseg1 << DBTP_DTSEG1_SHIFT) | > (tseg2 << DBTP_DTSEG2_SHIFT); Adjust thi

Re: [PATCH] flex_can: Correct the checking for frame length in flexcan_start_xmit()

2018-01-03 Thread Marc Kleine-Budde
s and frame maximum length is 8 bytes. > > Fix the check that compares frame length with 3. Because the register length > is 4. > > Signed-off-by: Luu An Phu <phu.lu...@nxp.com> Applied to can. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

2018-01-03 Thread Marc Kleine-Budde
On 01/03/2018 04:06 PM, Faiz Abbas wrote: > Hi, > > On Wednesday 03 January 2018 07:55 PM, Marc Kleine-Budde wrote: >> On 01/03/2018 01:39 PM, Faiz Abbas wrote: >>> On Tuesday 02 January 2018 09:37 PM, Marc Kleine-Budde wrote: >>>> On 12/22/2017 02:31 PM, Faiz

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

2018-01-04 Thread Marc Kleine-Budde
On 01/04/2018 04:17 PM, Faiz Abbas wrote: > Hi, > > On Wednesday 03 January 2018 08:47 PM, Marc Kleine-Budde wrote: >> On 01/03/2018 04:06 PM, Faiz Abbas wrote: >>> Hi, >>> >>> On Wednesday 03 January 2018 07:55 PM, Marc Kleine-Budde wrote: >

Re: pull-request: can 2018-07-30

2018-07-30 Thread Marc Kleine-Budde
On 07/30/2018 06:16 PM, David Miller wrote: > From: Marc Kleine-Budde > Date: Mon, 30 Jul 2018 11:08:21 +0200 > >> Hello David, >> >> this is a pull request of one patch for net/master. >> >> The patch by Anton Vasilyev and the Linux Driver Veri

pull-request: can-next 2018-01-16

2018-07-27 Thread Marc Kleine-Budde
uct kvaser_cmd_cardinfo Luc Van Oostenryck (3): can: janz-ican3: fix ican3_xmit()'s return type can: sun4i: fix sun4ican_start_xmit()'s return type can: xilinx: fix xcan_start_xmit()'s return type Marc Kleine-Budde (2): can: usb: Kconfig/Makefile: sort alphabetically

Re: pull-request: can 2018-07-23

2018-07-26 Thread Marc Kleine-Budde
On 07/26/2018 01:26 AM, David Miller wrote: > From: Marc Kleine-Budde > Date: Tue, 24 Jul 2018 09:27:30 +0200 > >> Thanks David. Can you please merge net into next-next, as I've some >> patches for net-next that would result in a merge conflict between net >> and ne

[PATCH] can: ems_usb: Fix memory leak on ems_usb_disconnect()

2018-07-30 Thread Marc Kleine-Budde
From: Anton Vasilyev ems_usb_probe() allocates memory for dev->tx_msg_buffer, but there is no its deallocation in ems_usb_disconnect(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev Cc: Signed-off-by: Marc Kleine-Budde --- drivers/net/can/

pull-request: can 2018-07-30

2018-07-30 Thread Marc Kleine-Budde
Hello David, this is a pull request of one patch for net/master. The patch by Anton Vasilyev and the Linux Driver Verification project fixes a memory leak in the ems_usb driver's disconnect function. regards, Marc

Re: pull-request: can 2018-07-23

2018-07-24 Thread Marc Kleine-Budde
On 07/23/2018 08:02 PM, David Miller wrote: > From: Marc Kleine-Budde > Date: Mon, 23 Jul 2018 14:58:31 +0200 > >> this is a pull request of 12 patches for net/master. >> >> The patch by Stephane Grosjean for the peak_canfd CAN driver fixes a problem >> wi

[PATCH 09/12] can: xilinx_can: keep only 1-2 frames in TX FIFO to fix TX accounting

2018-07-23 Thread Marc Kleine-Budde
waking the queue when xmit() had just filled it. v3: Keep local echo support and reduce the amount of frames in FIFO instead as suggested by Marc Kleine-Budde. Fixes: b1201e44f50b ("can: xilinx CAN controller support") Signed-off-by: Anssi Hannula Cc: Signed-off-by: Marc Kleine-Budde --

[PATCH 04/12] can: m_can: Fix runtime resume call

2018-07-23 Thread Marc Kleine-Budde
From: Faiz Abbas pm_runtime_get_sync() returns a 1 if the state of the device is already 'active'. This is not a failure case and should return a success. Therefore fix error handling for pm_runtime_get_sync() call such that it returns success when the value is 1. Also cleanup the TODO for

[PATCH 05/12] can: m_can: Move accessing of message ram to after clocks are enabled

2018-07-23 Thread Marc Kleine-Budde
From: Faiz Abbas MCAN message ram should only be accessed once clocks are enabled. Therefore, move the call to parse/init the message ram to after clocks are enabled. Signed-off-by: Faiz Abbas Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 7 +++ 1 file changed, 3

[PATCH 06/12] can: xilinx_can: fix device dropping off bus on RX overrun

2018-07-23 Thread Marc Kleine-Budde
by inducing an RX overflow also indicated that the device continues to work just fine without a reset. Remove the software reset. Tested with the integrated CAN on Zynq-7000 SoC. Fixes: b1201e44f50b ("can: xilinx CAN controller support") Signed-off-by: Anssi Hannula Cc: Signed-off-by: M

[PATCH 12/12] can: xilinx_can: fix power management handling

2018-07-23 Thread Marc Kleine-Budde
that separately. Also, the device_may_wakeup() checks are removed as the driver does not have wakeup support. Tested on Zynq-7000 integrated CAN. Signed-off-by: Anssi Hannula Cc: Michal Simek Cc: Signed-off-by: Marc Kleine-Budde --- drivers/net/can/xilinx_can.c | 69

[PATCH 10/12] can: xilinx_can: fix RX overflow interrupt not being enabled

2018-07-23 Thread Marc Kleine-Budde
t;can: xilinx CAN controller support") Signed-off-by: Anssi Hannula Cc: Michal Simek Cc: Signed-off-by: Marc Kleine-Budde --- drivers/net/can/xilinx_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index dc

pull-request: can 2018-07-23

2018-07-23 Thread Marc Kleine-Budde
Hello David, this is a pull request of 12 patches for net/master. The patch by Stephane Grosjean for the peak_canfd CAN driver fixes a problem with older firmware. The next patch is by Roman Fietze and fixes the setup of the CCCR register in the m_can driver. Nicholas Mc Guire's patch for the

[PATCH 02/12] can: m_can.c: fix setup of CCCR register: clear CCCR NISO bit before checking can.ctrlmode

2018-07-23 Thread Marc Kleine-Budde
was configured for CAN_CTRLMODE_FD_NON_ISO, this mode could never be cleared again. This fix is only relevant for controllers with version 3.1.x or 3.2.x. Older versions do not support NISO. Signed-off-by: Roman Fietze Cc: linux-stable Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 3

[PATCH 11/12] can: xilinx_can: fix incorrect clear of non-processed interrupts

2018-07-23 Thread Marc Kleine-Budde
to only clear those interrupts that it knows are asserted and therefore going to be processed in xcan_err_interrupt(). Fixes: b1201e44f50b ("can: xilinx CAN controller support") Signed-off-by: Anssi Hannula Cc: Michal Simek Cc: Signed-off-by: Marc Kleine-Budde --- drivers/net/can/xi

[PATCH 08/12] can: xilinx_can: fix recovery from error states not being propagated

2018-07-23 Thread Marc Kleine-Budde
for recovery after RX and TX if the interface is in one of those states. Tested with the integrated CAN on Zynq-7000 SoC. Fixes: b1201e44f50b ("can: xilinx CAN controller support") Signed-off-by: Anssi Hannula Cc: Signed-off-by: Marc Kleine-Budde --- drivers/net/can/xilinx_c

[PATCH 07/12] can: xilinx_can: fix RX loop if RXNEMP is asserted without RXOK

2018-07-23 Thread Marc Kleine-Budde
incoming messages. Fix the issue and simplify the RX processing by only using RXNEMP without RXOK. Tested with the integrated CAN on Zynq-7000 SoC. Fixes: b1201e44f50b ("can: xilinx CAN controller support") Signed-off-by: Anssi Hannula Cc: Signed-off-by: Marc Kleine-Budde --- drive

[PATCH 03/12] can: mpc5xxx_can: check of_iomap return before use

2018-07-23 Thread Marc Kleine-Budde
amily & mpc52xx_mscan") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/mscan/mpc5xxx_can.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c index c7427bdd3a4b..2949a381a94d 100644 --- a/drivers

[PATCH 01/12] can: peak_canfd: fix firmware < v3.3.0: limit allocation to 32-bit DMA addr only

2018-07-23 Thread Marc Kleine-Budde
le Signed-off-by: Marc Kleine-Budde --- drivers/net/can/peak_canfd/peak_pciefd_main.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/can/peak_canfd/peak_pciefd_main.c b/drivers/net/can/peak_canfd/peak_pciefd_main.c index b9e28578bc7b..455a3797a200 10064

Re: WARNING in can_rcv

2018-01-16 Thread Marc Kleine-Budde
n_once() will be more appropriate. It prints a single line. Thanks - just posted the patches, will send a pull request to David tomorrow. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Do

Re: WARNING in can_rcv

2018-01-17 Thread Marc Kleine-Budde
On 01/17/2018 09:07 AM, Oliver Hartkopp wrote: > > > On 01/17/2018 08:12 AM, Eric Biggers wrote: >> On Wed, Jan 17, 2018 at 07:39:24AM +0100, Oliver Hartkopp wrote: >>> >>> >>> On 01/16/2018 07:11 PM, Dmitry Vyukov wrote: >>>>

[PATCH 1/2] can: af_can: can_rcv(): replace WARN_ONCE by pr_warn_once

2018-01-18 Thread Marc Kleine-Budde
+4386709c0c1284dca...@syzkaller.appspotmail.com Suggested-by: Dmitry Vyukov <dvyu...@google.com> Acked-by: Oliver Hartkopp <socket...@hartkopp.net> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- net/can/af_can.c | 18 ++

pull-request: can 2018-01-18

2018-01-18 Thread Marc Kleine-Budde
: can: af_can: canfd_rcv(): replace WARN_ONCE by pr_warn_once (2018-01-18 09:32:54 +0100) linux-can-fixes-for-4.15-20180118 Marc Kleine-Budde (2): can: af_can

[PATCH 2/2] can: af_can: canfd_rcv(): replace WARN_ONCE by pr_warn_once

2018-01-18 Thread Marc Kleine-Budde
+e3b775f40babeff6e...@syzkaller.appspotmail.com Suggested-by: Dmitry Vyukov <dvyu...@google.com> Acked-by: Oliver Hartkopp <socket...@hartkopp.net> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- net/can/af_can.c | 18 ++

Re: [PATCH] can: m_can: select pinctrl state in each suspend/resume function

2018-03-12 Thread Marc Kleine-Budde
function 'pinctrl_pm_select_default_state' > [-Werror=implicit-function-declaration] > pinctrl_pm_select_default_state(dev); > ^ Fixed while applying the patch. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung We

[PATCH 4/6] can: peak/pcie_fd: fix echo_skb is occupied! bug

2018-03-12 Thread Marc Kleine-Budde
iana Burgess <di...@peloton-tech.com> Signed-off-by: Stephane Grosjean <s.grosj...@peak-system.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/peak_canfd/peak_canfd.c | 12 ++-- drive

[PATCH 6/6] can: m_can: select pinctrl state in each suspend/resume function

2018-03-12 Thread Marc Kleine-Budde
From: Bich HEMON <bich.he...@st.com> Make sure to apply the correct pin state in suspend/resume callbacks. Putting pins in sleep state saves power. Signed-off-by: Bich Hemon <bich.he...@st.com> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/m_can/m_

[PATCH 2/6] can: ifi: Check core revision upon probe

2018-03-12 Thread Marc Kleine-Budde
driver. Signed-off-by: Marek Vasut <ma...@denx.de> Cc: Heiko Schocher <h...@denx.de> Cc: Markus Marb <mar...@marb.org> Cc: Marc Kleine-Budde <m...@pengutronix.de> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de>

[PATCH 5/6] can: peak/pcie_fd: remove useless code when interface starts

2018-03-12 Thread Marc Kleine-Budde
tx may start. Signed-off-by: Stephane Grosjean <s.grosj...@peak-system.com> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/peak_canfd/peak_canfd.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(

[PATCH 3/6] can: ifi: Repair the error handling

2018-03-12 Thread Marc Kleine-Budde
e poll function. Signed-off-by: Marek Vasut <ma...@denx.de> Cc: Heiko Schocher <h...@denx.de> Cc: Markus Marb <mar...@marb.org> Cc: Marc Kleine-Budde <m...@pengutronix.de> Cc: linux-stable <sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutr

[PATCH 1/6] can: m_can: change comparison to bitshift when dealing with a mask

2018-03-12 Thread Marc Kleine-Budde
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Due to a typo, the mask was destroyed by a comparison instead of a bit shift. Reported-by: Geert Uytterhoeven <geert+rene...@glider.be> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Ma

pull-request: can 2018-03-12

2018-03-12 Thread Marc Kleine-Budde
Hello David, this is a pull reqeust of 6 patches for net/master. The first patch is by Wolfram Sang and fixes a bitshift vs. comparison mistake in the m_can driver. Two patches of Marek Vasut repair the error handling in the ifi driver. The two patches by Stephane Grosjean fix a "echo_skb is

Re: [PATCH] can: enable multi-queue for SocketCAN devices

2018-03-14 Thread Marc Kleine-Budde
v, echo_skb_max, 1, 1) > +#define alloc_candev_mq(sizeof_priv, echo_skb_max, count) \ > + alloc_candev_mqs(sizeof_priv, echo_skb_max, count, count) Can you make this a static inline function. > void free_candev(struct net_device *dev); > > /* a candev safe wrapper

Re: [PATCH] can: enable multi-queue for SocketCAN devices

2018-03-14 Thread Marc Kleine-Budde
w lines of code are missing to offer it to the > CAN networking subsystem as well. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | A

[PATCH 2/2] can: cc770: Fix queue stall & dropped RTR reply

2018-03-14 Thread Marc Kleine-Budde
.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/cc770/cc770.c | 94 ++- drivers/net/can/cc770/cc770.h | 2 + 2 files changed, 68 insertions(+), 28 deletions(-) diff --git a/drivers/net/can/cc770/cc770.c b/d

[PATCH 1/2] can: cc770: Fix stalls on rt-linux, remove redundant IRQ ack

2018-03-14 Thread Marc Kleine-Budde
<sta...@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/cc770/cc770.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/net/can/cc770/cc770.c b/drivers/net/can/cc770/cc770.c index 1e37313054f3..9fed163262e0 100644

pull-request: can 2018-03-14

2018-03-14 Thread Marc Kleine-Budde
Hello David, this is a pull request of two patches for net/master. Both patches are by Andri Yngvason and fix problems in the cc770 driver, that show up quite fast on RT systems, but also on non RT setups. regards, Marc --- The following changes since commit

Re: [PATCH] can: enable multi-queue for SocketCAN devices

2018-03-15 Thread Marc Kleine-Budde
early publication of our driver. >> >> Yes, please go ahead! > > Ok, I'll kick off the process and start to collect the required signatures. Tnx. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2

Re: [PATCH] can: enable multi-queue for SocketCAN devices

2018-03-15 Thread Marc Kleine-Budde
about the review I will get the process > rolling for an early publication of our driver. Yes, please go ahead! Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax:

Re: pull-request: can 2018-03-14

2018-03-14 Thread Marc Kleine-Budde
On 03/14/2018 01:24 PM, Andri Yngvason wrote: > On Wed, Mar 14, 2018 at 01:05:21PM +0100, Marc Kleine-Budde wrote: >> Hello David, >> >> this is a pull request of two patches for net/master. >> >> Both patches are by Andri Yngvason and fix problems in the cc770 d

Re: [PATCH] can: janz-ican3: fix ican3_xmit()'s return type

2018-04-25 Thread Marc Kleine-Budde
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> > --- Can you send a series fixing the return type in all CAN drivers? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924

Re: [PATCH 1/2] net: can: sja1000: Replace mdelay with usleep_range in peak_pci_probe

2018-04-25 Thread Marc Kleine-Budde
both to linux-can-next. tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature

pull-request: can 2018-03-19

2018-03-19 Thread Marc Kleine-Budde
Hello David, this is a pull reqeust of one patch for net/master. The patch is by Andri Yngvason and fixes a potential use-after-free bug in the cc770 driver introduced in the previous pull-request. regards, Marc --- The following changes since commit a069215cf5985f3aa1bba550264907d6bd05c5f7:

[PATCH] can: cc770: Fix use after free in cc770_tx_interrupt()

2018-03-19 Thread Marc Kleine-Budde
.@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de> --- drivers/net/can/cc770/cc770.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/cc770/cc770.c b/drivers/net/can/cc770/cc770.c index 2743d82d4424..6da69af103e6 100644 --- a/drive

Re: [PATCH v1 0/5] can: add SAE J1939 protocol

2018-10-30 Thread Marc Kleine-Budde
testing it is a time to send it mainline. I've removed some trailing newlines and added the stack to linux-can-next/j1939. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund

[PATCH 02/20] can: kvaser_usb: Fix potential uninitialized variable use

2018-11-12 Thread Marc Kleine-Budde
From: Jimmy Assarsson If alloc_can_err_skb() fails, cf is never initialized. Move assignment of cf inside check. Reported-by: Dan Carpenter Signed-off-by: Jimmy Assarsson Cc: linux-stable Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 10

[PATCH 13/20] can: dev: can_get_echo_skb(): factor out non sending code to __can_get_echo_skb()

2018-11-12 Thread Marc Kleine-Budde
This patch factors out all non sending parts of can_get_echo_skb() into a seperate function __can_get_echo_skb(), so that it can be re-used in an upcoming patch. Cc: linux-stable Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev.c | 36 +--- include

[PATCH 10/20] can: flexcan: Unlock the MB unconditionally

2018-11-12 Thread Marc Kleine-Budde
-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 8e972ef08637..0431f8d05518 100644 --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c @@ -720,9

pull-request: can 2018-11-09

2018-11-12 Thread Marc Kleine-Budde
: kvaser_usb: Fix accessing freed memory in kvaser_usb_start_xmit() Lukas Wunner (1): can: hi311x: Use level-triggered interrupt Marc Kleine-Budde (5): can: flexcan: remove not needed struct flexcan_priv::tx_mb and struct flexcan_priv::tx_mb_idx can: dev: can_get_echo_skb

[PATCH 06/20] dt-bindings: can: rcar_can: document r8a77965 support

2018-11-12 Thread Marc Kleine-Budde
d-by: Kieran Bingham Reviewed-by: Rob Herring Signed-off-by: Marc Kleine-Budde --- Documentation/devicetree/bindings/net/can/rcar_can.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicet

[PATCH 01/20] can: raw: check for CAN FD capable netdev in raw_sendmsg()

2018-11-12 Thread Marc Kleine-Budde
drop that CAN FD frame anyway - but with this patch the user gets a proper -EINVAL return code. Signed-off-by: Oliver Hartkopp Cc: linux-stable Signed-off-by: Marc Kleine-Budde --- net/can/raw.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/net/can/raw.c b

[PATCH 04/20] can: ucan: remove set but not used variable 'udev'

2018-11-12 Thread Marc Kleine-Budde
-by: Martin Elshuber Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/ucan.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c index 0678a38b1af4..c9fd83e8d947 100644 --- a/drivers/net/can/usb/ucan.c +++ b/drivers/net/can/usb

[PATCH 03/20] can: kvaser_usb: Fix accessing freed memory in kvaser_usb_start_xmit()

2018-11-12 Thread Marc Kleine-Budde
Signed-off-by: Jimmy Assarsson Cc: linux-stable Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_

[PATCH 07/20] can: rcar_can: Fix erroneous registration

2018-11-12 Thread Marc Kleine-Budde
clocks") Signed-off-by: Fabrizio Castro Signed-off-by: Chris Paterson Reviewed-by: Simon Horman Signed-off-by: Marc Kleine-Budde --- drivers/net/can/rcar/rcar_can.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/r

<    1   2   3   4   5   >