Re: [PATCH] net/9p: correct some comment errors in 9p file system code

On 05/07/2018 05:45 PM, Sun Lianwen wrote: > There are follow comment errors: > 1 The function name is wrong in p9_release_pages() comment. > 2 The function name and variable name is wrong in p9_poll_workfn() comment. > 3 There is no variable dm_mr and lkey in struct p9_trans_rdma. > 4 The

Re: [PATCH] net/9p: correct some comment errors in 9p file system code

ns_rdma. > 4 The function name is wrong in rdma_create_trans() comment. > 5 There is no variable initialized in struct virtio_chan. > 6 The variable name is wrong in p9_virtio_zc_request() comment. > > Signed-off-by: Sun Lianwen <sunlw.f...@cn.fujitsu.com> > Reviewed-by: Randy Dun

Re: linux-next: Tree for May 9 (mlx5)

On 05/09/2018 04:21 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180508: > on x86_64: # CONFIG_SMP is not set In file included from ../drivers/net/ethernet/mellanox/mlx5/core/main.c:43:0: ../include/linux/mlx5/driver.h: In function 'mlx5_get_vector_affinity_hint':

Re: [net-next] ipv6: sr: Add documentation for seg_flowlabel sysctl

On 04/27/2018 03:35 AM, Ahmed Abdelsalam wrote: > This patch adds a documentation for seg_flowlabel sysctl into > Documentation/networking/ip-sysctl.txt > > Signed-off-by: Ahmed Abdelsalam > --- > Documentation/networking/ip-sysctl.txt | 13 + > 1 file changed,

Re: linux-next: Tree for May 7 (net/xdp)

On 05/06/2018 10:31 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180504: > on i386: net/xdp/xdp_umem.o: In function `xdp_umem_reg': xdp_umem.c:(.text+0x47e): undefined reference to `__udivdi3' -- ~Randy

Re: [PATCH bpf-next] xsk: fix 64-bit division

he GCC built-in. > > Fixes: c0c77d8fb787 ("xsk: add user memory registration support sockopt") > Signed-off-by: Björn Töpel <bjorn.to...@intel.com> I don't know why the subject says xsk (instead of xdp), but anyway: Reported-by: Randy Dunlap <rdun...@infradead.org&g

Re: mmotm 2018-05-25-14-52 uploaded (drivers/net/ethernet/ti/davinci_mdio.c)

[forgot to add netdev] On 05/25/2018 04:14 PM, Randy Dunlap wrote: > On 05/25/2018 02:52 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2018-05-25-14-52 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-re

Re: [PATCH] fault-injection: reorder config entries

On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > This patch reorders Kconfig entries, so that menuconfig displays proper > indentation. > > Signed-off-by: Mikulas Patocka <mpato...@redhat.com> Acked-by: Randy Dunlap <rdun...@infradead.org> Tested-by: Randy Dunlap <rdu

Re: [PATCH] atm: zatm: Fix potential Spectre v1

On 05/03/2018 11:17 AM, Gustavo A. R. Silva wrote: > pool can be indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > drivers/atm/zatm.c:1462 zatm_ioctl() warn: potential

[PATCH] textsearch: fix typos in library helpers

From: Randy Dunlap <rdun...@infradead.org> Fix spellos (typos) in textsearch library helpers. Signed-off-by: Randy Dunlap <rdun...@infradead.org> --- lib/ts_fsm.c |2 +- lib/ts_kmp.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- lnx-414-rc5.orig/lib/ts_fsm.c

Re: [PATCH RFC 2/4] netlink: add generic object description infrastructure

On 02/06/2018 05:37 PM, Pablo Neira Ayuso wrote: > This patch allows netlink busses to provide object descriptions to > userspace, in terms of supported attributes and its corresponding > datatypes. > > Userspace sends a requests that looks like: > > netlink header > NLA_DESC_REQ_BUS

Re: [PATCH] headers: untangle kmemleak.h from mm.h

On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmeml

Re: [PATCH] headers: untangle kmemleak.h from mm.h

On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmeml

[PATCH] headers: untangle kmemleak.h from mm.h

From: Randy Dunlap <rdun...@infradead.org> Currently #includes for no obvious reason. It looks like it's only a convenience, so remove kmemleak.h from slab.h and add to any users of kmemleak_* that don't already #include it. Also remove from source files that do not use it. This is

Re: [PATCH] headers: untangle kmemleak.h from mm.h

On 02/13/2018 02:09 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> On 02/12/2018 04:28 AM, Michael Ellerman wrote: >>> Randy Dunlap <rdun...@infradead.org> writes: >>> >>>> From: Randy Dunlap <rdun...@infr

Re: [PATCH] headers: untangle kmemleak.h from mm.h

On 02/11/2018 11:27 PM, Ingo Molnar wrote: > > * Randy Dunlap <rdun...@infradead.org> wrote: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove km

Re: [net-next v2 2/2] bpf: Add eBPF seccomp sample programs

On 02/16/2018 11:36 PM, Sargun Dhillon wrote: > + close(111); > + assert(errno == EBADF); > + close(999); > + assert(errno = EPERM); should that be == ? > + > + return 0; > +} -- ~Randy

Re: Kernel panic with 4.16-rc1 (and 4.16-rc2) running selftest

[add Matthew Wilcox; hopefully he can look/see] On 02/23/2018 04:13 PM, Cong Wang wrote: > On Fri, Feb 23, 2018 at 3:27 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >> On Fri, Feb 23, 2018 at 11:00 AM, Randy Dunlap <rdun...@infradead.org> wrote: >>> [adding netde

Re: Kernel panic with 4.16-rc1 (and 4.16-rc2) running selftest

[adding netdev] On 02/23/2018 08:05 AM, Khalid Aziz wrote: > I am seeing a kernel panic with 4.16-rc1 and 4.16-rc2 kernels when running > selftests > from tools/testing/selftests. Last messages from selftest before kernel panic > are: > > > running psock_tpacket test >

[PATCH v2] tcp: identify cryptic messages as TCP seq # bugs

From: Randy Dunlap Attempt to make cryptic TCP seq number error messages clearer by (1) identifying the source of the message as "TCP", (2) identifying the errors as "seq # bug", and (3) grouping the field identifiers and values by separating them with commas. E.g., t

Re: linux-next: Tree for Jul 25 (netfilter)

n_nat_ipv4.o: In function `nft_chain_nat_exit': nft_chain_nat_ipv4.c:(.exit.text+0x9): undefined reference to `nft_unregister_chain_type' net/ipv4/netfilter/nft_chain_nat_ipv4.o: In function `nft_chain_nat_init': nft_chain_nat_ipv4.c:(.init.text+0x9): undefined reference to `nft_register_chain_type' Report

[PATCH] isdn/capi: fix defined but not used warnings

From: Randy Dunlap Fix build warnings in drivers/isdn/capi/ when CONFIG_PROC_FS is not enabled by marking the unused functions as __maybe_unused. ../drivers/isdn/capi/capi.c:1324:12: warning: 'capi20_proc_show' defined but not used [-Wunused-function] ../drivers/isdn/capi/capi.c:1347:12

[PATCH] connector: fix defined but not used warning

From: Randy Dunlap Fix a build warning in connector.c when CONFIG_PROC_FS is not enabled by marking the unused function as __maybe_unused. ../drivers/connector/connector.c:242:12: warning: 'cn_proc_show' defined but not used [-Wunused-function] Signed-off-by: Randy Dunlap Cc: Evgeniy

[PATCH net-next] TCP: make seq # error messages more readable

From: Randy Dunlap Attempt to make cryptic TCP seq number error messages clearer by (1) adding the function name, (2) identifying the errors as "seq # bug", and (3) grouping the field identifiers and values by separating them with commas. E.g., the following message is changed from

Re: [PATCH net-next] TCP: make seq # error messages more readable

On 07/13/2018 06:38 AM, Eric Dumazet wrote: > > > On 07/12/2018 05:48 PM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Attempt to make cryptic TCP seq number error messages clearer by >> (1) adding the function name, (2) identifying the errors as "seq

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

On 03/08/2018 11:14 AM, Doug Ledford wrote: > On 3/8/2018 1:04 PM, David Miller wrote: >> From: Saeed Mahameed >> Date: Wed, 7 Mar 2018 17:26:03 -0800 >> >>> Hi Dave and Doug, >>> >>> This series includes shared code updates (IPSec part2) for mlx5 core >>> driver for both

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On 03/09/2018 04:07 PM, Andrew Morton wrote: > On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote: > >> When max() is used in stack array size calculations from literal values >> (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the compiler >> thinks this is a

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

On 04/20/18 09:28, Alexander Duyck wrote: > This series is meant to add support for SR-IOV on devices when the VFs are > not managed by the kernel. Examples of recent patches attempting to do this > include: > virto - https://patchwork.kernel.org/patch/10241225/ > pci-stub -

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

On 04/20/18 13:01, Alexander Duyck wrote: > On Fri, Apr 20, 2018 at 10:23 AM, Randy Dunlap <rdun...@infradead.org> wrote: >> On 04/20/18 09:28, Alexander Duyck wrote: >>> This series is meant to add support for SR-IOV on devices when the VFs are >>> not managed

[PATCH] netfilter: fix nf_tables filter chain type build

From: Randy Dunlap <rdun...@infradead.org> Fix build errors due to a missing Kconfig dependency term. Fixes these build errors: net/ipv6/netfilter/nft_chain_nat_ipv6.o: In function `nft_nat_do_chain': net/ipv6/netfilter/nft_chain_nat_ipv6.c:37: undefined reference to `nft_do_chain' ne

[PATCH] textsearch: fix kernel-doc warnings and add kernel-api section

From: Randy Dunlap <rdun...@infradead.org> Make lib/textsearch.c usable as kernel-doc. Add textsearch() function family to kernel-api documentation. Fix kernel-doc warnings in : ../include/linux/textsearch.h:65: warning: Incorrect use of kernel-doc format: * get_next_block - fetc

Re: [PATCH net-next] Documentation/networking: Add net DIM documentation

On 03/21/2018 02:30 AM, Tal Gilboa wrote: > Net DIM is a generic algorithm, purposed for dynamically > optimizing network devices interrupt moderation. This > document describes how it works and how to use it. > > Signed-off-by: Tal Gilboa > --- >

Re: [PATCH net-next] Documentation/networking: Add net DIM documentation

On 03/21/2018 11:20 AM, Marcelo Ricardo Leitner wrote: > On Wed, Mar 21, 2018 at 11:30:29AM +0200, Tal Gilboa wrote: > ... >> +Dynamic Interrupt Moderation (DIM) (in networking) refers to changing the >> interrupt >> +moderation configuration of a channel in order to optimize packet >>

Re: [PATCH net-next V2] Documentation/networking: Add net DIM documentation

+int my_driver_handle_interrupt(struct my_driver_entity *my_entity, ...) > +{ > + ... > + /* A struct to hold current measured data */ > + struct net_dim_sample dim_sample; > + ... > + /* Initiate data sample struct with current data */ > + net_dim_sample(my_entity->events, > +my_entity->packets, > +my_entity->bytes, > +_sample); > + /* Call net DIM */ > + net_dim(_entity->dim, dim_sample); > + ... > +} > + > +/* My entity's initialization function (my_entity was already allocated) */ > +int my_driver_init_my_entity(struct my_driver_entity *my_entity, ...) > +{ > + ... > + /* Initiate struct work_struct with my driver's callback function */ > + INIT_WORK(_entity->dim.work, my_driver_do_dim_work); > + ... > +} > Reviewed-by: Randy Dunlap <rdun...@infradead.org> thanks, -- ~Randy

[PATCH] ethernet: natsemi: correct spelling

From: Randy Dunlap <rdun...@infradead.org> Correct spelling of National Semi-conductor (no hyphen) in drivers/net/ethernet/. Signed-off-by: Randy Dunlap <rdun...@infradead.org> --- drivers/net/ethernet/8390/Kconfig |2 +- drivers/net/ethernet/natsemi/Kconfig |6 +++---

[PATCH] net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

From: Randy Dunlap <rdun...@infradead.org> Lots of the wireless driver vendor Kconfig symol help text says "questions about cards." (2 spaces between "about" and "cards") Besides dropping one of those spaces, it also needs some other word inserted there. I

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

Hi, On 03/05/2018 05:34 PM, Alexei Starovoitov wrote: > diff --git a/kernel/module.c b/kernel/module.c > index ad2d420024f6..6cfa35795741 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3669,6 +3683,17 @@ static int load_module(struct load_info *info, const > char __user *uargs, >

Re: [PATCH v4] fault-injection: introduce kvmalloc fallback options

On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > > > From: Mikulas Patocka > Subject: [PATCH v4] fault-injection: introduce kvmalloc fallback options > > This patch introduces a fault-injection option "kvmalloc_fallback". This > option makes kvmalloc randomly fall back to

Re: [PATCH v5] fault-injection: introduce kvmalloc fallback options

On 04/25/2018 01:57 PM, Mikulas Patocka wrote: > > > On Wed, 25 Apr 2018, Randy Dunlap wrote: > >> On 04/25/2018 01:02 PM, Mikulas Patocka wrote: >>> >>> >>> From: Mikulas Patocka <mpato...@redhat.com> >>> Subject: [PA

Re: [PATCH] add an initial version of snmp_counter.rst

On 11/9/18 10:13 AM, yupeng wrote: > The snmp_counter.rst run a set of simple experiments, explains the > meaning of snmp counters depend on the experiments' results. This is > an initial version, only covers a small part of the snmp counters. > > Signed-off-by: yupeng > --- >

Re: [PATCH net V2] cxgb4: fix thermal zone build error

d of IS_ENABLED to fix the issue. > > Fixes: e70a57fa59bb (cxgb4: fix thermal configuration dependencies) > Reported-by: Randy Dunlap > Signed-off-by: Ganesh Goudar Acked-by: Randy Dunlap Thanks. > --- > V2: Fixing spelling mistake and avoid preprocessor conditionals. >

Re: [PATCH net-next] net: core: change bool members of struct net_device to bitfield members

On 10/8/18 1:00 PM, Heiner Kallweit wrote: > bool is good as parameter type or function return type, but if used > for struct members it consumes more memory than needed. > Changing the bool members of struct net_device to bitfield members > allows to decrease the memory footprint of this struct.

Re: [PATCH bpf-next] flow_dissector: fix build failure without CONFIG_NET

are not compiled and move the BPF_PROG_TYPE > definition in the #ifdef CONFIG_NET block. > > Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook") > Reported-by: Randy Dunlap > Signed-off-by: Willem de Bruijn Works for me. Thanks. Acked-by: Randy Du

<    1   2   3