Re: [PATCH net-next] net: delete "register" keyword

2019-08-08 Thread Simon Horman
-- > net/netfilter/ipvs/ip_vs_ctl.c|4 ++-- > net/netfilter/ipvs/ip_vs_lblcr.c |4 ++-- > 4 files changed, 21 insertions(+), 21 deletions(-) IPVS portion: Reviewed-by: Simon Horman > > --- a/drivers/net/ethernet/apple/bmac.c > +++ b/drivers/net/ether

[PATCH net] nfp: do not send control messages during cleanup

2020-12-11 Thread Simon Horman
t;net: flow_offload: fix flow_indr_dev_unregister path") Cc: wenxu Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c

Re: [PATCH net] nfp: do not send control messages during cleanup

2020-12-15 Thread Simon Horman
On Mon, Dec 14, 2020 at 06:26:50PM -0800, Jakub Kicinski wrote: > On Fri, 11 Dec 2020 10:27:38 +0100 Simon Horman wrote: > > On cleanup the txbufs are freed before app cleanup. But app clean-up may > > result in control messages due to use of common control paths. There is no >

[PATCH net] nfp: move indirect block cleanup to flower app stop callback

2020-12-16 Thread Simon Horman
problem may be resolved by moving the indirect block cleanup to the stop callback, where txbufs are still available. As suggested by Jakub Kicinski and Louis Peens. Fixes: a1db217861f3 ("net: flow_offload: fix flow_indr_dev_unregister path") Signed-off-by: Simon Horman Signed-off-by: L

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Simon Horman
ochip/Kconfig | 1 + > drivers/net/ethernet/netronome/Kconfig | 1 + > drivers/net/ethernet/nxp/Kconfig| 1 + > drivers/net/ethernet/rocker/Kconfig | 1 + > 10 files changed, 10 insertions(+) Hi Arnd, I'm slightly curious to know how you configured the kernel to build the Netronome NFP driver but not CRC32 but nonetheless I have no objection to this change. For the Netronome portion: Acked-by: Simon Horman

[PATCH] nfp: Replace zero-length array with flexible-array member

2020-12-04 Thread Simon Horman
ed[2]. [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays Cc: Gustavo A. R. Silva Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- drivers/net/ethernet/netronome/nfp/crypto/fw.h

Re: [PATCH net-next] nfp: silence set but not used warning with IPV6=n

2020-12-09 Thread Simon Horman
gt; > Reported-by: kernel test robot > Signed-off-by: Jakub Kicinski Thanks Jakub, this looks good to me. Reviewed-by: Simon Horman

Re: [PATCH] nfp: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread Simon Horman
Thanks, this does indeed seem to be the case. Reviewed-by: Simon Horman

Re: [PATCH][next] nfp: tls: Fix unreachable code issue

2020-11-17 Thread Simon Horman
ion > of macro 'fallthrough' > 299 | fallthrough; > | ^~~ > > Reported-by: kernel test robot > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Simon Horman

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-24 Thread Simon Horman
w if its intentionally that the following was left alone in ethernet/netronome/nfp/nfp_net_ethtool.c:nfp_net_get_nspinfo() snprintf(version, ETHTOOL_FWVERS_LEN, "%hu.%hu" If the above was not intentional then perhaps you could respin with that updated and resubmit when net-next re-opens. Feel free to add: Reviewed-by: Simon Horman

Re: [iproute2-next] tc flower: use right ethertype in icmp/arp parsing

2020-10-26 Thread Simon Horman
On Sun, Oct 25, 2020 at 03:18:48PM -0600, David Ahern wrote: > On 10/19/20 5:47 AM, Zahari Doychev wrote: > > Currently the icmp and arp prsing functions are called with inccorect > > ethtype in case of vlan or cvlan filter options. In this case either > > cvlan_ethtype or vlan_ethtype has to be us

Re: [PATCH net-next 3/6] virtio_net: support device stats

2024-01-03 Thread Simon Horman
On Fri, Dec 22, 2023 at 11:30:18AM +0800, Xuan Zhuo wrote: > As the spec > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > Virtio-net supports to get the stats from the device by ethtool -S . > > Signed-off-by: Xuan Zhuo Hi Xuan Zhuo, some minor fe

Re: [PATCH net-next 2/3] virtio-net: batch dim request

2024-01-16 Thread Simon Horman
On Tue, Jan 16, 2024 at 09:11:32PM +0800, Heng Qi wrote: > Currently, when each time the driver attempts to update the coalescing > parameters for a vq, it needs to kick the device. > The following path is observed: > 1. Driver kicks the device; > 2. After the device receives the kick, CPU sche

Re: [PATCH net-next 3/3] virtio-net: reduce the CPU consumption of dim worker

2024-01-16 Thread Simon Horman
On Tue, Jan 16, 2024 at 09:11:33PM +0800, Heng Qi wrote: > Accumulate multiple request commands to kick the device once, > and obtain the processing results of the corresponding commands > asynchronously. The batch command method is used to optimize the > CPU overhead of the DIM worker caused by th

Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-02-27 Thread Simon Horman
On Tue, Feb 27, 2024 at 04:03:00PM +0800, Xuan Zhuo wrote: > As the spec > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > make virtio-net support getting the stats from the device by ethtool -S > . > > Signed-off-by: Xuan Zhuo ... > +static int vi

Re: [PATCH net-next v5 0/9] virtio-net: support device stats

2024-03-21 Thread Simon Horman
On Thu, Mar 21, 2024 at 11:54:34AM +0800, Xuan Zhuo wrote: > On Wed, 20 Mar 2024 20:38:01 -0700, Jakub Kicinski wrote: > > On Wed, 20 Mar 2024 16:04:21 +0800 Xuan Zhuo wrote: > > > I have a question regarding the workflow for feature discussions. If we > > > consistently engage in discussions abou

Re: [PATCH net-next 2/4] virtio_net: Remove command data from control_buf

2024-03-28 Thread Simon Horman
On Mon, Mar 25, 2024 at 04:49:09PM -0500, Daniel Jurgens wrote: > Allocate memory for the data when it's used. Ideally the could be on the > stack, but we can't DMA stack memory. With this change only the header > and status memory are shared between commands, which will allow using a > tighter loc

Re: [PATCH net-next v5 1/4] ethtool: provide customized dim profile management

2024-04-11 Thread Simon Horman
On Wed, Apr 10, 2024 at 11:13:15AM +0800, Heng Qi wrote: > > > 在 2024/4/10 上午9:44, Jakub Kicinski 写道: > > On Tue, 9 Apr 2024 20:03:21 +0800 Heng Qi wrote: > > > +/** > > > + * coalesce_put_profile - fill reply with a nla nest with four child nla > > > nests. > > > + * @skb: socket buffer the me

Re: [PATCH net-next v7 2/4] ethtool: provide customized dim profile management

2024-04-15 Thread Simon Horman
On Mon, Apr 15, 2024 at 05:36:36PM +0800, Heng Qi wrote: ... > @@ -10229,6 +10230,61 @@ static void netdev_do_free_pcpu_stats(struct > net_device *dev) > } > } > > +static int dev_dim_profile_init(struct net_device *dev) > +{ > +#if IS_ENABLED(CONFIG_DIMLIB) > + u32 supported = dev-

Re: [PATCH net-next 0/7] virtnet_net: prepare for af-xdp

2024-05-08 Thread Simon Horman
On Wed, May 08, 2024 at 04:05:07PM +0800, Xuan Zhuo wrote: > This patch set prepares for supporting af-xdp zerocopy. > There is no feature change in this patch set. > I just want to reduce the patch num of the final patch set, > so I split the patch set. > > #1-#3 add independent directory for vir

Re: [PATCH net-next] net: virtio: fix virtnet_sq_free_stats initialization

2024-07-12 Thread Simon Horman
On Fri, Jul 12, 2024 at 06:41:34AM -0400, Michael S. Tsirkin wrote: > On Fri, Jul 12, 2024 at 09:03:30AM +0100, Jean-Philippe Brucker wrote: > > Commit c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits") > > added two new fields to struct virtnet_sq_free_stats, but commit > > 23c81a20b99

Re: [RFC net-next 3/3] drivers/vdpa: add NFP devices vDPA driver

2024-08-07 Thread Simon Horman
On Fri, Aug 02, 2024 at 11:59:31AM +0200, Louis Peens wrote: > From: Kyle Xu > > Add a new kernel module ‘nfp_vdpa’ for the NFP vDPA networking driver. > > The vDPA driver initializes the necessary resources on the VF and the > data path will be offloaded. It also implements the ‘vdpa_config_ops

[PATCH net] ethtool: fix the check logic of at least one channel for RX/TX

2021-02-23 Thread Simon Horman
10. Fixes: 7be92514b99c ("ethtool: check if there is at least one channel for TX/RX in the core") Signed-off-by: Yinjun Zhang Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- net/ethtool/channels.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/etht

[PATCH net v2] ethtool: fix the check logic of at least one channel for RX/TX

2021-02-25 Thread Simon Horman
10. Fixes: 7be92514b99c ("ethtool: check if there is at least one channel for TX/RX in the core") Signed-off-by: Yinjun Zhang Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- V2: (suggested by Jakub Kicinski) - A better change to fix the check of exceeding max count as well --- ne

[PATCH iproute2-next] police: add support for packet-per-second rate limiting

2021-03-26 Thread Simon Horman
action order 0: police 0x1 rate 0bit burst 0b mtu 4096Mb pkts_rate 1000 pkts_burst 200 ref 1 bind 0 Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- man/man8/tc-police.8 | 35 --- tc/m_police.c| 50

[PATCH net-next 2/2] selftests: forwarding: Add tc-police tests for packets per second

2021-03-26 Thread Simon Horman
From: Baowen Zheng Test tc-police action for packets per second. The test is mainly in scenarios Rx policing and Tx policing. The test passes with veth pairs ports. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman --- tools/testing/selftests/net/forwarding/lib.sh | 9

[PATCH net-next 0/2] selftest: add tests for packet per second

2021-03-26 Thread Simon Horman
Add self tests for the recently added packet per second rate limiting feature of the TC policer action[1]. The forwarding selftest (patch 2/2) depends on iproute2 support for packet per second rate limiting, which has been posted separately[2] [1] [PATCH v3 net-next 0/3] net/sched: act_police: ad

[PATCH net-next 1/2] selftests: tc-testing: add action police selftest for packets per second

2021-03-26 Thread Simon Horman
From: Baowen Zheng Add selftest cases in action police for packets per second. These tests depend on corresponding iproute2 command support. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman --- It is also planned, as a follow-up, to provide packet per second rate limiting tests in

Re: [PATCH] netfilter: ipvs: A spello fix

2021-03-27 Thread Simon Horman
+ netfilter-de...@vger.kernel.org On Sat, Mar 27, 2021 at 04:42:48AM +0530, Bhaskar Chowdhury wrote: > s/registerd/registered/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Simon Horman > --- > net/netfilter/ipvs/ip_vs_core.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH 08/19] netfilter: ipvs: A spello fix

2021-03-27 Thread Simon Horman
+ netfilter-de...@vger.kernel.org On Sat, Mar 27, 2021 at 04:43:01AM +0530, Bhaskar Chowdhury wrote: > s/registerd/registered/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Simon Horman > --- > net/netfilter/ipvs/ip_vs_core.c | 2 +- > 1 file changed, 1 insert

[PATCH net] nfp: flower: ignore duplicate merge hints from FW

2021-03-30 Thread Simon Horman
ctx's which are a limited resource. Avoid the duplicate merge by using hash table to store the sub_flows to be merged. Fixes: 8af56f40e53b ("nfp: flower: offload merge flows") Signed-off-by: Yinjun Zhang Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- .../net/ethernet/

[PATCH net-next] nfp: flower: add support for packet-per-second policing

2021-04-06 Thread Simon Horman
Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- .../net/ethernet/netronome/nfp/flower/main.h | 4 +- .../ethernet/netronome/nfp/flower/qos_conf.c | 161 +- 2 files changed, 119 insertions(+), 46 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp

[PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-26 Thread Simon Horman
parent : u32 match \ u32 0 0 police pkts_rate 3000 pkts_burst 1000 Testing was unable to uncover a performance impact of this change on existing features. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- include/net/sch_generic.h | 15

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-27 Thread Simon Horman
Hi Jakub, On Tue, Jan 26, 2021 at 06:38:12PM -0800, Jakub Kicinski wrote: > On Mon, 25 Jan 2021 16:18:19 +0100 Simon Horman wrote: > > From: Baowen Zheng > > > > Allow a policer action to enforce a rate-limit based on packets-per-second, > > configurable using a packe

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-28 Thread Simon Horman
On Wed, Jan 27, 2021 at 12:59:05PM -0800, Jakub Kicinski wrote: > On Wed, 27 Jan 2021 12:02:23 +0100 Simon Horman wrote: > > > > +void psched_ppscfg_precompute(struct psched_pktrate *r, > > > > + u64 pktrate64) > > > > +{

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-28 Thread Simon Horman
On Wed, Jan 27, 2021 at 12:02:23PM +0100, Simon Horman wrote: > Hi Jakub, > > On Tue, Jan 26, 2021 at 06:38:12PM -0800, Jakub Kicinski wrote: > > On Mon, 25 Jan 2021 16:18:19 +0100 Simon Horman wrote: > > > From: Baowen Zheng > > > > > > Allow a polic

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
On Thu, Jan 28, 2021 at 06:19:33PM +0200, Ido Schimmel wrote: > On Mon, Jan 25, 2021 at 04:18:19PM +0100, Simon Horman wrote: > > From: Baowen Zheng > > > > Allow a policer action to enforce a rate-limit based on packets-per-second, > > configurable using a packe

Re: [PATCH net-next v2] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
On Fri, Jan 29, 2021 at 09:30:00AM -0500, Jamal Hadi Salim wrote: > On 2021-01-29 5:28 a.m., Simon Horman wrote: > > From: Baowen Zheng > > > > Allow a policer action to enforce a rate-limit based on packets-per-second, > > configurable using a packet-per-second rate

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
On Mon, Feb 01, 2021 at 01:31:17PM +0100, Simon Horman wrote: > On Thu, Jan 28, 2021 at 06:19:33PM +0200, Ido Schimmel wrote: > > On Mon, Jan 25, 2021 at 04:18:19PM +0100, Simon Horman wrote: > > > From: Baowen Zheng > > > > > > Allow a policer act

Re: [PATCH net-next v2] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
Hi Cong, On Fri, Jan 29, 2021 at 03:04:51PM -0800, Cong Wang wrote: > On Fri, Jan 29, 2021 at 2:29 AM Simon Horman > wrote: > > +/** > > + * psched_ratecfg_precompute__() - Pre-compute values for reciprocal > > division > > + * @rate: Rate to compute

Re: [PATCH net-next v2] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
On Sat, Jan 30, 2021 at 04:57:38PM +0200, Ido Schimmel wrote: > On Fri, Jan 29, 2021 at 03:04:51PM -0800, Cong Wang wrote: > > On Fri, Jan 29, 2021 at 2:29 AM Simon Horman > > wrote: > > I didn't get v2 (didn't made it to the list), but I did leave feedback >

Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang

2021-03-05 Thread Simon Horman
inux/issues/115 > Signed-off-by: Gustavo A. R. Silva Thanks Gustavo, this looks good to me. Acked-by: Simon Horman > --- > drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net

Re: [RFC PATCH 03/10] nfp: Replace nfp_pr_et with ethtool_gsprintf

2021-03-11 Thread Simon Horman
> > Since they are so close just update nfp to make use of ethtool_gsprintf > > Signed-off-by: Alexander Duyck Reviewed-by: Simon Horman

[PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-12 Thread Simon Horman
This series enhances the TC policer action implementation to allow a policer action instance to enforce a rate-limit based on packets-per-second, configurable using a packet-per-second rate and burst parameters. In the hope of aiding review this is broken up into three patches. * [PATCH 1/3] flow

[PATCH v3 net-next 2/3] flow_offload: reject configuration of packet-per-second policing in offload drivers

2021-03-12 Thread Simon Horman
Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- drivers/net/dsa/sja1105/sja1105_flower.c | 6 ++ .../net/ethernet/chelsio/cxgb4/cxgb4_tc_matchall.c| 11 ++- drivers/net/ethernet/freescale/enetc/enetc_qos.c | 5 + drivers/net/ethernet

[PATCH v3 net-next 3/3] net/sched: act_police: add support for packet-per-second policing

2021-03-12 Thread Simon Horman
uncover a performance impact of this change on existing features. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- include/net/sch_generic.h | 14 +++ include/net/tc_act/tc_police.h | 48 -- include/uapi/linux/pkt_cls.h | 2

[PATCH v3 net-next 1/3] flow_offload: add support for packet-per-second policing

2021-03-12 Thread Simon Horman
, and TC code portion of this feature into separate patches with the aim of providing a logical flow for review. And the implementation of these helpers will be filled out by a follow-up patch. Signed-off-by: Xingfeng Hu Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- include/net

Re: [PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-12 Thread Simon Horman
On Fri, Mar 12, 2021 at 03:08:28PM +0100, Simon Horman wrote: > This series enhances the TC policer action implementation to allow a > policer action instance to enforce a rate-limit based on > packets-per-second, configurable using a packet-per-second rate and burst > parameters. .

Re: [PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-15 Thread Simon Horman
On Sun, Mar 14, 2021 at 10:17:37AM +0200, Ido Schimmel wrote: > On Fri, Mar 12, 2021 at 03:08:28PM +0100, Simon Horman wrote: > > This series enhances the TC policer action implementation to allow a > > policer action instance to enforce a rate-limit based on > > packets-per

Re: [PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-16 Thread Simon Horman
Hi Ido, On Tue, Mar 16, 2021 at 10:35:35AM +0200, Ido Schimmel wrote: > Sorry for the delay. Was AFK yesterday No problem at all. ... > > > > As follow-ups we plan to provide: > > > > * Corresponding updates to iproute2 > > > > * Corresponding self tests (which depend on the iproute2 changes) >

Re: [PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-16 Thread Simon Horman
On Tue, Mar 16, 2021 at 09:53:49AM -0400, Jamal Hadi Salim wrote: > On 2021-03-12 9:22 a.m., Simon Horman wrote: > > On Fri, Mar 12, 2021 at 03:08:28PM +0100, Simon Horman wrote: > > > This series enhances the TC policer action implementation to allow a > > > policer a

[PATCH net 1/3] nfp: flower: fix unsupported pre_tunnel flows

2021-03-16 Thread Simon Horman
: 120ffd84a9ec ("nfp: flower: verify pre-tunnel rules") Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- .../ethernet/netronome/nfp/flower/offload.c| 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/d

[PATCH net 2/3] nfp: flower: add ipv6 bit to pre_tunnel control message

2021-03-16 Thread Simon Horman
From: Louis Peens Differentiate between ipv4 and ipv6 flows when configuring the pre_tunnel table to prevent them trampling each other in the table. Fixes: 783461604f7e ("nfp: flower: update flow merge code to support IPv6 tunnels") Signed-off-by: Louis Peens Signed-off-by: Si

[PATCH net 0/3] Fixes for nfp pre_tunnel code

2021-03-16 Thread Simon Horman
Louis Peens says: The following set of patches fixes up a few bugs in the pre_tun decap code paths which has been hiding for a while. Louis Peens (3): nfp: flower: fix unsupported pre_tunnel flows nfp: flower: add ipv6 bit to pre_tunnel control message nfp: flower: fix pre_tun mask id alloc

[PATCH net 3/3] nfp: flower: fix pre_tun mask id allocation

2021-03-16 Thread Simon Horman
id, which triggers the allocation on the firmware side. This leads to the firmware mask being corrupted and causing all sorts of strange behaviour. Fixes: f12725d98cbe ("nfp: flower: offload pre-tunnel rules") Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- .../ethernet/

Re: [PATCH] drivers: net: ethernet: struct sk_buff is declared duplicately

2021-03-25 Thread Simon Horman
On Thu, Mar 25, 2021 at 02:35:55PM +0800, Wan Jiabing wrote: > struct sk_buff has been declared. Remove the duplicate. > > Signed-off-by: Wan Jiabing Thanks, nice catch. Reviewed-by: Simon Horman

Re: [Linux-kernel-mentees] [PATCH net-next v2] ipvs: Fix uninit-value in do_ip_vs_set_ctl()

2020-08-11 Thread Simon Horman
Anastasov Pablo, could you consider this for nf-next or should we repost when net-next re-opens? Reviewed-by: Simon Horman

Re: [PATCH net] nfp: update maintainer

2020-08-11 Thread Simon Horman
On Mon, Aug 10, 2020 at 12:11:42PM -0700, David Miller wrote: > From: Jakub Kicinski > Date: Mon, 10 Aug 2020 10:32:04 -0700 > > > I'm not doing much work on the NFP driver any more. > > > > Signed-off-by: Jakub Kicinski > > Applied. Thanks, for the record I'm happy to take this over on beha

Re: [oss-drivers] [PATCH 16/20] ethernet: netronome: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Simon Horman
ned-off-by: Romain Perier > Signed-off-by: Allen Pais Reviewed-by: Simon Horman But: This series should be targeted at net-next, and thus have net-next in its subject [PATCH net-next x/y] ... And it should be posted when net-next is open: it is currently closed. http://v

[PATCH net-next 2/2] nfp: flower: add support to offload QinQ match

2020-08-20 Thread Simon Horman
0x8100 as before. Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp/flower/cmsg.h | 17 .../net/ethernet/netronome/nfp/flower/main.h | 4 +- .../net/ethernet/netronome/nfp/flower/match.c | 62 +- .../ethernet/netronome/nfp/flower/offload.c

[PATCH net-next 0/2] nfp: flower: add support for QinQ matching

2020-08-20 Thread Simon Horman
Louis says: Add new feature to the Netronome flower driver to enable QinQ offload. This needed a bit of gymnastics in order to not break compatibility with older firmware as the flow key sent to the firmware had to be updated in order to make space for the extra field. Louis Peens (2): nfp: flo

[PATCH net-next 1/2] nfp: flower: check that we don't exceed the FW key size

2020-08-20 Thread Simon Horman
From: Louis Peens Add a check to make sure the total length of the flow key sent to the firmware stays within the supported limit. Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/main.h | 2 ++ drivers/net/ethernet/netronome/nfp/flower

Re: [PATCH net-next v6] net: sched: Introduce act_ctinfo action

2019-06-13 Thread Simon Horman
On Wed, Jun 12, 2019 at 11:46:27AM -0700, Jakub Kicinski wrote: > On Wed, 12 Jun 2019 15:02:39 -0300, Marcelo Ricardo Leitner wrote: > > On Tue, May 28, 2019 at 05:03:50PM +, Kevin 'ldir' Darbyshire-Bryant > > wrote: > > ... > > > +static int tcf_ctinfo_init(struct net *net, struct nlattr *nla

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings

2018-04-30 Thread Simon Horman
On Thu, Apr 26, 2018 at 10:41:14PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3M (R8A77970) SoC support in the R-Car CAN-FD bindings. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman > > --- > The patch is against the 'linux-can-next.git' r

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

2018-04-30 Thread Simon Horman
ngs > patch posted yesterday. Although I wouldn't object if they're both merged to > the 'linux-can.git' repo instead. :-) > > Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Horman >

Re: [PATCH] dt-bindings: can: rcar_can: Fix R8A7796 SoC name

2018-05-04 Thread Simon Horman
On Thu, May 03, 2018 at 03:02:33PM +0200, Geert Uytterhoeven wrote: > R8A7796 is R-Car M3-W. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

[GIT PULL 0/5] IPVS Updates for v4.18

2018-04-19 Thread Simon Horman
Hi Pablo, please consider these IPVS enhancements for v4.18. * Whitepace cleanup * Add Maglev hashing algorithm as a IPVS scheduler Inju Song says "Implements the Google's Maglev hashing algorithm as a IPVS scheduler. Basically it provides consistent hashing but offers some special featu

[PATCH 2/5] netfilter: ipvs: Keep latest weight of destination

2018-04-19 Thread Simon Horman
Anastasov Signed-off-by: Simon Horman --- include/net/ip_vs.h| 1 + net/netfilter/ipvs/ip_vs_ctl.c | 4 2 files changed, 5 insertions(+) diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h index eb0bec043c96..0ac795b41ab8 100644 --- a/include/net/ip_vs.h +++ b/include/net/ip_vs.h

[PATCH 1/5] netfilter: ipvs: Fix space before '[' error.

2018-04-19 Thread Simon Horman
From: Arvind Yadav Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netf

[PATCH 4/5] netfilter: ipvs: Add configurations of Maglev hashing

2018-04-19 Thread Simon Horman
From: Inju Song To build the maglev hashing scheduler, add some configuration to Kconfig and Makefile. - The compile configurations of MH are added to the Kconfig. - The MH build rule is added to the Makefile. Signed-off-by: Inju Song Signed-off-by: Julian Anastasov Signed-off-by: Simon

[PATCH 3/5] netfilter: ipvs: Add Maglev hashing scheduler

2018-04-19 Thread Simon Horman
Song Signed-off-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_mh.c | 540 ++ 1 file changed, 540 insertions(+) create mode 100644 net/netfilter/ipvs/ip_vs_mh.c diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter

[PATCH 5/5] ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms

2018-04-19 Thread Simon Horman
ernat Acked-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_dh.c| 3 ++- net/netfilter/ipvs/ip_vs_lblc.c | 3 ++- net/netfilter/ipvs/ip_vs_lblcr.c | 3 ++- net/netfilter/ipvs/ip_vs_sh.c| 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/net

Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 05:53:18PM +0300, Sergei Shtylyov wrote: > On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > > > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > > is ARCH_RENESAS a more appropriate platform dependency than the legacy > >"ARCH_RENESAS is", n

Re: [PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
maining #ifdefs. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
y > than the legacy ARCH_SHMOBILE, hence use the former. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 5/8] staging: emxx_udc: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
ce use the > former. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
sas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4 > check. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 6/8] ASoC: sh: Update menu title and platform dependency

2018-04-23 Thread Simon Horman
in the near > future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940 ("AR

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940 ("AR

Re: [Patch nf] ipvs: initialize tbl->entries after allocation

2018-04-26 Thread Simon Horman
re() > > as reported by syzbot. > > > > Reported-by: > > Cc: Simon Horman > > Cc: Julian Anastasov > > Cc: Pablo Neira Ayuso > > Signed-off-by: Cong Wang > > Thanks! > > Acked-by: Julian Anastasov Thanks. Pablo, could you take this into nf? Ac

Re: [Patch nf] ipvs: initialize tbl->entries in ip_vs_lblc_init_svc()

2018-04-26 Thread Simon Horman
e(), > > as reported by syzbot. > > > > Reported-by: > > Cc: Simon Horman > > Cc: Julian Anastasov > > Cc: Pablo Neira Ayuso > > Signed-off-by: Cong Wang > > Thanks! > > Acked-by: Julian Anastasov Thanks. Pablo, could you take thi

Re: [PATCH/RFC 2/3] net/sched: act_tunnel_key: add extended ack support

2018-03-22 Thread Simon Horman
On Fri, Mar 09, 2018 at 12:22:48PM +0100, Jiri Benc wrote: > On Tue, 6 Mar 2018 18:08:04 +0100, Simon Horman wrote: > > - if (!tb[TCA_TUNNEL_KEY_PARMS]) > > + if (!tb[TCA_TUNNEL_KEY_PARMS]) { > > + NL_SET_ERR_MSG(extack, "Missing tunnel key parameter"

Re: [PATCH/RFC 3/3] net/sched: add tunnel option support to act_tunnel_key

2018-03-22 Thread Simon Horman
On Fri, Mar 09, 2018 at 12:53:17PM +0100, Jiri Benc wrote: > On Tue, 6 Mar 2018 18:08:05 +0100, Simon Horman wrote: > > +static int > > +tunnel_key_copy_geneve_opt(const struct nlattr *nla, int dst_len, void > > *dst, > > + str

[PATCH net-next 2/2] nfp: flower: implement ip fragmentation match offload

2018-03-26 Thread Simon Horman
From: Pieter Jansen van Vuuren Implement ip fragmentation match offloading for both IPv4 and IPv6. Allows offloading frag, nofrag, first and nofirstfrag classification. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet

[PATCH net-next 0/2] nfp: flower: add ip fragmentation offloading support

2018-03-26 Thread Simon Horman
Pieter Jansen van Vuuren says: This set allows offloading IP fragmentation classification. It Implements ip fragmentation match offloading for both IPv4 and IPv6 and offloads frag, nofrag, first and nofirstfrag classification. Pieter Jansen van Vuuren (2): nfp: flower: refactor shared ip header

[PATCH net-next 1/2] nfp: flower: refactor shared ip header in match offload

2018-03-26 Thread Simon Horman
From: Pieter Jansen van Vuuren Refactored shared ip header code for IPv4 and IPv6 in match offload. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 19 +++ drivers/net/ethernet

Re: [iproute PATCH] man: ip-route.8: ssthresh parameter is NUMBER

2018-03-28 Thread Simon Horman
On Thu, Mar 22, 2018 at 03:00:38PM +0100, Phil Sutter wrote: > Synopsis section was inconsistent with regards to help text and later > description of ssthresh parameter. > > Signed-off-by: Phil Sutter Reviewed-by: Simon Horman

Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

2017-08-15 Thread Simon Horman
On Tue, Aug 15, 2017 at 09:03:58PM -0700, David Miller wrote: > From: David Miller > Date: Tue, 15 Aug 2017 17:52:40 -0700 (PDT) > > > From: Simon Horman > > Date: Tue, 15 Aug 2017 08:13:48 +0200 > > > >> Could you pull net into net-next? I'd like to

[PATCH net-next 0/2] nfp: process MTU updates from firmware flower app

2017-08-16 Thread Simon Horman
The first patch of this series moves processing of control messages from a BH handler to a workqueue. That change makes it safe to process MTU updates from the firmware which is added by the second patch of this series. Simon Horman (2): nfp: process control messages in workqueue in flower app

[PATCH net-next 2/2] nfp: process MTU updates from firmware flower app

2017-08-16 Thread Simon Horman
Now that control message processing occurs in a workqueue rather than a BH handler MTU updates received from the firmware may be safely processed. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 11 +-- 1 file changed, 9

[PATCH net-next 1/2] nfp: process control messages in workqueue in flower app

2017-08-16 Thread Simon Horman
Processing of control messages is not time-critical and future processing of some messages will require taking the RTNL which is not possible in a BH handler. It seems simplest to move all control message processing to a workqueue. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski

Re: [PATCH v2 0/5] ARM: dts: rcar-gen2: Convert to new CPG/MSSR bindings

2017-08-21 Thread Simon Horman
On Fri, Aug 18, 2017 at 11:11:33AM +0200, Geert Uytterhoeven wrote: > Hi Simon, Magnus, > > Currently Renesas R-Car Gen2 SoCs use the common clk-rcar-gen2, > clk-mstp, and clk-div6 drivers, which depend on most clocks being > described in DT. Especially the module (MSTP) clocks are cumberso

Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Simon Horman
On Mon, Aug 28, 2017 at 02:41:16AM -0400, Chris Mi wrote: > Currently, all filters with the same priority are linked in a doubly > linked list. Every filter should have a unique handle. To make the > handle unique, we need to iterate the list every time to see if the > handle exists or not when ins

[PATCH] ravb: Fix use-after-free ravb_tstamp_skb

2019-08-16 Thread Simon Horman
ned-off-by: Simon Horman --- As this is an old bug I am submitting a fix against net-next rather than net: I do not see any urgency here. I am however, happy for it to be applied against net instead. --- drivers/net/ethernet/renesas/ravb_main.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletion

Re: [PATCH net] ipvs: get sctphdr by sctphoff in sctp_csum_check

2019-02-27 Thread Simon Horman
k(). > > Signed-off-by: Xin Long Acked-by: Simon Horman Pablo, please consider applying this to nf-next. > --- > net/netfilter/ipvs/ip_vs_proto_sctp.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_proto_sctp.c

[PATCH net] ravb: Decrease TxFIFO depth of Q3 and Q2 to one

2019-03-07 Thread Simon Horman
river proper") Signed-off-by: Masaru Nagai Signed-off-by: Kazuya Mizuguchi [simon: updated changelog] Signed-off-by: Simon Horman --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/d

Re: [PATCH 0/5] isdn: deprecate non-mISDN drivers

2019-04-24 Thread Simon Horman
Hi Arnd, On Tue, Apr 23, 2019 at 05:11:32PM +0200, Arnd Bergmann wrote: > When isdn4linux came up in the context of another patch series, I > remembered that we had discussed removing it a while ago. > > It turns out that the suggestion from Karsten Keil wa to remove I4L > in 2018 after the last

Re: [PATCH 0/5] isdn: deprecate non-mISDN drivers

2019-04-24 Thread Simon Horman
On Wed, Apr 24, 2019 at 10:14:55AM +0200, Arnd Bergmann wrote: > On Wed, Apr 24, 2019 at 9:56 AM Simon Horman wrote: > > > > Hi Arnd, > > > > On Tue, Apr 23, 2019 at 05:11:32PM +0200, Arnd Bergmann wrote: > > > When isdn4linux came up in the context of anot

Re: [PATCH] ravb: implement MTU change while device is up

2019-05-13 Thread Simon Horman
On Thu, May 09, 2019 at 05:32:21PM +0200, Ulrich Hecht wrote: > > > On May 9, 2019 at 12:10 PM Simon Horman wrote: > > > > > > On Thu, May 09, 2019 at 08:57:44AM +0200, Ulrich Hecht wrote: > > > > > > > On May 8, 2019 at 6:52 PM Niklas Söderlu

  1   2   3   4   5   6   7   8   9   10   >