Re: [PATCH nf-next] ipvs: remove unused function ip_vs_set_state_timeout

2017-04-16 Thread Simon Horman
On vr, apr 14, 2017 at 02:13:09 +0200, Pablo Neira Ayuso wrote: > On Mon, Apr 10, 2017 at 03:50:44PM -0400, Aaron Conole wrote: > > There are no in-tree callers of this function and it isn't exported. > > Simon, let me know if you want to take this, or just add your > Signed-off-by. Hi Pablo, I

Re: [GIT 0/3] Second Round of IPVS Updates for v4.12

2017-04-13 Thread Simon Horman
On Fri, Apr 14, 2017 at 01:01:34AM +0200, Pablo Neira Ayuso wrote: > Hi Simon, > > On Mon, Apr 10, 2017 at 09:58:32AM -0700, Simon Horman wrote: > > Hi Pablo, > > > > please consider these clean-ups and enhancements to IPVS for v4.12. > > > > * Removal

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-13 Thread Simon Horman
>> >Allow dissection of Neighbour Discovery target IP, and source and > >> >destination link-layer addresses for neighbour solicitation and > >> >advertisement messages. > >> > > >> >Signed-off-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Simon Horman
dvertisement messages. > > > >Signed-off-by: Simon Horman <simon.hor...@netronome.com> > >--- > > [...] > > >@@ -633,6 +702,18 @@ bool __skb_flow_dissect(const struct sk_buff *skb, > >

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Simon Horman
>> >Allow dissection of Neighbour Discovery target IP, and source and > >> >destination link-layer addresses for neighbour solicitation and > >> >advertisement messages. > >> > > >> >Signed-off-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCHv2 net-next 0/4] update ipvs sysctl document

2017-03-13 Thread Simon Horman
On Tue, Feb 21, 2017 at 10:01:44PM +0200, Julian Anastasov wrote: > > Hello, > > On Mon, 20 Feb 2017, Hangbin Liu wrote: > > > Fix and add some new ipvs sysctl options. Also use tab instead of > > whitespaces to indent the descriptions. > > > > V2: Fix some descriptions based on Julian's

[PATCH net-next] ravb: Fix ravb_ptp_interrupt clear interrupt all status

2017-04-17 Thread Simon Horman
nesas.com> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- drivers/net/ethernet/renesas/ravb.h | 4 ++-- drivers/net/ethernet/renesas/ravb_main.c | 12 drivers/net/ethernet/

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-04-18 Thread Simon Horman
On Wed, Mar 08, 2017 at 11:22:01AM -0800, Eric Dumazet wrote: > On Wed, 2017-03-08 at 12:11 -0700, Subash Abhinov Kasiviswanathan wrote: > > On 2017-03-08 11:40, Eric Dumazet wrote: > > > Well, this 'optimization' actually hurts when UDP sockets are not > > > connected, since this adds an extra

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-04-18 Thread Simon Horman
On Tue, Apr 18, 2017 at 08:09:08PM +0200, Hannes Frederic Sowa wrote: > > > On Tue, Apr 18, 2017, at 17:16, David Miller wrote: > > From: Simon Horman <simon.hor...@netronome.com> > > Date: Tue, 18 Apr 2017 17:09:04 +0900 > > > > > On Wed, Mar 08, 20

Re: [PATCH] netfilter: ipvs: Fix space before '[' error.

2017-07-31 Thread Simon Horman
On Sun, Jul 30, 2017 at 12:29:25PM +0530, Arvind Yadav wrote: > Fix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav Thanks, applied for v4.14.

Re: [PATCH net 4/7] nfp: Initialize RX and TX ring 64-bit stats seqcounts

2017-08-01 Thread Simon Horman
NFP4000/NFP6000 NIC VFs") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> FYI, Jakub is on leave this week.

Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

2017-08-15 Thread Simon Horman
On Tue, Aug 15, 2017 at 09:03:58PM -0700, David Miller wrote: > From: David Miller <da...@davemloft.net> > Date: Tue, 15 Aug 2017 17:52:40 -0700 (PDT) > > > From: Simon Horman <simon.hor...@netronome.com> > > Date: Tue, 15 Aug 2017 08:13:48 +0200 > > >

[PATCH net-next 2/2] nfp: process MTU updates from firmware flower app

2017-08-16 Thread Simon Horman
Now that control message processing occurs in a workqueue rather than a BH handler MTU updates received from the firmware may be safely processed. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/

[PATCH net-next 0/2] nfp: process MTU updates from firmware flower app

2017-08-16 Thread Simon Horman
The first patch of this series moves processing of control messages from a BH handler to a workqueue. That change makes it safe to process MTU updates from the firmware which is added by the second patch of this series. Simon Horman (2): nfp: process control messages in workqueue in flower app

Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

2017-08-15 Thread Simon Horman
On Fri, Aug 11, 2017 at 02:51:07PM -0700, David Miller wrote: > From: Simon Horman <simon.hor...@netronome.com> > Date: Fri, 11 Aug 2017 10:18:20 +0200 > > > The Flower app may receive a request to update the MTU of a representor > > netdev upon receipt of a contro

[PATCH net] nfp: do not update MTU from BH in flower app

2017-08-11 Thread Simon Horman
+0x4f/0xd0 [ 1496.294996] common_interrupt+0x89/0x89 Fixes: 948faa46c05b ("nfp: add support for control messages for flower app") Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- src/flower/cmsg.c | 8 ++---

[PATCH net repost] nfp: do not update MTU from BH in flower app

2017-08-11 Thread Simon Horman
+0x4f/0xd0 [ 1496.294996] common_interrupt+0x89/0x89 Fixes: 948faa46c05b ("nfp: add support for control messages for flower app") Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/netro

[PATCH net-next] nfp: send control message when MAC representors are created

2017-08-11 Thread Simon Horman
The firmware expects a MAC_REPR control message when a MAC representor is created. The driver should expect a PORTMOD message to follow which will provide the link states of the physical port associated with the MAC representor. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Re

Re: [PATCH net] nfp: do not update MTU from BH in flower app

2017-08-11 Thread Simon Horman
On Fri, Aug 11, 2017 at 10:07:03AM +0200, Simon Horman wrote: > The Flower app may receive a request to update the MTU of a representor > netdev upon receipt of a control message from the firmware. This requires > the RTNL lock which needs to be taken outside of the packet processi

Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

2017-07-11 Thread Simon Horman
On Tue, Jul 11, 2017 at 03:51:40PM +0300, Sergei Shtylyov wrote: > On 07/11/2017 03:21 PM, Simon Horman wrote: > > >>>Add a new compatible string for the RZ/G1M (R8A7743) SoC. > >>> > >>>Signed-off-by: Biju Das <biju@bp.renesas.com> > >

Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

2017-07-11 Thread Simon Horman
On Tue, Jul 11, 2017 at 03:12:14PM +0300, Sergei Shtylyov wrote: > Hello! > > On 07/10/2017 06:32 PM, Biju Das wrote: > > >Add a new compatible string for the RZ/G1M (R8A7743) SoC. > > > >Signed-off-by: Biju Das > >--- > >v1->v2 > >* Changed the subject > >*

Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

2017-07-11 Thread Simon Horman
s.com> > > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> I believe that as net-next is currently closed you should repost it once it re-opens (likely in about a week) with the following subject prefix and Geert's tag. [PATCH net-next repost v2]

Re: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB

2017-07-10 Thread Simon Horman
On Thu, Jul 06, 2017 at 08:05:43AM +, Chris Paterson wrote: > Hello Sergei, > > Thank you for your comments. > > > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > > Sent: 05 July 2017 17:14 > > > > Hello! > > > > On 07/05/2017 06:56 PM, Biju Das wrote: > > > > > The

Re: [oss-drivers] [PATCH net-next 0/3] nfp: extend firmware request logic

2017-07-27 Thread Simon Horman
ave been using so far. > > > Jakub Kicinski (3): > nfp: remove the probe deferral when FW not present > nfp: look for firmware image by device serial number and PCI name > nfp: only use direct firmware requests Thanks Jakub, this looks good to me. All patches: Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH net-next v2 3/9] nfp: provide infrastructure for offloading flower based TC filters

2017-06-28 Thread Simon Horman
On Wed, Jun 28, 2017 at 06:35:07PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 22:29:56 +0200, Simon Horman wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Adds a flower based TC offload handler for representor devic

Re: [PATCH net-next v2 9/9] nfp: add control message passing capabilities to flower offloads

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 06:59:22PM +0300, Or Gerlitz wrote: > On Thu, Jun 29, 2017 at 6:30 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > On Thu, Jun 29, 2017 at 06:21:53PM +0300, Or Gerlitz wrote: > >> On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman >

[PATCH net-next v3 8/9] nfp: add a stats handler for flower offloads

2017-06-29 Thread Simon Horman
ed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 5 - drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 5 + drivers/net/ethernet/netronome

[PATCH net-next v3 9/9] nfp: add control message passing capabilities to flower offloads

2017-06-29 Thread Simon Horman
t_data() to be used outside of cmsg.c. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 6 ++- drivers/net/ethernet/netronome/nfp/flower/cmsg.h

[PATCH net-next v3 4/9] nfp: extend flower add flow offload

2017-06-29 Thread Simon Horman
Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 141 ++ drivers/net/ethernet/netronome/nfp/flower/main.h | 24 +++ .../net/ethernet/netronome/nfp/flower/

[PATCH net-next v3 3/9] nfp: provide infrastructure for offloading flower based TC filters

2017-06-29 Thread Simon Horman
flower app enables tc offloads on representors by default. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 3 +- drivers/net/ethernet/ne

[PATCH net-next v3 7/9] nfp: add metadata to each flow offload

2017-06-29 Thread Simon Horman
talled. This is solved by storing the offloaded flows in a hash table. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/ne

[PATCH net-next v3 0/9] introduce flower offload capabilities

2017-06-29 Thread Simon Horman
to each flow offload nfp: add a stats handler for flower offloads nfp: add control message passing capabilities to flower offloads Simon Horman (2): net: switchdev: add SET_SWITCHDEV_OPS helper nfp: add phys_switch_id support drivers/net/ethernet/netronome/nfp/Makefile| 6

[PATCH net-next v3 2/9] nfp: add phys_switch_id support

2017-06-29 Thread Simon Horman
is the representor for the PF. And eth5 is the PF netdev. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 3 +++ drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 2 ++

[PATCH net-next v3 5/9] nfp: extend flower matching capabilities

2017-06-29 Thread Simon Horman
senvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 4 + drivers/net/ethernet/netronome/nfp/flower/main.h | 5 + drivers/net/ethernet/ne

[PATCH net-next v3 1/9] net: switchdev: add SET_SWITCHDEV_OPS helper

2017-06-29 Thread Simon Horman
Add a helper to allow switchdev ops to be set if NET_SWITCHDEV is configured and do nothing otherwise. This allows for slightly cleaner code which uses switchdev but does not select NET_SWITCHDEV. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/net/switchdev.h | 4 +

[PATCH net-next v3 6/9] nfp: add basic action capabilities to flower offloads

2017-06-29 Thread Simon Horman
From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Adds push vlan, pop vlan, output and drop action capabilities to flower offloads. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor..

[PATCH net-next v2 7/9] nfp: add metadata to each flow offload

2017-06-28 Thread Simon Horman
talled. This is solved by storing the offloaded flows in a hash table. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/ne

[PATCH net-next v2 8/9] nfp: add a stats handler for flower offloads

2017-06-28 Thread Simon Horman
ed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 5 - drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 5 + drivers/net/ethernet/netronome

[PATCH net-next v2 6/9] nfp: add basic action capabilities to flower offloads

2017-06-28 Thread Simon Horman
From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Adds push vlan, pop vlan, output and drop action capabilities to flower offloads. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor..

[PATCH net-next v2 0/9] introduce flower offload capabilities

2017-06-28 Thread Simon Horman
offloads nfp: add control message passing capabilities to flower offloads Simon Horman (2): net: switchdev: add SET_SWITCHDEV_OPS helper nfp: add phys_switch_id support drivers/net/ethernet/netronome/nfp/Makefile| 6 +- drivers/net/ethernet/netronome/nfp/flower/action.c | 211

[PATCH net-next v2 2/9] nfp: add phys_switch_id support

2017-06-28 Thread Simon Horman
is the representor for the PF. And eth5 is the PF netdev. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 3 +++ drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 2 ++

[PATCH net-next v2 3/9] nfp: provide infrastructure for offloading flower based TC filters

2017-06-28 Thread Simon Horman
flower app enables tc offloads on representors by default. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 3 +- drivers/net/ethernet/ne

[PATCH net-next v2 1/9] net: switchdev: add SET_SWITCHDEV_OPS helper

2017-06-28 Thread Simon Horman
Add a helper to allow switchdev ops to be set if NET_SWITCHDEV is configured and do nothing otherwise. This allows for slightly cleaner code which uses switchdev but does not select NET_SWITCHDEV. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/net/switchdev.h | 4 +

[PATCH net-next v2 4/9] nfp: extend flower add flow offload

2017-06-28 Thread Simon Horman
Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 141 + drivers/net/ethernet/netronome/nfp/flower/main.h | 24 +++ .../net/ethernet/netronome/nfp/flower/

[PATCH net-next v2 9/9] nfp: add control message passing capabilities to flower offloads

2017-06-28 Thread Simon Horman
t_data() to be used outside of cmsg.c. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 6 ++- drivers/net/ethernet/netronome/nfp/flower/cmsg.h

[PATCH net-next v2 5/9] nfp: extend flower matching capabilities

2017-06-28 Thread Simon Horman
senvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 4 + drivers/net/ethernet/netronome/nfp/flower/main.h | 5 + drivers/net/ethernet/ne

Re: [PATCH net-next v2 8/9] nfp: add a stats handler for flower offloads

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 06:16:41PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Previously there was no w

Re: [PATCH net-next v2 8/9] nfp: add a stats handler for flower offloads

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 05:39:34PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Previously there was no w

Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 05:31:22PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > + /* Populate IPv4 frame. */ > > + frame->reserved = 0; > > + frame->ipv4_src = flow_ip

Re: [PATCH net-next v2 9/9] nfp: add control message passing capabilities to flower offloads

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 06:21:53PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > +++ b/drivers/net/ethernet/netronome/nfp/flower/cmsg.h > > @@ -245,7 +245,11 @@ struct nfp_flower_cmsg_hdr { > >

Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 05:33:32PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > +nfp_flower_compile_meta_tci(struct nfp_flower_meta_two *frame, > > + struct tc_cls_flower_of

Re: [oss-drivers] Re: [PATCH/RFC net-next 7/9] nfp: add metadata to each flow offload

2017-06-28 Thread Simon Horman
On Tue, Jun 27, 2017 at 11:15:20PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 01:21:47 +0200, Simon Horman wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Adds metadata describing the mask id of each flow and keeps t

Re: [oss-drivers] Re: [PATCH net-next v2 7/9] nfp: add metadata to each flow offload

2017-06-29 Thread Simon Horman
On Wed, Jun 28, 2017 at 07:33:02PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 22:30:00 +0200, Simon Horman wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Adds metadata describing the mask id of each flow and keeps t

Re: [oss-drivers] Re: [PATCH net-next v2 8/9] nfp: add a stats handler for flower offloads

2017-06-29 Thread Simon Horman
On Wed, Jun 28, 2017 at 06:28:17PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 22:30:01 +0200, Simon Horman wrote: > > @@ -288,7 +292,21 @@ nfp_flower_del_offload(struct nfp_app *app, struct > > net_device *netdev, > > static int > > nfp_flower_get_stats(

Re: [oss-drivers] Re: [PATCH net-next v2 8/9] nfp: add a stats handler for flower offloads

2017-06-29 Thread Simon Horman
On Wed, Jun 28, 2017 at 07:55:18PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 22:30:01 +0200, Simon Horman wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Previously there was no way of updating flow rule stats after t

Re: [PATCH net-next v2 3/9] nfp: provide infrastructure for offloading flower based TC filters

2017-06-29 Thread Simon Horman
On Wed, Jun 28, 2017 at 06:53:40PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 22:29:56 +0200, Simon Horman wrote: > > +/** > > + * nfp_flower_del_offload() - Removes a flow from hardware. > > + * @app: Pointer to the APP handle > > + * @netdev:netd

Re: [oss-drivers] Re: [PATCH net-next v2 7/9] nfp: add metadata to each flow offload

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 01:42:50AM -0700, Jakub Kicinski wrote: > On Thu, 29 Jun 2017 10:14:29 +0200, Simon Horman wrote: > > > > + /* Checking if buffer is empty. */ > > > > + if (ring->head == ring->tail) { > > > > + *mask_

Re: [PATCH net-next v2 3/9] nfp: provide infrastructure for offloading flower based TC filters

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 04:56:44PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > > +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c > > > + * nfp_flower_del_offload() - Removes a fl

[PATCH/RFC net-next 8/9] nfp: add a stats handler for flower offloads

2017-06-27 Thread Simon Horman
ed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/main.h | 26 .../net/ethernet/netronome/nfp/flower/metadata.c | 143 - .../net/

[PATCH/RFC net-next 9/9] nfp: add control message passing capabilities to flower offloads

2017-06-27 Thread Simon Horman
t_data() to be used outside of cmsg.c. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 11 ++--- drivers/net/ethernet/netronome/nfp/flower/cmsg.h |

[PATCH/RFC net-next 4/9] nfp: extend flower add flow offload

2017-06-27 Thread Simon Horman
Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 141 + drivers/net/ethernet/netronome/nfp/flower/main.h | 24 +++ .../net/ethernet/netronome/nfp/flower/

[PATCH/RFC net-next 7/9] nfp: add metadata to each flow offload

2017-06-27 Thread Simon Horman
talled. This is solved by storing the offloaded flows in a hash table. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/ne

[PATCH/RFC net-next 0/9] introduce flower offload capabilities

2017-06-27 Thread Simon Horman
matching capabilities nfp: add basic action capabilities to flower offloads nfp: add metadata to each flow offload nfp: add a stats handler for flower offloads nfp: add control message passing capabilities to flower offloads Simon Horman (2): net: switchdev: add SET_SWITCHDEV_OPS helper nfp

Re: [PATCH net-next v8 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 08:19:04AM +0200, Jiri Pirko wrote: > Tue, Apr 25, 2017 at 10:29:40PM CEST, j...@mojatatu.com wrote: ... > >So lets in first kernel I have support for bit 0. > >My validation check is to make sure only bit 0 is set. > >The valid_flags currently then only constitutes bit

Re: [PATCH net-next v8 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-26 Thread Simon Horman
On Tue, Apr 25, 2017 at 06:04:45PM +0200, Jiri Pirko wrote: > Tue, Apr 25, 2017 at 03:01:22PM CEST, j...@mojatatu.com wrote: > >On 17-04-25 08:13 AM, Jiri Pirko wrote: > >> Tue, Apr 25, 2017 at 01:54:06PM CEST, j...@mojatatu.com wrote: > > > > > >[..] > > > >> > -#define TCAA_MAX 1 > >> > +/*

Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-26 Thread Simon Horman
On Tue, Apr 25, 2017 at 10:20:22AM -0400, David Miller wrote: > From: Jamal Hadi Salim > Date: Tue, 25 Apr 2017 08:42:32 -0400 > > > So are we going to standardize these strings? > > No. > > > i.e what if some user has written a bash script that depends on this > > string

Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 10:44:16AM -0400, David Miller wrote: > From: Simon Horman <simon.hor...@netronome.com> > Date: Wed, 26 Apr 2017 13:13:16 +0200 > > > On Tue, Apr 25, 2017 at 10:20:22AM -0400, David Miller wrote: > >> From: Jamal Hadi Salim <j...@mojatatu

Re: [PATCH net-next v8 1/3] net sched actions: Use proper root attribute table for actions

2017-04-25 Thread Simon Horman
b ("[NET_SCHED]: Convert actions from rtnetlink to new > netlink API") > Suggested-by: Jiri Pirko <j...@mellanox.com> > Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH v2 net-next] net: ipv6: send unsolicited NA if enabled for all interfaces

2017-04-24 Thread Simon Horman
ink-layer > address change") > Signed-off-by: David Ahern <d...@cumulusnetworks.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- > v2 > - update commit message with subject of commit 4a6e3c5def13 per comment > from Sergei > > net/ipv6/ndis

Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Simon Horman
On Thu, Apr 20, 2017 at 04:24:53PM +0200, Jiri Pirko wrote: > Thu, Apr 20, 2017 at 04:18:50PM CEST, j...@mojatatu.com wrote: > >On 17-04-20 09:59 AM, Jiri Pirko wrote: > >> Thu, Apr 20, 2017 at 03:06:21PM CEST, j...@mojatatu.com wrote: > >> > From: Jamal Hadi Salim ... > >> >

Re: [PATCH net-next v4 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Simon Horman
On Fri, Apr 21, 2017 at 02:11:00PM -0400, Jamal Hadi Salim wrote: > On 17-04-21 12:12 PM, David Miller wrote: > > >Yes for existing attributes we are stuck in the mud because of how > >we've handled things in the past. I'm not saying we should change > >behavior for existing attributes. > > >

Re: [PATCH] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-24 Thread Simon Horman
On Mon, Apr 24, 2017 at 10:21:30AM +0300, Julian Anastasov wrote: > > Hello, > > On Mon, 24 Apr 2017, Paolo Abeni wrote: > > > Hi, > > > > The problem with the patched code is that it tries to resolve ipv6 > > addresses that are not created/validated by the kernel. > > OK. Simon,

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-25 Thread Simon Horman
On Mon, Apr 24, 2017 at 07:07:43PM -0700, Jakub Kicinski wrote: > On Mon, 24 Apr 2017 22:06:08 -0400, Jamal Hadi Salim wrote: > > On 17-04-24 10:00 PM, Jamal Hadi Salim wrote: > > > On 17-04-24 09:48 PM, Jamal Hadi Salim wrote: > > > > > > > > Hrm. maybe I am wrong. > > > Lets say user sets all

[PATCH 1/1] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-28 Thread Simon Horman
ot;IPVS: Add function to determine if IPv6 address is local") Signed-off-by: Paolo Abeni <pab...@redhat.com> Acked-by: Julian Anastasov <j...@ssi.bg> Signed-off-by: Simon Horman <ho...@verge.net.au> --- net/netfilter/ipvs/ip_vs_ctl.c | 22 +- 1 file changed,

[GIT 0/1] IPVS Fixes for v4.11

2017-04-28 Thread Simon Horman
Hi Pablo, please consider this fix to IPVS for v4.11. Or if it is too late for v4.11 please consider it for v4.12. I would also like it considered for stable. * Explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled to avoid oops caused by IPVS accesing IPv6 routing code in such

Re: [GIT 0/1] IPVS Fixes for v4.11

2017-04-28 Thread Simon Horman
Sorry, I messed this up. I will repost. On Fri, Apr 28, 2017 at 11:58:15AM +0200, Simon Horman wrote: > Hi Pablo, > > please consider this fix to IPVS for v4.11. > Or if it is too late for v4.11 please consider it for v4.12. > I would also like it considered for stable. > >

[PATCH 1/2] ipvs: remove unused function ip_vs_set_state_timeout

2017-04-28 Thread Simon Horman
From: Aaron Conole <acon...@bytheb.org> There are no in-tree callers of this function and it isn't exported. Signed-off-by: Aaron Conole <acon...@bytheb.org> Signed-off-by: Simon Horman <ho...@verge.net.au> --- include/net/ip_vs.h | 2 -- net/netfilter/ipvs/

[GIT PULL 0/2] Third Round of IPVS Updates for v4.12

2017-04-28 Thread Simon Horman
Hi Pablo, please consider these enhancements to IPVS for v4.12. If it is too late for v4.12 then please consider them for v4.13. * Remove unused function * Correct comparison of unsigned value The following changes since commit 9a08ecfe74d7796ddc92ec312d3b7eaeba5a7c22: netfilter: don't

[GIT PULL v2 0/1] IPVS Fixes for v4.11

2017-04-28 Thread Simon Horman
Hi Pablo, please consider this fix to IPVS for v4.11. Or if it is too late for v4.11 please consider it for v4.12. I would also like it considered for stable. * Explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled to avoid oops caused by IPVS accesing IPv6 routing code in such

[PATCH 1/1] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-28 Thread Simon Horman
ot;IPVS: Add function to determine if IPv6 address is local") Signed-off-by: Paolo Abeni <pab...@redhat.com> Acked-by: Julian Anastasov <j...@ssi.bg> Signed-off-by: Simon Horman <ho...@verge.net.au> --- net/netfilter/ipvs/ip_vs_ctl.c | 22 +- 1 file changed,

[PATCH 2/2] ipvs: change comparison on sync_refresh_period

2017-04-28 Thread Simon Horman
From: Aaron Conole <acon...@bytheb.org> The sync_refresh_period variable is unsigned, so it can never be < 0. Signed-off-by: Aaron Conole <acon...@bytheb.org> Signed-off-by: Simon Horman <ho...@verge.net.au> --- net/netfilter/ipvs/ip_vs_sync.c | 2 +- 1 file changed, 1 ins

Re: [PATCH/RFC net-next 0/4] net/sched: cls_flower: avoid false matching of truncated packets

2017-04-28 Thread Simon Horman
On Fri, Apr 28, 2017 at 09:41:00AM -0400, Jamal Hadi Salim wrote: > On 17-04-28 09:11 AM, Simon Horman wrote: > >On Fri, Apr 28, 2017 at 08:52:56AM -0400, Jamal Hadi Salim wrote: > >>On 17-04-28 08:00 AM, Simon Horman wrote: > >>>Hi, > >>> > >&g

[PATCH/RFC net-next 4/4] net/sched: cls_flower: allow control of tree traversal on packet parse errors

2017-04-28 Thread Simon Horman
be parsed. # tc qdisc del dev eth0 ingress; tc qdisc add dev eth0 ingress # tc filter add dev eth0 protocol ip parent : flower \ indev eth0 ip_proto udp dst_port 80 header_parse_err_action drop \ action continue Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- i

[PATCH/RFC net-next 3/4] net/sched: cls_flower: do not match if dissection fails

2017-04-28 Thread Simon Horman
as packets with zero ICMP code and type. Separate patches to the flow dissector are required in order for it to return errors in the above cases. Fixes: 77b9900ef53a ("tc: introduce Flower classifier") Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- net/sched/

[PATCH/RFC net-next 2/4] flow dissector: return error on icmp dissection under-run

2017-04-28 Thread Simon Horman
from __skb_header_pointer(). This should only effect the flower classifier as it is the only user of W_DISSECTOR_KEY_ICMP. The behavioural update for flower only takes effect with a separate patch to have it refuse to match if dissection fails. Signed-off-by: Simon Horman <simon.hor...@netronome.

[PATCH/RFC net-next 0/4] net/sched: cls_flower: avoid false matching of truncated packets

2017-04-28 Thread Simon Horman
to skb_flow_get_ports()). The last patch of the series builds on the above to allow users to specify a policy for how to handle packets whose dissection fails. I will separately provide RFC patches to iproute2 to allow exercising the last patch. Simon Horman (4): flow dissector: return error on port

[PATCH/RFC net-next 1/4] flow dissector: return error on port dissection under-run

2017-04-28 Thread Simon Horman
of flow_keys_dissector_keys[] and flow_keys_dissector_symmetric_keys[]. The behavioural change for *_keys[] changes seem reasonable as the change will should only be for truncated packets. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/linux/skbuff.h| 11 --- net/core/flow_disse

Re: [PATCH net-next v8 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-28 Thread Simon Horman
On Wed, Apr 26, 2017 at 10:46:58AM -0400, David Miller wrote: > From: Jiri Pirko <j...@resnulli.us> > Date: Wed, 26 Apr 2017 15:05:06 +0200 > > > Wed, Apr 26, 2017 at 02:46:22PM CEST, j...@mojatatu.com wrote: > >>On 17-04-26 07:02 AM, Simon Horman wrote: > >&

[PATCH/RFC iproute2/net-next 3/3] tc: flower: allow control of tree traversal on packet parse errors

2017-04-28 Thread Simon Horman
be parsed. # tc qdisc del dev eth0 ingress; tc qdisc add dev eth0 ingress # tc filter add dev eth0 protocol ip parent : flower \ indev eth0 ip_proto udp dst_port 80 header_parse_err_action drop \ action continue Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- ma

[PATCH/RFC iproute2/net-next 2/3] tc: flower: update headers for TCA_FLOWER_HEADER_PARSE_ERR_ACT

2017-04-28 Thread Simon Horman
This change is proposed for net-next. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/linux/pkt_cls.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index f1129e383b2a..1e2dd535703d 100644 --- a/include/linux/pkt

[PATCH/RFC iproute2/net-next 1/3] tc: flower: update headers for TCA_FLOWER_KEY_MPLS*

2017-04-28 Thread Simon Horman
These changes are present in net-next. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/linux/pkt_cls.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index 7a69f2a4ca0c..f1129e383b2a 100644 --- a/include

[PATCH/RFC iproute2/net-next 0/3] tc: flower: allow control of tree traversal on packet parse errors

2017-04-28 Thread Simon Horman
detailed description. Simon Horman (3): tc: flower: update headers for TCA_FLOWER_KEY_MPLS* tc: flower: update headers for TCA_FLOWER_HEADER_PARSE_ERR_ACT tc: flower: allow control of tree traversal on packet parse errors include/linux/pkt_cls.h | 7 +++ man/man8/tc-flower.8| 29

Re: [PATCH/RFC net-next 0/4] net/sched: cls_flower: avoid false matching of truncated packets

2017-04-28 Thread Simon Horman
On Fri, Apr 28, 2017 at 08:52:56AM -0400, Jamal Hadi Salim wrote: > On 17-04-28 08:00 AM, Simon Horman wrote: > >Hi, > > > >this series is intended to avoid false-positives which match > >truncated packets against flower classifiers which match on: > >* zero

Re: [PATCH V2 net-next 0/2] liquidio: Add support for managing liquidio adapter

2017-07-30 Thread Simon Horman
On Fri, Jul 28, 2017 at 11:17:07PM -0700, Felix Manlunas wrote: > From: Veerasenareddy Burru > > The LiquidIO adapter has processor cores that can run Linux. This patch > set adds support to create a virtual Ethernet interface on host to > communicate with

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

2017-08-04 Thread Simon Horman
On Thu, Aug 03, 2017 at 02:26:58PM -0600, David Ahern wrote: > On 5/18/17 10:24 PM, David Ahern wrote: > > On 5/18/17 3:02 AM, Daniel Borkmann wrote: > >> So effectively this means libmnl has to be used for new stuff, noone > >> has time to do the work to convert the existing tooling over (which >

Re: [PATCH] ip: mpls: fix printing of mpls labels

2017-05-10 Thread Simon Horman
to 31 labels with a separator. > > With this change the above is: > $ ip/ip -f mpls ro ls > 101 as to 102/103/104/105/106/107/108/109/110 via inet 172.16.2.2 dev > virt12 > > Signed-off-by: David Ahern <dsah...@gmail.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-16 Thread Simon Horman
On Tue, May 16, 2017 at 11:07:34AM +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Tue, May 16, 2017 at 11:02 AM, Niklas Söderlund > wrote: > >> > Whit all this being said I still like to withdraw this patch as I found > >> > another fault with it,

Re: [PATCH iproute2] ip: add support for more MPLS labels

2017-05-16 Thread Simon Horman
long */ > + fprintf(stderr, "Error: too many labels.\n"); > return 0; > } > > -int mpls_pton(int af, const char *src, void *addr) > +int mpls_pton(int af, const char *src, void *addr, size_t alen) > { > + unsigned int maxlabels = alen / sizeof(

Re: [oss-drivers] [PATCH net-next 9/9] nfp: eliminate an if statement in calculation of completed frames

2017-05-16 Thread Simon Horman
; > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [oss-drivers] [PATCH net-next 3/9] nfp: support LSO2 capability

2017-05-16 Thread Simon Horman
> field in struct nfp_net_tx_desc is repurposed, making TXVLAN a mutually > exclusive configuration to LSO2. > > Signed-off-by: Edwin Peer <edwin.p...@netronome.com> > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

<    3   4   5   6   7   8   9   10   11   >