[PATCH nf-next 1/1] netfilter: Remove useless variable timeouts in init_conntrack

2017-04-04 Thread gfree . wind
From: Gao Feng All l4_proto->new callbacks don't use the param timeouts currently, so remove it from param list. Then the variable timeouts isn't used as right value in init_conntrack, so remove it too. Signed-off-by: Gao Feng ---

RE: [PATCH nf-next 1/1] netfilter: udplite4: Remove duplicated udplite4 declaration

2017-04-04 Thread Gao Feng
Hi, > -Original Message- > From: gfree.w...@foxmail.com [mailto:gfree.w...@foxmail.com] > Sent: Wednesday, April 5, 2017 9:23 AM > To: pa...@netfilter.org; netfilter-devel@vger.kernel.org > Cc: Gao Feng > Subject: [PATCH nf-next 1/1] netfilter: udplite4: Remove

[PATCH nf-next 1/1] netfilter: udplite4: Remove duplicated udplite4 declaration

2017-04-04 Thread gfree . wind
From: Gao Feng There are two nf_conntrack_l4proto_udp4 declarations in the head file nf_conntrack_ipv4.h. Now remove one which is not enbraced by the macro CONFIG_NF_CT_PROTO_UDPLITE. Signed-off-by: Gao Feng --- include/net/netfilter/ipv4/nf_conntrack_ipv4.h

[PATCH nft] exthdr: avoid crash with older kernels

2017-04-04 Thread Florian Westphal
if kernel is older it won't understand the EXTHDR_OP attribute, i.e. the rule gets accepted as a check for ipv6 exthdr. On dump nft is then presented with a invalid ipv6 exthdr. So we need to get rid of the assert and output an "invalid" message on list. Longterm we need a proper vm description

Re: [PATCH] net: netfilter: Use seq_puts()/seq_putc() where possible

2017-04-04 Thread Simon Horman
On Wed, Mar 29, 2017 at 03:25:17AM +0530, simran singhal wrote: > For string without format specifiers, use seq_puts(). For > seq_printf("\n"), use seq_putc('\n'). > > Signed-off-by: simran singhal > --- > net/netfilter/ipvs/ip_vs_ctl.c | 8 Simran, I

Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator

2017-04-04 Thread Pablo Neira Ayuso
On Tue, Apr 04, 2017 at 01:41:11PM -0400, Simon Horman wrote: > On Wed, Mar 29, 2017 at 03:45:01PM +0530, Arushi Singhal wrote: > > Replace explicit NULL comparison with ! operator to simplify code. > > > > Signed-off-by: Arushi Singhal > > --- > >

Re: [PATCH] net: netfilters: Remove unnecessary parenthesis

2017-04-04 Thread Simon Horman
On Tue, Mar 28, 2017 at 06:56:48PM +0530, Arushi Singhal wrote: > Rmoved parentheses on the right hand side of assignment, as they are > not required. The following coccinelle script was used to fix this > issue: > > @@ > local idexpression id; > expression e; > @@ > > id = > -( > e > -) > >

Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator

2017-04-04 Thread Simon Horman
On Wed, Mar 29, 2017 at 03:45:01PM +0530, Arushi Singhal wrote: > Replace explicit NULL comparison with ! operator to simplify code. > > Signed-off-by: Arushi Singhal > --- > net/netfilter/ipvs/ip_vs_ctl.c | 8 ++--- > net/netfilter/ipvs/ip_vs_proto.c