[PATCH nf-next V2] netfilter: nf_ct_helper: use nf_ct_iterate_destroy to unlink helper objs

2017-05-28 Thread Liping Zhang
From: Liping Zhang When we unlink the helper objects, we will iterate the nf_conntrack_hash, iterate the unconfirmed list, handle the hash resize situation, etc. Actually this logic is same as the nf_ct_iterate_destroy, so we can use it to remove these copy & paste codes. Signed-off-by: Liping

[PATCH nf-next V2] netfilter: cttimeout: use nf_ct_iterate_cleanup_net to unlink timeout objs

2017-05-28 Thread Liping Zhang
From: Liping Zhang Similar to nf_conntrack_helper, we can use nf_ct_iterare_cleanup_net to remove these copy & paste codes. Signed-off-by: Liping Zhang --- V2: rebase on Florian's patch set "netfilter: conntrack: rework nf_ct_iterate, part 1." net/netfilter/nfnetlink_cttimeout.c | 39 ++

Re: [PATCH nf-next V2] netfilter: cttimeout: use nf_ct_iterate_cleanup_net to unlink timeout objs

2017-05-28 Thread kbuild test robot
Hi Liping, [auto build test ERROR on nf-next/master] url: https://github.com/0day-ci/linux/commits/Liping-Zhang/netfilter-cttimeout-use-nf_ct_iterate_cleanup_net-to-unlink-timeout-objs/20170528-232231 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config

Re: [PATCH nf-next V2] netfilter: nf_ct_helper: use nf_ct_iterate_destroy to unlink helper objs

2017-05-28 Thread kbuild test robot
-nf_ct_iterate_destroy-to-unlink-helper-objs/20170528-230817 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master config: x86_64-randconfig-x014-201722 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build

Re: [PATCH nf-next V2] netfilter: cttimeout: use nf_ct_iterate_cleanup_net to unlink timeout objs

2017-05-28 Thread Liping Zhang
Hi, 2017-05-29 0:07 GMT+08:00 kbuild test robot : >net/netfilter/nfnetlink_cttimeout.c: In function 'ctnl_untimeout': >>> net/netfilter/nfnetlink_cttimeout.c:303:2: error: implicit declaration of >>> function 'nf_ct_iterate_cleanup_net' [-Werror=implicit-function-declaration] > nf_ct_ite