libmnl/example/rtnl-route-dump - only dumping up to table #255?

2018-05-18 Thread hvjunk
Good day, I’m busy looking to develop a C program to do some reporting and adding of route tables and rules. Looking at the libmnl example program rtnl-route-dump.c, I can’t seem to find why it only list the tables up to #255. I picked this up as I had a table 993 (the port used for imaps :).

Re: [Drbd-dev] [PATCH 28/42] drbd: switch to proc_create_single

2018-05-18 Thread Lars Ellenberg
On Wed, May 16, 2018 at 11:43:32AM +0200, Christoph Hellwig wrote: > And stop messing with try_module_get on THIS_MODULE, which doesn't make > any sense here. The idea was to increase module count on /proc/drbd access. If someone holds /proc/drbd open, previously rmmod would "succeed" in starting

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-18 Thread Greg Kroah-Hartman
On Fri, May 18, 2018 at 11:27:56AM +0200, Florian Westphal wrote: > Greg Kroah-Hartman wrote: > > On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > > > > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: > > > >> > --- a/net/netfilter/x_tables.c > > > >> > +++ b/net/netf

Re: [PATCH libmnl] examples: add arp cache dump example

2018-05-18 Thread Pablo Neira Ayuso
On Thu, May 17, 2018 at 03:10:34PM +0200, Laura Garcia Liebana wrote: > Adding ARP example in order to dump the info in the form: > > index= family= dst= lladdr= > state= Applied, thanks Laura. BTW, before applying, I have renamed this to rtnl-neigh-dump instead. -- To unsubscribe from this lis

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-18 Thread Florian Westphal
Greg Kroah-Hartman wrote: > On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: > > >> > --- a/net/netfilter/x_tables.c > > >> > +++ b/net/netfilter/x_tables.c > > >> > @@ -1183,11 +1183,10 @@ struct xt_table_info > > >>

Re: [PATCH 38/42] isdn: replace ->proc_fops with ->proc_show

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 10:43:46AM +0200, Paul Bolle wrote: > > iif->ctr.release_appl = gigaset_release_appl; > > iif->ctr.send_message = gigaset_send_message; > > - iif->ctr.procinfo = gigaset_procinfo; > > Is this intentional? You didn't touch the procinfo method in the other IS

Re: [PATCH 38/42] isdn: replace ->proc_fops with ->proc_show

2018-05-18 Thread Paul Bolle
Hi Christoph, (I don't think the patches of this series ever hit the ISDN related addresses still found in MAINTAINERS. And now I might be a bit late.) Christoph Hellwig schreef op wo 16-05-2018 om 11:43 [+0200]: > diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c > index cc

Re: [PATCH] netfilter: ebtables: handle string from userspace with care

2018-05-18 Thread Pablo Neira Ayuso
On Fri, Apr 27, 2018 at 10:45:31AM +0200, Paolo Abeni wrote: > strlcpy() can't be safely used on a user-space provided string, > as it can try to read beyond the buffer's end, if the latter is > not NULL terminated. Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netf

Re: [PATCH nft 1/2] Introduce socket matching

2018-05-18 Thread Máté Eckl
On Thu, May 17, 2018 at 04:42:15PM +0200, Florian Westphal wrote: > Máté Eckl wrote: > > +socket_stmt: SOCKET EXISTS /* with the actual > > implementation we cannot match abscence */ > > I think we should go for a native expression. > > I'll leave it up to you what you'd