Re: [PATCH libnfnetlink 1/1] src: Minimally resurrect doxygen documentation

On Wed, Oct 23, 2019 at 01:13:46PM +0200, Pablo Neira Ayuso wrote: > On Mon, Oct 14, 2019 at 01:02:23PM +1100, Duncan Roe wrote: > > The documentation was written in the days before doxygen required groups or > > even > > doxygen.cfg, so create doxygen.cfg.in and introd

Re: [PATCH libnfnetlink 1/1] src: Minimally resurrect doxygen documentation

On Wed, Oct 23, 2019 at 01:13:46PM +0200, Pablo Neira Ayuso wrote: > On Mon, Oct 14, 2019 at 01:02:23PM +1100, Duncan Roe wrote: > > The documentation was written in the days before doxygen required groups or > > even > > doxygen.cfg, so create doxygen.cfg.in and introd

Re: [PATCH libnfnetlink 0/1] Minimally resurrect doxygen documentation

Hi Pablo, On Mon, Oct 14, 2019 at 01:02:22PM +1100, Duncan Roe wrote: > libnfnetlink has good doxygen documentation but there was no output when > doxygen was run. > > Patch 1/1 fixes that, > but on rebuilding there were a number warnings of the form: > > right-hand operan

[PATCH libnfnetlink 0/1] Minimally resurrect doxygen documentation

e fragment "&& ({ 1;})". Duncan Roe (1): src: Minimally resurrect doxygen documentation configure.ac | 2 +- doxygen.cfg.in | 180 +++ include/linux_list.h | 9 +++ src/iftable.c| 9 +++ src/libnfnet

[PATCH libnfnetlink 1/1] src: Minimally resurrect doxygen documentation

= *.c linux_list.h Updated: configure.ac: Create doxygen.cfg include/linux_list.h: Add defgroup src/iftable.c: Add defgroup src/libnfnetlink.c: Add mainpage and defgroup Signed-off-by: Duncan Roe --- configure.ac | 2 +- doxygen.cfg.in | 180

[PATCH libnetfilter_queue 2/5] src: Enable clang build

ter blocks with opening parenthesis. Signed-off-by: Duncan Roe --- src/extra/ipv4.c | 24 +++ src/extra/ipv6.c | 14 ++-- src/extra/pktbuff.c | 65 +- src/extra/tcp.c | 24 +++ src/extra/udp.c | 25 +++ src/interna

[PATCH libnetfilter_queue 1/5] src: doc: Miscellaneous updates

(void fn) - nfq_nlmsg_cfg_put_params(); Document (params only) - nfq_nlmsg_cfg_put_qmaxlen(): Document (params only) - nfq_nlmsg_parse: - Change name (was: nfq_pkt_parse) - Fix params Signed-off-by: Duncan Roe --- src/extra

[PATCH libnetfilter_queue 0/5] clang and documentation updates

This series is a mixture of patches to enable clang build and correct / insert doxygen comments. It ended up that way after git merges of local branches where they were originally developed. Hopefully they are all uncontroversial so can just be applied. Duncan Roe (4): src: doc: Miscellaneous

[PATCH libnetfilter_queue 5/5] src: doc: Minor fix

The documentation generally uses OSI layer numbering, where TCP (i.e. Transport) is layer 4 so that IP is layer 3. Bring pktb_mangle documentation into line with this. Signed-off-by: Duncan Roe --- src/extra/pktbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

[PATCH libnetfilter_queue 4/5] src: Fix invalid conversion specifier

Clang (but not gcc) warned about this. Gcc (but not clang) used to warn that nfq_set_verdict_mark is deprecated, but this has stopped since re-defining EXPORT_SYMBOL. Signed-off-by: Duncan Roe --- src/extra/ipv6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/extra

[PATCH libnetfilter_queue 3/5] doxygen: remove EXPORT_SYMBOL from the output

From: Pablo Neira Ayuso Add input filter to remove the internal EXPORT_SYMBOL macro that turns on the compiler visibility attribute. Signed-off-by: Duncan Roe --- doxygen.cfg.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doxygen.cfg.in b/doxygen.cfg.in index a7378ca

Re: [PATCH] libmnl: doxygen: remove EXPORT_SYMBOL from the output

O > IMAGE_PATH = > -INPUT_FILTER = > +INPUT_FILTER = "sed 's/EXPORT_SYMBOL//g'" > FILTER_PATTERNS= > FILTER_SOURCE_FILES= NO > SOURCE_BROWSER = YES > -- > 2.11.0 > Just tried this. Looks good. Acked-by: Duncan Roe

Re: [PATCH libmnl] src: fix doxygen function documentation

Hi Pablo, On Mon, Sep 30, 2019 at 04:17:53PM +0200, Pablo Neira Ayuso wrote: > On Wed, Sep 25, 2019 at 03:14:19PM +0200, Fernando Fernandez Mancera wrote: > > Currently clang requires EXPORT_SYMBOL() to be above the function > > implementation. At the same time doxygen is not generating the proper

Re: [PATCH libnetfilter_queue] BUG: src: Update UDP header length field after mangling

Hi Pablo, On Fri, Sep 27, 2019 at 10:56:45PM +1000, Duncan Roe wrote: > One would expect nfq_udp_mangle_ipv4() to take care of the length field in > the UDP header but it did not. > With this patch, it does. > This patch is very unlikely to adversely affect any existing userspace >

Re: [PATCH] Fix a missing doxygen section trailer in nlmsg.c

On Wed, Oct 02, 2019 at 04:48:48PM +1000, Duncan Roe wrote: > This corrects an oddity in the web doco (and presumably in the man pages as > well) whereby "Netlink message batch helpers" was showing up as a sub-topic of > "Netlink message helpers". > > This wa

[PATCH] Fix a missing doxygen section trailer in nlmsg.c

This corrects an oddity in the web doco (and presumably in the man pages as well) whereby "Netlink message batch helpers" was showing up as a sub-topic of "Netlink message helpers". This was included in my original (rejected) patch "Enable doxygen to generate Function Documentation" with a comment

Re: [PATCH libnetfilter_queue] BUG: src: Fix UDP checksum calculation

On Mon, Sep 30, 2019 at 04:28:40PM +0200, Pablo Neira Ayuso wrote: > On Fri, Sep 27, 2019 at 10:18:38PM +1000, Duncan Roe wrote: > > The level 4 protocol is part of the UDP and TCP calculations. > > nfq_checksum_tcpudp_ipv4() was using IPPROTO_TCP in this calculation, > >

[PATCH libnetfilter_queue] BUG: src: Update UDP header length field after mangling

One would expect nfq_udp_mangle_ipv4() to take care of the length field in the UDP header but it did not. With this patch, it does. This patch is very unlikely to adversely affect any existing userspace software (that did its own length adjustment), because UDP checksumming was broken --- src/extr

[PATCH libnetfilter_queue] BUG: src: Fix UDP checksum calculation

The level 4 protocol is part of the UDP and TCP calculations. nfq_checksum_tcpudp_ipv4() was using IPPROTO_TCP in this calculation, which gave the wrong answer for UDP. --- src/extra/checksum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/extra/checksum.c b/src/extra/che

Re: [PATCH libnetfilter_queue] src: Enable clang build

On Fri, Sep 27, 2019 at 10:00:32AM +1000, Duncan Roe wrote: > On Wed, Sep 25, 2019 at 12:28:12PM +1000, Duncan Roe wrote: > > On Tue, Sep 24, 2019 at 01:11:29PM +0100, Jeremy Sowden wrote: > > > On 2019-09-22, at 10:10:31 +1000, Duncan Roe wrote: > > > > Unl

Re: [PATCH libnetfilter_queue] src: Enable clang build

On Wed, Sep 25, 2019 at 12:28:12PM +1000, Duncan Roe wrote: > On Tue, Sep 24, 2019 at 01:11:29PM +0100, Jeremy Sowden wrote: > > On 2019-09-22, at 10:10:31 +1000, Duncan Roe wrote: > > > Unlike gcc, clang insists to have EXPORT_SYMBOL(x) come before the > > > definit

Re: [PATCH libmnl] src: fix doxygen function documentation

hat problem but EXPORT_SYMBOL looks less like the Linux > kernel way exporting symbols. > > Reported-by: Duncan Roe > Signed-off-by: Fernando Fernandez Mancera > --- > src/attr.c | 145 + > src/callback.c | 14 ++--- > src/inte

Re: [PATCH libnetfilter_queue] src: Enable clang build

On Tue, Sep 24, 2019 at 01:11:29PM +0100, Jeremy Sowden wrote: > On 2019-09-22, at 10:10:31 +1000, Duncan Roe wrote: > > Unlike gcc, clang insists to have EXPORT_SYMBOL(x) come before the > > definition > > of x. So move all EXPORT_SYMBOL lines to just after t

[PATCH libnetfilter_queue] src: Enable clang build

Unlike gcc, clang insists to have EXPORT_SYMBOL(x) come before the definition of x. So move all EXPORT_SYMBOL lines to just after the last #include line. pktbuff.c was missing its associated header, so correct that as well. gcc & clang produce different warnings. gcc warns that nfq_set_verdict_ma

Re: [PATCH] src: Enable doxygen to generate Function Documentation

Hi Pablo, On Fri, Sep 20, 2019 at 11:05:09AM +0200, Pablo Neira Ayuso wrote: > On Fri, Sep 20, 2019 at 10:00:06AM +1000, Duncan Roe wrote: > > (cc'ing list - already sent to Pablo) > > > > Hi Pablo, > > > > On Sat, Sep 14, 2019 at 01:25:56PM +1000, Duncan Roe

[PATCH libmnl, v3] Enable doxygen to generate Function Documentation

The C source files all contain doxygen documentation for each defined function but this was not appearing in the generated HTML or man pages. Fix is to move all EXPORT_SYMBOL macro calls to near the start of each file. Doxygen seems to otherwise forget the documentation on encountering EXPORT_SYMBO

[PATCH libmnl, v2] Enable doxygen to generate Function Documentation

diff --git a/src/attr.c b/src/attr.c index 0359ba9..00a5354 100644 --- a/src/attr.c +++ b/src/attr.c @@ -12,6 +12,42 @@ #include #include "internal.h" +EXPORT_SYMBOL(mnl_attr_get_type); +EXPORT_SYMBOL(mnl_attr_get_len); +EXPORT_SYMBOL(mnl_attr_get_payload_len); +EXPORT_SYMBOL(mnl_attr_get_payl

Re: [PATCH] src: Enable doxygen to generate Function Documentation

(cc'ing list - already sent to Pablo) Hi Pablo, On Sat, Sep 14, 2019 at 01:25:56PM +1000, Duncan Roe wrote: > Hi Pablo, > > On Sun, Sep 08, 2019 at 06:25:05PM +1000, Duncan Roe wrote: > > The C source files all contain doxygen documentation for each defined > > fun

Re: [PATCH] src: Enable doxygen to generate Function Documentation

Hi Pablo, On Sun, Sep 08, 2019 at 06:25:05PM +1000, Duncan Roe wrote: > The C source files all contain doxygen documentation for each defined function > but this was not appearing in the generated HTML. > Fix is to move all EXPORT_SYMBOL macro calls to after the function definition.

[PATCH] src: Enable doxygen to generate Function Documentation

flagged in the EXCLUDE_SYMBOLS tag in doxygen.cfg.in. I encountered this "feature" in doxygen 1.8.9.1 but it still appears to be present in 1.8.16 Signed-off-by: Duncan Roe --- src/attr.c | 70 +- src/callback.c | 4 ++-- s

Re: meter in 0.9.1 (nft noob question)

On Thu, Aug 22, 2019 at 01:14:40PM +0200, Laura Garcia wrote: > Hi Duncan, > > On Mon, Aug 19, 2019 at 6:11 AM Duncan Roe wrote: > > > > [...] > > > > > *** I had expected or at least hoped that an element's expiry would revert > > *** to the timeou

Re: meter in 0.9.1 (nft noob question)

On Wed, Aug 07, 2019 at 04:13:36PM +0200, Laura Garcia wrote: > On Tue, Aug 6, 2019 at 8:21 PM Duncan Roe wrote: > > > > I thought meters were unique in that the set underlying them gets added to > > by incoming traffic. Can maps/sets do that? [...] > > Sure, s

git pull has stopped working

Hi, As of tonight, whenever I try to do a git oull, this happens: > 01:38:00$ git pull > fatal: read error: Connection reset by peer > 01:39:12$ Tried ebtables, iptables, libmnl, libnftnl & nftables. It was working the day before yesterday, Cheers ... Duncan.

Re: [PATCH conntrack-tools] src: fix strncpy -Wstringop-truncation warnings

Hi Jose, PLEASE DO NOT DO THIS! See at end On Fri, Aug 16, 2019 at 11:25:11AM +0200, Jose M. Guisado Gomez wrote: > -Wstringop-truncation warning was introduced in GCC-8 as truncation > checker for strncpy and strncat. > > Systems using gcc version >= 8 would receive the following warnings: > > r

Re: [PATCH nft] doc: update nft list plural form parameters

On Thu, Apr 04, 2019 at 02:01:23PM +0200, Pablo Neira Ayuso wrote: > Cc'ing Duncan, he's been helping with reviewing documentation. > > On Thu, Apr 04, 2019 at 01:41:58PM +0200, Fernando Fernandez Mancera wrote: > > Signed-off-by: Fernando Fernandez Mancera > > --- > > doc/nft.txt | 13 +-

Re: [PATCH] doc: libnftables.adoc misc cleanups

On Mon, Nov 05, 2018 at 10:37:52AM +0100, Pablo Neira Ayuso wrote: > Applied, thanks Duncan. > [...] > > Hm, nft_ctx_output_get_flags() and nft_ctx_output_set_flags() should > be actually at the end, after the list of flags. I fixed this here > with this patch too, I hope you don't mind. > No worri

[PATCH] doc: libnftables.adoc misc cleanups

t; to "e.g." Signed-off-by: Duncan Roe --- doc/libnftables.adoc | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/doc/libnftables.adoc b/doc/libnftables.adoc index 0075067..8ccbff7 100644 --- a/doc/libnftables.adoc +++ b/doc/libnftables.adoc @@ -

Re: [PATCH nft 4/5,v2] src: add nft_ctx_output_{get,set}_json() to nft_ctx_output_{get,set}_flags

On Mon, Oct 29, 2018 at 12:33:39PM +0100, Pablo Neira Ayuso wrote: > Add NFT_CTX_OUTPUT_JSON flag and display output in json format. > > Signed-off-by: Pablo Neira Ayuso > --- > v2: Add nft_output_json() > Fix missing conversion to use NFT_CTX_OUTPUT_JSON. > Remove json field from struct o

[PATCH] doc: Re-work RULES:add/insert/replace to read better.

It was tempting to remove "position" from the synopsis, but have left that for another patch. Signed-off-by: Duncan Roe --- doc/nft.txt | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/nft.txt b/doc/nft.txt index 9d04e43..2a76a6c 100644 --- a/d

Re: [PATCH] nft: Fix build failure in rule.c

Hi Pablo, On Fri, Aug 17, 2018 at 12:00:24PM +0200, Pablo Neira Ayuso wrote: > On Fri, Aug 17, 2018 at 01:56:32PM +1000, Duncan Roe wrote: > > Commit 88456a7ef added #include but that header > > needs > > the definition of IFNAMSIZ from > > Hm, it must be c8a0e8c9

[PATCH v2] nft: Fix build failure in rule.c

undeclared here (not in a function) char dev[IFNAMSIZ]; /* Local device to use */ ^ Makefile:687: recipe for target 'rule.lo' failed Signed-off-by: Duncan Roe --- src/rule.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rule.c b/src/

Re: [PATCH] nft: Fix build failure in rule.c

On Fri, Aug 17, 2018 at 12:00:24PM +0200, Pablo Neira Ayuso wrote: > On Fri, Aug 17, 2018 at 01:56:32PM +1000, Duncan Roe wrote: > > Commit 88456a7ef added #include but that header > > needs > > the definition of IFNAMSIZ from > > Hm, it must be c8a0e8c90e2d1, right

[PATCH] doc: Add script to build PDF files

See comments at end of doc/build_pdfs.sh Signed-off-by: Duncan Roe --- doc/build_pdfs.sh | 51 +++ 1 file changed, 51 insertions(+) create mode 100755 doc/build_pdfs.sh diff --git a/doc/build_pdfs.sh b/doc/build_pdfs.sh new file mode 100755

[PATCH] nft: Fix build failure in rule.c

Commit 88456a7ef added #include but that header needs the definition of IFNAMSIZ from Signed-off-by: Duncan Roe --- src/rule.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rule.c b/src/rule.c index d11b1d2..570d667 100644 --- a/src/rule.c +++ b/src/rule.c @@ -29,6 +29,7

Re: [PATCH nft] build: remove PDF documentation generation

On Thu, Aug 16, 2018 at 08:20:33PM +0200, Pablo Neira Ayuso wrote: > > As an alternative, would you be OK if we keep in the tree a > build-pdf.sh script that calls asciidoc to generate the PDF? So we get > this away from the build infrastructure but still you have an easy > way to quickly build the

Re: [PATCH nft] build: remove PDF documentation generation

On Tue, Aug 14, 2018 at 02:51:45PM +0200, Pablo Neira Ayuso wrote: > This adds unnecessary complexity to our build infrastructure. People can > just manually generate them in PDF in case they need too. So let's keep > it simple and remove this. > > Signed-off-by: Pablo Neira Ayuso [...] I thought

Re: [PATCH] doc: Remove double-spacing in text

On Tue, Aug 14, 2018 at 08:11:41AM +0200, Máté Eckl wrote: > On Tue, Aug 14, 2018 at 02:31:51PM +1000, Duncan Roe wrote: > > Double-spacing in .txt files has no effect on PDF or man page output and > > can make it hard to locate phrases when editing, so remove them. > > >

[PATCH] doc: Remove double-spacing in text

Double-spacing in .txt files has no effect on PDF or man page output and can make it hard to locate phrases when editing, so remove them. Signed-off-by: Duncan Roe --- doc/data-types.txt | 16 +++ doc/nft.txt| 50

Re: [PATCH] nft: doc: fix make distcheck

On Mon, Aug 13, 2018 at 02:15:07PM +0200, Pablo Neira Ayuso wrote: > If I apply this patch, when I run `make distcheck', asciidoc tries to > write into the read-only automake unpacked dist tree here. > > "/usr/bin/asciidoc" --backend docbook -a "a2x-format=manpage" --doctype > manpage --out-file

[PATCH] nft: Fix configure.ac so --enable-pdf-doc actually works

e -j7 || make Signed-off-by: Duncan Roe --- configure.ac | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index c1c9035..8ea702d 100644 --- a/configure.ac +++ b/configure.ac @@ -62,13 +62,6 @@ AM_COND_IF([BUILD_PDF], [ AS_IF([test &quo

Re: [PATCH v2] nft: doc: changes in configure file for PDF creation

Hi Pablo, On Wed, Aug 08, 2018 at 07:21:49PM +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 08, 2018 at 02:34:37AM +0530, Arushi Singhal wrote: > > changes in package dependencies for PDF creation (nft.pdf) from > > asciidoc. > > If I apply this patch, I can hit the following error: > > make[2]: En

[PATCH] doc: user niggles

previous 2, but apply fine without them (2 occurrences of "offset -5 lines"). Signed-off-by: Duncan Roe --- doc/data-types.txt | 2 +- doc/nft.txt| 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/data-types.txt b/doc/data-types.txt index 7a02a21..1d

Re: [PATCH nft] doc: Add comment possibility to man page

On Mon, Aug 06, 2018 at 08:58:21PM +0200, Máté Eckl wrote: > Commenting is really useful in complex rulesets, however it is not > documented that they can be added to any rule. > > This patch adds commenting possibility to the man page. > Acked-by: Duncan Roe > Signed-off-by

Re: [PATCH nft] doc: fix syntax for RULES

On Mon, Aug 06, 2018 at 08:58:19PM +0200, Máté Eckl wrote: > [] means optional but 'add' or 'insert' is not optional one of them is > required > which is usually signed with {} braces. > Acked-by: Duncan Roe > Signed-off-by: Máté Eckl -- To unsubscribe from th

[PATCH] doc: Changes following detailed comparison with last XML version

of empty lines in them. 6. Occasionally there is severe wrapping, e.g. under CHAINS see add/create/delete/&c. which wrap at about cc40. Signed-off-by: Duncan Roe --- doc/data-types.txt | 2 +- doc/nft.txt| 21 ++--- doc/payload-expression.txt | 40 +

[PATCH] doc: Miscellaneous spelling fixes

-expression.txt: ispell suggested rtclassid instead of rtlclassid, which agres with previous usage - stateful-objects.txt: (nothing special) - statements.txt: nonbase chains changed back to non-base chains as it used to be Signed-off-by: Duncan Roe --- doc/ispell_nft | 11

[PATCH] doc: resolve run-together IPv6 address specification headers

This run-together header has been there since before the conversion to .txt. Also the comment starting "without []" wrapped around in an 80cc xterm, so split into 2 comment lines and fixed grammar (extrs "the"). Signed-off-by: Duncan Roe --- doc/data-types.txt | 8 ++-

[PATCH] doc: Remove UTF8(?) sequences

using man in the C locale Signed-off-by: Duncan Roe --- doc/nft.txt | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/doc/nft.txt b/doc/nft.txt index d1eaf3b..dcc3bf3 100644 --- a/doc/nft.txt +++ b/doc/nft.txt @@ -45,11 +45,11 @@ For a full summary

Re: git.netfilter.org:git is closed - intentionally?

On Fri, Jul 06, 2018 at 11:20:53AM +1000, Duncan Roe wrote: > Hi, > > git pull in nftables/ timed out so I tried: > > telnet git.netfilter.org 9418 ... times out > telnet git.netfilter.org 443 ... connects > telnet git.netfilter.org 80 ... connects > > So it woul

git.netfilter.org:git is closed - intentionally?

Hi, git pull in nftables/ timed out so I tried: telnet git.netfilter.org 9418 ... times out telnet git.netfilter.org 443 ... connects telnet git.netfilter.org 80 ... connects So it would seem git is blocked by an nft rule but http and https are still open When is this likely to change? C

Re: [PATCH 2/6] build: rename sed source files to .in

we're not going to address the build failure > > >> experienced by Duncan Roe and the tomato project? > > > > > >I think we agreed the problem there is a very old toolchain that is > > >ignoring -I for some reason, right? > > > > Negative! It *is

Re: [PATCH 2/6] build: rename sed source files to .in

Hi Pablo, On Fri, Jun 29, 2018 at 12:11:42PM +0200, Pablo Neira Ayuso wrote: > On Fri, Jun 29, 2018 at 12:05:12PM +0200, Jan Engelhardt wrote: > > So does that mean we're not going to address the build failure > > experienced by Duncan Roe and the tomato project? > > I t

Re: [PATCH nft] configure.ac: docbook2man invalid syntax error

On Thu, Jun 28, 2018 at 11:15:58PM +0200, Máté Eckl wrote: > On Thu, Jun 28, 2018 at 06:43:40PM +0200, Pablo Neira Ayuso wrote: > > On Thu, Jun 28, 2018 at 06:30:15PM +0200, Florian Westphal wrote: > > > Máté Eckl wrote: > > > > I don't really know autoconfig, but isn't that possible to prioritize

Re: [PATCH] extensions: ebt_string: take action if snprintf discards data

Hi Pablo, On Wed, Jun 27, 2018 at 05:28:48PM +0200, Pablo Neira Ayuso wrote: > Hi Duncan, > > On Fri, Jun 15, 2018 at 11:31:56AM +1000, Duncan Roe wrote: > > commit e6359eedfbf497e52d52451072aea4713ed80a88 eliminated a gcc warning > > that > > strncpy could make a st

[PATCH] ebtables: abandon KERNEL_INCLUDES and use double quotes

targets discovered a set-but-never-used variable in ebtablesd.c: this (ret) is removed. Signed-off-by: Duncan Roe --- INSTALL | 6 + Makefile | 38 +--- ebtablesd.c

Re: [PATCH] build: abandon KERNEL_INCLUDES variable

On Tue, Jun 26, 2018 at 08:21:30AM +0200, Jan Engelhardt wrote: > Since UAPI headers are shipped since commit > ebtables-2.0.10-4-8-gf4bdc80, "-Iinclude" must always be used ever > since. Remove the KERNEL_INCLUDES make variable for good. > > Signed-off-by: Jan Engelhardt > --- > INSTALL

Re: [PATCH] ebtables: Use double quotes in #include statements for local headers

@@ -12,7 +12,7 @@ > > > #include > > > #include "../include/ebtables_u.h" > > > #include "../include/ethernetdb.h" > > > -#include > > > +#include "linux/netfilter_bridge/ebt_802_3.h" Cheers ... Duncan. [q] https://github.c

[PATCH] ebtables: Use double quotes in #include statements for local headers

uctions at the URL. Replace ebtables with the one from git. Enter "make distclean && make r7000e". I think you need to "apt install" some extra packages to progress to the ebtables fail. You do need to "apt install gperf" to finish the build with a fixed

Re: [PATCH v2] nftables: Fix typos/Grammatical Errors

On Tue, Jun 19, 2018 at 08:34:51AM +0530, Arushi Singhal wrote: > typos/Grammatical errors are corrected. > Acked-by: Duncan Roe > Signed-off-by: Arushi Singhal > --- > changes in v2 > -removed the changes with better original version. > > doc/nft.xml | 8 -

Re: [PATCH] nftables: Fix typos/Grammatical Errors

On Fri, Jun 15, 2018 at 07:27:37AM +0530, Arushi Singhal wrote: > typos/Grammatical errors are corrected. > > Signed-off-by: Arushi Singhal > --- > doc/nft.xml | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/doc/nft.xml b/doc/nft.xml > index 3a5571b..8f463c6

[PATCH] extensions: ebt_string: take action if snprintf discards data

eventuality. Signed-off-by: Duncan Roe --- extensions/ebt_string.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/ebt_string.c b/extensions/ebt_string.c index 3deff1b..79e24dc 100644 --- a/extensions/ebt_string.c +++ b/extensions/ebt_string.c @@ -168,7 +168,9

Re: [PATCH] src: Fix another build warning / error

On Tue, Jun 12, 2018 at 08:31:49PM +0200, Pablo Neira Ayuso wrote: > On Tue, Jun 12, 2018 at 01:25:35PM +1000, Duncan Roe wrote: > > gcc 8.1 warns when it can detect that a strncpy may result in a string with > > no > > null terminator. It also warns when it can sim

Re: [PATCH] src: Fix another build warning / error

On Tue, Jun 12, 2018 at 01:25:35PM +1000, Duncan Roe wrote: > gcc 8.1 warns when it can detect that a strncpy may result in a string with no > null terminator. It also warns when it can similarly detect that an snprintf > may > discard characters, unless the return value from that

[PATCH] src: Fix another build warning / error

line, but the gcc 8.1.1 snapshot that comes with FC28 does. Reported-by: Florian Westphal Signed-off-by: Duncan Roe --- extensions/ebt_string.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/ebt_string.c b/extensions/ebt_string.c index 9550c41..2c40501 100644

Re: [PATCH] ebtables: Fix build errors and warnings

On Mon, May 21, 2018 at 03:53:11PM +1000, Duncan Roe wrote: > On Tue, May 15, 2018 at 12:42:09AM +0200, Florian Westphal wrote: > > Duncan Roe wrote: > > > Since commit b1cdae87f25021eb835872d86d6e7206bd421c3f, make fails thusly: > > > > > > > libebt

Re: [PATCH] iptables src: Use double quotes in #includes for local headers

On Wed, Jun 06, 2018 at 01:16:43PM +0200, Jan Engelhardt wrote: > > On Wednesday 2018-06-06 09:45, Duncan Roe wrote: > > > >ebtables would not build on my system and I submitted a patch to fix that > >which > >was accepted as commit 66a97018a31eed416c6a25d051ea172

Re: [PATCH] iptables src: Use double quotes in #includes for local headers

p6tables.c i.e. using all the preprocessor options found in the log of the build. You might like to try it yourself (it only works after you have done a build) to see whether you get the same result. In detail: On Tue, Jun 05, 2018 at 09:50:33PM +0200, Jan Engelhardt wrote: > > On Tuesday 20

[PATCH] iptables src: Use double quotes in #includes for local headers

double quotes, developers are reminded that the code is using a private copy of a system header which may differ from the installed one. Signed-off-by: Duncan Roe --- extensions/dscp_helper.c | 2 +- extensions/libarpt_mangle.c| 4 ++-- extensions

[PATCH] libnftnl src: Use double quotes in #includes for non-system headers

-off-by: Duncan Roe --- include/data_reg.h | 2 +- include/libnftnl/chain.h| 2 +- include/libnftnl/flowtable.h| 2 +- include/libnftnl/gen.h | 2 +- include/libnftnl/object.h | 2 +- include/libnftnl/rule.h | 2 +- include/libnftnl/ruleset.h

Re: [PATCH v2] libmnl src: Use double quotes in #includes for non-system headers

On Tue, Jun 05, 2018 at 10:13:18AM +0200, Jan Engelhardt wrote: > On Tuesday 2018-06-05 08:20, Duncan Roe wrote: > > >libmnl carries a private copy of a number of system headers. These were > >mostly > >still being included with angle brackets as though they were system he

[PATCH] nftables src: Use double quotes in #includes for non-system headers

quotes, developers are reminded that the code is using a private header which may differ from the system one. Signed-off-by: Duncan Roe --- include/datatype.h| 2 +- include/erec.h| 4 ++-- include/expression.h | 30

[PATCH v2] libmnl src: Use double quotes in #includes for non-system headers

in ./examples/, because it is expected that these may be compiled out-of-tree, where angle brackets are appropriate. Signed-off-by: Duncan Roe --- include/libmnl/libmnl.h | 2 +- include/linux/netlink.h | 2 +- src/attr.c | 2 +- src/callback.c | 2 +- src/nlmsg.c

[PATCH v1] libmnl src: Use double quotes in #includes for non-system headers

quotes, developers are reminded that the code is using a private header which may differ from the system one. (In fact ./include/linux/netlink.h differs considerably from /usr/include/linux/netlink.h at kernel-headers-4.4.14 and even more so at kernel-headers-4.16.12). Signed-off-by: Duncan Roe

Re: Is there something wrong with this patch?

On Mon, Jun 04, 2018 at 10:05:15AM +0200, Pablo Neira Ayuso wrote: > Hi Duncan, > > On Mon, Jun 04, 2018 at 01:11:01PM +1000, Duncan Roe wrote: > > Hi, > > > > Did you guys miss this? I pushed it out to the list a week ago, as > > > > [PATCH] src: Use doub

Is there something wrong with this patch?

Hi, Did you guys miss this? I pushed it out to the list a week ago, as [PATCH] src: Use double quotes in include statements for non-system headers but have heard nothing back. It did fix a problem for someone, Cheers ... Duncan. On Sun, May 27, 2018 at 02:54:11PM +1000, Duncan Roe wrote

[PATCH] src: Use double quotes in include statements for non-system headers

. Reported-by: Edriss Mirzadeh Cc: Edriss Mirzadeh Signed-off-by: Duncan Roe --- examples/ulog/test_ulog.c| 2 +- extensions/ebt_802_3.c | 2 +- extensions/ebt_among.c | 2 +- extensions/ebt_arp.c | 2

Re: ebtables commit

Hi Edriss, On Fri, May 25, 2018 at 02:43:39PM -0400, Edriss Mirzadeh wrote: > Hi there Duncan, > > I tried pulling the most up to date version of ebtables to compile as part > of the Tomato Firmware (for ARM routers). > > I found that the build failed on two files I believe related to commit > > 6

Re: [PATCH] ebtables: Fix build errors and warnings

On Tue, May 15, 2018 at 12:42:09AM +0200, Florian Westphal wrote: > Duncan Roe wrote: > > Since commit b1cdae87f25021eb835872d86d6e7206bd421c3f, make fails thusly: > > > > > libebtc.c: In function 'ebt_reinit_extensions': > > > libebtc.c:

[PATCH] ebtables: Fix build errors and warnings

me to be otherwise close enough, so amended ebtables_u.h to use the newer one. Makefile insists on being warning-free, so cleared up warnings. Apart from unused variables, there was also the issue that the diagnostic macro ebt_print_error2 *returns* (i.e. makes its caller

[PATCH] doc: update doc/ispell_nft to track recent nft.8 updates

Track changes in commits 3baa28f24b3d70a7ee17d584c113a2c4e057a565 and 4787edad132c30ae0f6bb00135ae5d970b0ccb74 (rename ibriport and obriport: s/iport/name). Signed-off-by: Duncan Roe --- doc/ispell_nft | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/ispell_nft b/doc

Re: [ANNOUNCE] libnftnl 1.1.0 release

On Wed, May 02, 2018 at 10:09:04AM +0200, Pablo Neira Ayuso wrote: > On Wed, May 02, 2018 at 11:32:13AM +1000, Duncan Roe wrote: > > On Tue, May 01, 2018 at 11:33:33PM +0200, Florian Westphal wrote: [...] > > Hey Florian, > > > > I just downloaded > > https:

Re: [ANNOUNCE] libnftnl 1.1.0 release

On Tue, May 01, 2018 at 11:33:33PM +0200, Florian Westphal wrote: > Hi! > > The Netfilter project proudly presents: > > libnftnl 1.1.0 > > libnftnl is a userspace library providing a low-level netlink > programming interface (API) to the in-kernel nf_tables subsystem. > This library is currentl

[PATCH] nft: Fix --debug mnl not producing output

cache_update() needs to accept the full debug mask instead of a boolean of NFT_DEBUG_NETLINK, because called functions may wish to check other bits (NFT_DEBUG_MNL in particular). Signed-off-by: Duncan Roe --- include/rule.h | 2 +- src/evaluate.c | 30 +++--- src

[PATCH] doc: nft.8 more spelling fixes

, e.g. IPv4 is always that way but ipv4_addr stays as before. The existing dictionary suggested capital Ethernet so that is in there too. Signed-off-by: Duncan Roe --- doc/ispell_nft | 217 + doc/nft.xml| 54 +++--- 2 files

Re: [PATCH nft] create u32_integer type to be used as a key for sets and maps

On Mon, Mar 26, 2018 at 09:43:06AM +0200, Laura Garcia wrote: > On Sat, Mar 24, 2018 at 12:47 AM, Duncan Roe > wrote: > > On Wed, Mar 14, 2018 at 10:00:35PM +0100, Laura Garcia Liebana wrote: > >> Create the new type u32_integer with a fixed size in order to > >>

Re: [PATCH nft] create u32_integer type to be used as a key for sets and maps

On Wed, Mar 14, 2018 at 10:00:35PM +0100, Laura Garcia Liebana wrote: > Create the new type u32_integer with a fixed size in order to > be used as a key in maps and sets. The type integer cannot be > used as a key cause is a dynamic size type and is used as a > base type of some subtypes. > > Witho

[PATCH] doc: nft.8 aim for consistent synopses throughout (again)

Fix a few more items as per commit f9cb9580b924f6320005f429f7d59e52a38aff82 Also insert a missing space I noticed along the way Signed-off-by: Duncan Roe --- doc/nft.xml | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/doc/nft.xml b/doc/nft.xml index

[WIKI] Certificate has expired

Hi, Firefox just complained to me about opening the Wiki https://wiki.nftables.org/wiki-nftables/index.php/Main_Page because the certificate has expired (a few hours ago). Of course I added an exception and can now get the page, but... Can someone fix this please? Cheers ... Duncan. -- To unsub

Re: [nft PATCH v2 1/3] nftables: rearrange files and examples

On Sat, Mar 10, 2018 at 02:19:33PM +0100, Arturo Borrero Gonzalez wrote: > On 10 March 2018 at 09:28, Duncan Roe wrote: > > # > Up to Release 0.8.2, it used to be the case that after *make install*, these > > example files would show up in /etc/nftables. > > > > N

Re: [PATCH nf-next 0/2] ebtables: add support for ICMP and IGMP type/code matching

On Sun, Mar 04, 2018 at 12:16:55PM +0100, Matthias Schiffer wrote: > On 03/04/2018 10:40 AM, Florian Westphal wrote: > > Matthias Schiffer wrote: [...] > Switching from ebtables to nftables without also dropping iptables from > Gluon is definitely out of the question, which leaves us with two opti

  1   2   >