From: Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Alexander Aring
Cc: Stefan Schmidt
Cc: "David S. Miller"
Cc: Alexey Kuznetsov
Cc:
From: Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Alexander Aring
Cc: Stefan Schmidt
Cc: "David S. Miller"
Cc: Alexey Kuznetsov
Cc:
From: Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Alexander Aring
Cc: Stefan Schmidt
Cc: "David S. Miller"
Cc: Alexey Kuznetsov
Cc:
Remove trailing whitespace and blank lines at EOF
Signed-off-by: Stephen Hemminger
---
net/sched/Kconfig| 4 ++--
net/sched/Makefile | 2 +-
net/sched/act_connmark.c | 1 -
net/sched/act_pedit.c| 1 -
net/sched/cls_basic.c| 1 -
5 files changed, 3 insertions(+), 6
Ran script that I use to check for trailing whitespace and
blank lines at end of files across all files in net/ directory.
These are errors that checkpatch reports and git flags.
These are the resulting fixes broken up mostly by subsystem.
Stephen Hemminger (18):
sched: fix trailing whitespace
Signed-off-by: Stephen Hemminger
---
net/wimax/Makefile | 2 --
net/wimax/debugfs.c | 2 --
net/wimax/op-msg.c | 1 -
net/wimax/stack.c | 1 -
4 files changed, 6 deletions(-)
diff --git a/net/wimax/Makefile b/net/wimax/Makefile
index eb2db0d3b880..c2a71ae487ac 100644
--- a/net/wimax
Remove trailing whitespace and blank lines at EOF
Signed-off-by: Stephen Hemminger
---
net/9p/client.c | 4 ++--
net/9p/trans_virtio.c | 2 +-
net/9p/util.c | 1 -
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/9p/client.c b/net/9p/client.c
index 5c1343195292
Signed-off-by: Stephen Hemminger
---
net/ipv6/ila/ila_common.c | 1 -
net/ipv6/ila/ila_xlat.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/net/ipv6/ila/ila_common.c b/net/ipv6/ila/ila_common.c
index 579310466eac..95e9146918cc 100644
--- a/net/ipv6/ila/ila_common.c
+++ b/net/ipv6/ila
Signed-off-by: Stephen Hemminger
---
net/rds/Kconfig | 1 -
net/rds/Makefile | 1 -
net/rds/ib.c | 1 -
net/rds/message.c| 1 -
net/rds/rdma_transport.c | 1 -
net/rds/tcp.c| 1 -
net/rds/transport.c | 1 -
7 files changed, 7 deletions
Signed-off-by: Stephen Hemminger
---
net/xfrm/Kconfig | 1 -
net/xfrm/xfrm_user.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
index 286ed25c1a69..eab952cca7d0 100644
--- a/net/xfrm/Kconfig
+++ b/net/xfrm/Kconfig
@@ -87,4 +87,3 @@ config
Signed-off-by: Stephen Hemminger
---
net/mpls/mpls_iptunnel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c
index 6e558a419f60..94f53a9b7d1a 100644
--- a/net/mpls/mpls_iptunnel.c
+++ b/net/mpls/mpls_iptunnel.c
@@ -224,7
Remove blank line at EOF and trailing whitespace.
Signed-off-by: Stephen Hemminger
---
net/sctp/Kconfig | 4 ++--
net/sctp/sm_sideeffect.c | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/sctp/Kconfig b/net/sctp/Kconfig
index c740b189d4ba..950ecf6e7439 100644
Remove blank lines at end of file and trailing whitespace.
Signed-off-by: Stephen Hemminger
---
net/ceph/Kconfig | 1 -
net/ceph/Makefile | 1 -
net/ceph/auth_none.c | 1 -
net/ceph/auth_none.h | 1 -
net/ceph/auth_x.c | 2 --
net/ceph/auth_x.h | 1 -
net/ceph/mon_client.c
Remove trailing whitespace and extra lines at EOF
Signed-off-by: Stephen Hemminger
---
net/decnet/Kconfig | 1 -
net/decnet/Makefile | 1 -
net/decnet/TODO | 5 ++---
net/decnet/dn_fib.c | 2 --
net/decnet/dn_nsp_in.c | 1 -
net
Signed-off-by: Stephen Hemminger
---
net/ax25/ax25_addr.c| 1 -
net/ax25/ax25_ds_in.c | 1 -
net/ax25/ax25_ds_subr.c | 1 -
net/ax25/ax25_ip.c | 1 -
net/ax25/ax25_out.c | 1 -
5 files changed, 5 deletions(-)
diff --git a/net/ax25/ax25_addr.c b/net/ax25/ax25_addr.c
index
Signed-off-by: Stephen Hemminger
---
net/bpfilter/Kconfig | 1 -
net/ipv4/bpfilter/Makefile | 1 -
2 files changed, 2 deletions(-)
diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
index 76deb6615883..e558b46596c4 100644
--- a/net/bpfilter/Kconfig
+++ b/net/bpfilter/Kconfig
Several files have extra line at end of file.
Signed-off-by: Stephen Hemminger
---
net/8021q/Makefile | 1 -
net/Kconfig | 2 +-
net/core/neighbour.c| 1 -
net/dns_resolver/dns_key.c | 1 -
net/ieee802154/core.c | 1 -
net/ieee802154
Signed-off-by: Stephen Hemminger
---
net/l2tp/l2tp_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index 1ea285bad84b..c8fc0f7f0b4b 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -1795,4 +1795,3 @@ MODULE_AUTHOR("
Remove trailing whitespace and blank line at EOF
Signed-off-by: Stephen Hemminger
---
net/sunrpc/auth_gss/auth_gss.c | 2 +-
net/sunrpc/auth_gss/gss_generic_token.c | 1 -
net/sunrpc/auth_gss/gss_krb5_crypto.c | 1 -
net/sunrpc/auth_gss/gss_krb5_keys.c | 1 -
net/sunrpc/auth_gss
Signed-off-by: Stephen Hemminger
---
net/llc/Kconfig | 2 +-
net/llc/Makefile | 2 +-
net/llc/llc_if.c | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/llc/Kconfig b/net/llc/Kconfig
index b91c65108162..176a6c1521a5 100644
--- a/net/llc/Kconfig
+++ b/net/llc/Kconfig
Signed-off-by: Stephen Hemminger
---
net/x25/Kconfig| 2 --
net/x25/x25_subr.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/net/x25/Kconfig b/net/x25/Kconfig
index e2fa133f9fba..59fcb41fc5e6 100644
--- a/net/x25/Kconfig
+++ b/net/x25/Kconfig
@@ -31,5 +31,3 @@ config X25
Signed-off-by: Stephen Hemminger
---
net/atm/mpoa_proc.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/net/atm/mpoa_proc.c b/net/atm/mpoa_proc.c
index b93cc0f18292..46d6cd9a36ae 100644
--- a/net/atm/mpoa_proc.c
+++ b/net/atm/mpoa_proc.c
@@ -307,9 +307,3 @@ void mpc_proc_clean(void
The destination mac (destmac) is only valid if EBT_DESTMAC flag
is set. Fix by changing the order of the comparison to look for
the flag first.
Reported-by: syzbot+5c06e318fc558cc27...@syzkaller.appspotmail.com
Signed-off-by: Stephen Hemminger
---
Note: no fixes since this bug goes back to pre
Support for Decnet has been orphaned for some time.
In the interest of reducing the potential bug surface and pre-holiday
cleaning, move the decnet protocol into staging for eventual removal.
Signed-off-by: Stephen Hemminger
---
Note original submission was hour or so before net-next closed.
Not
Begin forwarded message:
Date: Mon, 23 Oct 2017 16:17:38 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 197367] New: NMI watchdog: BUG: soft lockup - CPU#1 stuck for
22s! [nf_conntrack]
https://bugzilla.kernel.org/show_bug.cgi?id=197367
Signed-off-by: Stephen Hemminger
---
net/bluetooth/6lowpan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 2af4f1cc0ab4..4e2576fc0c59 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -273,9 +273,6 @@ static int
warning: ‘recent_old_fops’ defined but not used
Signed-off-by: Stephen Hemminger
---
net/netfilter/xt_recent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c
index 3f6c4fa78bdb..245fa350a7a8 100644
--- a/net/netfilter
The variable owned_by_user is always set, but only used
when kernel is configured with LOCKDEP enabled.
Get rid of the warning by moving the code to put the call
to owned_by_user into the the rcu_protected call.
Signed-off-by: Stephen Hemminger
---
net/socket.c | 6 ++
1 file changed, 2
warning: variable ‘netdev’ set but not used
Signed-off-by: Stephen Hemminger
---
drivers/net/ethernet/emulex/benet/be_roce.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_roce.c
b/drivers/net/ethernet/emulex/benet/be_roce.c
index 2b62841c4c63
Various fixes for warnings in network code and drivers.
Stephen Hemminger (6):
bnxt: fix unsigned comparsion with 0
bnxt: fix unused variable warnings
benet: fix set but not used warning
netfilter: remove unused variable
socket: fix set not used warning
6lowpan: fix set not used
Fixes warning because location is u32 and can never be netative
warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Signed-off-by: Stephen Hemminger
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Fix a couple of warnings where variable ‘txq’ set but not used
Signed-off-by: Stephen Hemminger
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index
On Tue, 11 Jul 2017 07:24:16 -0700 (PDT)
David Miller wrote:
> It has gotten to the point that even casually walking around
> Faro, Portugal last week, random German tourists would stop
> me in the street and ask if net-next was open or not.
>
> Therefore, in order to avoid any and all confusion
‘nft_rt_get_dump’ [-Wmissing-prototypes]
Signed-off-by: Stephen Hemminger
---
net/netfilter/nft_rt.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/net/netfilter/nft_rt.c b/net/netfilter/nft_rt.c
index d3eb640bc784..c7383d8f88d0 100644
--- a/net/netfilter
Missing include file causes:
net/netfilter/nf_dup_netdev.c:26:6: warning: no previous prototype for
‘nf_fwd_netdev_egress’ [-Wmissing-prototypes]
net/netfilter/nf_dup_netdev.c:40:6: warning: no previous prototype for
‘nf_dup_netdev_egress’ [-Wmissing-prototypes]
Signed-off-by: Stephen
> - (T*)
> e
> )
>
> Unnecessary parantheses are also remove.
>
> Signed-off-by: simran singhal
Looks good
Reviewed-by: Stephen Hemminger
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 21 Mar 2017 23:28:45 +0100
Linus Lüssing wrote:
> However, the IP code drops it in the beginning of ip_input.c/ip_rcv()
> as the dnat target did not update the skb->pkt_type. If after
> dnat'ing the packet is now destined to us then the skb->pkt_type
> needs to be updated from PACKET_OTHE
: Pablo Neira Ayuso
Thanks, for fixing this. This is old.
Acked-by: Stephen Hemminger
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 17 May 2016 00:36:58 +0900
Hajime Tazaki wrote:
> Following the last successful Netdev 0.1 in Ottawa, Canada and
> 1.1 in Seville, Spain. We are happy to announce the third Netdev conference:
> Netdev 1.2 (year 1, conference 2) from 5th to 7th October 2016 in Tokyo,
> Japan (http://netdev
39 matches
Mail list logo