[PATCH] extensions: libxt_hashlimit: Do not print default timeout and burst

2017-12-19 Thread Harsha Sharma
Do not print timeout and burst in case default values are used. For e.g. iptables-translate -A INPUT -m tcp -p tcp --dport 80 -m hashlimit --hashlimit-above 200/sec --hashlimit-mode srcip,dstport --hashlimit-name http1 -j DROP nft add rule ip filter INPUT tcp dport 80 flow table http1 { tcp dport

Re: [PATCH] extensions: libxt_hashlimit: Do not print default timeout and burst

2017-12-19 Thread Pablo Neira Ayuso
On Tue, Dec 19, 2017 at 05:57:16PM +0530, Harsha Sharma wrote: > @@ -1340,7 +1345,9 @@ static int hashlimit_mt_xlate(struct xt_xlate *xl, > const char *name, > xt_xlate_add(xl, "flow table %s {", name); > ret = hashlimit_mode_xlate(xl, cfg->mode, family, >

Re: [PATCH] extensions: libxt_hashlimit: Do not print default timeout and burst

2017-12-19 Thread Harsha Sharma
On Tue, Dec 19, 2017 at 7:31 PM, Pablo Neira Ayuso wrote: > On Tue, Dec 19, 2017 at 05:57:16PM +0530, Harsha Sharma wrote: >> @@ -1340,7 +1345,9 @@ static int hashlimit_mt_xlate(struct xt_xlate *xl, >> const char *name, >> xt_xlate_add(xl, "flow table %s {", name); >> ret = hashlimit_

Re: [PATCH] extensions: libxt_hashlimit: Do not print default timeout and burst

2017-12-26 Thread Duncan Roe
On Tue, Dec 19, 2017 at 08:20:31PM +0530, Harsha Sharma wrote: > On Tue, Dec 19, 2017 at 7:31 PM, Pablo Neira Ayuso > wrote: > > On Tue, Dec 19, 2017 at 05:57:16PM +0530, Harsha Sharma wrote: > >> @@ -1340,7 +1345,9 @@ static int hashlimit_mt_xlate(struct xt_xlate *xl, > >> const char *name, > >

Re: [PATCH] extensions: libxt_hashlimit: Do not print default timeout and burst

2017-12-27 Thread Duncan Roe
On Wed, Dec 27, 2017 at 10:31:04AM +1100, Duncan Roe wrote: > On Tue, Dec 19, 2017 at 08:20:31PM +0530, Harsha Sharma wrote: > > On Tue, Dec 19, 2017 at 7:31 PM, Pablo Neira Ayuso > > wrote: > > > On Tue, Dec 19, 2017 at 05:57:16PM +0530, Harsha Sharma wrote: > > >> @@ -1340,7 +1345,9 @@ static i

Re: [PATCH] extensions: libxt_hashlimit: Do not print default timeout and burst

2017-12-27 Thread Pablo Neira Ayuso
On Wed, Dec 27, 2017 at 10:31:04AM +1100, Duncan Roe wrote: > On Tue, Dec 19, 2017 at 08:20:31PM +0530, Harsha Sharma wrote: > > On Tue, Dec 19, 2017 at 7:31 PM, Pablo Neira Ayuso > > wrote: > > > On Tue, Dec 19, 2017 at 05:57:16PM +0530, Harsha Sharma wrote: > > >> @@ -1340,7 +1345,9 @@ static i

Re: [PATCH] extensions: libxt_hashlimit: Do not print default timeout and burst

2017-12-27 Thread Duncan Roe
On Wed, Dec 27, 2017 at 12:13:26PM +0100, Pablo Neira Ayuso wrote: > On Wed, Dec 27, 2017 at 10:31:04AM +1100, Duncan Roe wrote: > > On Tue, Dec 19, 2017 at 08:20:31PM +0530, Harsha Sharma wrote: > > > On Tue, Dec 19, 2017 at 7:31 PM, Pablo Neira Ayuso > > > wrote: > > > > On Tue, Dec 19, 2017 at