Re: [PATCH 1/1] netfilter: ipset: Fix set:list type crash when flush/dump set in parallel

2016-03-10 Thread Pablo Neira Ayuso
On Tue, Mar 08, 2016 at 08:27:30PM +0100, Jozsef Kadlecsik wrote: > Hi Pablo, > > On Sat, 5 Mar 2016, Pablo Neira Ayuso wrote: > > > On Mon, Feb 29, 2016 at 01:47:59PM +0100, Jozsef Kadlecsik wrote: > > > On Mon, 29 Feb 2016, Pablo Neira Ayuso wrote: > > > > > > > On Wed, Feb 24, 2016 at 09:19:2

Re: [PATCH 1/1] netfilter: ipset: Fix set:list type crash when flush/dump set in parallel

2016-03-08 Thread Jozsef Kadlecsik
Hi Pablo, On Sat, 5 Mar 2016, Pablo Neira Ayuso wrote: > On Mon, Feb 29, 2016 at 01:47:59PM +0100, Jozsef Kadlecsik wrote: > > On Mon, 29 Feb 2016, Pablo Neira Ayuso wrote: > > > > > On Wed, Feb 24, 2016 at 09:19:26PM +0100, Jozsef Kadlecsik wrote: > > > > Flushing/listing entries was not RCU sa

Re: [PATCH 1/1] netfilter: ipset: Fix set:list type crash when flush/dump set in parallel

2016-03-05 Thread Pablo Neira Ayuso
Hi Jozsef, On Mon, Feb 29, 2016 at 01:47:59PM +0100, Jozsef Kadlecsik wrote: > On Mon, 29 Feb 2016, Pablo Neira Ayuso wrote: > > > On Wed, Feb 24, 2016 at 09:19:26PM +0100, Jozsef Kadlecsik wrote: > > > Flushing/listing entries was not RCU safe, so parallel flush/dump > > > could lead to kernel c

Re: [PATCH 1/1] netfilter: ipset: Fix set:list type crash when flush/dump set in parallel

2016-02-29 Thread Jozsef Kadlecsik
On Mon, 29 Feb 2016, Pablo Neira Ayuso wrote: > On Wed, Feb 24, 2016 at 09:19:26PM +0100, Jozsef Kadlecsik wrote: > > Flushing/listing entries was not RCU safe, so parallel flush/dump > > could lead to kernel crash. Bug reported by Deniz Eren. > > > > Fixes netfilter bugzilla id #1050. > > > > S

Re: [PATCH 1/1] netfilter: ipset: Fix set:list type crash when flush/dump set in parallel

2016-02-29 Thread Pablo Neira Ayuso
On Wed, Feb 24, 2016 at 09:19:26PM +0100, Jozsef Kadlecsik wrote: > Flushing/listing entries was not RCU safe, so parallel flush/dump > could lead to kernel crash. Bug reported by Deniz Eren. > > Fixes netfilter bugzilla id #1050. > > Signed-off-by: Jozsef Kadlecsik > --- > net/netfilter/ipset/

[PATCH 1/1] netfilter: ipset: Fix set:list type crash when flush/dump set in parallel

2016-02-24 Thread Jozsef Kadlecsik
Flushing/listing entries was not RCU safe, so parallel flush/dump could lead to kernel crash. Bug reported by Deniz Eren. Fixes netfilter bugzilla id #1050. Signed-off-by: Jozsef Kadlecsik --- net/netfilter/ipset/ip_set_core.c | 3 ++ net/netfilter/ipset/ip_set_list_set.c | 55