Re: [PATCH libnetfilter_queue] src: make nfq_open_nfnl thread-safe

2016-06-20 Thread Pablo Neira Ayuso
On Mon, Jun 20, 2016 at 02:52:27PM +0200, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > On Mon, Jun 20, 2016 at 02:42:59PM +0200, Pablo Neira Ayuso wrote: > > > On Mon, Jun 20, 2016 at 01:19:52PM +0200, Florian Westphal wrote: > > > > nfq_open_nfnl uses an

Re: [PATCH libnetfilter_queue] src: make nfq_open_nfnl thread-safe

2016-06-20 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Mon, Jun 20, 2016 at 02:42:59PM +0200, Pablo Neira Ayuso wrote: > > On Mon, Jun 20, 2016 at 01:19:52PM +0200, Florian Westphal wrote: > > > nfq_open_nfnl uses an intermediate static object, so when > > > it is invoked by distinct threads at the

Re: [PATCH libnetfilter_queue] src: make nfq_open_nfnl thread-safe

2016-06-20 Thread Pablo Neira Ayuso
On Mon, Jun 20, 2016 at 01:19:52PM +0200, Florian Westphal wrote: > nfq_open_nfnl uses an intermediate static object, so when > it is invoked by distinct threads at the same time there is a small > chance that some threads end up with another threads nfq_handle pointer > stored in ->data. > >

[PATCH libnetfilter_queue] src: make nfq_open_nfnl thread-safe

2016-06-20 Thread Florian Westphal
nfq_open_nfnl uses an intermediate static object, so when it is invoked by distinct threads at the same time there is a small chance that some threads end up with another threads nfq_handle pointer stored in ->data. Tested-by: Michal Tesar Signed-off-by: Florian Westphal