Re: [PATCH net] ipvs: fix buffer overflow with sync daemon and service

2018-05-25 Thread Jesper Dangaard Brouer
On Sat, 19 May 2018 18:22:35 +0300 Julian Anastasov wrote: > The same happens for sched_name when adding/editing virtual server. > > We are restricted by IP_VS_SCHEDNAME_MAXLEN and IP_VS_IFNAME_MAXLEN > being used as size in include/uapi/linux/ip_vs.h, so they > include the space for NUL. Ah, o

Re: [PATCH net] ipvs: fix buffer overflow with sync daemon and service

2018-05-23 Thread Pablo Neira Ayuso
On Wed, May 23, 2018 at 10:19:09AM +0200, Simon Horman wrote: > On Sat, May 19, 2018 at 06:22:35PM +0300, Julian Anastasov wrote: > > syzkaller reports for buffer overflow for interface name > > when starting sync daemons [1] > > > > What we do is that we copy user structure into larger stack > >

Re: [PATCH net] ipvs: fix buffer overflow with sync daemon and service

2018-05-23 Thread Simon Horman
On Sat, May 19, 2018 at 06:22:35PM +0300, Julian Anastasov wrote: > syzkaller reports for buffer overflow for interface name > when starting sync daemons [1] > > What we do is that we copy user structure into larger stack > buffer but later we search NUL past the stack buffer. > The same happens f

[PATCH net] ipvs: fix buffer overflow with sync daemon and service

2018-05-19 Thread Julian Anastasov
syzkaller reports for buffer overflow for interface name when starting sync daemons [1] What we do is that we copy user structure into larger stack buffer but later we search NUL past the stack buffer. The same happens for sched_name when adding/editing virtual server. We are restricted by IP_VS_