[PATCH nf,v2] netfilter: nf_queue: don't re-enter same hook on packet reinjection

2016-10-14 Thread Pablo Neira Ayuso
Make sure we skip the current hook from where the packet was enqueued, otherwise the packets gets enqueued over and over again. Fixes: e3b37f11e6e4 ("netfilter: replace list_head with single linked list") Signed-off-by: Pablo Neira Ayuso --- v2: Make sure next hook is non-null, otherwise we are a

Re: [PATCH nf,v2] netfilter: nf_queue: don't re-enter same hook on packet reinjection

2016-10-17 Thread Aaron Conole
Pablo Neira Ayuso writes: > Make sure we skip the current hook from where the packet was enqueued, > otherwise the packets gets enqueued over and over again. > > Fixes: e3b37f11e6e4 ("netfilter: replace list_head with single linked list") > Signed-off-by: Pablo Neira Ayuso > --- > v2: Make sure

Re: [PATCH nf,v2] netfilter: nf_queue: don't re-enter same hook on packet reinjection

2016-10-17 Thread Pablo Neira Ayuso
On Mon, Oct 17, 2016 at 11:23:01AM -0400, Aaron Conole wrote: > Pablo Neira Ayuso writes: > > > Make sure we skip the current hook from where the packet was enqueued, > > otherwise the packets gets enqueued over and over again. > > > > Fixes: e3b37f11e6e4 ("netfilter: replace list_head with single

Re: [PATCH nf,v2] netfilter: nf_queue: don't re-enter same hook on packet reinjection

2016-10-17 Thread Aaron Conole
Pablo Neira Ayuso writes: > On Mon, Oct 17, 2016 at 11:23:01AM -0400, Aaron Conole wrote: >> Pablo Neira Ayuso writes: >> >> > Make sure we skip the current hook from where the packet was enqueued, >> > otherwise the packets gets enqueued over and over again. >> > >> > Fixes: e3b37f11e6e4 ("netf

Re: [PATCH nf,v2] netfilter: nf_queue: don't re-enter same hook on packet reinjection

2016-10-18 Thread Pablo Neira Ayuso
On Mon, Oct 17, 2016 at 03:29:27PM -0400, Aaron Conole wrote: > Pablo Neira Ayuso writes: [...] > > From c1a731c68791bcd504a7fe5d28f5f0fd59d66118 Mon Sep 17 00:00:00 2001 > > From: Pablo Neira Ayuso > > Date: Thu, 13 Oct 2016 08:14:03 +0200 > > Subject: [PATCH nf,v3] netfilter: nf_queue: don't re

Re: [PATCH nf,v2] netfilter: nf_queue: don't re-enter same hook on packet reinjection

2016-10-18 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Mon, Oct 17, 2016 at 03:29:27PM -0400, Aaron Conole wrote: > > Pablo Neira Ayuso writes: > [...] > > > From c1a731c68791bcd504a7fe5d28f5f0fd59d66118 Mon Sep 17 00:00:00 2001 > > > From: Pablo Neira Ayuso > > > Date: Thu, 13 Oct 2016 08:14:03 +0200 > > > Subject: [PA

Re: [PATCH nf,v2] netfilter: nf_queue: don't re-enter same hook on packet reinjection

2016-10-18 Thread Aaron Conole
Florian Westphal writes: > Pablo Neira Ayuso wrote: >> On Mon, Oct 17, 2016 at 03:29:27PM -0400, Aaron Conole wrote: >> > Pablo Neira Ayuso writes: >> [...] >> > > From c1a731c68791bcd504a7fe5d28f5f0fd59d66118 Mon Sep 17 00:00:00 2001 >> > > From: Pablo Neira Ayuso >> > > Date: Thu, 13 Oct 201