From: Anders K. Pedersen
As Liping Zhang reports, after commit a8b1e36d0d1d ("netfilter: nft_dynset:
fix element timeout for HZ != 1000"), priv->timeout was stored in jiffies,
while set->timeout was stored in milliseconds. This is inconsistent and
incorrect.
Firstly, we already call msecs_to_jif
2016-11-21 0:38 GMT+08:00 Anders K. Pedersen | Cohaesio :
> From: Anders K. Pedersen
>
> As Liping Zhang reports, after commit a8b1e36d0d1d ("netfilter: nft_dynset:
> fix element timeout for HZ != 1000"), priv->timeout was stored in jiffies,
> while set->timeout was stored in milliseconds. This is
Hi Liping,
On man, 2016-11-21 at 09:48 +0800, Liping Zhang wrote:
> 2016-11-21 0:38 GMT+08:00 Anders K. Pedersen | Cohaesio .com>:
> Acked-by: Liping Zhang
>
> But there's some small indent issues, see below.
> diff --git a/net/netfilter/nf_tables_api.c
> > b/net/netfilter/nf_tables_api.c
> >
Hi Anders,
2016-11-21 16:57 GMT+08:00 Anders K. Pedersen | Cohaesio :
[...]
>> nla[NFTA_SET_TIMEOUT] should be kept indent consistent with
>> be64_to_cpu.
>> You can add some spaces after tab.
>
> The indentation is deliberate, because I don't want to give the
> impression that nla[] is an argumen
On Sun, Nov 20, 2016 at 04:38:47PM +, Anders K. Pedersen | Cohaesio wrote:
> From: Anders K. Pedersen
>
> As Liping Zhang reports, after commit a8b1e36d0d1d ("netfilter: nft_dynset:
> fix element timeout for HZ != 1000"), priv->timeout was stored in jiffies,
> while set->timeout was stored in
