Re: [PATCH nf-next] netfilter: nft_numgen: fix race between num generate and store it

2016-09-12 Thread Pablo Neira Ayuso
i On Mon, Sep 12, 2016 at 10:21:36PM +0800, Liping Zhang wrote: > From: Liping Zhang > > After we generate a new number, we still use the priv->counter and > store it to the dreg. This is not correct, another cpu may already > change it to a new number. So we must

[PATCH nf-next] netfilter: nft_numgen: fix race between num generate and store it

2016-09-12 Thread Liping Zhang
From: Liping Zhang After we generate a new number, we still use the priv->counter and store it to the dreg. This is not correct, another cpu may already change it to a new number. So we must use the generated number, not the priv->counter itself. Fixes: 91dbc6be0a62