Re: [PATCH nf-next] netfilter: x_tables: Decrease code duplication in tproxy target

2018-06-01 Thread Pablo Neira Ayuso
On Fri, Jun 01, 2018 at 09:08:09AM +0200, Máté Eckl wrote: > On Thu, May 31, 2018 at 11:07:12AM +0200, Máté Eckl wrote: > > Transparent socket check is already implemented in nf_socket.h. > > I just realised that even nf_sk_is_transparent is code duplication itself, as > inet_sk_transparent does

Re: [PATCH nf-next] netfilter: x_tables: Decrease code duplication in tproxy target

2018-06-01 Thread Pablo Neira Ayuso
On Thu, May 31, 2018 at 11:09:25AM +0200, Florian Westphal wrote: > Máté Eckl wrote: > > Transparent socket check is already implemented in nf_socket.h. > > Acked-by: Florian Westphal Applied, thanks Mate. And thanks for reviewing. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH nf-next] netfilter: x_tables: Decrease code duplication in tproxy target

2018-06-01 Thread Máté Eckl
On Thu, May 31, 2018 at 11:07:12AM +0200, Máté Eckl wrote: > Transparent socket check is already implemented in nf_socket.h. I just realised that even nf_sk_is_transparent is code duplication itself, as inet_sk_transparent does exactly the same in include/net/tcp.h. However adding this would

Re: [PATCH nf-next] netfilter: x_tables: Decrease code duplication in tproxy target

2018-05-31 Thread Florian Westphal
Máté Eckl wrote: > Transparent socket check is already implemented in nf_socket.h. Acked-by: Florian Westphal -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH nf-next] netfilter: x_tables: Decrease code duplication in tproxy target

2018-05-31 Thread Máté Eckl
Transparent socket check is already implemented in nf_socket.h. Signed-off-by: Máté Eckl --- net/netfilter/xt_TPROXY.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/net/netfilter/xt_TPROXY.c b/net/netfilter/xt_TPROXY.c index 8c89323c06af..a2ee85240926