Re: [PATCH nf-next 1/2] ebtables: add support for matching ICMP type and code

2018-03-11 Thread Pablo Neira Ayuso
On Sun, Mar 11, 2018 at 11:04:22PM +0100, Matthias Schiffer wrote: > On 03/11/2018 10:14 PM, Pablo Neira Ayuso wrote: > > On Sun, Mar 04, 2018 at 09:28:53AM +0100, Matthias Schiffer wrote: > >> We already have ICMPv6 type/code matches. This adds support for IPv4 ICMP > >> matches in the same way.

Re: [PATCH nf-next 1/2] ebtables: add support for matching ICMP type and code

2018-03-11 Thread Matthias Schiffer
On 03/11/2018 10:14 PM, Pablo Neira Ayuso wrote: > On Sun, Mar 04, 2018 at 09:28:53AM +0100, Matthias Schiffer wrote: >> We already have ICMPv6 type/code matches. This adds support for IPv4 ICMP >> matches in the same way. >> >> Signed-off-by: Matthias Schiffer >>

Re: [PATCH nf-next 1/2] ebtables: add support for matching ICMP type and code

2018-03-11 Thread Pablo Neira Ayuso
On Sun, Mar 04, 2018 at 09:28:53AM +0100, Matthias Schiffer wrote: > We already have ICMPv6 type/code matches. This adds support for IPv4 ICMP > matches in the same way. > > Signed-off-by: Matthias Schiffer > --- > include/uapi/linux/netfilter_bridge/ebt_ip.h |

[PATCH nf-next 1/2] ebtables: add support for matching ICMP type and code

2018-03-04 Thread Matthias Schiffer
We already have ICMPv6 type/code matches. This adds support for IPv4 ICMP matches in the same way. Signed-off-by: Matthias Schiffer --- include/uapi/linux/netfilter_bridge/ebt_ip.h | 13 +++-- net/bridge/netfilter/ebt_ip.c| 43