Re: [iptables PATCH] ebtables: Remove flags misinterpretations

2018-08-10 Thread Florian Westphal
Phil Sutter wrote: > This is actually quite a mess: xtables-eb.c defines names for bits in > 'flags' variable of do_commandeb(), though these tend to clash with bit > names defined in xshared.h due to the same 'OPT_' prefix. Therefore > checking for bits OPT_NUMERIC and OPT_VERBOSE is syntacticall

[iptables PATCH] ebtables: Remove flags misinterpretations

2018-08-10 Thread Phil Sutter
This is actually quite a mess: xtables-eb.c defines names for bits in 'flags' variable of do_commandeb(), though these tend to clash with bit names defined in xshared.h due to the same 'OPT_' prefix. Therefore checking for bits OPT_NUMERIC and OPT_VERBOSE is syntactically correct, but semantically