Re: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2017-03-20 Thread Robert Wilton
Hi Acee, On 17/03/2017 17:18, Acee Lindem (acee) wrote: Hi Rob, On 3/10/17, 9:46 AM, "netmod on behalf of Robert Wilton -X (rwilton - ENSOFT LIMITED at Cisco)" wrote: Lada, Thanks for the comments, some further comments inline ... On 10/03/2017 14:09, Ladislav Lhotka wrote: Hi Rob, plea

Re: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2017-03-17 Thread Acee Lindem (acee)
Hi Rob, On 3/10/17, 9:46 AM, "netmod on behalf of Robert Wilton -X (rwilton - ENSOFT LIMITED at Cisco)" wrote: >Lada, > >Thanks for the comments, some further comments inline ... > > >On 10/03/2017 14:09, Ladislav Lhotka wrote: >> Hi Rob, >> >> please see inline. >> >> Robert Wilton writes: >>

Re: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2017-03-10 Thread Robert Wilton
Lada, Thanks for the comments, some further comments inline ... On 10/03/2017 14:09, Ladislav Lhotka wrote: Hi Rob, please see inline. Robert Wilton writes: Hi Lada, To pick up an old thread, I'm updating the interface model per your comments below, and I had a few questions that you mig

Re: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2017-03-10 Thread Ladislav Lhotka
Hi Rob, please see inline. Robert Wilton writes: > Hi Lada, > > To pick up an old thread, I'm updating the interface model per your > comments below, and I had a few questions that you might have an opinion on. > > On 22/12/2016 14:32, Robert Wilton wrote: >> Hi Lada, >> >> Thanks for the revi

Re: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2017-03-10 Thread Robert Wilton
Hi Lada, To pick up an old thread, I'm updating the interface model per your comments below, and I had a few questions that you might have an opinion on. On 22/12/2016 14:32, Robert Wilton wrote: Hi Lada, Thanks for the review and comments. On 21/12/2016 13:08, Ladislav Lhotka wrote: Hi,

Re: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2016-12-22 Thread Ladislav Lhotka
> On 22 Dec 2016, at 15:32, Robert Wilton wrote: > > Hi Lada, > > Thanks for the review and comments. > > > On 21/12/2016 13:08, Ladislav Lhotka wrote: >> Hi, >> >> I think this is a very useful addition to ietf-interfaces. In general, >> the document is clearly written and YANG modules nice

Re: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2016-12-22 Thread Robert Wilton
Hi Lada, Thanks for the review and comments. On 21/12/2016 13:08, Ladislav Lhotka wrote: Hi, I think this is a very useful addition to ietf-interfaces. In general, the document is clearly written and YANG modules nicely designed. Here are my comments: *** Sec. 1 - "This document defines

Re: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2016-12-21 Thread Martin Bjorklund
Ladislav Lhotka wrote: > *** YANG modules > - Descriptions are not consistently formatted. I think that the > current BCP is to start description text on the same line as the > "description" keyword only if it all fits on one line. Just a FYI. Try using: pyang --keep-comments -f

[netmod] LL review of draft-ietf-netmod-intf-ext-yang-03

2016-12-21 Thread Ladislav Lhotka
Hi, I think this is a very useful addition to ietf-interfaces. In general, the document is clearly written and YANG modules nicely designed. Here are my comments: *** Sec. 1 - "This document defines two YANG RFC 7950 [RFC7950] modules …" looks weird. I'd suggest "… YANG 1.1 [RFC7950] …"