[netsniff-ng] Re: [PATCH 0/6] trafgen: Implement ICMPv4 packet creation

On 2016-06-29 at 11:21:24 +0200, Vadim Kochan wrote: > Hi Tobias, > > On Sat, Apr 30, 2016 at 6:01 PM, Tobias Klauser wrote: > > Hi Vadim > > > > Thanks for the series. I'll be travelling for a while starting tomorrow, > > so it will probably take a while

[netsniff-ng] Re: [PATCH 3/6] trafgen: parser: Split echorequest & echoreply with "-"

On 2016-04-30 at 16:39:17 +0200, Vadim Kochan wrote: > Change echorequest to echo-request, and echoreply to echo-reply > which looks more readable. > > Signed-off-by: Vadim Kochan NAK, I think it's OK the way it currently is. All other "2-word" keywords

[netsniff-ng] Re: [PATCH 1/6] trafgen: parser: Split [e]type to separate keywords

On 2016-04-30 at 16:39:15 +0200, Vadim Kochan wrote: > Split [e]etype to separate 'type' & 'etype' keywords, > the reason is that 'type' might be used in other protocol > headers (e.g. ICMP). > > Signed-off-by: Vadim Kochan Applied, thanks. -- You

[netsniff-ng] Re: [PATCH 2/6] trafgen: parser: Replace 'mtype' by 'type'

On 2016-04-30 at 16:39:16 +0200, Vadim Kochan wrote: > After splitting etype & type to different tokens it is possible > to use 'type' for ICMP type field which is used by RFC. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message