[netsniff-ng] Re: flowtop: Example of UI tabs interface

2017-01-13 Thread Vadim Kochan
On Fri, Jan 13, 2017 at 3:07 PM, Daniel Borkmann wrote: > On 01/13/2017 02:02 PM, Vadim Kochan wrote: >> >> Hi, >> >> I tried to extend flowtop UI to have some aggregated info via tabbed >> panel interface. >> Currently there is only 1 new "Process" tab which grouped flows stat info >> per >> uniq

[netsniff-ng] Re: flowtop: Example of UI tabs interface

2017-01-13 Thread Daniel Borkmann
On 01/13/2017 02:02 PM, Vadim Kochan wrote: Hi, I tried to extend flowtop UI to have some aggregated info via tabbed panel interface. Currently there is only 1 new "Process" tab which grouped flows stat info per unique pid (with summed rates & bytes). Plz let me know if it would be good to have.

[netsniff-ng] Re: [PATCH] flowtop: Replace single linked list by list_head from list.h

2017-01-13 Thread Vadim Kochan
On Thu, Jan 12, 2017 at 5:20 PM, Tobias Klauser wrote: > On 2017-01-12 at 15:54:31 +0100, Vadim Kochan wrote: >> On Thu, Jan 12, 2017 at 4:28 PM, Tobias Klauser wrote: > [...] >> >> enum flow_direction { >> >> @@ -355,15 +357,15 @@ static inline struct flow_entry >> >> *flow_entry_xalloc(void)

[netsniff-ng] [PATCH v2] flowtop: Replace single linked list by list_head from list.h

2017-01-13 Thread Vadim Kochan
list.h provides generic Linux-like linked list API which also supports RCU list operations. Also additionally was removed the spinlock which is not needed for RCU-list operations, for the list_del_rcu(...) case it is needed additionally call call_rcu(...) before free the flow entry. Because of fu