Re: [PATCH] Integration of chacha in Makefile.in

2014-01-15 Thread Niels Möller
ni...@lysator.liu.se (Niels Möller) writes: > I edited it a bit, to take out support for rounds != 20 for now (except > for the _chacha_core_internal function), and I split the set key > function into two functions for the two available key sizes, 128 and 256 > bits. I have a couple of questinos

Re: [PATCH] Integration of chacha in Makefile.in

2014-01-15 Thread Stefan Bühler
Hi, On Wed, 15 Jan 2014 22:01:13 +0100 ni...@lysator.liu.se (Niels Möller) wrote: > In the chacha paper I've read, it seems that "chacha" is the name of > the family, and "chacha20" always refers to the 20-round variant. So a > reduced round chacha would be named "chacha12", not "chacha20_r12". >

Re: [PATCH] Integration of chacha in Makefile.in

2014-01-15 Thread Niels Möller
Stefan Bühler writes: > What about: > > chacha20_crypt (20 rounds) > chacha12_crypt (12 rounds) > chacha_set_key128 (128 key bits) > chacha_set_key256 (256 key bits) > salsa20_set_key128 (128 key bits) > salsa20_set_key256 (256 key bits) My gut feeling is that think putting the numbe

Re: [PATCH] Integration of chacha in Makefile.in

2014-01-15 Thread Stefan Bühler
On Wed, 15 Jan 2014 22:41:43 +0100 ni...@lysator.liu.se (Niels Möller) wrote: > Stefan Bühler writes: > > > What about: > > > > chacha20_crypt (20 rounds) > > chacha12_crypt (12 rounds) > > chacha_set_key128 (128 key bits) > > chacha_set_key256 (256 key bits) > > salsa20_set_key128 (12

Re: [PATCH] Integration of chacha in Makefile.in

2014-01-15 Thread Nikos Mavrogiannopoulos
On 01/15/2014 10:01 PM, Niels Möller wrote: > It might be a bit confusing if we have > > chacha20_crypt (20 rounds) > chacha12_crypt (12 rounds) > chacha128_set_key (128 key bits) > chacha256_set_key (256 key bits) I'd say to simplify to: chacha_crypt (20 rounds) chacha128_set_key