Re: [PATCH v2 0/2] Add Cipher FeedBack mode support

2017-10-04 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > 2017-10-03 23:04 GMT+03:00 Niels Möller : >> What about message sizes which aren't a multiple of the block size? As I >> understood your code, it would be possible to call cfb_encrypt with an >> input lenght of, e.g., 19 octets, which would be processed as one CF

Re: [PATCH v2 0/2] Add Cipher FeedBack mode support

2017-10-04 Thread Dmitry Eremin-Solenikov
2017-10-04 17:55 GMT+03:00 Niels Möller : > Dmitry Eremin-Solenikov writes: > >> 2017-10-03 23:04 GMT+03:00 Niels Möller : >>> What about message sizes which aren't a multiple of the block size? As I >>> understood your code, it would be possible to call cfb_encrypt with an >>> input lenght of, e.

Re: [PATCH v2 0/2] Add Cipher FeedBack mode support

2017-10-04 Thread Niels Möller
Dmitry Eremin-Solenikov writes: >> I see three reasonable approaches: >> >> 1. Support only segments matching the block size (i.e., CFB128 for a >>16-octet block size), no partial segments. >> >> 2. Allow a partial segment, and encrypt it in the same way as if it had >>been padded to a bl