Static analyzer (was: Re: nettle symbols: improve map files)

2018-07-13 Thread Niels Möller
Nikos Mavrogiannopoulos writes: > It seems > that static analyzer in F28 finds few issues: > https://gitlab.com/gnutls/nettle/-/jobs/81332560 (click on browse for > artifacts) > > They are mem leaks on examples and one which relates to gmp-mini. I fixed the leaks. Remaining issues listed on http

Re: nettle symbols: improve map files

2018-07-13 Thread Nikos Mavrogiannopoulos
On Thu, 2018-07-12 at 18:04 +0200, Niels Möller wrote: > > We'll see how to deal with those failures, but I don't think they > should block merging to the master branch. > > There are also two "runner system failures", see > https://gitlab.com/gnutls/nettle/-/jobs/81332562. Can that be > restart

Re: Static analyzer (was: Re: nettle symbols: improve map files)

2018-07-13 Thread Nikos Mavrogiannopoulos
On Fri, 2018-07-13 at 10:08 +0200, Niels Möller wrote: > > I've had a closer look now, and I think both are of similar type. In > eratosthenes.c, we have a bitmap initialized with > > static void > vector_init(unsigned long *vector, unsigned long size) > { > unsigned long end = (size +

Re: Static analyzer

2018-07-13 Thread Niels Möller
Nikos Mavrogiannopoulos writes: > An assert() should be sufficient to inform it of the constraints. I've added two asserts for the eratosthenes.c warning, we'lll see if that helps (only vector_alloc wasn't enough). For the other case, eccdata.c, I think some additional checks of the input argume

Re: Static analyzer

2018-07-13 Thread Niels Möller
ni...@lysator.liu.se (Niels Möller) writes: > Nikos Mavrogiannopoulos writes: > >> An assert() should be sufficient to inform it of the constraints. > > I've added two asserts for the eratosthenes.c warning, we'lll see if > that helps (only vector_alloc wasn't enough). Another analysis run has c