Re: Intel CET protection

2019-04-27 Thread Niels Möller
Simo Sorce writes: > they address all concerns except for adding the CET_SECTION macro > automagically to all asm files. Thanks. I commented on that issue in my other mail. > I also added a patch to deal with the missing epilogues. Applied now. BTW are there any git experts here? I often appl

Re: Intel CET protection

2019-04-27 Thread Niels Möller
Simo Sorce writes: > Ok attached find new patches, > they address all concerns except for adding the CET_SECTION macro > automagically to all asm files. Ah, one more thing: > +define(, > + +<.pushsection .note.gnu.property,"a" How portable is .pushsection? If we ensure that notes are last, pla

Re: Intel CET protection

2019-04-27 Thread Simo Sorce
On Fri, 2019-04-26 at 22:31 +0200, Niels Möller wrote: > Simo Sorce writes: > > > I understand this is not a high bar, and I will fold the segment note > > in if you think that is what we should do, but I wanted to make you > > aware of why I did not do the same as what we do with the stack note.

Re: Intel CET protection

2019-04-27 Thread Simo Sorce
Oh sorry I did not see this email and the previous before sending my new patches. About git, generally git am wants to be applied in order, but I think there may be a fuzz option to git too, never really investigated as I usually apply all patches to a branch (or pull that branch directly from PR