Re: Release? (was: Re: curve448 branch)

2019-05-11 Thread Nikos Mavrogiannopoulos
I know of one or two applications that moved to nettle once the des functionality was removed from libcrypt. Not sure if that's a good reason to keep it, they are deprecated, but removing it may make it slower to move to that version. On May 11, 2019 7:40:34 PM UTC, ni...@lysator.liu.se wrote:

Re: Release? (was: Re: curve448 branch)

2019-05-11 Thread Dmitry Eremin-Solenikov
Hello, сб, 11 мая 2019 г. в 22:40, Niels Möller : > > Dmitry Eremin-Solenikov writes: > > > Is there anything that we can do to help with 3.5? > > I've just updated the NEWS file, please review. Since it's an ABI break, > maybe a few more things could be deleted. > > * Can we delete

Release? (was: Re: curve448 branch)

2019-05-11 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > Is there anything that we can do to help with 3.5? I've just updated the NEWS file, please review. Since it's an ABI break, maybe a few more things could be deleted. * Can we delete _rsa_blind/_rsa_unblind (currently demoted from rsa.h to rsa-internal.h,

Re: [PATCH 3/3] GOST curves generate larger overflows in mod arithmetics

2019-05-11 Thread Niels Möller
Dmitry Eremin-Solenikov writes: >> If p is close to B^size / 2, then I think a reduction like > > Yes, it is. > > As an overflow happens in low level code, do you suggest > duplicating ecc-dup-jj/ecc-add-jja/ecc-add-jjj for GOST curves? I'd prefer not to duplicate the point functions. Could

Re: [PATCH 3/3] GOST curves generate larger overflows in mod arithmetics

2019-05-11 Thread Niels Möller
Dmitry Eremin-Solenikov writes: >> Is it the condition b < B^size / p that is not valid for the GOST >> curves? What are the problematic values of b and p? > > I did not try debugging maths part of this issue. > Basically you can apply first two patches and then observe asserts failing > when

Re: [PATCH 3/3] GOST curves generate larger overflows in mod arithmetics

2019-05-11 Thread Dmitry Eremin-Solenikov
Hello, сб, 11 мая 2019 г. в 11:26, Niels Möller : > > Dmitry Eremin-Solenikov writes: > > > Signed-off-by: Dmitry Eremin-Solenikov > > --- > > ecc-mod-arith.c | 30 ++ > > 1 file changed, 18 insertions(+), 12 deletions(-) > > > > diff --git a/ecc-mod-arith.c

Re: [PATCH 3/3] GOST curves generate larger overflows in mod arithmetics

2019-05-11 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > Signed-off-by: Dmitry Eremin-Solenikov > --- > ecc-mod-arith.c | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) > > diff --git a/ecc-mod-arith.c b/ecc-mod-arith.c > index f2e47f6747c1..571680a98dc3 100644 > ---

Re: curve448 branch

2019-05-11 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > Niels, Daiki, do you have plans to update/merge curve448 branch? > I'd benefit from generalized Edwards curves support, which is part of > that branch. My plan was to merge it after the 3.5 release, in order to (i) to be able to do it without another abi

Re: Add check for ECC at point 0

2019-05-11 Thread Niels Möller
Simo Sorce writes: > While reviewing FIPS requirements for public key checks in Ephemeral > Diffie-Hellman key exchanges it came out that FIPS requires checks that > the public key point is not the (0, 0) coordinate and nettle is not > doing it (only checks that neither point is negative.

Re: SIV-CMAC

2019-05-11 Thread Niels Möller
Nikos Mavrogiannopoulos writes: > Thanks. If you added the zero-nonce method, maybe it would be better > to add test vectors for it as well. I'm copying from my last patch > with it: I was about to add the miscreant.js examples (and with nettle's output, which is different), to illustrate